This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
regen/op_private: remove sassign special-casing
authorDavid Mitchell <davem@iabyn.com>
Tue, 8 Aug 2017 11:19:53 +0000 (12:19 +0100)
committerDavid Mitchell <davem@iabyn.com>
Tue, 8 Aug 2017 11:48:03 +0000 (12:48 +0100)
Since v5.25.5-46-g1257c08, sassign has been correctly listed in
regen/opcodes as a binary op ('2') rather than as a base op, so there's no
need to special-case it in regen/op_private any more.

This commit makes no functional changes, because since
v5.25.5-46-g1257c08, $args2{sassign} was redundantly getting set to a true
value twice, which was harmless. Now it only gets set once.

regen/op_private

index 0122863..753a0bd 100644 (file)
@@ -220,9 +220,6 @@ use strict;
                         qw(vec),
                         grep !$maxarg{$_} && !$args0{$_} && !$args1{$_},
                             ops_with_flag('2'), # BINOP
                         qw(vec),
                         grep !$maxarg{$_} && !$args0{$_} && !$args1{$_},
                             ops_with_flag('2'), # BINOP
-                            # this is a binop, but special-cased as a
-                            # baseop in regen/opcodes
-                            'sassign',
                     );
 
     $args3{$_} = 1 for grep !$maxarg{$_} && !$args0{$_}
                     );
 
     $args3{$_} = 1 for grep !$maxarg{$_} && !$args0{$_}