This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
Revert "Check against negative uid/gid for fchown()."
authorJarkko Hietaniemi <jhi@iki.fi>
Tue, 16 Aug 2016 23:06:31 +0000 (19:06 -0400)
committerJarkko Hietaniemi <jhi@iki.fi>
Wed, 17 Aug 2016 00:19:59 +0000 (20:19 -0400)
This reverts commit f95ba548a286b17c260cc168715a9d0d441b14a6.

[rt.perl.org #128967]

The negative arguments to fchown depend on the platform,
so Coverity should not claim it knows what is acceptable.

doio.c

diff --git a/doio.c b/doio.c
index 2dc7082..b8f3c28 100644 (file)
--- a/doio.c
+++ b/doio.c
@@ -1845,18 +1845,8 @@ Perl_apply(pTHX_ I32 type, SV **mark, SV **sp)
                         int fd = PerlIO_fileno(IoIFP(GvIOn(gv)));
                        APPLY_TAINT_PROPER();
                         if (fd < 0) {
-                           SETERRNO(EBADF,RMS_IFI);
-                           tot--;
-#if Uid_t_sign == 1
-                       } else if (val < 0) {
-                           SETERRNO(EINVAL,LIB_INVARG);
-                           tot--;
-#endif
-#if Gid_t_sign == 1
-                       } else if (val2 < 0) {
-                           SETERRNO(EINVAL,LIB_INVARG);
+                            SETERRNO(EBADF,RMS_IFI);
                            tot--;
-#endif
                         } else if (fchown(fd, val, val2))
                            tot--;
 #else