This is a live mirror of the Perl 5 development currently hosted at
https://github.com/perl/perl5
https://perl5.git.perl.org
/
perl5.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
0ea2315
)
Perl_sv_vcatpvfn_flags: add %n code comment
author
David Mitchell
<davem@iabyn.com>
Wed, 24 May 2017 15:29:16 +0000
(16:29 +0100)
committer
David Mitchell
<davem@iabyn.com>
Wed, 7 Jun 2017 08:11:03 +0000
(09:11 +0100)
point out thngs like "%-4.5n" don't currently warn
sv.c
patch
|
blob
|
blame
|
history
diff --git
a/sv.c
b/sv.c
index
5fc3b89
..
3bcaa50
100644
(file)
--- a/
sv.c
+++ b/
sv.c
@@
-13009,6
+13009,8
@@
Perl_sv_vcatpvfn_flags(pTHX_ SV *const sv, const char *const pat, const STRLEN p
int i;
if (vectorize)
goto unknown;
+ /* XXX ideally we should warn if any flags etc have been
+ * set, e.g. "%-4.5n" */
/* XXX if sv was originally non-utf8 with a char in the
* range 0x80-0xff, then if it got upgraded, we should
* calculate char len rather than byte len here */