In makedef.pl, avoid creating %PLATFORMS just for one existence check.

A single linear search of @PLATFORMS is simpler and possibly even faster
than building a hash from @PLATFORMS, making one lookup, then discarding the
hash.

Add a block to limit the scope of @PLATFORMS to the code that uses it.

diff --git a/makedef.pl b/makedef.pl
index 42ca395..0a97ba1 100644 (file)
--- a/makedef.pl
+++ b/makedef.pl
@@ -54,14 +54,16 @@ while (@ARGV) {
     }
 }
 
-my @PLATFORM = qw(aix win32 wince os2 netware vms);
-my %PLATFORM;
-@PLATFORM{@PLATFORM} = ();
-
-die "PLATFORM undefined, must be one of: @PLATFORM\n"
-    unless defined $ARGS{PLATFORM};
-die "PLATFORM must be one of: @PLATFORM\n"
-    unless exists $PLATFORM{$ARGS{PLATFORM}};
+{
+    my @PLATFORM = qw(aix win32 wince os2 netware vms);
+    my %PLATFORM;
+    @PLATFORM{@PLATFORM} = ();
+
+    die "PLATFORM undefined, must be one of: @PLATFORM\n"
+       unless defined $ARGS{PLATFORM};
+    die "PLATFORM must be one of: @PLATFORM\n"
+       unless exists $PLATFORM{$ARGS{PLATFORM}};
+}
 
 # Is the following guard strictly necessary? Added during refactoring
 # to keep the same behaviour when merging other code into here.