This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
Perl_sv_vcatpvfn_flags: simplify an expression
authorDavid Mitchell <davem@iabyn.com>
Wed, 10 May 2017 13:03:25 +0000 (14:03 +0100)
committerDavid Mitchell <davem@iabyn.com>
Wed, 7 Jun 2017 08:11:00 +0000 (09:11 +0100)
In the hex floating/point code, (subnormal ? vfnz : vhex) is equivalent to
v0, which we just set to the same value.

So keep things simple.

sv.c

diff --git a/sv.c b/sv.c
index 2490b15..f56fc16 100644 (file)
--- a/sv.c
+++ b/sv.c
@@ -12693,7 +12693,7 @@ Perl_sv_vcatpvfn_flags(pTHX_ SV *const sv, const char *const pat, const STRLEN p
 
                     if (has_precis) {
                         U8* ve = (subnormal ? vlnz + 1 : vend);
-                        SSize_t vn = ve - (subnormal ? vfnz : vhex);
+                        SSize_t vn = ve - v0;
                         if ((SSize_t)(precis + 1) < vn) {
                             bool overflow = FALSE;
                             if (v0[precis + 1] < 0x8) {