This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
In inet_aton(), use newSVpvn_flags() instead of sv_newmortal(), sv_setpvn()
authorNicholas Clark <nick@ccl4.org>
Sun, 6 Mar 2011 10:16:22 +0000 (10:16 +0000)
committerNicholas Clark <nick@ccl4.org>
Sun, 6 Mar 2011 10:16:22 +0000 (10:16 +0000)
The API calls are equivalent, but the object code is slightly smaller.

ext/Socket/Socket.xs

index e9a8c56..3e81105 100644 (file)
@@ -431,9 +431,7 @@ inet_aton(host)
                ok = 1;
        }
 
-       ST(0) = sv_newmortal();
-       if (ok)
-               sv_setpvn( ST(0), (char *)&ip_address, sizeof ip_address );
+       ST(0) = newSVpvn_flags(ok ? (char *)&ip_address : NULL, sizeof ip_address, SVs_TEMP);
        }
 
 void