Gisle points out that it's ok to ignore the return value of newSVrv.

[perl5.git] / Porting / findrfuncs

diff --git a/Porting/findrfuncs b/Porting/findrfuncs
index 4254a7a..c9a7ff8 100644 (file)
--- a/Porting/findrfuncs
+++ b/Porting/findrfuncs
@@ -1,11 +1,14 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl -ws
 
 #
 # findrfuncs: find reentrant variants of functions used in an executable.
+#
 # Requires a functional "nm -u".  Searches headers in /usr/include
 # to find available *_r functions and looks for non-reentrant
 # variants used in the supplied executable.
 #
+# Requires debug info in the shared libraries/executables.
+#
 # Gurusamy Sarathy
 # gsar@ActiveState.com
 #
@@ -106,12 +109,12 @@ my %syms;
 
 for my $exe (@EXES) {
     # warn "#--- $exe\n";
-    for my $sym (`$NMU $exe`) {
+    for my $sym (`$NMU $exe 2>/dev/null`) {
         chomp $sym;
         $sym =~ s/^\s+//;
         $sym =~ s/^([0-9A-Fa-f]+\s+)?[Uu]\s+//;
         $sym =~ s/\s+[Uu]\s+-$//;
-        next if /\s/;
+        next if $sym =~ /\s/;
         $sym =~ s/\@.*\z//;    # remove @@GLIBC_2.0 etc
         # warn "#### $sym\n";
         if (exists $rfuncs{"${sym}_r"} && ! $syms{"$sym:$exe"}++) {
@@ -128,4 +131,3 @@ for my $exe (@EXES) {
     }
     @syms = ();
 }
-