* or may not be utf8.
*/
-STATIC I32
+STATIC Size_t
S_do_trans_simple(pTHX_ SV * const sv)
{
- I32 matches = 0;
+ Size_t matches = 0;
STRLEN len;
U8 *s = (U8*)SvPV_nomg(sv,len);
U8 * const send = s+len;
- const short * const tbl = (short*)cPVOP->op_pv;
+ const OPtrans_map * const tbl = (OPtrans_map*)cPVOP->op_pv;
PERL_ARGS_ASSERT_DO_TRANS_SIMPLE;
/* First, take care of non-UTF-8 input strings, because they're easy */
if (!SvUTF8(sv)) {
while (s < send) {
- const I32 ch = tbl[*s];
+ const short ch = tbl->map[*s];
if (ch >= 0) {
matches++;
*s = (U8)ch;
SvSETMAGIC(sv);
}
else {
- const I32 grows = PL_op->op_private & OPpTRANS_GROWS;
+ const bool grows = cBOOL(PL_op->op_private & OPpTRANS_GROWS);
U8 *d;
U8 *dstart;
dstart = d;
while (s < send) {
STRLEN ulen;
- I32 ch;
+ short ch;
/* Need to check this, otherwise 128..255 won't match */
const UV c = utf8n_to_uvchr(s, send - s, &ulen, UTF8_ALLOW_DEFAULT);
- if (c < 0x100 && (ch = tbl[c]) >= 0) {
+ if (c < 0x100 && (ch = tbl->map[c]) >= 0) {
matches++;
- d = uvchr_to_utf8(d, ch);
+ d = uvchr_to_utf8(d, (UV)ch);
s += ulen;
}
else { /* No match -> copy */
* or may not be utf8.
*/
-STATIC I32
+STATIC Size_t
S_do_trans_count(pTHX_ SV * const sv)
{
STRLEN len;
const U8 *s = (const U8*)SvPV_nomg_const(sv, len);
const U8 * const send = s + len;
- I32 matches = 0;
- const short * const tbl = (short*)cPVOP->op_pv;
+ Size_t matches = 0;
+ const OPtrans_map * const tbl = (OPtrans_map*)cPVOP->op_pv;
PERL_ARGS_ASSERT_DO_TRANS_COUNT;
if (!SvUTF8(sv)) {
while (s < send) {
- if (tbl[*s++] >= 0)
+ if (tbl->map[*s++] >= 0)
matches++;
}
}
else {
- const I32 complement = PL_op->op_private & OPpTRANS_COMPLEMENT;
+ const bool complement = cBOOL(PL_op->op_private & OPpTRANS_COMPLEMENT);
while (s < send) {
STRLEN ulen;
const UV c = utf8n_to_uvchr(s, send - s, &ulen, UTF8_ALLOW_DEFAULT);
if (c < 0x100) {
- if (tbl[c] >= 0)
+ if (tbl->map[c] >= 0)
matches++;
} else if (complement)
matches++;
* or may not be utf8.
*/
-STATIC I32
+STATIC Size_t
S_do_trans_complex(pTHX_ SV * const sv)
{
STRLEN len;
U8 *s = (U8*)SvPV_nomg(sv, len);
U8 * const send = s+len;
- I32 matches = 0;
- const short * const tbl = (short*)cPVOP->op_pv;
+ Size_t matches = 0;
+ const OPtrans_map * const tbl = (OPtrans_map*)cPVOP->op_pv;
PERL_ARGS_ASSERT_DO_TRANS_COMPLEX;
if (PL_op->op_private & OPpTRANS_SQUASH) {
const U8* p = send;
while (s < send) {
- const I32 ch = tbl[*s];
+ const short ch = tbl->map[*s];
if (ch >= 0) {
*d = (U8)ch;
matches++;
}
else {
while (s < send) {
- const I32 ch = tbl[*s];
+ const short ch = tbl->map[*s];
if (ch >= 0) {
matches++;
*d++ = (U8)ch;
SvCUR_set(sv, d - dstart);
}
else { /* is utf8 */
- const I32 complement = PL_op->op_private & OPpTRANS_COMPLEMENT;
- const I32 grows = PL_op->op_private & OPpTRANS_GROWS;
- const I32 del = PL_op->op_private & OPpTRANS_DELETE;
+ const bool squash = cBOOL(PL_op->op_private & OPpTRANS_SQUASH);
+ const bool grows = cBOOL(PL_op->op_private & OPpTRANS_GROWS);
U8 *d;
U8 *dstart;
- SSize_t excess = 0;
+ Size_t size = tbl->size;
+ UV pch = 0xfeedface;
if (grows)
Newx(d, len*2+1, U8);
else
d = s;
dstart = d;
- if (complement && !del)
- /* number of replacement chars in excess of any 0x00..0xff
- * search characters */
- excess = (SSize_t)tbl[0x100];
- if (PL_op->op_private & OPpTRANS_SQUASH) {
- UV pch = 0xfeedface;
- while (s < send) {
- STRLEN len;
- const UV comp = utf8n_to_uvchr(s, send - s, &len,
- UTF8_ALLOW_DEFAULT);
- I32 ch;
+ while (s < send) {
+ STRLEN len;
+ const UV comp = utf8n_to_uvchr(s, send - s, &len,
+ UTF8_ALLOW_DEFAULT);
+ UV ch;
+ short sch;
+
+ sch = tbl->map[comp >= size ? size : comp];
+
+ if (sch >= 0) {
+ ch = (UV)sch;
+ replace:
+ matches++;
+ if (LIKELY(!squash || ch != pch)) {
+ d = uvchr_to_utf8(d, ch);
+ pch = ch;
+ }
+ s += len;
+ continue;
+ }
+ else if (sch == -1) { /* -1 is unmapped character */
+ Move(s, d, len, U8);
+ d += len;
+ }
+ else if (sch == -2) /* -2 is delete character */
+ matches++;
+ else {
+ assert(sch == -3); /* -3 is empty replacement */
+ ch = comp;
+ goto replace;
+ }
+
+ s += len;
+ pch = 0xfeedface;
+ }
- if (comp > 0xff) {
- if (!complement) {
- Move(s, d, len, U8);
- d += len;
- }
- else {
- /* use the implicit 0x100..0x7fffffff search range */
- matches++;
- if (!del) {
- ch = (excess == -1) ? (I32)comp :
- ( excess == 0
- || excess < (IV)comp - 0xff) ? tbl[0x101]
- : tbl[comp+2];
- if ((UV)ch != pch) {
- d = uvchr_to_utf8(d, ch);
- pch = (UV)ch;
- }
- s += len;
- continue;
- }
- }
- }
- else if ((ch = tbl[comp]) >= 0) {
- matches++;
- if ((UV)ch != pch) {
- d = uvchr_to_utf8(d, ch);
- pch = (UV)ch;
- }
- s += len;
- continue;
- }
- else if (ch == -1) { /* -1 is unmapped character */
- Move(s, d, len, U8);
- d += len;
- }
- else if (ch == -2) /* -2 is delete character */
- matches++;
- s += len;
- pch = 0xfeedface;
- }
- }
- else {
- while (s < send) {
- STRLEN len;
- const UV comp = utf8n_to_uvchr(s, send - s, &len,
- UTF8_ALLOW_DEFAULT);
- I32 ch;
- if (comp > 0xff) {
- if (!complement) {
- Move(s, d, len, U8);
- d += len;
- }
- else {
- /* use the implicit 0x100..0x7fffffff search range */
- matches++;
- if (!del) {
- /* tr/...//c should call S_do_trans_count
- * instead */
- assert(excess != -1);
- ch = ( excess == 0
- || excess < (IV)comp - 0xff) ? tbl[0x101]
- : tbl[comp+2];
- d = uvchr_to_utf8(d, ch);
- }
- }
- }
- else if ((ch = tbl[comp]) >= 0) {
- d = uvchr_to_utf8(d, ch);
- matches++;
- }
- else if (ch == -1) { /* -1 is unmapped character */
- Move(s, d, len, U8);
- d += len;
- }
- else if (ch == -2) /* -2 is delete character */
- matches++;
- s += len;
- }
- }
if (grows) {
sv_setpvn(sv, (char*)dstart, d - dstart);
Safefree(dstart);
* or may not be utf8.
*/
-STATIC I32
+STATIC Size_t
S_do_trans_simple_utf8(pTHX_ SV * const sv)
{
U8 *s;
U8 *d;
U8 *start;
U8 *dstart, *dend;
- I32 matches = 0;
- const I32 grows = PL_op->op_private & OPpTRANS_GROWS;
+ Size_t matches = 0;
+ const bool grows = cBOOL(PL_op->op_private & OPpTRANS_GROWS);
STRLEN len;
SV* const rv =
#ifdef USE_ITHREADS
* or may not be utf8.
*/
-STATIC I32
+STATIC Size_t
S_do_trans_count_utf8(pTHX_ SV * const sv)
{
const U8 *s;
const U8 *start = NULL;
const U8 *send;
- I32 matches = 0;
+ Size_t matches = 0;
STRLEN len;
SV* const rv =
#ifdef USE_ITHREADS
* or may not be utf8.
*/
-STATIC I32
+STATIC Size_t
S_do_trans_complex_utf8(pTHX_ SV * const sv)
{
U8 *start, *send;
U8 *d;
- I32 matches = 0;
- const I32 squash = PL_op->op_private & OPpTRANS_SQUASH;
- const I32 del = PL_op->op_private & OPpTRANS_DELETE;
- const I32 grows = PL_op->op_private & OPpTRANS_GROWS;
+ Size_t matches = 0;
+ const bool squash = cBOOL(PL_op->op_private & OPpTRANS_SQUASH);
+ const bool del = cBOOL(PL_op->op_private & OPpTRANS_DELETE);
+ const bool grows = cBOOL(PL_op->op_private & OPpTRANS_GROWS);
SV* const rv =
#ifdef USE_ITHREADS
PAD_SVl(cPADOP->op_padix);
* Returns a count of number of characters translated
*/
-I32
+Size_t
Perl_do_trans(pTHX_ SV *sv)
{
STRLEN len;
- const I32 flags = PL_op->op_private;
- const I32 hasutf = flags & (OPpTRANS_FROM_UTF | OPpTRANS_TO_UTF);
+ const U8 flags = PL_op->op_private;
+ const U8 hasutf = flags & (OPpTRANS_FROM_UTF | OPpTRANS_TO_UTF);
PERL_ARGS_ASSERT_DO_TRANS;
Perl_croak(aTHX_ "Illegal number of bits in vec");
if (SvUTF8(sv)) {
- if (Perl_sv_utf8_downgrade(aTHX_ sv, TRUE)) {
+ if (Perl_sv_utf8_downgrade_flags(aTHX_ sv, TRUE, 0)) {
/* PVX may have changed */
s = (unsigned char *) SvPV_flags(sv, srclen, svpv_flags);
}
else {
- Perl_ck_warner_d(aTHX_ packWARN(WARN_DEPRECATED),
- "Use of strings with code points over 0xFF as"
- " arguments to vec is deprecated. This will"
- " be a fatal error in Perl 5.32");
+ Perl_croak(aTHX_ "Use of strings with code points over 0xFF as arguments to vec is forbidden");
}
}
SV_GMAGIC | SV_UNDEF_RETURNS_NULL);
if (SvUTF8(targ)) {
/* This is handled by the SvPOK_only below...
- if (!Perl_sv_utf8_downgrade(aTHX_ targ, TRUE))
+ if (!Perl_sv_utf8_downgrade_flags(aTHX_ targ, TRUE, 0))
SvUTF8_off(targ);
*/
- (void) Perl_sv_utf8_downgrade(aTHX_ targ, TRUE);
+ (void) Perl_sv_utf8_downgrade_flags(aTHX_ targ, TRUE, 0);
}
(void)SvPOK_only(targ);
STRLEN rightlen;
const char *lc;
const char *rc;
- STRLEN len;
+ STRLEN len = 0;
STRLEN lensave;
const char *lsave;
const char *rsave;
* on zeros without having to do it. In the case of '&', the result is
* zero, and the dangling portion is simply discarded. For '|' and '^', the
* result is the same as the other operand, so the dangling part is just
- * appended to the final result, unchanged. We currently accept above-FF
- * code points in the dangling portion, as that's how it has long worked,
- * and code depends on it staying that way. But it is now fatal for
- * above-FF to appear in the portion that does get operated on. Hence, any
- * above-FF must come only in the longer operand, and only in its dangling
- * portion. That means that at least one of the operands has to be
- * entirely non-UTF-8, and the length of that operand has to be before the
- * first above-FF in the other */
- if (left_utf8) {
- if (right_utf8 || rightlen > leftlen) {
- Perl_croak(aTHX_ fatal_above_ff_msg, PL_op_desc[optype]);
- }
- len = rightlen;
- }
- else if (right_utf8) {
- if (leftlen > rightlen) {
- Perl_croak(aTHX_ fatal_above_ff_msg, PL_op_desc[optype]);
- }
- len = leftlen;
+ * appended to the final result, unchanged. As of perl-5.32, we no longer
+ * accept above-FF code points in the dangling portion.
+ */
+ if (left_utf8 || right_utf8) {
+ Perl_croak(aTHX_ FATAL_ABOVE_FF_MSG, PL_op_desc[optype]);
}
else { /* Neither is UTF-8 */
- len = leftlen < rightlen ? leftlen : rightlen;
+ len = MIN(leftlen, rightlen);
}
lensave = len;
len = lensave;
if (rightlen > len) {
if (dc == rc)
- SvCUR(sv) = rightlen;
+ SvCUR_set(sv, rightlen);
else
sv_catpvn_nomg(sv, rsave + len, rightlen - len);
}
else if (leftlen > len) {
if (dc == lc)
- SvCUR(sv) = leftlen;
+ SvCUR_set(sv, leftlen);
else
sv_catpvn_nomg(sv, lsave + len, leftlen - len);
}