my $TB = Test::More->builder;
-plan tests => 136;
+plan tests => 466;
-# We're going to override rename() later on but Perl has to see an override
+# We are going to override rename() later on but Perl has to see an override
# at compile time to honor it.
BEGIN { *CORE::GLOBAL::rename = sub { CORE::rename($_[0], $_[1]) }; }
-use File::Copy;
+use File::Copy qw(copy move cp);
use Config;
{
my $warnings = '';
local $SIG{__WARN__} = sub { $warnings .= join '', @_ };
- ok copy("file-$$", "file-$$"), 'copy(fn, fn) succeeds';
+ ok !copy("file-$$", "file-$$"), 'copy to itself fails';
like $warnings, qr/are identical/, 'but warns';
ok -s "file-$$", 'contents preserved';
local $SIG{__WARN__} = sub { push @warnings, join '', @_ };
# pie-$$ so that we force a non-constant, else the numeric conversion (of 0)
- # is cached and we don't get a warning the second time round
+ # is cached and we do not get a warning the second time round
is eval { copy("file-$$", "copy-$$", "pie-$$"); 1 }, undef,
"a bad buffer size fails to copy";
like $@, qr/Bad buffer size for copy/, "with a helpful error message";
unlink "file-$$" or die $!;
unlink "copy-$$" or die $!;
+
+ # RT #73714 copy to file with leading whitespace failed
+
+ TODO: {
+ local $TODO = 'spaces in filenames require DECC$EFS_CHARSET enabled' if $^O eq 'VMS';
+ open(F, ">file-$$") or die $!;
+ close F;
+ copy "file-$$", " copy-$$";
+ ok -e " copy-$$", "copy with leading whitespace";
+ unlink "file-$$" or die "unlink: $!";
+ unlink " copy-$$" or die "unlink: $!";
+ }
}
+my $can_suidp = sub {
+ my $dir = "suid-$$";
+ my $ok = 1;
+ mkdir $dir or die "Can't mkdir($dir) for suid test";
+ $ok = 0 unless chmod 2000, $dir;
+ rmdir $dir;
+ return $ok;
+};
SKIP: {
+ my @tests = (
+ [0000, 0777, 0777, 0777],
+ [0000, 0751, 0751, 0644],
+ [0022, 0777, 0755, 0206],
+ [0022, 0415, 0415, 0666],
+ [0077, 0777, 0700, 0333],
+ [0027, 0755, 0750, 0251],
+ [0777, 0751, 0000, 0215],
+ );
+
+ my $skips = @tests * 6 * 8;
+
+ my $can_suid = $can_suidp->();
+ skip "Can't suid on this $^O filesystem", $skips unless $can_suid;
+ skip "-- Copy preserves RMS defaults, not POSIX permissions.", $skips
+ if $^O eq 'VMS';
+ skip "Copy doesn't set file permissions correctly on Win32.", $skips
+ if $^O eq "MSWin32";
+ skip "Copy maps POSIX permissions to VOS permissions.", $skips
+ if $^O eq "vos";
+ skip "There be dragons here with DragonflyBSD.", $skips
+ if $^O eq 'dragonfly';
- skip "-- Copy preserves RMS defaults, not source file permissions.", 21 if $^O eq 'VMS';
- skip "Copy doesn't set file permissions correctly on Win32.", 21 if $^O eq "MSWin32";
# Just a sub to get better failure messages.
sub __ ($) {
- join "" => map {(qw [--- --x -w- -wx r-- r-x rw- rwx]) [$_]}
- split // => sprintf "%03o" => shift
+ my $perm = shift;
+ my $id = 07000 & $perm;
+ $id >>= 9;
+ $perm &= 0777;
+ my @chunks = map {(qw [--- --x -w- -wx r-- r-x rw- rwx]) [$_]}
+ split // => sprintf "%03o" => $perm;
+ if ($id & 4) {$chunks [0] =~ s/(.)$/$1 eq '-' ? 'S' : 's'/e;}
+ if ($id & 2) {$chunks [1] =~ s/(.)$/$1 eq '-' ? 'S' : 's'/e;}
+ if ($id & 1) {$chunks [2] =~ s/(.)$/$1 eq '-' ? 'T' : 't'/e;}
+ join "" => @chunks;
}
# Testing permission bits.
my $src = "file-$$";
my $copy1 = "copy1-$$";
my $copy2 = "copy2-$$";
my $copy3 = "copy3-$$";
+ my $copy4 = "copy4-$$";
+ my $copy5 = "copy5-$$";
+ my $copy6 = "copy6-$$";
+ my $copyd = "copyd-$$";
open my $fh => ">", $src or die $!;
close $fh or die $!;
open $fh => ">", $copy3 or die $!;
close $fh or die $!;
- my @tests = (
- [0000, 0777, 0777, 0777],
- [0000, 0751, 0751, 0644],
- [0022, 0777, 0755, 0206],
- [0022, 0415, 0415, 0666],
- [0077, 0777, 0700, 0333],
- [0027, 0755, 0750, 0251],
- [0777, 0751, 0000, 0215],
- );
+ open $fh => ">", $copy6 or die $!;
+ close $fh or die $!;
+
my $old_mask = umask;
foreach my $test (@tests) {
- my ($umask, $s_perm, $c_perm1, $c_perm3) = @$test;
- # Make sure the copies doesn't exist.
- ! -e $_ or unlink $_ or die $! for $copy1, $copy2;
-
- (umask $umask) // die $!;
- chmod $s_perm => $src or die $!;
- chmod $c_perm3 => $copy3 or die $!;
-
- open my $fh => "<", $src or die $!;
-
- copy ($src, $copy1);
- copy ($fh, $copy2);
- copy ($src, $copy3);
-
- my $perm1 = (stat $copy1) [2] & 0xFFF;
- my $perm2 = (stat $copy2) [2] & 0xFFF;
- my $perm3 = (stat $copy3) [2] & 0xFFF;
- is (__$perm1, __$c_perm1, "Permission bits set correctly");
- is (__$perm2, __$c_perm1, "Permission bits set correctly");
- TODO: {
- local $TODO = 'Permission bits inconsistent under cygwin' if $^O eq 'cygwin';
+ foreach my $id (0 .. 7) {
+ my ($umask, $s_perm, $c_perm1, $c_perm3) = @$test;
+ # Make sure the copies do not exist.
+ ! -e $_ or unlink $_ or die $! for $copy1, $copy2, $copy4, $copy5;
+
+ $s_perm |= $id << 9;
+ $c_perm1 |= $id << 9;
+ diag(sprintf "Src permission: %04o; umask %03o\n", $s_perm, $umask)
+ unless ($ENV{PERL_CORE});
+
+ # Test that we can actually set a file to the correct permission.
+ # Slightly convoluted, because some operating systems will let us
+ # set a directory, but not a file. These should all work:
+ mkdir $copyd or die "Can't mkdir $copyd: $!";
+ chmod $s_perm, $copyd
+ or die sprintf "Can't chmod %o $copyd: $!", $s_perm;
+ rmdir $copyd
+ or die sprintf "Can't rmdir $copyd: $!";
+ open my $fh0, '>', $copy1 or die "Can't open $copy1: $!";
+ close $fh0 or die "Can't close $copy1: $!";
+ unless (chmod $s_perm, $copy1) {
+ $TB->skip(sprintf "Can't chmod $copy1 to %o: $!", $s_perm)
+ for 1..6;
+ next;
+ }
+ my $perm0 = (stat $copy1) [2] & 07777;
+ unless ($perm0 == $s_perm) {
+ $TB->skip(sprintf "chmod %o $copy1 lies - we actually get %o",
+ $s_perm, $perm0)
+ for 1..6;
+ next;
+ }
+ unlink $copy1 or die "Can't unlink $copy1: $!";
+
+ (umask $umask) // die $!;
+ chmod $s_perm => $src or die sprintf "$!: $src => %o", $s_perm;
+ chmod $c_perm3 => $copy3 or die $!;
+ chmod $c_perm3 => $copy6 or die $!;
+
+ open my $fh => "<", $src or die $!;
+
+ copy ($src, $copy1);
+ copy ($fh, $copy2);
+ copy ($src, $copy3);
+ cp ($src, $copy4);
+ cp ($fh, $copy5);
+ cp ($src, $copy6);
+
+ my $permdef = 0666 & ~$umask;
+ my $perm1 = (stat $copy1) [2] & 07777;
+ my $perm2 = (stat $copy2) [2] & 07777;
+ my $perm3 = (stat $copy3) [2] & 07777;
+ my $perm4 = (stat $copy4) [2] & 07777;
+ my $perm5 = (stat $copy5) [2] & 07777;
+ my $perm6 = (stat $copy6) [2] & 07777;
+ is (__$perm1, __$permdef, "Permission bits set correctly");
+ is (__$perm2, __$permdef, "Permission bits set correctly");
+ is (__$perm4, __$c_perm1, "Permission bits set correctly");
+ is (__$perm5, __$c_perm1, "Permission bits set correctly");
is (__$perm3, __$c_perm3, "Permission bits not modified");
+ is (__$perm6, __$c_perm3, "Permission bits not modified");
}
}
umask $old_mask or die $!;
# Clean up.
- ! -e $_ or unlink $_ or die $! for $src, $copy1, $copy2, $copy3;
+ ! -e $_ or unlink $_ or die $! for $src, $copy1, $copy2, $copy3,
+ $copy4, $copy5, $copy6;
}
{
foreach my $right (qw(plain object1 object2)) {
@warnings = ();
$! = 0;
- is eval {copy $what{$left}, $what{$right}}, 1, "copy $left $right";
+ is eval {copy $what{$left}, $what{$right}}, 0, "copy $left $right";
is $@, '', 'No croaking';
is $!, '', 'No system call errors';
is @warnings, 1, 'Exactly 1 warning';
}
}
+# On Unix systems, File::Copy always returns 0 to signal failure,
+# even when in list context! On Windows, it always returns "" to signal
+# failure.
+#
+# While returning a list containing a false value is arguably a bad
+# API design, at the very least we can make sure it always returns
+# the same false value.
+
+my $NO_SUCH_FILE = "this_file_had_better_not_exist";
+my $NO_SUCH_OTHER_FILE = "my_goodness_im_sick_of_airports";
+
+use constant EXPECTED_SCALAR => 0;
+use constant EXPECTED_LIST => [ EXPECTED_SCALAR ];
+
+my %subs = (
+ copy => \&File::Copy::copy,
+ cp => \&File::Copy::cp,
+ move => \&File::Copy::move,
+ mv => \&File::Copy::mv,
+);
+
+SKIP: {
+ skip( "Test can't run with $NO_SUCH_FILE existing", 2 * keys %subs)
+ if (-e $NO_SUCH_FILE);
+
+ foreach my $name (keys %subs) {
+
+ my $sub = $subs{$name};
+
+ my $scalar = $sub->( $NO_SUCH_FILE, $NO_SUCH_OTHER_FILE );
+ is( $scalar, EXPECTED_SCALAR, "$name in scalar context");
+
+ my @array = $sub->( $NO_SUCH_FILE, $NO_SUCH_OTHER_FILE );
+ is_deeply( \@array, EXPECTED_LIST, "$name in list context");
+ }
+}
+
+SKIP: {
+ skip("fork required to test pipe copying", 2)
+ if (!$Config{'d_fork'});
+
+ open(my $IN, "-|") || exec $^X, '-e', 'print "Hello, world!\n"';
+ open(my $OUT, "|-") || exec $^X, '-ne', 'exit(/Hello/ ? 55 : 0)';
+
+ ok(copy($IN, $OUT), "copy pipe to another");
+ close($OUT);
+ is($? >> 8, 55, "content copied through the pipes");
+ close($IN);
+}
+
+use File::Temp qw(tempdir);
+use File::Spec;
+
+SKIP: {
+ # RT #111126: File::Copy copy() zeros file when copying a file
+ # into the same directory it is stored in
+
+ my $temp_dir = tempdir( CLEANUP => 1 );
+ my $temp_file = File::Spec->catfile($temp_dir, "somefile");
+
+ open my $fh, ">", $temp_file
+ or skip "Cannot create $temp_file: $!", 2;
+ print $fh "Just some data";
+ close $fh
+ or skip "Cannot close $temp_file: $!", 2;
+
+ my $warn_message = "";
+ local $SIG{__WARN__} = sub { $warn_message .= "@_" };
+ ok(!copy($temp_file, $temp_dir),
+ "Copy of foo/file to foo/ should fail");
+ like($warn_message, qr/^\Q'$temp_file' and '$temp_file'\E are identical.*Copy\.t/i,
+ "error message should describe the problem");
+ 1 while unlink $temp_file;
+}
+
+{
+ open(my $F, '>', "file-$$") or die $!;
+ binmode $F; # for DOSISH platforms
+ printf $F "ok\n";
+ close $F;
+
+ my $buffer = (1024 * 1024 * 2) + 1;
+ is eval {copy "file-$$", "copy-$$", $buffer}, 1,
+ "copy with buffer above normal size";
+}
+
+
END {
+ 1 while unlink "copy-$$";
1 while unlink "file-$$";
1 while unlink "lib/file-$$";
}
https://perl5.git.perl.org / perl5.git / blobdiff