This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
threads-shared 1.03 - Changes, Makefile.PL
[perl5.git] / regexec.c
index a94625e..f7f0d2b 100644 (file)
--- a/regexec.c
+++ b/regexec.c
@@ -77,7 +77,7 @@
 
 #define RF_tainted     1               /* tainted information used? */
 #define RF_warned      2               /* warned about big count? */
-#define RF_evaled      4               /* Did an EVAL with setting? */
+
 #define RF_utf8                8               /* Pattern contains multibyte chars? */
 
 #define UTF ((PL_reg_flags & RF_utf8) != 0)
                ? (U8*)pos - off                \
                : NULL)
 
-#define HOP3(pos,off,lim) (PL_reg_match_utf8 ? reghop3((U8*)pos, off, (U8*)lim) : (U8*)(pos + off))
+#define HOP3(pos,off,lim) (PL_reg_match_utf8 ? reghop3((U8*)(pos), off, (U8*)(lim)) : (U8*)(pos + off))
 #define HOP3c(pos,off,lim) ((char*)HOP3(pos,off,lim))
 
 #define LOAD_UTF8_CHARCLASS(class,str) STMT_START { \
@@ -356,7 +356,7 @@ Perl_re_intuit_start(pTHX_ regexp *prog, SV *sv, char *strpos,
     register SV *check;
     char *strbeg;
     char *t;
-    const int do_utf8 = sv ? SvUTF8(sv) : 0;   /* if no sv we have to assume bytes */
+    const bool do_utf8 = (sv && SvUTF8(sv)) ? 1 : 0; /* if no sv we have to assume bytes */
     I32 ml_anch;
     register char *other_last = NULL;  /* other substr checked before this */
     char *check_at = NULL;             /* check substr found at this pos */
@@ -374,7 +374,8 @@ Perl_re_intuit_start(pTHX_ regexp *prog, SV *sv, char *strpos,
     }
     DEBUG_EXECUTE_r( 
         debug_start_match(prog, do_utf8, strpos, strend, 
-            "Guessing start of match for");
+            sv ? "Guessing start of match in sv for"
+               : "Guessing start of match in string for");
              );
 
     /* CHR_DIST() would be more correct here but it makes things slow. */
@@ -383,6 +384,7 @@ Perl_re_intuit_start(pTHX_ regexp *prog, SV *sv, char *strpos,
                              "String too short... [re_intuit_start]\n"));
        goto fail;
     }
+                
     strbeg = (sv && SvPOK(sv)) ? strend - SvCUR(sv) : strpos;
     PL_regeol = strend;
     if (do_utf8) {
@@ -394,9 +396,9 @@ Perl_re_intuit_start(pTHX_ regexp *prog, SV *sv, char *strpos,
            to_byte_substr(prog);
        check = prog->check_substr;
     }
-   if (check == &PL_sv_undef) {
+    if (check == &PL_sv_undef) {
        DEBUG_EXECUTE_r(PerlIO_printf(Perl_debug_log,
-               "Non-utf string cannot match utf check string\n"));
+               "Non-utf8 string cannot match utf8 check string\n"));
        goto fail;
     }
     if (prog->reganch & ROPT_ANCH) {   /* Match at beg-of-str or after \n */
@@ -419,6 +421,7 @@ Perl_re_intuit_start(pTHX_ regexp *prog, SV *sv, char *strpos,
            I32 slen;
 
            s = HOP3c(strpos, prog->check_offset_min, strend);
+           
            if (SvTAIL(check)) {
                slen = SvCUR(check);    /* >= 1 */
 
@@ -448,8 +451,8 @@ Perl_re_intuit_start(pTHX_ regexp *prog, SV *sv, char *strpos,
        /* Match is anchored, but substr is not anchored wrt beg-of-str. */
        s = strpos;
        start_shift = prog->check_offset_min; /* okay to underestimate on CC */
-       end_shift = prog->minlen - start_shift -
-           CHR_SVLEN(check) + (SvTAIL(check) != 0);
+       end_shift = prog->check_end_shift;
+       
        if (!ml_anch) {
            const I32 end = prog->check_offset_max + CHR_SVLEN(check)
                                         - (SvTAIL(check) != 0);
@@ -462,20 +465,37 @@ Perl_re_intuit_start(pTHX_ regexp *prog, SV *sv, char *strpos,
     else {                             /* Can match at random position */
        ml_anch = 0;
        s = strpos;
-       start_shift = prog->check_offset_min; /* okay to underestimate on CC */
-       /* Should be nonnegative! */
-       end_shift = prog->minlen - start_shift -
-           CHR_SVLEN(check) + (SvTAIL(check) != 0);
+       start_shift = prog->check_offset_min;  /* okay to underestimate on CC */
+       end_shift = prog->check_end_shift;
+       
+       /* end shift should be non negative here */
     }
 
 #ifdef DEBUGGING       /* 7/99: reports of failure (with the older version) */
     if (end_shift < 0)
-       Perl_croak(aTHX_ "panic: end_shift");
+       Perl_croak(aTHX_ "panic: end_shift: %"IVdf" pattern:\n%s\n ",
+                  (IV)end_shift, prog->precomp);
 #endif
 
   restart:
     /* Find a possible match in the region s..strend by looking for
        the "check" substring in the region corrected by start/end_shift. */
+    
+    {
+        I32 srch_start_shift = start_shift;
+        I32 srch_end_shift = end_shift;
+        if (srch_start_shift < 0 && strbeg - s > srch_start_shift) {
+           srch_end_shift -= ((strbeg - s) - srch_start_shift); 
+           srch_start_shift = strbeg - s;
+       }
+    DEBUG_OPTIMISE_r({
+        PerlIO_printf(Perl_debug_log, "Check offset min: %"IVdf" Start shift: %"IVdf" End shift %"IVdf" Real End Shift: %"IVdf"\n",
+            (IV)prog->check_offset_min,
+            (IV)srch_start_shift,
+            (IV)srch_end_shift, 
+            (IV)prog->check_end_shift);
+    });       
+        
     if (flags & REXEC_SCREAM) {
        I32 p = -1;                     /* Internal iterator of scream. */
        I32 * const pp = data ? data->scream_pos : &p;
@@ -485,7 +505,7 @@ Perl_re_intuit_start(pTHX_ regexp *prog, SV *sv, char *strpos,
                 && (BmPREVIOUS(check) == SvCUR(check) - 1)
                 && SvTAIL(check) ))
            s = screaminstr(sv, check,
-                           start_shift + (s - strbeg), end_shift, pp, 0);
+                           srch_start_shift + (s - strbeg), srch_end_shift, pp, 0);
        else
            goto fail_finish;
        /* we may be pointing at the wrong string */
@@ -494,15 +514,27 @@ Perl_re_intuit_start(pTHX_ regexp *prog, SV *sv, char *strpos,
        if (data)
            *data->scream_olds = s;
     }
-    else if (prog->reganch & ROPT_CANY_SEEN)
-       s = fbm_instr((U8*)(s + start_shift),
-                     (U8*)(strend - end_shift),
-                     check, multiline ? FBMrf_MULTILINE : 0);
-    else
-       s = fbm_instr(HOP3(s, start_shift, strend),
-                     HOP3(strend, -end_shift, strbeg),
+    else {
+        U8* start_point;
+        U8* end_point;
+        if (prog->reganch & ROPT_CANY_SEEN) {
+            start_point= (U8*)(s + srch_start_shift);
+            end_point= (U8*)(strend - srch_end_shift);
+        } else {
+           start_point= HOP3(s, srch_start_shift, srch_start_shift < 0 ? strbeg : strend);
+            end_point= HOP3(strend, -srch_end_shift, strbeg);
+       }
+       DEBUG_OPTIMISE_r({
+            PerlIO_printf(Perl_debug_log, "fbm_instr len=%d str=<%.*s>\n", 
+                (int)(end_point - start_point),
+                (int)(end_point - start_point) > 20 ? 20 : (int)(end_point - start_point), 
+                start_point);
+        });
+
+       s = fbm_instr( start_point, end_point,
                      check, multiline ? FBMrf_MULTILINE : 0);
-
+    }
+    }
     /* Update the count-of-usability, remove useless subpatterns,
        unshift s.  */
 
@@ -520,12 +552,20 @@ Perl_re_intuit_start(pTHX_ regexp *prog, SV *sv, char *strpos,
 
     if (!s)
        goto fail_finish;
-
-    check_at = s;
-
     /* Finish the diagnostic message */
     DEBUG_EXECUTE_r(PerlIO_printf(Perl_debug_log, "%ld...\n", (long)(s - i_strpos)) );
 
+    /* XXX dmq: first branch is for positive lookbehind...
+       Our check string is offset from the beginning of the pattern.
+       So we need to do any stclass tests offset forward from that 
+       point. I think. :-(
+     */
+    
+        
+    
+    check_at=s;
+     
+
     /* Got a candidate.  Check MBOL anchoring, and the *other* substr.
        Start with the other substr.
        XXXX no SCREAM optimization yet - and a very coarse implementation
@@ -534,7 +574,9 @@ Perl_re_intuit_start(pTHX_ regexp *prog, SV *sv, char *strpos,
        Probably it is right to do no SCREAM here...
      */
 
-    if (do_utf8 ? (prog->float_utf8 && prog->anchored_utf8) : (prog->float_substr && prog->anchored_substr)) {
+    if (do_utf8 ? (prog->float_utf8 && prog->anchored_utf8) 
+                : (prog->float_substr && prog->anchored_substr)) 
+    {
        /* Take into account the "other" substring. */
        /* XXXX May be hopelessly wrong for UTF... */
        if (!other_last)
@@ -561,12 +603,17 @@ Perl_re_intuit_start(pTHX_ regexp *prog, SV *sv, char *strpos,
                last2 = last1 = HOP3c(strend, -prog->minlen, strbeg);
                if (last < last1)
                    last1 = last;
- /* XXXX It is not documented what units *_offsets are in.  Assume bytes.  */
+                /* XXXX It is not documented what units *_offsets are in.  
+                   We assume bytes, but this is clearly wrong. 
+                   Meaning this code needs to be carefully reviewed for errors.
+                   dmq.
+                  */
                /* On end-of-str: see comment below. */
                must = do_utf8 ? prog->anchored_utf8 : prog->anchored_substr;
                if (must == &PL_sv_undef) {
                    s = (char*)NULL;
-                   DEBUG_EXECUTE_r(must = prog->anchored_utf8);        /* for debug */
+                   DEBUG_r(must = prog->anchored_utf8);        /* for debug */
                }
                else
                    s = fbm_instr(
@@ -630,7 +677,7 @@ Perl_re_intuit_start(pTHX_ regexp *prog, SV *sv, char *strpos,
               and end-of-str is not later than strend we are OK. */
            if (must == &PL_sv_undef) {
                s = (char*)NULL;
-               DEBUG_EXECUTE_r(must = prog->float_utf8);       /* for debug message */
+               DEBUG_r(must = prog->float_utf8);       /* for debug message */
            }
            else
                s = fbm_instr((unsigned char*)s,
@@ -669,11 +716,26 @@ Perl_re_intuit_start(pTHX_ regexp *prog, SV *sv, char *strpos,
        }
     }
 
-    t = s - prog->check_offset_max;
+    
+    t= (char*)HOP3( s, -prog->check_offset_max, (prog->check_offset_max<0) ? strend : strpos);
+        
+    DEBUG_OPTIMISE_r(
+        PerlIO_printf(Perl_debug_log, 
+            "Check offset min:%"IVdf" max:%"IVdf" S:%"IVdf" t:%"IVdf" D:%"IVdf" end:%"IVdf"\n",
+            (IV)prog->check_offset_min,
+            (IV)prog->check_offset_max,
+            (IV)(s-strpos),
+            (IV)(t-strpos),
+            (IV)(t-s),
+            (IV)(strend-strpos)
+        )
+    );
+
     if (s - strpos > prog->check_offset_max  /* signed-corrected t > strpos */
         && (!do_utf8
-           || ((t = (char*)reghopmaybe3((U8*)s, -prog->check_offset_max, (U8*)strpos))
-                && t > strpos))) {
+           || ((t = (char*)reghopmaybe3((U8*)s, -prog->check_offset_max, (U8*) ((prog->check_offset_max<0) ? strend : strpos)))
+                && t > strpos))) 
+    {
        /* Fixed substring is found far enough so that the match
           cannot start at strpos. */
       try_at_offset:
@@ -782,6 +844,8 @@ Perl_re_intuit_start(pTHX_ regexp *prog, SV *sv, char *strpos,
 
     /* Last resort... */
     /* XXXX BmUSEFUL already changed, maybe multiple change is meaningful... */
+    /* trie stclasses are too expensive to use here, we are better off to
+       leave it to regmatch itself */
     if (prog->regstclass && PL_regkind[OP(prog->regstclass)]!=TRIE) {
        /* minlen == 0 is possible if regstclass is \b or \B,
           and the fixed substr is ''$.
@@ -795,14 +859,17 @@ Perl_re_intuit_start(pTHX_ regexp *prog, SV *sv, char *strpos,
         const int cl_l = (PL_regkind[OP(prog->regstclass)] == EXACT
                    ? CHR_DIST(str+STR_LEN(prog->regstclass), str)
                    : 1);
-       const char * endpos = (prog->anchored_substr || prog->anchored_utf8 || ml_anch)
-               ? HOP3c(s, (prog->minlen ? cl_l : 0), strend)
-               : (prog->float_substr || prog->float_utf8
-                  ? HOP3c(HOP3c(check_at, -start_shift, strbeg),
-                          cl_l, strend)
-                  : strend);
-        /*if (OP(prog->regstclass) == TRIE)
-            endpos++;*/
+       char * endpos;
+       if (prog->anchored_substr || prog->anchored_utf8 || ml_anch)
+            endpos= HOP3c(s, (prog->minlen ? cl_l : 0), strend);
+        else if (prog->float_substr || prog->float_utf8)
+           endpos= HOP3c(HOP3c(check_at, -start_shift, strbeg), cl_l, strend);
+        else 
+            endpos= strend;
+                   
+        DEBUG_EXECUTE_r(PerlIO_printf(Perl_debug_log, "start_shift: %"IVdf" check_at: %d s: %d endpos: %d\n",
+                                     (IV)start_shift, check_at - strbeg, s - strbeg, endpos - strbeg));
+       
        t = s;
         s = find_byclass(prog, prog->regstclass, s, endpos, NULL);
        if (!s) {
@@ -1329,8 +1396,8 @@ S_find_byclass(pTHX_ regexp * prog, const regnode *c, char *s,
                !isDIGIT_LC_utf8((U8*)s),
                !isDIGIT_LC(*s)
            );
-       case TRIEC:
-       case TRIE
+       case AHOCORASICKC:
+       case AHOCORASICK
            {
                const enum { trie_plain, trie_utf8, trie_utf8_fold }
                    trie_type = do_utf8 ?
@@ -1369,7 +1436,9 @@ S_find_byclass(pTHX_ regexp * prog, const regnode *c, char *s,
                 SvPOK_on(sv_points);
                 sv_2mortal(sv_points);
                 points=(U8**)SvPV_nolen(sv_points );
-                if ( trie_type != trie_utf8_fold && (trie->bitmap || OP(c)==TRIEC) ) {
+                if ( trie_type != trie_utf8_fold 
+                     && (trie->bitmap || OP(c)==AHOCORASICKC) ) 
+                {
                     if (trie->bitmap) 
                         bitmap=(U8*)trie->bitmap;
                     else
@@ -1412,19 +1481,21 @@ S_find_byclass(pTHX_ regexp * prog, const regnode *c, char *s,
                         int failed=0;
                         U32 word = aho->states[ state ].wordnum;
 
-                        if( state==1 && bitmap ) {
-                            DEBUG_TRIE_EXECUTE_r(
-                                if ( uc <= (U8*)last_start && !BITMAP_TEST(bitmap,*uc) ) {
-                                    dump_exec_pos( (char *)uc, c, strend, real_start, 
-                                        (char*)uc, do_utf8 );
-                                    PerlIO_printf( Perl_debug_log,
-                                        " Scanning for legal start char...\n");
+                        if( state==1 ) {
+                            if ( bitmap ) {
+                                DEBUG_TRIE_EXECUTE_r(
+                                    if ( uc <= (U8*)last_start && !BITMAP_TEST(bitmap,*uc) ) {
+                                        dump_exec_pos( (char *)uc, c, strend, real_start, 
+                                            (char *)uc, do_utf8 );
+                                        PerlIO_printf( Perl_debug_log,
+                                            " Scanning for legal start char...\n");
+                                    }
+                                );            
+                                while ( uc <= (U8*)last_start  && !BITMAP_TEST(bitmap,*uc) ) {
+                                    uc++;
                                 }
-                            );            
-                            while ( uc <= (U8*)last_start  && !BITMAP_TEST(bitmap,*uc) ) {
-                                uc++;
+                                s= (char *)uc;
                             }
-                            s= (char *)uc;    
                             if (uc >(U8*)last_start) break;
                         }
                                             
@@ -1566,7 +1637,7 @@ Perl_regexec_flags(pTHX_ register regexp *prog, char *stringarg, register char *
     I32 scream_pos = -1;               /* Internal iterator of scream. */
     char *scream_olds = NULL;
     SV* const oreplsv = GvSV(PL_replgv);
-    const bool do_utf8 = DO_UTF8(sv);
+    const bool do_utf8 = (bool)DO_UTF8(sv);
     I32 multiline;
 
     regmatch_info reginfo;  /* create some info to pass to regtry etc */
@@ -1585,14 +1656,20 @@ Perl_regexec_flags(pTHX_ register regexp *prog, char *stringarg, register char *
     reginfo.prog = prog;
 
     RX_MATCH_UTF8_set(prog, do_utf8);
+    DEBUG_EXECUTE_r( 
+        debug_start_match(prog, do_utf8, startpos, strend, 
+        "Matching");
+    );
 
     minlen = prog->minlen;
-    if (strend - startpos < minlen) {
+    
+    if (strend - startpos < (minlen+(prog->check_offset_min<0?prog->check_offset_min:0))) {
         DEBUG_EXECUTE_r(PerlIO_printf(Perl_debug_log,
                              "String too short [regexec_flags]...\n"));
        goto phooey;
     }
 
+    
     /* Check validity of program. */
     if (UCHARAT(prog->program) != REG_MAGIC) {
        Perl_croak(aTHX_ "corrupted regexp program");
@@ -1651,10 +1728,7 @@ Perl_regexec_flags(pTHX_ register regexp *prog, char *stringarg, register char *
        }
     }
 
-    DEBUG_EXECUTE_r( 
-        debug_start_match(prog, do_utf8, startpos, strend, 
-            "Matching");
-             );
+
 
     /* Simplest case:  anchored match need be tried only once. */
     /*  [unless only anchor is BOL and multiline is set] */
@@ -1699,7 +1773,11 @@ Perl_regexec_flags(pTHX_ register regexp *prog, char *stringarg, register char *
            }
        }
        goto phooey;
-    } else if (prog->reganch & ROPT_ANCH_GPOS) {
+    } else if (ROPT_GPOS_CHECK == (prog->reganch & ROPT_GPOS_CHECK)) 
+    {
+        /* the warning about reginfo.ganch being used without intialization
+           is bogus -- we set it above, when prog->reganch & ROPT_GPOS_SEEN 
+           and we only enter this block when the same bit is set. */
        if (regtry(&reginfo, reginfo.ganch))
            goto got_it;
        goto phooey;
@@ -1768,14 +1846,19 @@ Perl_regexec_flags(pTHX_ register regexp *prog, char *stringarg, register char *
            back_max = prog->float_max_offset;
            back_min = prog->float_min_offset;
        }
+       
+           
        if (must == &PL_sv_undef)
            /* could not downgrade utf8 check substring, so must fail */
            goto phooey;
 
-       last = HOP3c(strend,    /* Cannot start after this */
-                         -(I32)(CHR_SVLEN(must)
-                                - (SvTAIL(must) != 0) + back_min), strbeg);
-
+        if (back_min<0) {
+           last = strend;
+       } else {
+            last = HOP3c(strend,       /* Cannot start after this */
+                 -(I32)(CHR_SVLEN(must)
+                        - (SvTAIL(must) != 0) + back_min), strbeg);
+        }
        if (s > PL_bostr)
            last1 = HOPc(s, -1);
        else
@@ -1788,9 +1871,9 @@ Perl_regexec_flags(pTHX_ register regexp *prog, char *stringarg, register char *
        strend = HOPc(strend, -dontbother);
        while ( (s <= last) &&
                ((flags & REXEC_SCREAM)
-                ? (s = screaminstr(sv, must, HOP3c(s, back_min, strend) - strbeg,
+                ? (s = screaminstr(sv, must, HOP3c(s, back_min, (back_min<0 ? strbeg : strend)) - strbeg,
                                    end_shift, &scream_pos, 0))
-                : (s = fbm_instr((unsigned char*)HOP3(s, back_min, strend),
+                : (s = fbm_instr((unsigned char*)HOP3(s, back_min, (back_min<0 ? strbeg : strend)),
                                  (unsigned char*)strend, must,
                                  multiline ? FBMrf_MULTILINE : 0))) ) {
            /* we may be pointing at the wrong string */
@@ -1993,9 +2076,6 @@ S_regtry(pTHX_ const regmatch_info *reginfo, char *startpos)
     regexp *prog = reginfo->prog;
     GET_RE_DEBUG_FLAGS_DECL;
 
-#ifdef DEBUGGING
-    PL_regindent = 0;  /* XXXX Not good when matches are reenterable... */
-#endif
     if ((prog->reganch & ROPT_EVAL_SEEN) && !PL_reg_eval_set) {
        MAGIC *mg;
 
@@ -2121,27 +2201,22 @@ S_regtry(pTHX_ const regmatch_info *reginfo, char *startpos)
 
 #define sayYES goto yes
 #define sayNO goto no
-#define sayNO_ANYOF goto no_anyof
-#define sayYES_FINAL goto yes_final
-#define sayNO_FINAL  goto no_final
-#define sayNO_SILENT goto do_no
+#define sayNO_SILENT goto no_silent
 #define saySAME(x) if (x) goto yes; else goto no
 
-#define CACHEsayNO STMT_START { \
+/* we dont use STMT_START/END here because it leads to 
+   "unreachable code" warnings, which are bogus, but distracting. */
+#define CACHEsayNO \
     if (st->u.whilem.cache_offset | st->u.whilem.cache_bit) \
        PL_reg_poscache[st->u.whilem.cache_offset] |= \
            (1<<st->u.whilem.cache_bit); \
-    sayNO; \
-} STMT_END
-
+    sayNO
 
 /* this is used to determine how far from the left messages like
-   'failed...' are printed. Currently 29 makes these messages line
-   up with the opcode they refer to. Earlier perls used 25 which
-   left these messages outdented making reviewing a debug output
-   quite difficult.
+   'failed...' are printed. It should be set such that messages 
+   are inline with the regop output that created them.
 */
-#define REPORT_CODE_OFF 29
+#define REPORT_CODE_OFF 32
 
 
 /* Make sure there is a test for this +1 options in re_tests */
@@ -2302,37 +2377,21 @@ S_push_slab(pTHX)
  * allocated since entry are freed.
  */
  
-/* *** every FOO_fail should = FOO+1 */
-#define TRIE_next              (REGNODE_MAX+1)
-#define TRIE_next_fail         (REGNODE_MAX+2)
-#define EVAL_A                 (REGNODE_MAX+3)
-#define EVAL_A_fail            (REGNODE_MAX+4)
-#define resume_CURLYX          (REGNODE_MAX+5)
-#define resume_WHILEM1         (REGNODE_MAX+6)
-#define resume_WHILEM2         (REGNODE_MAX+7)
-#define resume_WHILEM3         (REGNODE_MAX+8)
-#define resume_WHILEM4         (REGNODE_MAX+9)
-#define resume_WHILEM5         (REGNODE_MAX+10)
-#define resume_WHILEM6         (REGNODE_MAX+11)
-#define BRANCH_next            (REGNODE_MAX+12)
-#define BRANCH_next_fail       (REGNODE_MAX+13)
-#define CURLYM_A               (REGNODE_MAX+14)
-#define CURLYM_A_fail          (REGNODE_MAX+15)
-#define CURLYM_B               (REGNODE_MAX+16)
-#define CURLYM_B_fail          (REGNODE_MAX+17)
-#define IFMATCH_A              (REGNODE_MAX+18)
-#define IFMATCH_A_fail         (REGNODE_MAX+19)
-#define CURLY_B_min_known      (REGNODE_MAX+20)
-#define CURLY_B_min_known_fail (REGNODE_MAX+21)
-#define CURLY_B_min            (REGNODE_MAX+22)
-#define CURLY_B_min_fail       (REGNODE_MAX+23)
-#define CURLY_B_max            (REGNODE_MAX+24)
-#define CURLY_B_max_fail       (REGNODE_MAX+25)
+
+#define DEBUG_STATE_pp(pp)                                 \
+    DEBUG_STATE_r({                                        \
+       DUMP_EXEC_POS(locinput, scan, do_utf8);             \
+       PerlIO_printf(Perl_debug_log,                       \
+           "    %*s"pp" %s\n",                             \
+           depth*2, "",                                    \
+           reg_name[st->resume_state] );   \
+    });
 
 
 #define REG_NODE_NUM(x) ((x) ? (int)((x)-prog) : -1)
 
 #ifdef DEBUGGING
+
 STATIC void
 S_debug_start_match(pTHX_ const regexp *prog, const bool do_utf8, 
     const char *start, const char *end, const char *blurb)
@@ -2352,9 +2411,10 @@ S_debug_start_match(pTHX_ const regexp *prog, const bool do_utf8,
                       PL_colors[4], blurb, PL_colors[5], s0, s1); 
         
         if (do_utf8||utf8_pat) 
-            PerlIO_printf(Perl_debug_log, "UTF-8 %s...\n",
-                !do_utf8 ? "pattern" : !utf8_pat ? "string" : 
-                    "pattern and string"
+            PerlIO_printf(Perl_debug_log, "UTF-8 %s%s%s...\n",
+                utf8_pat ? "pattern" : "",
+                utf8_pat && do_utf8 ? " and " : "",
+                do_utf8 ? "string" : ""
             ); 
     }
 }
@@ -2396,15 +2456,16 @@ S_dump_exec_pos(pTHX_ const char *locinput,
        const int is_uni = (do_utf8 && OP(scan) != CANY) ? 1 : 0;
 
        RE_PV_COLOR_DECL(s0,len0,is_uni,PERL_DEBUG_PAD(0),
-           (locinput - pref_len),pref0_len, pref0_len, 4, 5);
+           (locinput - pref_len),pref0_len, 60, 4, 5);
        
        RE_PV_COLOR_DECL(s1,len1,is_uni,PERL_DEBUG_PAD(1),
                    (locinput - pref_len + pref0_len),
-                   pref_len - pref0_len, pref_len - pref0_len, 2, 3);
+                   pref_len - pref0_len, 60, 2, 3);
        
        RE_PV_COLOR_DECL(s2,len2,is_uni,PERL_DEBUG_PAD(2),
-                   locinput, loc_regeol - locinput, l, 0, 1);
+                   locinput, loc_regeol - locinput, 10, 0, 1);
 
+       const STRLEN tlen=len0+len1+len2;
        PerlIO_printf(Perl_debug_log,
                    "%4"IVdf" <%.*s%.*s%s%.*s>%*s|",
                    (IV)(locinput - loc_bostr),
@@ -2412,7 +2473,7 @@ S_dump_exec_pos(pTHX_ const char *locinput,
                    len1, s1,
                    (docolor ? "" : "> <"),
                    len2, s2,
-                   15 - l - pref_len + 1,
+                   (int)(tlen > 19 ? 0 :  19 - tlen),
                    "");
     }
 }
@@ -2449,13 +2510,14 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
     int depth = 0;         /* depth of recursion */
     regmatch_state *yes_state = NULL; /* state to pop to on success of
                                                            subpattern */
+    regmatch_state *cur_eval = NULL; /* most recent EVAL_AB state */
+    struct regmatch_state  *cur_curlyx = NULL; /* most recent curlyx */
     U32 state_num;
     
     I32 parenfloor = 0;
 
 #ifdef DEBUGGING
     GET_RE_DEBUG_FLAGS_DECL;
-    PL_regindent++;
 #endif
 
     /* on first ever call to regmatch, allocate first slab */
@@ -2479,7 +2541,7 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
     st->minmod = 0;
     st->sw = 0;
     st->logical = 0;
-    st->cc = NULL;
+    cur_curlyx = NULL;
 
     /* Note that nextchr is a byte even in UTF */
     nextchr = UCHARAT(locinput);
@@ -2488,14 +2550,16 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
 
         DEBUG_EXECUTE_r( {
            SV * const prop = sv_newmortal();
+           regnode *rnext=regnext(scan);
            DUMP_EXEC_POS( locinput, scan, do_utf8 );
            regprop(rex, prop, scan);
             
            PerlIO_printf(Perl_debug_log,
                    "%3"IVdf":%*s%s(%"IVdf")\n",
-                   (IV)(scan - rex->program), PL_regindent*2, "",
+                   (IV)(scan - rex->program), depth*2, "",
                    SvPVX_const(prop),
-                   PL_regkind[OP(scan)] == END ? 0 : (IV)(regnext(scan) - rex->program));
+                   (PL_regkind[OP(scan)] == END || !rnext) ? 
+                       0 : (IV)(rnext - rex->program));
        });
 
        next = scan + NEXT_OFF(scan);
@@ -2585,7 +2649,7 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
                     DEBUG_EXECUTE_r(
                         PerlIO_printf(Perl_debug_log,
                                  "%*s  %sfailed to match trie start class...%s\n",
-                                 REPORT_CODE_OFF+PL_regindent*2, "", PL_colors[4], PL_colors[5])
+                                 REPORT_CODE_OFF+depth*2, "", PL_colors[4], PL_colors[5])
                     );
                     sayNO_SILENT;
                     /* NOTREACHED */
@@ -2612,14 +2676,14 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
                         DEBUG_EXECUTE_r(
                             PerlIO_printf(Perl_debug_log,
                                          "%*s  %smatched empty string...%s\n",
-                                         REPORT_CODE_OFF+PL_regindent*2, "", PL_colors[4], PL_colors[5])
+                                         REPORT_CODE_OFF+depth*2, "", PL_colors[4], PL_colors[5])
                         );
                        break;
                    } else {
                        DEBUG_EXECUTE_r(
                             PerlIO_printf(Perl_debug_log,
                                          "%*s  %sfailed to match trie start class...%s\n",
-                                         REPORT_CODE_OFF+PL_regindent*2, "", PL_colors[4], PL_colors[5])
+                                         REPORT_CODE_OFF+depth*2, "", PL_colors[4], PL_colors[5])
                         );
                        sayNO_SILENT;
                   }
@@ -2652,7 +2716,7 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
 
                while ( state && uc <= (U8*)PL_regeol ) {
                     U32 base = trie->states[ state ].trans.base;
-                    UV uvc;
+                    UV uvc = 0;
                     U16 charid;
                     /* We use charid to hold the wordnum as we don't use it
                        for charid until after we have done the wordnum logic. 
@@ -2698,7 +2762,7 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
                                DUMP_EXEC_POS( (char *)uc, scan, do_utf8 );
                                PerlIO_printf( Perl_debug_log,
                                    "%*s  %sState: %4"UVxf" Accepted: %4"UVxf" ",
-                                   2+PL_regindent * 2, "", PL_colors[4],
+                                   2+depth * 2, "", PL_colors[4],
                                    (UV)state, (UV)ST.accepted );
                    });
 
@@ -2737,7 +2801,7 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
                DEBUG_EXECUTE_r(
                    PerlIO_printf( Perl_debug_log,
                        "%*s  %sgot %"IVdf" possible matches%s\n",
-                       REPORT_CODE_OFF + PL_regindent * 2, "",
+                       REPORT_CODE_OFF + depth * 2, "",
                        PL_colors[4], (IV)ST.accepted, PL_colors[5] );
                );
            }}
@@ -2756,7 +2820,7 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
                                    : NULL;
                    PerlIO_printf( Perl_debug_log,
                        "%*s  %sonly one match left: #%d <%s>%s\n",
-                       REPORT_CODE_OFF+PL_regindent*2, "", PL_colors[4],
+                       REPORT_CODE_OFF+depth*2, "", PL_colors[4],
                        ST.accept_buff[ 0 ].wordnum,
                        tmp ? SvPV_nolen_const( *tmp ) : "not compiled under -Dr",
                        PL_colors[5] );
@@ -2802,7 +2866,7 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
                    DEBUG_TRIE_EXECUTE_r(
                        PerlIO_printf( Perl_debug_log,
                            "%*s  %sgot %"IVdf" (%d) as best, looking at %"IVdf" (%d)%s\n",
-                           REPORT_CODE_OFF + PL_regindent * 2, "", PL_colors[4],
+                           REPORT_CODE_OFF + depth * 2, "", PL_colors[4],
                            (IV)best, ST.accept_buff[ best ].wordnum, (IV)cur,
                            ST.accept_buff[ cur ].wordnum, PL_colors[5] );
                    );
@@ -2818,10 +2882,15 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
                    SV ** const tmp = RX_DEBUG(reginfo->prog)
                                ? av_fetch( trie->words, ST.accept_buff[ best ].wordnum - 1, 0 )
                                : NULL;
-                   PerlIO_printf( Perl_debug_log, "%*s  %strying alternation #%d <%s> at node #%d %s\n",
-                       REPORT_CODE_OFF+PL_regindent*2, "", PL_colors[4],
+                   regnode *nextop=!ST.jump ? 
+                                   ST.B : 
+                                   ST.B - ST.jump[ST.accept_buff[best].wordnum];    
+                   PerlIO_printf( Perl_debug_log, 
+                       "%*s  %strying alternation #%d <%s> at node #%d %s\n",
+                       REPORT_CODE_OFF+depth*2, "", PL_colors[4],
                        ST.accept_buff[best].wordnum,
-                       tmp ? SvPV_nolen_const( *tmp ) : "not compiled under -Dr", REG_NODE_NUM(scan),
+                       tmp ? SvPV_nolen_const( *tmp ) : "not compiled under -Dr", 
+                           REG_NODE_NUM(nextop),
                        PL_colors[5] );
                });
 
@@ -2951,7 +3020,7 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
                STRLEN inclasslen = PL_regeol - locinput;
 
                if (!reginclass(rex, scan, (U8*)locinput, &inclasslen, do_utf8))
-                   sayNO_ANYOF;
+                   goto anyof_fail;
                if (locinput >= PL_regeol)
                    sayNO;
                locinput += inclasslen ? inclasslen : UTF8SKIP(locinput);
@@ -2962,13 +3031,13 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
                if (nextchr < 0)
                    nextchr = UCHARAT(locinput);
                if (!REGINCLASS(rex, scan, (U8*)locinput))
-                   sayNO_ANYOF;
+                   goto anyof_fail;
                if (!nextchr && locinput >= PL_regeol)
                    sayNO;
                nextchr = UCHARAT(++locinput);
                break;
            }
-       no_anyof:
+       anyof_fail:
            /* If we might have the case of the German sharp s
             * in a casefolding Unicode character class. */
 
@@ -3321,7 +3390,7 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
 
                        Zero(&pm, 1, PMOP);
                        if (DO_UTF8(ret)) pm.op_pmdynflags |= PMdf_DYN_UTF8;
-                       re = CALLREGCOMP(aTHX_ (char*)t, (char*)t + len, &pm);
+                       re = CALLREGCOMP((char*)t, (char*)t + len, &pm);
                        if (!(SvFLAGS(ret)
                              & (SVs_TEMP | SVs_PADTMP | SVf_READONLY
                                | SVs_GMG)))
@@ -3332,11 +3401,6 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
                }
 
                /* run the pattern returned from (??{...}) */
-               DEBUG_EXECUTE_r(
-                    debug_start_match(re, do_utf8, locinput, PL_regeol, 
-                        "Matching embedded");
-                   );
-
                ST.cp = regcppush(0);   /* Save *all* the positions. */
                REGCP_SET(ST.lastcp);
                *PL_reglastparen = 0;
@@ -3347,56 +3411,60 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
                PL_reg_maxiter = 0;
 
                st->logical = 0;
-               ST.toggleutf = ((PL_reg_flags & RF_utf8) != 0) ^
-                           ((re->reganch & ROPT_UTF8) != 0);
-               if (ST.toggleutf) PL_reg_flags ^= RF_utf8;
+               ST.toggle_reg_flags = PL_reg_flags;
+               if (re->reganch & ROPT_UTF8)
+                   PL_reg_flags |= RF_utf8;
+               else
+                   PL_reg_flags &= ~RF_utf8;
+               ST.toggle_reg_flags ^= PL_reg_flags; /* diff of old and new */
+
                ST.prev_rex = rex;
+               ST.prev_curlyx = cur_curlyx;
                rex = re;
-
+               cur_curlyx = NULL;
                ST.B = next;
-               /* now continue  from first node in postoned RE */
-               PUSH_YES_STATE_GOTO(EVAL_A, re->program + 1);
+               ST.prev_eval = cur_eval;
+               cur_eval = st;
+
+               DEBUG_EXECUTE_r(
+                    debug_start_match(re, do_utf8, locinput, PL_regeol, 
+                        "Matching embedded");
+                   );
+               /* now continue from first node in postoned RE */
+               PUSH_YES_STATE_GOTO(EVAL_AB, re->program + 1);
                /* NOTREACHED */
            }
            /* /(?(?{...})X|Y)/ */
-           st->sw = SvTRUE(ret);
+           st->sw = (bool)SvTRUE(ret);
            st->logical = 0;
            break;
        }
 
-       case EVAL_A: /* successfully ran inner rex (??{rex}) */
-           if (ST.toggleutf)
-               PL_reg_flags ^= RF_utf8;
+       case EVAL_AB: /* cleanup after a successful (??{A})B */
+           /* note: this is called twice; first after popping B, then A */
+           PL_reg_flags ^= ST.toggle_reg_flags; 
            ReREFCNT_dec(rex);
            rex = ST.prev_rex;
+           regcpblow(ST.cp);
+           cur_eval = ST.prev_eval;
+           cur_curlyx = ST.prev_curlyx;
            /* XXXX This is too dramatic a measure... */
            PL_reg_maxiter = 0;
-           /* Restore parens of the caller without popping the
-            * savestack */
-           {
-               const I32 tmp = PL_savestack_ix;
-               PL_savestack_ix = ST.lastcp;
-               regcppop(rex);
-               PL_savestack_ix = tmp;
-           }
-           PL_reginput = locinput;
-            /* continue at the node following the (??{...}) */
-           scan = ST.B;
-           continue;
+           sayYES;
+
 
-       case EVAL_A_fail: /* unsuccessfully ran inner rex (??{rex}) */
-           /* Restore state to the outer re then re-throw the failure */
-           if (ST.toggleutf)
-               PL_reg_flags ^= RF_utf8;
+       case EVAL_AB_fail: /* unsuccessfully ran A or B in (??{A})B */
+           /* note: this is called twice; first after popping B, then A */
+           PL_reg_flags ^= ST.toggle_reg_flags; 
            ReREFCNT_dec(rex);
            rex = ST.prev_rex;
-
-           /* XXXX This is too dramatic a measure... */
-           PL_reg_maxiter = 0;
-
            PL_reginput = locinput;
            REGCP_UNWIND(ST.lastcp);
            regcppop(rex);
+           cur_eval = ST.prev_eval;
+           cur_curlyx = ST.prev_curlyx;
+           /* XXXX This is too dramatic a measure... */
+           PL_reg_maxiter = 0;
            sayNO_SILENT;
 
 #undef ST
@@ -3417,7 +3485,7 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
            break;
        case GROUPP:
            n = ARG(scan);  /* which paren pair */
-           st->sw = ((I32)*PL_reglastparen >= n && PL_regendp[n] != -1);
+           st->sw = (bool)((I32)*PL_reglastparen >= n && PL_regendp[n] != -1);
            break;
        case IFTHEN:
            PL_reg_leftiter = PL_reg_maxiter;           /* Void cache */
@@ -3433,32 +3501,32 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
            st->logical = scan->flags;
            break;
 /*******************************************************************
- cc points to the regmatch_state associated with the most recent CURLYX.
+ cur_curlyx points to the regmatch_state associated with the most recent CURLYX.
  This struct contains info about the innermost (...)* loop (an
- "infoblock"), and a pointer to the next outer cc.
+ "infoblock"), and a pointer to the next outer cur_curlyx.
 
  Here is how Y(A)*Z is processed (if it is compiled into CURLYX/WHILEM):
 
    1) After matching Y, regnode for CURLYX is processed;
 
-   2) This regnode populates cc, and calls regmatch() recursively
+   2) This regnode populates cur_curlyx, and calls regmatch() recursively
       with the starting point at WHILEM node;
 
    3) Each hit of WHILEM node tries to match A and Z (in the order
       depending on the current iteration, min/max of {min,max} and
       greediness).  The information about where are nodes for "A"
-      and "Z" is read from cc, as is info on how many times "A"
+      and "Z" is read from cur_curlyx, as is info on how many times "A"
       was already matched, and greediness.
 
    4) After A matches, the same WHILEM node is hit again.
 
-   5) Each time WHILEM is hit, cc is the infoblock created by CURLYX
+   5) Each time WHILEM is hit, cur_curlyx is the infoblock created by CURLYX
       of the same pair.  Thus when WHILEM tries to match Z, it temporarily
-      resets cc, since this Y(A)*Z can be a part of some other loop:
+      resets cur_curlyx, since this Y(A)*Z can be a part of some other loop:
       as in (Y(A)*Z)*.  If Z matches, the automaton will hit the WHILEM node
       of the external loop.
 
- Currently present infoblocks form a tree with a stem formed by st->cc
+ Currently present infoblocks form a tree with a stem formed by cur_curlyx
  and whatever it mentions via ->next, and additional attached trees
  corresponding to temporarily unset infoblocks as in "5" above.
 
@@ -3533,8 +3601,8 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
                    parenfloor = *PL_reglastparen; /* Pessimization... */
 
                st->u.curlyx.cp = PL_savestack_ix;
-               st->u.curlyx.outercc = st->cc;
-               st->cc = st;
+               st->u.curlyx.outercc = cur_curlyx;
+               cur_curlyx = st;
                /* these fields contain the state of the current curly.
                 * they are accessed by subsequent WHILEMs;
                 * cur and lastloc are also updated by WHILEM */
@@ -3550,7 +3618,7 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
                REGMATCH(PREVOPER(next), CURLYX); /* start on the WHILEM */
                /*** all unsaved local vars undefined at this point */
                regcpblow(st->u.curlyx.cp);
-               st->cc = st->u.curlyx.outercc;
+               cur_curlyx = st->u.curlyx.outercc;
                saySAME(result);
            }
            /* NOTREACHED */
@@ -3566,62 +3634,61 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
 
                /* Dave says:
 
-                  st->cc gets initialised by CURLYX ready for use by WHILEM.
-                  So again, unless somethings been corrupted, st->cc cannot
+                  cur_curlyx gets initialised by CURLYX ready for use by WHILEM.
+                  So again, unless somethings been corrupted, cur_curlyx cannot
                   be null at that point in WHILEM.
                   
                   See http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2006-04/msg00556.html
                   So we'll assert that this is true:
                */
-               assert(st->cc);
-               st->u.whilem.lastloc = st->cc->u.curlyx.lastloc; /* Detection of 0-len. */
+               assert(cur_curlyx);
+               st->u.whilem.lastloc = cur_curlyx->u.curlyx.lastloc; /* Detection of 0-len. */
                st->u.whilem.cache_offset = 0;
                st->u.whilem.cache_bit = 0;
                
-               n = st->cc->u.curlyx.cur + 1; /* how many we know we matched */
+               n = cur_curlyx->u.curlyx.cur + 1; /* how many we know we matched */
                PL_reginput = locinput;
 
                DEBUG_EXECUTE_r(
                    PerlIO_printf(Perl_debug_log,
                                  "%*s  %ld out of %ld..%ld  cc=%"UVxf"\n",
-                                 REPORT_CODE_OFF+PL_regindent*2, "",
-                                 (long)n, (long)st->cc->u.curlyx.min,
-                                 (long)st->cc->u.curlyx.max, PTR2UV(st->cc))
+                                 REPORT_CODE_OFF+depth*2, "",
+                                 (long)n, (long)cur_curlyx->u.curlyx.min,
+                                 (long)cur_curlyx->u.curlyx.max,
+                                 PTR2UV(cur_curlyx))
                    );
 
                /* If degenerate scan matches "", assume scan done. */
 
-               if (locinput == st->cc->u.curlyx.lastloc && n >= st->cc->u.curlyx.min) {
-                   st->u.whilem.savecc = st->cc;
-                   st->cc = st->cc->u.curlyx.outercc;
-                   if (st->cc)
-                       st->ln = st->cc->u.curlyx.cur;
+               if (locinput == cur_curlyx->u.curlyx.lastloc && n >=
+                   cur_curlyx->u.curlyx.min)
+               {
+                   st->u.whilem.savecc = cur_curlyx;
+                   cur_curlyx = cur_curlyx->u.curlyx.outercc;
                    DEBUG_EXECUTE_r(
                        PerlIO_printf(Perl_debug_log,
                           "%*s  empty match detected, try continuation...\n",
-                          REPORT_CODE_OFF+PL_regindent*2, "")
+                          REPORT_CODE_OFF+depth*2, "")
                        );
                    REGMATCH(st->u.whilem.savecc->next, WHILEM1);
                    /*** all unsaved local vars undefined at this point */
-                   st->cc = st->u.whilem.savecc;
+                   cur_curlyx = st->u.whilem.savecc;
                    if (result)
                        sayYES;
-                   if (st->cc->u.curlyx.outercc)
-                       st->cc->u.curlyx.outercc->u.curlyx.cur = st->ln;
                    sayNO;
                }
 
                /* First just match a string of min scans. */
 
-               if (n < st->cc->u.curlyx.min) {
-                   st->cc->u.curlyx.cur = n;
-                   st->cc->u.curlyx.lastloc = locinput;
-                   REGMATCH(st->cc->u.curlyx.scan, WHILEM2);
+               if (n < cur_curlyx->u.curlyx.min) {
+                   cur_curlyx->u.curlyx.cur = n;
+                   cur_curlyx->u.curlyx.lastloc = locinput;
+                   REGMATCH(cur_curlyx->u.curlyx.scan, WHILEM2);
                    /*** all unsaved local vars undefined at this point */
                    if (result)
                        sayYES;
-                   st->cc->u.curlyx.cur = n - 1;
-                   st->cc->u.curlyx.lastloc = st->u.whilem.lastloc;
+                   cur_curlyx->u.curlyx.cur = n - 1;
+                   cur_curlyx->u.curlyx.lastloc = st->u.whilem.lastloc;
                    sayNO;
                }
 
@@ -3666,7 +3733,7 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
                    DEBUG_EXECUTE_r(
                        PerlIO_printf(Perl_debug_log,
                                      "%*s  already tried at this position...\n",
-                                     REPORT_CODE_OFF+PL_regindent*2, "")
+                                     REPORT_CODE_OFF+depth*2, "")
                        );
                        sayNO; /* cache records failure */
                    }
@@ -3675,26 +3742,22 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
 
                /* Prefer next over scan for minimal matching. */
 
-               if (st->cc->minmod) {
-                   st->u.whilem.savecc = st->cc;
-                   st->cc = st->cc->u.curlyx.outercc;
-                   if (st->cc)
-                       st->ln = st->cc->u.curlyx.cur;
+               if (cur_curlyx->minmod) {
+                   st->u.whilem.savecc = cur_curlyx;
+                   cur_curlyx = cur_curlyx->u.curlyx.outercc;
                    st->u.whilem.cp = regcppush(st->u.whilem.savecc->u.curlyx.parenfloor);
                    REGCP_SET(st->u.whilem.lastcp);
                    REGMATCH(st->u.whilem.savecc->next, WHILEM3);
                    /*** all unsaved local vars undefined at this point */
-                   st->cc = st->u.whilem.savecc;
+                   cur_curlyx = st->u.whilem.savecc;
                    if (result) {
                        regcpblow(st->u.whilem.cp);
                        sayYES; /* All done. */
                    }
                    REGCP_UNWIND(st->u.whilem.lastcp);
                    regcppop(rex);
-                   if (st->cc->u.curlyx.outercc)
-                       st->cc->u.curlyx.outercc->u.curlyx.cur = st->ln;
 
-                   if (n >= st->cc->u.curlyx.max) { /* Maximum greed exceeded? */
+                   if (n >= cur_curlyx->u.curlyx.max) { /* Maximum greed exceeded? */
                        if (ckWARN(WARN_REGEXP) && n >= REG_INFTY
                            && !(PL_reg_flags & RF_warned)) {
                            PL_reg_flags |= RF_warned;
@@ -3708,15 +3771,15 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
                    DEBUG_EXECUTE_r(
                        PerlIO_printf(Perl_debug_log,
                                      "%*s  trying longer...\n",
-                                     REPORT_CODE_OFF+PL_regindent*2, "")
+                                     REPORT_CODE_OFF+depth*2, "")
                        );
                    /* Try scanning more and see if it helps. */
                    PL_reginput = locinput;
-                   st->cc->u.curlyx.cur = n;
-                   st->cc->u.curlyx.lastloc = locinput;
-                   st->u.whilem.cp = regcppush(st->cc->u.curlyx.parenfloor);
+                   cur_curlyx->u.curlyx.cur = n;
+                   cur_curlyx->u.curlyx.lastloc = locinput;
+                   st->u.whilem.cp = regcppush(cur_curlyx->u.curlyx.parenfloor);
                    REGCP_SET(st->u.whilem.lastcp);
-                   REGMATCH(st->cc->u.curlyx.scan, WHILEM4);
+                   REGMATCH(cur_curlyx->u.curlyx.scan, WHILEM4);
                    /*** all unsaved local vars undefined at this point */
                    if (result) {
                        regcpblow(st->u.whilem.cp);
@@ -3724,19 +3787,19 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
                    }
                    REGCP_UNWIND(st->u.whilem.lastcp);
                    regcppop(rex);
-                   st->cc->u.curlyx.cur = n - 1;
-                   st->cc->u.curlyx.lastloc = st->u.whilem.lastloc;
+                   cur_curlyx->u.curlyx.cur = n - 1;
+                   cur_curlyx->u.curlyx.lastloc = st->u.whilem.lastloc;
                    CACHEsayNO;
                }
 
                /* Prefer scan over next for maximal matching. */
 
-               if (n < st->cc->u.curlyx.max) { /* More greed allowed? */
-                   st->u.whilem.cp = regcppush(st->cc->u.curlyx.parenfloor);
-                   st->cc->u.curlyx.cur = n;
-                   st->cc->u.curlyx.lastloc = locinput;
+               if (n < cur_curlyx->u.curlyx.max) {     /* More greed allowed? */
+                   st->u.whilem.cp = regcppush(cur_curlyx->u.curlyx.parenfloor);
+                   cur_curlyx->u.curlyx.cur = n;
+                   cur_curlyx->u.curlyx.lastloc = locinput;
                    REGCP_SET(st->u.whilem.lastcp);
-                   REGMATCH(st->cc->u.curlyx.scan, WHILEM5);
+                   REGMATCH(cur_curlyx->u.curlyx.scan, WHILEM5);
                    /*** all unsaved local vars undefined at this point */
                    if (result) {
                        regcpblow(st->u.whilem.cp);
@@ -3748,7 +3811,7 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
                    DEBUG_EXECUTE_r(
                        PerlIO_printf(Perl_debug_log,
                                      "%*s  failed, try continuation...\n",
-                                     REPORT_CODE_OFF+PL_regindent*2, "")
+                                     REPORT_CODE_OFF+depth*2, "")
                        );
                }
                if (ckWARN(WARN_REGEXP) && n >= REG_INFTY
@@ -3760,19 +3823,15 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
                }
 
                /* Failed deeper matches of scan, so see if this one works. */
-               st->u.whilem.savecc = st->cc;
-               st->cc = st->cc->u.curlyx.outercc;
-               if (st->cc)
-                   st->ln = st->cc->u.curlyx.cur;
+               st->u.whilem.savecc = cur_curlyx;
+               cur_curlyx = cur_curlyx->u.curlyx.outercc;
                REGMATCH(st->u.whilem.savecc->next, WHILEM6);
                /*** all unsaved local vars undefined at this point */
-               st->cc = st->u.whilem.savecc;
+               cur_curlyx = st->u.whilem.savecc;
                if (result)
                    sayYES;
-               if (st->cc->u.curlyx.outercc)
-                   st->cc->u.curlyx.outercc->u.curlyx.cur = st->ln;
-               st->cc->u.curlyx.cur = n - 1;
-               st->cc->u.curlyx.lastloc = st->u.whilem.lastloc;
+               cur_curlyx->u.curlyx.cur = n - 1;
+               cur_curlyx->u.curlyx.lastloc = st->u.whilem.lastloc;
                CACHEsayNO;
            }
            /* NOTREACHED */
@@ -3880,7 +3939,7 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
            DEBUG_EXECUTE_r(
                PerlIO_printf(Perl_debug_log,
                          "%*s  CURLYM now matched %"IVdf" times, len=%"IVdf"...\n",
-                         (int)(REPORT_CODE_OFF+(PL_regindent*2)), "",
+                         (int)(REPORT_CODE_OFF+(depth*2)), "",
                          (IV) ST.count, (IV)ST.alen)
            );
 
@@ -3921,7 +3980,7 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
            DEBUG_EXECUTE_r(
                PerlIO_printf(Perl_debug_log,
                    "%*s  CURLYM trying tail with matches=%"IVdf"...\n",
-                   (int)(REPORT_CODE_OFF+(PL_regindent*2)),
+                   (int)(REPORT_CODE_OFF+(depth*2)),
                    "", (IV)ST.count)
                );
            if (ST.c1 != CHRTEST_VOID
@@ -4259,6 +4318,39 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
 
 
        case END:
+           if (cur_eval) {
+               /* we've just finished A in /(??{A})B/; now continue with B */
+               I32 tmpix;
+
+
+               st->u.eval.toggle_reg_flags
+                           = cur_eval->u.eval.toggle_reg_flags;
+               PL_reg_flags ^= st->u.eval.toggle_reg_flags; 
+
+               st->u.eval.prev_rex = rex;              /* inner */
+               rex    = cur_eval->u.eval.prev_rex;     /* outer */
+               cur_curlyx = cur_eval->u.eval.prev_curlyx;
+               ReREFCNT_inc(rex);
+               st->u.eval.cp = regcppush(0);   /* Save *all* the positions. */
+               REGCP_SET(st->u.eval.lastcp);
+               PL_reginput = locinput;
+
+               /* Restore parens of the outer rex without popping the
+                * savestack */
+               tmpix = PL_savestack_ix;
+               PL_savestack_ix = cur_eval->u.eval.lastcp;
+               regcppop(rex);
+               PL_savestack_ix = tmpix;
+
+               st->u.eval.prev_eval = cur_eval;
+               cur_eval = cur_eval->u.eval.prev_eval;
+               DEBUG_EXECUTE_r(
+                   PerlIO_printf(Perl_debug_log, "%*s  EVAL trying tail ...\n",
+                                     REPORT_CODE_OFF+depth*2, ""););
+               PUSH_YES_STATE_GOTO(EVAL_AB,
+                       st->u.eval.prev_eval->u.eval.B); /* match B */
+           }
+
            if (locinput < reginfo->till) {
                DEBUG_EXECUTE_r(PerlIO_printf(Perl_debug_log,
                                      "%sMatch possible, but length=%ld is smaller than requested=%ld, failing!%s\n",
@@ -4266,18 +4358,18 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
                                      (long)(locinput - PL_reg_starttry),
                                      (long)(reginfo->till - PL_reg_starttry),
                                      PL_colors[5]));
-               sayNO_FINAL;            /* Cannot match: too short. */
+               sayNO_SILENT;           /* Cannot match: too short. */
            }
            PL_reginput = locinput;     /* put where regtry can find it */
-           sayYES_FINAL;               /* Success! */
+           sayYES;                     /* Success! */
 
        case SUCCEED: /* successful SUSPEND/UNLESSM/IFMATCH/CURLYM */
            DEBUG_EXECUTE_r(
            PerlIO_printf(Perl_debug_log,
                "%*s  %ssubpattern success...%s\n",
-               REPORT_CODE_OFF+PL_regindent*2, "", PL_colors[4], PL_colors[5]));
+               REPORT_CODE_OFF+depth*2, "", PL_colors[4], PL_colors[5]));
            PL_reginput = locinput;     /* put where regtry can find it */
-           sayYES_FINAL;               /* Success! */
+           sayYES;                     /* Success! */
 
 #undef  ST
 #define ST st->u.ifmatch
@@ -4370,15 +4462,13 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
        {
            regmatch_state *newst;
 
+           DEBUG_STATE_pp("push");
            depth++;
-           DEBUG_STATE_r(PerlIO_printf(Perl_debug_log,
-                       "PUSH STATE(%d)\n", depth));
            st->locinput = locinput;
            newst = st+1; 
            if (newst >  SLAB_LAST(PL_regmatch_slab))
                newst = S_push_slab(aTHX);
            PL_regmatch_state = newst;
-           newst->cc = st->cc;
            /* XXX probably don't need to initialise these */
            newst->minmod = 0;
            newst->sw = 0;
@@ -4402,8 +4492,10 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
            /* push new state */
            regmatch_state *oldst = st;
 
+           DEBUG_STATE_pp("push");
            depth++;
-           DEBUG_EXECUTE_r(PerlIO_printf(Perl_debug_log, "PUSH RECURSE STATE(%d)\n", depth));
+           st->u.yes.prev_yes_state = yes_state;
+           yes_state = st;
 
            /* grab the next free state slot */
            st++;
@@ -4415,21 +4507,15 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
            oldst->n = n;
            oldst->locinput = locinput;
 
-           st->cc = oldst->cc;
            locinput = PL_reginput;
            nextchr = UCHARAT(locinput);
            st->minmod = 0;
            st->sw = 0;
            st->logical = 0;
            
-#ifdef DEBUGGING
-           PL_regindent++;
-#endif
        }
     }
 
-
-
     /*
     * We get here only if there's trouble -- normally "case END" is
     * the terminating point.
@@ -4438,13 +4524,22 @@ S_regmatch(pTHX_ const regmatch_info *reginfo, regnode *prog)
     /*NOTREACHED*/
     sayNO;
 
-yes_final:
-
+yes:
     if (yes_state) {
        /* we have successfully completed a subexpression, but we must now
         * pop to the state marked by yes_state and continue from there */
-
        assert(st != yes_state);
+#ifdef DEBUGGING
+       while (st != yes_state) {
+           st--;
+           if (st < SLAB_FIRST(PL_regmatch_slab)) {
+               PL_regmatch_slab = PL_regmatch_slab->prev;
+               st = SLAB_LAST(PL_regmatch_slab);
+           }
+           DEBUG_STATE_pp("pop (yes)");
+           depth--;
+       }
+#else
        while (yes_state < SLAB_FIRST(PL_regmatch_slab)
            || yes_state > SLAB_LAST(PL_regmatch_slab))
        {
@@ -4454,16 +4549,47 @@ yes_final:
            st = SLAB_LAST(PL_regmatch_slab);
        }
        depth -= (st - yes_state);
-       DEBUG_STATE_r(PerlIO_printf(Perl_debug_log, "POP STATES (%"UVuf"..%"UVuf")\n",
-           (UV)(depth+1), (UV)(depth+(st - yes_state))));
+#endif
        st = yes_state;
        yes_state = st->u.yes.prev_yes_state;
        PL_regmatch_state = st;
 
        switch (st->resume_state) {
+       case resume_CURLYX:
+       case resume_WHILEM1:
+       case resume_WHILEM2:
+       case resume_WHILEM3:
+       case resume_WHILEM4:
+       case resume_WHILEM5:
+       case resume_WHILEM6:
+           result = 1;
+           /* restore previous state and re-enter */
+           scan        = st->scan;
+           next        = st->next;
+           n   = st->n;
+           locinput= st->locinput;
+           nextchr = UCHARAT(locinput);
+           switch (st->resume_state) {
+           case resume_CURLYX:
+               goto resume_point_CURLYX;
+           case resume_WHILEM1:
+               goto resume_point_WHILEM1;
+           case resume_WHILEM2:
+               goto resume_point_WHILEM2;
+           case resume_WHILEM3:
+               goto resume_point_WHILEM3;
+           case resume_WHILEM4:
+               goto resume_point_WHILEM4;
+           case resume_WHILEM5:
+               goto resume_point_WHILEM5;
+           case resume_WHILEM6:
+               goto resume_point_WHILEM6;
+           }
+           Perl_croak(aTHX_ "unexpected whilem resume state");
+
+       case EVAL_AB: 
        case IFMATCH_A:
        case CURLYM_A:
-       case EVAL_A:
            state_num = st->resume_state;
            goto reenter_switch;
 
@@ -4478,82 +4604,23 @@ yes_final:
 
     DEBUG_EXECUTE_r(PerlIO_printf(Perl_debug_log, "%sMatch successful!%s\n",
                          PL_colors[4], PL_colors[5]));
-yes:
-#ifdef DEBUGGING
-    PL_regindent--;
-#endif
 
     result = 1;
-    /* XXX this is duplicate(ish) code to that in the do_no section.
-     * will disappear when REGFMATCH goes */
-    if (depth) {
-       /* restore previous state and re-enter */
-       DEBUG_STATE_r(PerlIO_printf(Perl_debug_log, "POP STATE(%d)\n", depth));
-       depth--;
-       st--;
-       if (st < SLAB_FIRST(PL_regmatch_slab)) {
-           PL_regmatch_slab = PL_regmatch_slab->prev;
-           st = SLAB_LAST(PL_regmatch_slab);
-       }
-       PL_regmatch_state = st;
-       scan    = st->scan;
-       next    = st->next;
-       n       = st->n;
-       locinput= st->locinput;
-       nextchr = UCHARAT(locinput);
-
-       switch (st->resume_state) {
-       case resume_CURLYX:
-           goto resume_point_CURLYX;
-       case resume_WHILEM1:
-           goto resume_point_WHILEM1;
-       case resume_WHILEM2:
-           goto resume_point_WHILEM2;
-       case resume_WHILEM3:
-           goto resume_point_WHILEM3;
-       case resume_WHILEM4:
-           goto resume_point_WHILEM4;
-       case resume_WHILEM5:
-           goto resume_point_WHILEM5;
-       case resume_WHILEM6:
-           goto resume_point_WHILEM6;
-
-       case TRIE_next:
-       case CURLYM_A:
-       case CURLYM_B:
-       case EVAL_A:
-       case IFMATCH_A:
-       case BRANCH_next:
-       case CURLY_B_max:
-       case CURLY_B_min:
-       case CURLY_B_min_known:
-           break;
-
-       default:
-           Perl_croak(aTHX_ "regexp resume memory corruption");
-       }
-    }
     goto final_exit;
 
 no:
     DEBUG_EXECUTE_r(
        PerlIO_printf(Perl_debug_log,
             "%*s  %sfailed...%s\n",
-            REPORT_CODE_OFF+PL_regindent*2, "", 
+            REPORT_CODE_OFF+depth*2, "", 
             PL_colors[4], PL_colors[5])
        );
-no_final:
-do_no:
 
-#ifdef DEBUGGING
-    PL_regindent--;
-#endif
+no_silent:
     result = 0;
 
     if (depth) {
        /* there's a previous state to backtrack to */
-       DEBUG_STATE_r(PerlIO_printf(Perl_debug_log, "POP STATE(%d)\n", depth));
-       depth--;
        st--;
        if (st < SLAB_FIRST(PL_regmatch_slab)) {
            PL_regmatch_slab = PL_regmatch_slab->prev;
@@ -4566,6 +4633,11 @@ do_no:
        locinput= st->locinput;
        nextchr = UCHARAT(locinput);
 
+       DEBUG_STATE_pp("pop");
+       depth--;
+       if (yes_state == st)
+           yes_state = st->u.yes.prev_yes_state;
+
        switch (st->resume_state) {
        case resume_CURLYX:
            goto resume_point_CURLYX;
@@ -4583,7 +4655,7 @@ do_no:
            goto resume_point_WHILEM6;
 
        case TRIE_next:
-       case EVAL_A:
+       case EVAL_AB:
        case BRANCH_next:
        case CURLYM_A:
        case CURLYM_B:
@@ -4591,8 +4663,6 @@ do_no:
        case CURLY_B_max:
        case CURLY_B_min:
        case CURLY_B_min_known:
-           if (yes_state == st)
-               yes_state = st->u.yes.prev_yes_state;
            state_num = st->resume_state + 1; /* failure = success + 1 */
            goto reenter_switch;
 
@@ -4601,7 +4671,7 @@ do_no:
        }
     }
 
-final_exit:
+  final_exit:
 
     /* restore original high-water mark */
     PL_regmatch_slab  = orig_slab;
@@ -4619,7 +4689,6 @@ final_exit:
     }
 
     return result;
-
 }
 
 /*
@@ -4944,15 +5013,8 @@ S_reginclass(pTHX_ const regexp *prog, register const regnode *n, register const
        c = utf8n_to_uvchr(p, UTF8_MAXBYTES, &len,
                (UTF8_ALLOW_DEFAULT & UTF8_ALLOW_ANYUV) | UTF8_CHECK_ONLY);
                /* see [perl #37836] for UTF8_ALLOW_ANYUV */
-       if (len == (STRLEN)-1) {
-           int i;
-           PerlIO_printf(Perl_debug_log, "utf8: ");
-           for (i = 0; i < 4; i++)
-               PerlIO_printf(Perl_debug_log, "\\x%02x", p[i]);
-           PerlIO_printf(Perl_debug_log, "\n");
-           Perl_warner(aTHX_ packWARN(WARN_REGEXP), "Malformed UTF-8 character");
-           /* Perl_croak(aTHX_ "Malformed UTF-8 character (fatal)"); */
-       }
+       if (len == (STRLEN)-1) 
+           Perl_croak(aTHX_ "Malformed UTF-8 character (fatal)");
     }
 
     plen = lenp ? *lenp : UNISKIP(NATIVE_TO_UNI(c));
@@ -5071,20 +5133,47 @@ S_reghop3(U8 *s, I32 off, const U8* lim)
        }
     }
     else {
-       while (off++) {
-           if (s > lim) {
-               s--;
-               if (UTF8_IS_CONTINUED(*s)) {
-                   while (s > (U8*)lim && UTF8_IS_CONTINUATION(*s))
-                       s--;
-               }
-               /* XXX could check well-formedness here */
+        while (off++ && s > lim) {
+            s--;
+            if (UTF8_IS_CONTINUED(*s)) {
+                while (s > lim && UTF8_IS_CONTINUATION(*s))
+                    s--;
            }
+            /* XXX could check well-formedness here */
        }
     }
     return s;
 }
 
+#ifdef XXX_dmq
+/* there are a bunch of places where we use two reghop3's that should
+   be replaced with this routine. but since thats not done yet 
+   we ifdef it out - dmq
+*/
+STATIC U8 *
+S_reghop4(U8 *s, I32 off, const U8* llim, const U8* rlim)
+{
+    dVAR;
+    if (off >= 0) {
+        while (off-- && s < rlim) {
+            /* XXX could check well-formedness here */
+            s += UTF8SKIP(s);
+        }
+    }
+    else {
+        while (off++ && s > llim) {
+            s--;
+            if (UTF8_IS_CONTINUED(*s)) {
+                while (s > llim && UTF8_IS_CONTINUATION(*s))
+                    s--;
+            }
+            /* XXX could check well-formedness here */
+        }
+    }
+    return s;
+}
+#endif
+
 STATIC U8 *
 S_reghopmaybe3(U8* s, I32 off, const U8* lim)
 {
@@ -5098,17 +5187,13 @@ S_reghopmaybe3(U8* s, I32 off, const U8* lim)
            return NULL;
     }
     else {
-       while (off++) {
-           if (s > lim) {
-               s--;
-               if (UTF8_IS_CONTINUED(*s)) {
-                   while (s > (U8*)lim && UTF8_IS_CONTINUATION(*s))
-                       s--;
-               }
-               /* XXX could check well-formedness here */
+        while (off++ && s > lim) {
+            s--;
+            if (UTF8_IS_CONTINUED(*s)) {
+                while (s > lim && UTF8_IS_CONTINUATION(*s))
+                    s--;
            }
-           else
-               break;
+            /* XXX could check well-formedness here */
        }
        if (off <= 0)
            return NULL;