This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
Yes, you guessed it -- a typos fixed
[perl5.git] / scope.c
diff --git a/scope.c b/scope.c
index 44713e1..3f48609 100644 (file)
--- a/scope.c
+++ b/scope.c
@@ -30,7 +30,7 @@ I32
 cxinc()
 {
     cxstack_max = cxstack_max * 3 / 2;
-    Renew(cxstack, cxstack_max, CONTEXT);
+    Renew(cxstack, cxstack_max + 1, CONTEXT);  /* XXX should fix CXINC macro */
     return cxstack_ix + 1;
 }
 
@@ -152,7 +152,7 @@ GV *gv;
     GP *ogp = GvGP(gv);
 
     SSCHECK(3);
-    SSPUSHPTR(gv);
+    SSPUSHPTR(SvREFCNT_inc(gv));
     SSPUSHPTR(ogp);
     SSPUSHINT(SAVEt_GP);
 
@@ -276,7 +276,7 @@ save_iv(ivp)
 IV *ivp;
 {
     SSCHECK(3);
-    SSPUSHINT(*ivp);
+    SSPUSHIV(*ivp);
     SSPUSHPTR(ivp);
     SSPUSHINT(SAVEt_IV);
 }
@@ -365,7 +365,7 @@ save_clearsv(svp)
 SV** svp;
 {
     SSCHECK(2);
-    SSPUSHPTR(svp);
+    SSPUSHLONG((long)(svp-curpad));
     SSPUSHINT(SAVEt_CLEARSV);
 }
 
@@ -525,6 +525,7 @@ I32 base;
            gv = (GV*)SSPOPPTR;
             gp_free(gv);
             GvGP(gv) = (GP*)ptr;
+           SvREFCNT_dec(gv);
             break;
        case SAVEt_FREESV:
            ptr = SSPOPPTR;
@@ -540,7 +541,7 @@ I32 base;
            Safefree((char*)ptr);
            break;
        case SAVEt_CLEARSV:
-           ptr = SSPOPPTR;
+           ptr = (void*)&curpad[SSPOPLONG];
            sv = *(SV**)ptr;
            if (SvREFCNT(sv) <= 1) { /* Can clear pad variable in place. */
                if (SvTHINKFIRST(sv)) {
@@ -573,12 +574,14 @@ I32 base;
                }
            }
            else {      /* Someone has a claim on this, so abandon it. */
+               U32 padflags = SvFLAGS(sv) & (SVs_PADBUSY|SVs_PADMY|SVs_PADTMP);
                SvREFCNT_dec(sv);       /* Cast current value to the winds. */
                switch (SvTYPE(sv)) {   /* Console ourselves with a new value */
                case SVt_PVAV:  *(SV**)ptr = (SV*)newAV();      break;
                case SVt_PVHV:  *(SV**)ptr = (SV*)newHV();      break;
                default:        *(SV**)ptr = NEWSV(0,0);        break;
                }
+               SvFLAGS(*(SV**)ptr) |= padflags; /* preserve pad nature */
            }
            break;
        case SAVEt_DELETE:
@@ -593,7 +596,10 @@ I32 base;
            (*SSPOPDPTR)(ptr);
            break;
        case SAVEt_REGCONTEXT:
-           savestack_ix -= SSPOPINT;   /* regexp must have croaked */
+           {
+               I32 delta = SSPOPINT;
+               savestack_ix -= delta;  /* regexp must have croaked */
+           }
            break;
        default:
            croak("panic: leave_scope inconsistency");
@@ -635,8 +641,9 @@ CONTEXT* cx;
     case CXt_EVAL:
        fprintf(stderr, "BLK_EVAL.OLD_IN_EVAL = %ld\n",
                (long)cx->blk_eval.old_in_eval);
-       fprintf(stderr, "BLK_EVAL.OLD_OP_TYPE = %s\n",
-               op_name[cx->blk_eval.old_op_type]);
+       fprintf(stderr, "BLK_EVAL.OLD_OP_TYPE = %s (%s)\n",
+               op_name[cx->blk_eval.old_op_type],
+               op_desc[cx->blk_eval.old_op_type]);
        fprintf(stderr, "BLK_EVAL.OLD_NAME = %s\n",
                cx->blk_eval.old_name);
        fprintf(stderr, "BLK_EVAL.OLD_EVAL_ROOT = 0x%lx\n",