This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
[perl #37694] segfault with PerlIO::get_layers()
[perl5.git] / universal.c
index d629dfd..10dddb5 100644 (file)
@@ -1,6 +1,7 @@
 /*    universal.c
  *
- *    Copyright (c) 1997-2002, Larry Wall
+ *    Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004,
+ *    2005, by Larry Wall and others
  *
  *    You may distribute under the terms of either the GNU General Public
  *    License or the Artistic License, as specified in the README file.
  * beginning." --Gandalf, relating Gollum's story
  */
 
+/* This file contains the code that implements the functions in Perl's
+ * UNIVERSAL package, such as UNIVERSAL->can().
+ */
+
 #include "EXTERN.h"
 #define PERL_IN_UNIVERSAL_C
 #include "perl.h"
 
+#ifdef USE_PERLIO
+#include "perliol.h" /* For the PERLIO_F_XXX */
+#endif
+
 /*
  * Contributed by Graham Barr  <Graham.Barr@tiuk.ti.com>
  * The main guts of traverse_isa was actually copied from gv_fetchmeth
@@ -31,36 +40,42 @@ S_isa_lookup(pTHX_ HV *stash, const char *name, HV* name_stash,
     GV** gvp;
     HV* hv = Nullhv;
     SV* subgen = Nullsv;
+    const char *hvname;
 
     /* A stash/class can go by many names (ie. User == main::User), so 
        we compare the stash itself just in case */
     if (name_stash && (stash == name_stash))
         return &PL_sv_yes;
 
-    if (strEQ(HvNAME(stash), name))
+    hvname = HvNAME_get(stash);
+
+    if (strEQ(hvname, name))
+       return &PL_sv_yes;
+
+    if (strEQ(name, "UNIVERSAL"))
        return &PL_sv_yes;
 
     if (level > 100)
        Perl_croak(aTHX_ "Recursive inheritance detected in package '%s'",
-                  HvNAME(stash));
+                  hvname);
 
     gvp = (GV**)hv_fetch(stash, "::ISA::CACHE::", 14, FALSE);
 
     if (gvp && (gv = *gvp) != (GV*)&PL_sv_undef && (subgen = GvSV(gv))
        && (hv = GvHV(gv)))
     {
-       if (SvIV(subgen) == PL_sub_generation) {
+       if (SvIV(subgen) == (IV)PL_sub_generation) {
            SV* sv;
-           SV** svp = (SV**)hv_fetch(hv, name, len, FALSE);
+           SV** const svp = (SV**)hv_fetch(hv, name, len, FALSE);
            if (svp && (sv = *svp) != (SV*)&PL_sv_undef) {
                DEBUG_o( Perl_deb(aTHX_ "Using cached ISA %s for package %s\n",
-                                 name, HvNAME(stash)) );
+                                 name, hvname) );
                return sv;
            }
        }
        else {
            DEBUG_o( Perl_deb(aTHX_ "ISA Cache in package %s is stale\n",
-                             HvNAME(stash)) );
+                             hvname) );
            hv_clear(hv);
            sv_setiv(subgen, PL_sub_generation);
        }
@@ -89,13 +104,13 @@ S_isa_lookup(pTHX_ HV *stash, const char *name, HV* name_stash,
            /* NOTE: No support for tied ISA */
            I32 items = AvFILLp(av) + 1;
            while (items--) {
-               SV* sv = *svp++;
-               HV* basestash = gv_stashsv(sv, FALSE);
+               SV* const sv = *svp++;
+               HV* const basestash = gv_stashsv(sv, FALSE);
                if (!basestash) {
                    if (ckWARN(WARN_MISC))
-                       Perl_warner(aTHX_ WARN_SYNTAX,
-                            "Can't locate package %s for @%s::ISA",
-                           SvPVX(sv), HvNAME(stash));
+                       Perl_warner(aTHX_ packWARN(WARN_SYNTAX),
+                                   "Can't locate package %"SVf" for @%s::ISA",
+                                   sv, hvname);
                    continue;
                }
                if (&PL_sv_yes == isa_lookup(basestash, name, name_stash, 
@@ -107,8 +122,7 @@ S_isa_lookup(pTHX_ HV *stash, const char *name, HV* name_stash,
            (void)hv_store(hv,name,len,&PL_sv_no,0);
        }
     }
-
-    return boolSV(strEQ(name, "UNIVERSAL"));
+    return &PL_sv_no;
 }
 
 /*
@@ -126,15 +140,11 @@ for class names as well as for objects.
 bool
 Perl_sv_derived_from(pTHX_ SV *sv, const char *name)
 {
-    char *type;
-    HV *stash;
+    const char *type = Nullch;
+    HV *stash = Nullhv;
     HV *name_stash;
 
-    stash = Nullhv;
-    type = Nullch;
-
-    if (SvGMAGICAL(sv))
-        mg_get(sv) ;
+    SvGETMAGIC(sv);
 
     if (SvROK(sv)) {
         sv = SvRV(sv);
@@ -157,9 +167,23 @@ Perl_sv_derived_from(pTHX_ SV *sv, const char *name)
 
 #include "XSUB.h"
 
-void XS_UNIVERSAL_isa(pTHX_ CV *cv);
-void XS_UNIVERSAL_can(pTHX_ CV *cv);
-void XS_UNIVERSAL_VERSION(pTHX_ CV *cv);
+PERL_XS_EXPORT_C void XS_UNIVERSAL_isa(pTHX_ CV *cv);
+PERL_XS_EXPORT_C void XS_UNIVERSAL_can(pTHX_ CV *cv);
+PERL_XS_EXPORT_C void XS_UNIVERSAL_VERSION(pTHX_ CV *cv);
+XS(XS_version_new);
+XS(XS_version_stringify);
+XS(XS_version_numify);
+XS(XS_version_normal);
+XS(XS_version_vcmp);
+XS(XS_version_boolean);
+#ifdef HASATTRIBUTE_NORETURN
+XS(XS_version_noop) __attribute__noreturn__;
+#else
+XS(XS_version_noop);
+#endif
+XS(XS_version_is_alpha);
+XS(XS_version_qv);
+XS(XS_utf8_is_utf8);
 XS(XS_utf8_valid);
 XS(XS_utf8_encode);
 XS(XS_utf8_decode);
@@ -167,16 +191,45 @@ XS(XS_utf8_upgrade);
 XS(XS_utf8_downgrade);
 XS(XS_utf8_unicode_to_native);
 XS(XS_utf8_native_to_unicode);
-XS(XS_access_readonly);
+XS(XS_Internals_SvREADONLY);
+XS(XS_Internals_SvREFCNT);
+XS(XS_Internals_hv_clear_placehold);
+XS(XS_PerlIO_get_layers);
+XS(XS_Regexp_DESTROY);
+XS(XS_Internals_hash_seed);
+XS(XS_Internals_rehash_seed);
+XS(XS_Internals_HvREHASH);
 
 void
 Perl_boot_core_UNIVERSAL(pTHX)
 {
-    char *file = __FILE__;
+    const char file[] = __FILE__;
 
     newXS("UNIVERSAL::isa",             XS_UNIVERSAL_isa,         file);
     newXS("UNIVERSAL::can",             XS_UNIVERSAL_can,         file);
     newXS("UNIVERSAL::VERSION",        XS_UNIVERSAL_VERSION,     file);
+    {
+       /* register the overloading (type 'A') magic */
+       PL_amagic_generation++;
+       /* Make it findable via fetchmethod */
+       newXS("version::()", XS_version_noop, file);
+       newXS("version::new", XS_version_new, file);
+       newXS("version::(\"\"", XS_version_stringify, file);
+       newXS("version::stringify", XS_version_stringify, file);
+       newXS("version::(0+", XS_version_numify, file);
+       newXS("version::numify", XS_version_numify, file);
+       newXS("version::normal", XS_version_normal, file);
+       newXS("version::(cmp", XS_version_vcmp, file);
+       newXS("version::(<=>", XS_version_vcmp, file);
+       newXS("version::vcmp", XS_version_vcmp, file);
+       newXS("version::(bool", XS_version_boolean, file);
+       newXS("version::boolean", XS_version_boolean, file);
+       newXS("version::(nomethod", XS_version_noop, file);
+       newXS("version::noop", XS_version_noop, file);
+       newXS("version::is_alpha", XS_version_is_alpha, file);
+       newXS("version::qv", XS_version_qv, file);
+    }
+    newXS("utf8::is_utf8", XS_utf8_is_utf8, file);
     newXS("utf8::valid", XS_utf8_valid, file);
     newXS("utf8::encode", XS_utf8_encode, file);
     newXS("utf8::decode", XS_utf8_decode, file);
@@ -184,55 +237,62 @@ Perl_boot_core_UNIVERSAL(pTHX)
     newXS("utf8::downgrade", XS_utf8_downgrade, file);
     newXS("utf8::native_to_unicode", XS_utf8_native_to_unicode, file);
     newXS("utf8::unicode_to_native", XS_utf8_unicode_to_native, file);
-    newXSproto("access::readonly",XS_access_readonly, file, "\\[$%@];$");
+    newXSproto("Internals::SvREADONLY",XS_Internals_SvREADONLY, file, "\\[$%@];$");
+    newXSproto("Internals::SvREFCNT",XS_Internals_SvREFCNT, file, "\\[$%@];$");
+    newXSproto("Internals::hv_clear_placeholders",
+               XS_Internals_hv_clear_placehold, file, "\\%");
+    newXSproto("PerlIO::get_layers",
+               XS_PerlIO_get_layers, file, "*;@");
+    newXS("Regexp::DESTROY", XS_Regexp_DESTROY, file);
+    newXSproto("Internals::hash_seed",XS_Internals_hash_seed, file, "");
+    newXSproto("Internals::rehash_seed",XS_Internals_rehash_seed, file, "");
+    newXSproto("Internals::HvREHASH", XS_Internals_HvREHASH, file, "\\%");
 }
 
 
 XS(XS_UNIVERSAL_isa)
 {
     dXSARGS;
-    SV *sv;
-    char *name;
-    STRLEN n_a;
 
     if (items != 2)
        Perl_croak(aTHX_ "Usage: UNIVERSAL::isa(reference, kind)");
+    else {
+       SV * const sv = ST(0);
+       const char *name;
 
-    sv = ST(0);
-
-    if (SvGMAGICAL(sv))
-       mg_get(sv);
+       SvGETMAGIC(sv);
 
-    if (!SvOK(sv) || !(SvROK(sv) || (SvPOK(sv) && SvCUR(sv))))
-       XSRETURN_UNDEF;
+       if (!SvOK(sv) || !(SvROK(sv) || (SvPOK(sv) && SvCUR(sv))
+                   || (SvGMAGICAL(sv) && SvPOKp(sv) && SvCUR(sv))))
+           XSRETURN_UNDEF;
 
-    name = (char *)SvPV(ST(1),n_a);
+       name = SvPV_nolen_const(ST(1));
 
-    ST(0) = boolSV(sv_derived_from(sv, name));
-    XSRETURN(1);
+       ST(0) = boolSV(sv_derived_from(sv, name));
+       XSRETURN(1);
+    }
 }
 
 XS(XS_UNIVERSAL_can)
 {
     dXSARGS;
     SV   *sv;
-    char *name;
+    const char *name;
     SV   *rv;
     HV   *pkg = NULL;
-    STRLEN n_a;
 
     if (items != 2)
        Perl_croak(aTHX_ "Usage: UNIVERSAL::can(object-ref, method)");
 
     sv = ST(0);
 
-    if (SvGMAGICAL(sv))
-       mg_get(sv);
+    SvGETMAGIC(sv);
 
-    if (!SvOK(sv) || !(SvROK(sv) || (SvPOK(sv) && SvCUR(sv))))
+    if (!SvOK(sv) || !(SvROK(sv) || (SvPOK(sv) && SvCUR(sv))
+               || (SvGMAGICAL(sv) && SvPOKp(sv) && SvCUR(sv))))
        XSRETURN_UNDEF;
 
-    name = (char *)SvPV(ST(1),n_a);
+    name = SvPV_nolen_const(ST(1));
     rv = &PL_sv_undef;
 
     if (SvROK(sv)) {
@@ -245,7 +305,7 @@ XS(XS_UNIVERSAL_can)
     }
 
     if (pkg) {
-        GV *gv = gv_fetchmethod_autoload(pkg, name, FALSE);
+       GV * const gv = gv_fetchmethod_autoload(pkg, name, FALSE);
         if (gv && isGV(gv))
            rv = sv_2mortal(newRV((SV*)GvCV(gv)));
     }
@@ -261,7 +321,7 @@ XS(XS_UNIVERSAL_VERSION)
     GV **gvp;
     GV *gv;
     SV *sv;
-    char *undef;
+    const char *undef;
 
     if (SvROK(ST(0))) {
         sv = (SV*)SvRV(ST(0));
@@ -275,10 +335,12 @@ XS(XS_UNIVERSAL_VERSION)
 
     gvp = pkg ? (GV**)hv_fetch(pkg,"VERSION",7,FALSE) : Null(GV**);
 
-    if (gvp && isGV(gv = *gvp) && SvOK(sv = GvSV(gv))) {
-        SV *nsv = sv_newmortal();
+    if (gvp && isGV(gv = *gvp) && (sv = GvSV(gv)) && SvOK(sv)) {
+        SV * const nsv = sv_newmortal();
         sv_setsv(nsv, sv);
         sv = nsv;
+       if ( !sv_derived_from(sv, "version"))
+           upg_version(sv);
         undef = Nullch;
     }
     else {
@@ -287,97 +349,319 @@ XS(XS_UNIVERSAL_VERSION)
     }
 
     if (items > 1) {
-       STRLEN len;
        SV *req = ST(1);
 
        if (undef) {
-            if (pkg)
-                 Perl_croak(aTHX_
-                            "%s does not define $%s::VERSION--version check failed",
-                            HvNAME(pkg), HvNAME(pkg));
-            else {
-                 char *str = SvPVx(ST(0), len);
-
-                 Perl_croak(aTHX_
-                            "%s defines neither package nor VERSION--version check failed", str);
+           if (pkg) {
+               const char * const name = HvNAME_get(pkg);
+               Perl_croak(aTHX_
+                          "%s does not define $%s::VERSION--version check failed",
+                          name, name);
+           } else {
+               Perl_croak(aTHX_
+                            "%s defines neither package nor VERSION--version check failed",
+                            SvPVx_nolen_const(ST(0)) );
             }
        }
-       if (!SvNIOK(sv) && SvPOK(sv)) {
-           char *str = SvPVx(sv,len);
-           while (len) {
-               --len;
-               /* XXX could DWIM "1.2.3" here */
-               if (!isDIGIT(str[len]) && str[len] != '.' && str[len] != '_')
-                   break;
+
+       if ( !sv_derived_from(req, "version")) {
+           /* req may very well be R/O, so create a new object */
+           SV * const nsv = sv_newmortal();
+           sv_setsv(nsv, req);
+           req = nsv;
+           upg_version(req);
+       }
+
+       if ( vcmp( req, sv ) > 0 )
+           Perl_croak(aTHX_ "%s version %"SVf" (%"SVf") required--"
+                   "this is only version %"SVf" (%"SVf")", HvNAME_get(pkg),
+                   vnumify(req),vnormal(req),vnumify(sv),vnormal(sv));
+    }
+
+    if ( SvOK(sv) && sv_derived_from(sv, "version") ) {
+       ST(0) = vnumify(sv);
+    } else {
+       ST(0) = sv;
+    }
+
+    XSRETURN(1);
+}
+
+XS(XS_version_new)
+{
+    dXSARGS;
+    if (items > 3)
+       Perl_croak(aTHX_ "Usage: version::new(class, version)");
+    SP -= items;
+    {
+        SV *vs = ST(1);
+       SV *rv;
+       const char * const classname =
+           sv_isobject(ST(0)) /* get the class if called as an object method */
+               ? HvNAME(SvSTASH(SvRV(ST(0))))
+               : (char *)SvPV_nolen(ST(0));
+
+       if ( items == 1 ) {
+           /* no parameter provided */
+           if ( sv_isobject(ST(0)) ) {
+               /* copy existing object */
+               vs = ST(0);
            }
-           if (len) {
-               if (SvNOK(req) && SvPOK(req)) {
-                   /* they said C<use Foo v1.2.3> and $Foo::VERSION
-                    * doesn't look like a float: do string compare */
-                   if (sv_cmp(req,sv) == 1) {
-                       Perl_croak(aTHX_ "%s v%"VDf" required--"
-                                  "this is only v%"VDf,
-                                  HvNAME(pkg), req, sv);
-                   }
-                   goto finish;
-               }
-               /* they said C<use Foo 1.002_003> and $Foo::VERSION
-                * doesn't look like a float: force numeric compare */
-               (void)SvUPGRADE(sv, SVt_PVNV);
-               SvNVX(sv) = str_to_version(sv);
-               SvPOK_off(sv);
-               SvNOK_on(sv);
+           else {
+               /* create empty object */
+               vs = sv_newmortal();
+               sv_setpvn(vs,"",0);
            }
        }
-       /* if we get here, we're looking for a numeric comparison,
-        * so force the required version into a float, even if they
-        * said C<use Foo v1.2.3> */
-       if (SvNOK(req) && SvPOK(req)) {
-           NV n = SvNV(req);
-           req = sv_newmortal();
-           sv_setnv(req, n);
+       else if ( items == 3 ) {
+           vs = sv_newmortal();
+           Perl_sv_setpvf(aTHX_ vs,"v%s",SvPV_nolen_const(ST(2)));
        }
 
-       if (SvNV(req) > SvNV(sv))
-           Perl_croak(aTHX_ "%s version %s required--this is only version %s",
-                      HvNAME(pkg), SvPV_nolen(req), SvPV_nolen(sv));
+       rv = new_version(vs);
+       if ( strcmp(classname,"version") != 0 ) /* inherited new() */
+           sv_bless(rv, gv_stashpv(classname,TRUE));
+
+       PUSHs(sv_2mortal(rv));
+       PUTBACK;
+       return;
     }
+}
 
-finish:
-    ST(0) = sv;
+XS(XS_version_stringify)
+{
+     dXSARGS;
+     if (items < 1)
+         Perl_croak(aTHX_ "Usage: version::stringify(lobj, ...)");
+     SP -= items;
+     {
+         SV *  lobj;
+
+         if (sv_derived_from(ST(0), "version")) {
+              lobj = SvRV(ST(0));
+         }
+         else
+              Perl_croak(aTHX_ "lobj is not of type version");
+
+         PUSHs(sv_2mortal(vstringify(lobj)));
+
+         PUTBACK;
+         return;
+     }
+}
 
-    XSRETURN(1);
+XS(XS_version_numify)
+{
+     dXSARGS;
+     if (items < 1)
+         Perl_croak(aTHX_ "Usage: version::numify(lobj, ...)");
+     SP -= items;
+     {
+         SV *  lobj;
+
+         if (sv_derived_from(ST(0), "version")) {
+              lobj = SvRV(ST(0));
+         }
+         else
+              Perl_croak(aTHX_ "lobj is not of type version");
+
+         PUSHs(sv_2mortal(vnumify(lobj)));
+
+         PUTBACK;
+         return;
+     }
 }
 
-XS(XS_utf8_valid)
+XS(XS_version_normal)
+{
+     dXSARGS;
+     if (items < 1)
+         Perl_croak(aTHX_ "Usage: version::normal(lobj, ...)");
+     SP -= items;
+     {
+         SV *  lobj;
+
+         if (sv_derived_from(ST(0), "version")) {
+              lobj = SvRV(ST(0));
+         }
+         else
+              Perl_croak(aTHX_ "lobj is not of type version");
+
+         PUSHs(sv_2mortal(vnormal(lobj)));
+
+         PUTBACK;
+         return;
+     }
+}
+
+XS(XS_version_vcmp)
+{
+     dXSARGS;
+     if (items < 1)
+         Perl_croak(aTHX_ "Usage: version::vcmp(lobj, ...)");
+     SP -= items;
+     {
+         SV *  lobj;
+
+         if (sv_derived_from(ST(0), "version")) {
+              lobj = SvRV(ST(0));
+         }
+         else
+              Perl_croak(aTHX_ "lobj is not of type version");
+
+         {
+              SV       *rs;
+              SV       *rvs;
+              SV * robj = ST(1);
+              const IV  swap = (IV)SvIV(ST(2));
+
+              if ( ! sv_derived_from(robj, "version") )
+              {
+                   robj = new_version(robj);
+              }
+              rvs = SvRV(robj);
+
+              if ( swap )
+              {
+                   rs = newSViv(vcmp(rvs,lobj));
+              }
+              else
+              {
+                   rs = newSViv(vcmp(lobj,rvs));
+              }
+
+              PUSHs(sv_2mortal(rs));
+         }
+
+         PUTBACK;
+         return;
+     }
+}
+
+XS(XS_version_boolean)
+{
+     dXSARGS;
+     if (items < 1)
+         Perl_croak(aTHX_ "Usage: version::boolean(lobj, ...)");
+     SP -= items;
+    if (sv_derived_from(ST(0), "version")) {
+       SV * const lobj = SvRV(ST(0));
+       SV * const rs = newSViv( vcmp(lobj,new_version(newSVpvn("0",1))) );
+       PUSHs(sv_2mortal(rs));
+       PUTBACK;
+       return;
+    }
+    else
+       Perl_croak(aTHX_ "lobj is not of type version");
+}
+
+XS(XS_version_noop)
+{
+    dXSARGS;
+    if (items < 1)
+       Perl_croak(aTHX_ "Usage: version::noop(lobj, ...)");
+    if (sv_derived_from(ST(0), "version"))
+       Perl_croak(aTHX_ "operation not supported with version object");
+    else
+       Perl_croak(aTHX_ "lobj is not of type version");
+#ifndef HASATTRIBUTE_NORETURN
+    XSRETURN_EMPTY;
+#endif
+}
+
+XS(XS_version_is_alpha)
 {
     dXSARGS;
     if (items != 1)
-       Perl_croak(aTHX_ "Usage: utf8::valid(sv)");
-    {
-       SV *    sv = ST(0);
- {
-  STRLEN len;
-  char *s = SvPV(sv,len);
-  if (!SvUTF8(sv) || is_utf8_string((U8*)s,len))
-   XSRETURN_YES;
-  else
-   XSRETURN_NO;
- }
+       Perl_croak(aTHX_ "Usage: version::is_alpha(lobj)");
+    SP -= items;
+    if (sv_derived_from(ST(0), "version")) {
+       SV * const lobj = ST(0);
+       if ( hv_exists((HV*)SvRV(lobj), "alpha", 5 ) )
+           XSRETURN_YES;
+       else
+           XSRETURN_NO;
+       PUTBACK;
+       return;
     }
-    XSRETURN_EMPTY;
+    else
+       Perl_croak(aTHX_ "lobj is not of type version");
 }
 
-XS(XS_utf8_encode)
+XS(XS_version_qv)
 {
     dXSARGS;
     if (items != 1)
-       Perl_croak(aTHX_ "Usage: utf8::encode(sv)");
+       Perl_croak(aTHX_ "Usage: version::qv(ver)");
+    SP -= items;
     {
-       SV *    sv = ST(0);
+       SV *    ver = ST(0);
+       if ( !SvVOK(ver) ) { /* only need to do with if not already v-string */
+           SV * const vs = sv_newmortal();
+           char *version;
+           if ( SvNOK(ver) ) /* may get too much accuracy */
+           {
+               char tbuf[64];
+               const STRLEN len = my_sprintf(tbuf,"%.9"NVgf, SvNVX(ver));
+               version = savepvn(tbuf, len);
+           }
+           else
+           {
+               version = savesvpv(ver);
+           }
+           (void)scan_version(version,vs,TRUE);
+           Safefree(version);
+
+           PUSHs(vs);
+       }
+       else
+       {
+           PUSHs(sv_2mortal(new_version(ver)));
+       }
+
+       PUTBACK;
+       return;
+    }
+}
 
-       sv_utf8_encode(sv);
+XS(XS_utf8_is_utf8)
+{
+     dXSARGS;
+     if (items != 1)
+         Perl_croak(aTHX_ "Usage: utf8::is_utf8(sv)");
+     else {
+       const SV * const sv = ST(0);
+           if (SvUTF8(sv))
+               XSRETURN_YES;
+           else
+               XSRETURN_NO;
+     }
+     XSRETURN_EMPTY;
+}
+
+XS(XS_utf8_valid)
+{
+     dXSARGS;
+     if (items != 1)
+         Perl_croak(aTHX_ "Usage: utf8::valid(sv)");
+    else {
+       SV * const sv = ST(0);
+       STRLEN len;
+       const char * const s = SvPV_const(sv,len);
+       if (!SvUTF8(sv) || is_utf8_string((const U8*)s,len))
+           XSRETURN_YES;
+       else
+           XSRETURN_NO;
     }
+     XSRETURN_EMPTY;
+}
+
+XS(XS_utf8_encode)
+{
+    dXSARGS;
+    if (items != 1)
+       Perl_croak(aTHX_ "Usage: utf8::encode(sv)");
+    sv_utf8_encode(ST(0));
     XSRETURN_EMPTY;
 }
 
@@ -386,11 +670,9 @@ XS(XS_utf8_decode)
     dXSARGS;
     if (items != 1)
        Perl_croak(aTHX_ "Usage: utf8::decode(sv)");
-    {
-       SV *    sv = ST(0);
-       bool    RETVAL;
-
-       RETVAL = sv_utf8_decode(sv);
+    else {
+       SV * const sv = ST(0);
+       const bool RETVAL = sv_utf8_decode(sv);
        ST(0) = boolSV(RETVAL);
        sv_2mortal(ST(0));
     }
@@ -402,8 +684,8 @@ XS(XS_utf8_upgrade)
     dXSARGS;
     if (items != 1)
        Perl_croak(aTHX_ "Usage: utf8::upgrade(sv)");
-    {
-       SV *    sv = ST(0);
+    else {
+       SV * const sv = ST(0);
        STRLEN  RETVAL;
        dXSTARG;
 
@@ -418,18 +700,11 @@ XS(XS_utf8_downgrade)
     dXSARGS;
     if (items < 1 || items > 2)
        Perl_croak(aTHX_ "Usage: utf8::downgrade(sv, failok=0)");
-    {
-       SV *    sv = ST(0);
-       bool    failok;
-       bool    RETVAL;
-
-       if (items < 2)
-           failok = 0;
-       else {
-           failok = (int)SvIV(ST(1));
-       }
+    else {
+       SV * const sv = ST(0);
+        const bool failok = (items < 2) ? 0 : (int)SvIV(ST(1));
+        const bool RETVAL = sv_utf8_downgrade(sv, failok);
 
-       RETVAL = sv_utf8_downgrade(sv, failok);
        ST(0) = boolSV(RETVAL);
        sv_2mortal(ST(0));
     }
@@ -439,7 +714,7 @@ XS(XS_utf8_downgrade)
 XS(XS_utf8_native_to_unicode)
 {
  dXSARGS;
- UV uv = SvUV(ST(0));
const UV uv = SvUV(ST(0));
 
  if (items > 1)
      Perl_croak(aTHX_ "Usage: utf8::native_to_unicode(sv)");
@@ -451,7 +726,7 @@ XS(XS_utf8_native_to_unicode)
 XS(XS_utf8_unicode_to_native)
 {
  dXSARGS;
- UV uv = SvUV(ST(0));
const UV uv = SvUV(ST(0));
 
  if (items > 1)
      Perl_croak(aTHX_ "Usage: utf8::unicode_to_native(sv)");
@@ -460,22 +735,226 @@ XS(XS_utf8_unicode_to_native)
  XSRETURN(1);
 }
 
-XS(XS_access_readonly)
+XS(XS_Internals_SvREADONLY)    /* This is dangerous stuff. */
 {
     dXSARGS;
-    SV *sv = SvRV(ST(0));
-    IV old = SvREADONLY(sv);
-    if (items == 2) {
+    SV * const sv = SvRV(ST(0));
+
+    if (items == 1) {
+        if (SvREADONLY(sv))
+            XSRETURN_YES;
+        else
+            XSRETURN_NO;
+    }
+    else if (items == 2) {
        if (SvTRUE(ST(1))) {
            SvREADONLY_on(sv);
+           XSRETURN_YES;
        }
        else {
+           /* I hope you really know what you are doing. */
            SvREADONLY_off(sv);
+           XSRETURN_NO;
        }
     }
-    if (old)
-       XSRETURN_YES;
-    else
-       XSRETURN_NO;
+    XSRETURN_UNDEF; /* Can't happen. */
+}
+
+XS(XS_Internals_SvREFCNT)      /* This is dangerous stuff. */
+{
+    dXSARGS;
+    SV * const sv = SvRV(ST(0));
+
+    if (items == 1)
+        XSRETURN_IV(SvREFCNT(sv) - 1); /* Minus the ref created for us. */
+    else if (items == 2) {
+         /* I hope you really know what you are doing. */
+        SvREFCNT(sv) = SvIV(ST(1));
+        XSRETURN_IV(SvREFCNT(sv));
+    }
+    XSRETURN_UNDEF; /* Can't happen. */
 }
 
+XS(XS_Internals_hv_clear_placehold)
+{
+    dXSARGS;
+
+    if (items != 1)
+       Perl_croak(aTHX_ "Usage: UNIVERSAL::hv_clear_placeholders(hv)");
+    else {
+       HV * const hv = (HV *) SvRV(ST(0));
+       hv_clear_placeholders(hv);
+       XSRETURN(0);
+    }
+}
+
+XS(XS_Regexp_DESTROY)
+{
+    PERL_UNUSED_ARG(cv);
+}
+
+XS(XS_PerlIO_get_layers)
+{
+    dXSARGS;
+    if (items < 1 || items % 2 == 0)
+       Perl_croak(aTHX_ "Usage: PerlIO_get_layers(filehandle[,args])");
+#ifdef USE_PERLIO
+    {
+       SV *    sv;
+       GV *    gv;
+       IO *    io;
+       bool    input = TRUE;
+       bool    details = FALSE;
+
+       if (items > 1) {
+            SV * const *svp;
+            for (svp = MARK + 2; svp <= SP; svp += 2) {
+                 SV * const * const varp = svp;
+                 SV * const * const valp = svp + 1;
+                 STRLEN klen;
+                 const char * const key = SvPV_const(*varp, klen);
+
+                 switch (*key) {
+                 case 'i':
+                      if (klen == 5 && memEQ(key, "input", 5)) {
+                           input = SvTRUE(*valp);
+                           break;
+                      }
+                      goto fail;
+                 case 'o': 
+                      if (klen == 6 && memEQ(key, "output", 6)) {
+                           input = !SvTRUE(*valp);
+                           break;
+                      }
+                      goto fail;
+                 case 'd':
+                      if (klen == 7 && memEQ(key, "details", 7)) {
+                           details = SvTRUE(*valp);
+                           break;
+                      }
+                      goto fail;
+                 default:
+                 fail:
+                      Perl_croak(aTHX_
+                                 "get_layers: unknown argument '%s'",
+                                 key);
+                 }
+            }
+
+            SP -= (items - 1);
+       }
+
+       sv = POPs;
+       gv = (GV*)sv;
+
+       if (!isGV(sv)) {
+            if (SvROK(sv) && isGV(SvRV(sv)))
+                 gv = (GV*)SvRV(sv);
+            else if (SvPOKp(sv))
+                 gv = gv_fetchsv(sv, FALSE, SVt_PVIO);
+       }
+
+       if (gv && (io = GvIO(gv))) {
+            dTARGET;
+            AV* const av = PerlIO_get_layers(aTHX_ input ?
+                                       IoIFP(io) : IoOFP(io));
+            I32 i;
+            const I32 last = av_len(av);
+            I32 nitem = 0;
+            
+            for (i = last; i >= 0; i -= 3) {
+                 SV * const * const namsvp = av_fetch(av, i - 2, FALSE);
+                 SV * const * const argsvp = av_fetch(av, i - 1, FALSE);
+                 SV * const * const flgsvp = av_fetch(av, i,     FALSE);
+
+                 const bool namok = namsvp && *namsvp && SvPOK(*namsvp);
+                 const bool argok = argsvp && *argsvp && SvPOK(*argsvp);
+                 const bool flgok = flgsvp && *flgsvp && SvIOK(*flgsvp);
+
+                 if (details) {
+                      XPUSHs(namok
+                             ? newSVpvn(SvPVX_const(*namsvp), SvCUR(*namsvp))
+                             : &PL_sv_undef);
+                      XPUSHs(argok
+                             ? newSVpvn(SvPVX_const(*argsvp), SvCUR(*argsvp))
+                             : &PL_sv_undef);
+                      if (flgok)
+                           XPUSHi(SvIVX(*flgsvp));
+                      else
+                           XPUSHs(&PL_sv_undef);
+                      nitem += 3;
+                 }
+                 else {
+                      if (namok && argok)
+                           XPUSHs(Perl_newSVpvf(aTHX_ "%"SVf"(%"SVf")",
+                                              *namsvp, *argsvp));
+                      else if (namok)
+                           XPUSHs(Perl_newSVpvf(aTHX_ "%"SVf, *namsvp));
+                      else
+                           XPUSHs(&PL_sv_undef);
+                      nitem++;
+                      if (flgok) {
+                           const IV flags = SvIVX(*flgsvp);
+
+                           if (flags & PERLIO_F_UTF8) {
+                                XPUSHs(newSVpvn("utf8", 4));
+                                nitem++;
+                           }
+                      }
+                 }
+            }
+
+            SvREFCNT_dec(av);
+
+            XSRETURN(nitem);
+       }
+    }
+#endif
+
+    XSRETURN(0);
+}
+
+XS(XS_Internals_hash_seed)
+{
+    /* Using dXSARGS would also have dITEM and dSP,
+     * which define 2 unused local variables.  */
+    dAXMARK;
+    PERL_UNUSED_ARG(cv);
+    PERL_UNUSED_VAR(mark);
+    XSRETURN_UV(PERL_HASH_SEED);
+}
+
+XS(XS_Internals_rehash_seed)
+{
+    /* Using dXSARGS would also have dITEM and dSP,
+     * which define 2 unused local variables.  */
+    dAXMARK;
+    PERL_UNUSED_ARG(cv);
+    PERL_UNUSED_VAR(mark);
+    XSRETURN_UV(PL_rehash_seed);
+}
+
+XS(XS_Internals_HvREHASH)      /* Subject to change  */
+{
+    dXSARGS;
+    if (SvROK(ST(0))) {
+       const HV * const hv = (HV *) SvRV(ST(0));
+       if (items == 1 && SvTYPE(hv) == SVt_PVHV) {
+           if (HvREHASH(hv))
+               XSRETURN_YES;
+           else
+               XSRETURN_NO;
+       }
+    }
+    Perl_croak(aTHX_ "Internals::HvREHASH $hashref");
+}
+
+/*
+ * Local variables:
+ * c-indentation-style: bsd
+ * c-basic-offset: 4
+ * indent-tabs-mode: t
+ * End:
+ *
+ * ex: set ts=8 sts=4 sw=4 noet:
+ */