toke.c: White-space alignment, add comment

[perl5.git] / dquote_static.c

diff --git a/dquote_static.c b/dquote_static.c
index 5a22993..802d83b 100644 (file)
--- a/dquote_static.c
+++ b/dquote_static.c
@@ -15,7 +15,7 @@
     Pulled from regcomp.c.
  */
 PERL_STATIC_INLINE I32
-S_regcurly(pTHX_ const char *s)
+S_regcurly(const char *s)
 {
     PERL_ARGS_ASSERT_REGCURLY;
 
@@ -30,9 +30,8 @@ S_regcurly(pTHX_ const char *s)
        while (isDIGIT(*s))
            s++;
     }
-    if (*s != '}')
-       return FALSE;
-    return TRUE;
+
+    return *s == '}';
 }
 
 /* XXX Add documentation after final interface and behavior is decided */
@@ -41,44 +40,36 @@ S_regcurly(pTHX_ const char *s)
 */
 
 STATIC char
-S_grok_bslash_c(pTHX_ const char source, const bool utf8, const bool output_warning)
+S_grok_bslash_c(pTHX_ const char source, const bool output_warning)
 {
 
     U8 result;
 
-    if (utf8) {
-       /* Trying to deprecate non-ASCII usages.  This construct has never
-        * worked for a utf8 variant.  So, even though are accepting non-ASCII
-        * Latin1 in 5.14, no need to make them work under utf8 */
-       if (! isASCII(source)) {
-           Perl_croak(aTHX_ "Character following \"\\c\" must be ASCII");
-       }
+    if (! isPRINT_A(source)) {
+        Perl_croak(aTHX_ "%s",
+                        "Character following \"\\c\" must be printable ASCII");
     }
+    else if (source == '{') {
+        assert(isPRINT_A(toCTRL('{')));
 
-    result = toCTRL(source);
-    if (! isASCII(source)) {
-           Perl_ck_warner_d(aTHX_ packWARN2(WARN_DEPRECATED, WARN_SYNTAX),
-                           "Character following \"\\c\" must be ASCII");
+        /* diag_listed_as: Use "%s" instead of "%s" */
+        Perl_croak(aTHX_ "Use \"%c\" instead of \"\\c{\"", toCTRL('{'));
     }
-    else if (! isCNTRL(result) && output_warning) {
-       if (source == '{') {
-           Perl_ck_warner_d(aTHX_ packWARN2(WARN_DEPRECATED, WARN_SYNTAX),
-                           "\"\\c{\" is deprecated and is more clearly written as \";\"");
-       }
-       else {
-           U8 clearer[3];
-           U8 i = 0;
-           if (! isWORDCHAR(result)) {
-               clearer[i++] = '\\';
-           }
-           clearer[i++] = result;
-           clearer[i++] = '\0';
-
-           Perl_ck_warner(aTHX_ packWARN(WARN_SYNTAX),
-                           "\"\\c%c\" is more clearly written simply as \"%s\"",
-                           source,
-                           clearer);
-       }
+
+    result = toCTRL(source);
+    if (output_warning && isPRINT_A(result)) {
+        U8 clearer[3];
+        U8 i = 0;
+        if (! isWORDCHAR(result)) {
+            clearer[i++] = '\\';
+        }
+        clearer[i++] = result;
+        clearer[i++] = '\0';
+
+        Perl_ck_warner(aTHX_ packWARN(WARN_SYNTAX),
+                        "\"\\c%c\" is more clearly written simply as \"%s\"",
+                        source,
+                        clearer);
     }
 
     return result;