#!./perl -w
-# use strict;
-
-print "1..56\n";
-
-my $test = 1;
-
-sub ok ($;$$) {
- my ($pass, $wrong, $err) = @_;
- if ($pass) {
- print "ok $test\n";
- $test = $test + 1; # Would be doubleplusbad to use ++ in the ++ test.
- return 1;
- } else {
- if ($err) {
- chomp $err;
- print "not ok $test # $err\n";
- } else {
- if (defined $wrong) {
- $wrong = ", got $wrong";
- } else {
- $wrong = '';
- }
- printf "not ok $test # line %d$wrong\n", (caller)[2];
- }
- }
- $test = $test + 1;
- return;
+BEGIN {
+ chdir 't' if -d 't';
+ @INC = '../lib';
+ require './test.pl';
}
+use strict;
+
+use Config;
+
+# Tests of post/pre - increment/decrement operators.
+
# Verify that addition/subtraction properly upgrade to doubles.
# These tests are only significant on machines with 32 bit longs,
# and two's complement negation, but shouldn't fail anywhere.
my $a = 2147483647;
my $c=$a++;
-ok ($a == 2147483648, $a);
+cmp_ok($a, '==', 2147483648, "postincrement properly upgrades to double");
$a = 2147483647;
$c=++$a;
-ok ($a == 2147483648, $a);
+cmp_ok($a, '==', 2147483648, "preincrement properly upgrades to double");
$a = 2147483647;
$a=$a+1;
-ok ($a == 2147483648, $a);
+cmp_ok($a, '==', 2147483648, "addition properly upgrades to double");
$a = -2147483648;
$c=$a--;
-ok ($a == -2147483649, $a);
+cmp_ok($a, '==', -2147483649, "postdecrement properly upgrades to double");
$a = -2147483648;
$c=--$a;
-ok ($a == -2147483649, $a);
+cmp_ok($a, '==', -2147483649, "predecrement properly upgrades to double");
$a = -2147483648;
$a=$a-1;
-ok ($a == -2147483649, $a);
+cmp_ok($a, '==', -2147483649, "subtraction properly upgrades to double");
$a = 2147483648;
$a = -$a;
$c=$a--;
-ok ($a == -2147483649, $a);
+cmp_ok($a, '==', -2147483649,
+ "negation and postdecrement properly upgrade to double");
$a = 2147483648;
$a = -$a;
$c=--$a;
-ok ($a == -2147483649, $a);
+cmp_ok($a, '==', -2147483649,
+ "negation and predecrement properly upgrade to double");
$a = 2147483648;
$a = -$a;
$a=$a-1;
-ok ($a == -2147483649, $a);
+cmp_ok($a, '==', -2147483649,
+ "negation and subtraction properly upgrade to double");
$a = 2147483648;
$b = -$a;
$c=$b--;
-ok ($b == -$a-1, $a);
+cmp_ok($b, '==', -$a-1, "negation, postdecrement and additional negation");
$a = 2147483648;
$b = -$a;
$c=--$b;
-ok ($b == -$a-1, $a);
+cmp_ok($b, '==', -$a-1, "negation, predecrement and additional negation");
$a = 2147483648;
$b = -$a;
$b=$b-1;
-ok ($b == -(++$a), $a);
+cmp_ok($b, '==', -(++$a),
+ "negation, subtraction, preincrement and additional negation");
$a = undef;
-ok ($a++ eq '0', do { $a=undef; $a++ }, "postinc undef returns '0'");
+is($a++, '0', "postinc undef returns '0'");
$a = undef;
-ok (!defined($a--), do { $a=undef; $a-- }, "postdec undef returns undef");
+is($a--, undef, "postdec undef returns undef");
# Verify that shared hash keys become unshared.
print "# key '$_' was '$orig->{$_}' now missing\n";
$fail = 1;
}
- ok (!$fail);
+ ok (!$fail, "original hashes unchanged");
}
my (%orig) = my (%inc) = my (%dec) = my (%postinc) = my (%postdec)
my $ans = $up{$_};
my $up;
eval {$up = ++$_};
- ok ((defined $up and $up eq $ans), $up, $@);
+ is($up, $ans, "key '$_' incremented correctly");
+ is($@, '', "no error condition");
}
check_same (\%orig, \%inc);
my $ans = $down{$_};
my $down;
eval {$down = --$_};
- ok ((defined $down and $down eq $ans), $down, $@);
+ is($down, $ans, "key '$_' decremented correctly");
+ is($@, '', "no error condition");
}
check_same (\%orig, \%dec);
my $ans = $postinc{$_};
my $up;
eval {$up = $_++};
- ok ((defined $up and $up eq $ans), $up, $@);
+ is($up, $ans, "assignment preceded postincrement");
+ is($@, '', "no error condition");
}
check_same (\%orig, \%postinc);
my $ans = $postdec{$_};
my $down;
eval {$down = $_--};
- ok ((defined $down and $down eq $ans), $down, $@);
+ is($down, $ans, "assignment preceded postdecrement");
+ is($@, '', "no error condition");
}
check_same (\%orig, \%postdec);
$y ="$x\n";
++$x;
};
- ok($x == 1, $x);
- ok($@ eq '', $@);
+ cmp_ok($x, '==', 1, "preincrement of previously uninitialized variable");
+ is($@, '', "no error condition");
my ($p, $q);
eval {
$q ="$p\n";
--$p;
};
- ok($p == -1, $p);
- ok($@ eq '', $@);
+ cmp_ok($p, '==', -1, "predecrement of previously uninitialized variable");
+ is($@, '', "no error condition");
}
$a = 2147483648;
$c=--$a;
-ok ($a == 2147483647, $a);
+cmp_ok($a, '==', 2147483647, "predecrement properly downgrades from double");
$a = 2147483648;
$c=$a--;
-ok ($a == 2147483647, $a);
+cmp_ok($a, '==', 2147483647, "postdecrement properly downgrades from double");
{
use integer;
my $x = 0;
$x++;
- ok ($x == 1, "(void) i_postinc");
+ cmp_ok($x, '==', 1, "(void) i_postinc");
$x--;
- ok ($x == 0, "(void) i_postdec");
+ cmp_ok($x, '==', 0, "(void) i_postdec");
}
+SKIP: {
+ if ($Config{uselongdouble} &&
+ ($Config{longdblkind} == 6 || $Config{longdblkind} == 5)) {
+ skip "the double-double format is weird", 1;
+ }
+
# I'm sure that there's an IBM format with a 48 bit mantissa
# IEEE doubles have a 53 bit mantissa
# 80 bit long doubles have a 64 bit mantissa
[$start_n, '--$i', 'pre-dec', 'dec'],
[$start_n, '$i--', 'post-dec', 'dec']) {
my ($start, $action, $description, $act) = @$_;
- foreach my $warn (0, 1) {
- my $warn_line = ($warn ? 'use' : 'no') . " warnings 'imprecision';";
-
- print "# checking $action under $warn_line\n";
- my $code = <<"EOC";
-$warn_line
-my \$i = \$start;
-for(0 .. 3) {
- my \$a = $action;
+ my $code = eval << "EOC" or die $@;
+sub {
+ no warnings 'imprecision';
+ my \$i = \$start;
+ for(0 .. 3) {
+ my \$a = $action;
+ }
}
-1;
EOC
- my @warnings;
- {
- local $SIG{__WARN__} = sub {push @warnings, "@_"};
- eval $code or die "# $@\n$code";
- }
-
- if ($warn) {
- unless (ok (scalar @warnings == 2, scalar @warnings)) {
- print STDERR "# $_" foreach @warnings;
- }
- foreach (@warnings) {
- unless (ok (/Lost precision when ${act}rementing -?\d+/, $_)) {
- print STDERR "# $_"
- }
- }
- } else {
- unless (ok (scalar @warnings == 0)) {
- print STDERR "# @$_" foreach @warnings;
- }
- }
- }
+
+ warning_is($code, undef, "$description under no warnings 'imprecision'");
+
+ $code = eval << "EOC" or die $@;
+sub {
+ use warnings 'imprecision';
+ my \$i = \$start;
+ for(0 .. 3) {
+ my \$a = $action;
+ }
+}
+EOC
+
+ warnings_like($code, [(qr/Lost precision when ${act}rementing -?\d+/) x 2],
+ "$description under use warnings 'imprecision'");
}
$found = 1;
last;
}
-die "Could not find a value which overflows the mantissa" unless $found;
+
+ok($found, "found a NV value which overflows the mantissa");
+
+} # SKIP
# these will segfault if they fail
sub PVBM () { 'foo' }
{ my $dummy = index 'foo', PVBM }
-ok (scalar eval { my $pvbm = PVBM; $pvbm++ });
-ok (scalar eval { my $pvbm = PVBM; $pvbm-- });
-ok (scalar eval { my $pvbm = PVBM; ++$pvbm });
-ok (scalar eval { my $pvbm = PVBM; --$pvbm });
+isnt(scalar eval { my $pvbm = PVBM; $pvbm++ }, undef, "postincrement defined");
+isnt(scalar eval { my $pvbm = PVBM; $pvbm-- }, undef, "postdecrement defined");
+isnt(scalar eval { my $pvbm = PVBM; ++$pvbm }, undef, "preincrement defined");
+isnt(scalar eval { my $pvbm = PVBM; --$pvbm }, undef, "predecrement defined");
# #9466
my $a = bless {};
my $b = $_ ? $a++ : $a--;
undef $a; undef $b;
- ::ok ($x, $x, "9466 case $_");
+ ::is($x, 1, "9466 case $_");
}
}
+
+# *Do* use pad TARG if it is actually a named variable, even when the thing
+# you’re copying is a ref. The fix for #9466 broke this.
+{
+ package P9466_2;
+ my $x;
+ sub DESTROY { $x = 1 }
+ for (2..3) {
+ $x = 0;
+ my $a = bless {};
+ my $b;
+ use integer;
+ if ($_ == 2) {
+ $b = $a--; # sassign optimised away
+ }
+ else {
+ $b = $a++;
+ }
+ ::is(ref $b, __PACKAGE__, 'i_post(in|de)c/TARGMY on ref');
+ undef $a; undef $b;
+ ::is($x, 1, "9466 case $_");
+ }
+}
+
+$_ = ${qr //};
+$_--;
+is($_, -1, 'regexp--');
+{
+ no warnings 'numeric';
+ $_ = ${qr //};
+ $_++;
+ is($_, 1, 'regexp++');
+}
+
+if ($::IS_EBCDIC) {
+ $_ = v129;
+ $_++;
+ isnt(ref\$_, 'VSTRING', '++ flattens vstrings');
+}
+else {
+ $_ = v97;
+ $_++;
+ isnt(ref\$_, 'VSTRING', '++ flattens vstrings');
+}
+
+sub TIESCALAR {bless\my $x}
+sub STORE { ++$store::called }
+tie my $t, "";
+{
+ $t = $_++;
+ $t = $_--;
+ use integer;
+ $t = $_++;
+ $t = $_--;
+}
+is $store::called, 4, 'STORE called on "my" target';
+
+{
+ # Temporarily broken between before 5.6.0 (b162f9ea/21f5b33c) and
+ # between 5.21.5 and 5.21.6 (9e319cc4fd)
+ my $x = 7;
+ $x = $x++;
+ is $x, 7, '$lex = $lex++';
+ $x = 7;
+ # broken in b162f9ea (5.6.0); fixed in 5.21.6
+ use integer;
+ $x = $x++;
+ is $x, 7, '$lex = $lex++ under use integer';
+}
+
+{
+ # RT #126637 - it should refuse to modify globs
+ no warnings 'once';
+ *GLOB126637 = [];
+
+ eval 'my $y = ++$_ for *GLOB126637';
+ like $@, qr/Modification of a read-only value/, '++*GLOB126637';
+ eval 'my $y = --$_ for *GLOB126637';
+ like $@, qr/Modification of a read-only value/, '--*GLOB126637';
+ eval 'my $y = $_++ for *GLOB126637';
+ like $@, qr/Modification of a read-only value/, '*GLOB126637++';
+ eval 'my $y = $_-- for *GLOB126637';
+ like $@, qr/Modification of a read-only value/, '*GLOB126637--';
+
+ use integer;
+
+ eval 'my $y = ++$_ for *GLOB126637';
+ like $@, qr/Modification of a read-only value/, 'use int; ++*GLOB126637';
+ eval 'my $y = --$_ for *GLOB126637';
+ like $@, qr/Modification of a read-only value/, 'use int; --*GLOB126637';
+ eval 'my $y = $_++ for *GLOB126637';
+ like $@, qr/Modification of a read-only value/, 'use int; *GLOB126637++';
+ eval 'my $y = $_-- for *GLOB126637';
+ like $@, qr/Modification of a read-only value/, 'use int; *GLOB126637--';
+}
+
+done_testing();
https://perl5.git.perl.org / perl5.git / blobdiff