This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
Add created_as_... builtins to perldelta
[perl5.git] / pod / perlhack.pod
CommitLineData
04c692a8 1=encoding utf8
35c336e6 2
04c692a8
DR
3=for comment
4Consistent formatting of this file is achieved with:
5 perl ./Porting/podtidy pod/perlhack.pod
35c336e6 6
04c692a8 7=head1 NAME
35c336e6 8
04c692a8 9perlhack - How to hack on Perl
35c336e6 10
04c692a8 11=head1 DESCRIPTION
35c336e6 12
531e2078 13This document explains how Perl development works. It includes details
617d9ec4 14about the Perl 5 Porters email list, the Perl repository, the Perl
04c692a8
DR
15bug tracker, patch guidelines, and commentary on Perl development
16philosophy.
f7e1e956 17
04c692a8 18=head1 SUPER QUICK PATCH GUIDE
f7e1e956 19
04c692a8
DR
20If you just want to submit a single small patch like a pod fix, a test
21for a bug, comment fixes, etc., it's easy! Here's how:
f7e1e956 22
04c692a8 23=over 4
e018f8be 24
04c692a8 25=item * Check out the source repository
e018f8be 26
531e2078 27The perl source is in a git repository. You can clone the repository
04c692a8 28with the following command:
e018f8be 29
47ef154c 30 % git clone https://github.com/Perl/perl5.git perl
e018f8be 31
69434957
S
32=item * Ensure you're following the latest advice
33
34In case the advice in this guide has been updated recently, read the
35latest version directly from the perl source:
36
37 % perldoc pod/perlhack.pod
38
617d9ec4
DB
39=item * Create a branch for your change
40
41Create a branch based on blead to commit your change to, which will
42later be used to send it to the Perl issue tracker.
43
44 % git checkout -b mychange
45
04c692a8 46=item * Make your change
e018f8be 47
eb9df707
KW
48Hack, hack, hack. Keep in mind that Perl runs on many different
49platforms, with different operating systems that have different
50capabilities, different filesystem organizations, and even different
51character sets. L<perlhacktips> gives advice on this.
7205a85d 52
04c692a8 53=item * Test your change
e018f8be 54
04c692a8 55You can run all the tests with the following commands:
b26492ee 56
04c692a8
DR
57 % ./Configure -des -Dusedevel
58 % make test
7205a85d 59
04c692a8 60Keep hacking until the tests pass.
b26492ee 61
04c692a8 62=item * Commit your change
e018f8be 63
b6538e4f 64Committing your work will save the change I<on your local system>:
7205a85d 65
04c692a8 66 % git commit -a -m 'Commit message goes here'
e018f8be 67
04c692a8 68Make sure the commit message describes your change in a single
531e2078 69sentence. For example, "Fixed spelling errors in perlhack.pod".
e018f8be 70
617d9ec4 71=item * Send your change to the Perl issue tracker
7a834142 72
617d9ec4 73The next step is to submit your patch to the Perl core ticket system.
7a834142 74
617d9ec4
DB
75Create a GitHub fork of the perl5 repository and add it as a remote,
76if you haven't already, as described in the GitHub documentation at
77L<https://help.github.com/en/articles/working-with-forks>.
e018f8be 78
617d9ec4 79 % git remote add fork git@github.com:MyUser/perl5.git
e018f8be 80
b998bd1a 81For more information, see L<"Connecting to GitHub with SSH"|https://docs.github.com/en/free-pro-team@latest/github/authenticating-to-github/connecting-to-github-with-ssh>.
82
83If you'd rather use an HTTPS URL for your C<git push> see L<"Cloning with
84HTTPS URLs"|https://docs.github.com/en/free-pro-team@latest/github/using-git/which-remote-url-should-i-use#cloning-with-https-urls>.
85
86 % git remote add fork https://github.com/MyUser/perl5.git
87
617d9ec4 88Then, push your new branch to your fork.
e018f8be 89
617d9ec4 90 % git push -u fork mychange
2d1c9392 91
617d9ec4
DB
92Finally, create a Pull Request on GitHub from your branch to blead as
93described in the GitHub documentation at
94L<https://help.github.com/en/articles/creating-a-pull-request-from-a-fork>.
2d1c9392 95
04c692a8 96=item * Thank you
e018f8be 97
04c692a8
DR
98The porters appreciate the time you spent helping to make Perl better.
99Thank you!
e018f8be 100
bb288857
S
101=item * Acknowledgement
102
103All contributors are credited (by name and email address) in the
6cb72a3d
S
104AUTHORS file, which is part of the perl distribution, as well as the
105Git commit history.
bb288857
S
106
107If you don’t want to be included in the AUTHORS file, just let us
108know. Otherwise we will take your submission of a patch as permission
109to credit you in the AUTHORS file.
110
e99cf3f0
S
111=item * Next time
112
113The next time you wish to make a patch, you need to start from the
30454452 114latest perl in a pristine state. Check you don't have any local changes
e99cf3f0
S
115or added files in your perl check-out which you wish to keep, then run
116these commands:
117
617d9ec4 118 % git checkout blead
e99cf3f0
S
119 % git pull
120 % git reset --hard origin/blead
121 % git clean -dxf
122
cce04beb 123=back
e018f8be 124
04c692a8 125=head1 BUG REPORTING
cc0710ff 126
8166b4e0
DB
127If you want to report a bug in Perl, or browse existing Perl bugs and
128patches, use the GitHub issue tracker at
129L<https://github.com/perl/perl5/issues>.
244d9cb7 130
04c692a8 131Please check the archive of the perl5-porters list (see below) and/or
531e2078 132the bug tracking system before submitting a bug report. Often, you'll
04c692a8 133find that the bug has been reported already.
244d9cb7 134
04c692a8 135You can log in to the bug tracking system and comment on existing bug
531e2078
FC
136reports. If you have additional information regarding an existing bug,
137please add it. This will help the porters fix the bug.
7205a85d 138
04c692a8 139=head1 PERL 5 PORTERS
7205a85d 140
04c692a8 141The perl5-porters (p5p) mailing list is where the Perl standard
531e2078 142distribution is maintained and developed. The people who maintain Perl
9e6670f3
DR
143are also referred to as the "Perl 5 Porters", "p5p" or just the
144"porters".
a75f557c 145
04c692a8 146A searchable archive of the list is available at
71c89d21
MM
147L<https://markmail.org/search/?q=perl5-porters>. There is also an archive at
148L<https://archive.develooper.com/perl5-porters@perl.org/>.
7205a85d 149
04c692a8 150=head2 perl-changes mailing list
7205a85d 151
04c692a8
DR
152The perl5-changes mailing list receives a copy of each patch that gets
153submitted to the maintenance and development branches of the perl
fdee78a1 154repository. See L<https://lists.perl.org/list/perl5-changes.html> for
04c692a8 155subscription and archive information.
244d9cb7 156
37bf3a91
DR
157=head2 #p5p on IRC
158
159Many porters are also active on the L<irc://irc.perl.org/#p5p> channel.
160Feel free to join the channel and ask questions about hacking on the
161Perl core.
162
04c692a8 163=head1 GETTING THE PERL SOURCE
244d9cb7 164
04c692a8 165All of Perl's source code is kept centrally in a Git repository at
47ef154c 166I<github.com>. The repository contains many Perl revisions
a44b8c28 167from Perl 1 onwards and all the revisions from Perforce, the previous
04c692a8 168version control system.
244d9cb7 169
04c692a8
DR
170For much more detail on using git with the Perl repository, please see
171L<perlgit>.
244d9cb7 172
04c692a8 173=head2 Read access via Git
244d9cb7 174
531e2078 175You will need a copy of Git for your computer. You can fetch a copy of
04c692a8 176the repository using the git protocol:
244d9cb7 177
a85e04e2 178 % git clone git@github.com:Perl/perl5.git perl
244d9cb7 179
04c692a8
DR
180This clones the repository and makes a local copy in the F<perl>
181directory.
7205a85d 182
04c692a8 183If you cannot use the git protocol for firewall reasons, you can also
47ef154c 184clone via http:
7205a85d 185
47ef154c 186 % git clone https://github.com/Perl/perl5.git perl
7205a85d 187
04c692a8 188=head2 Read access via the web
7205a85d 189
531e2078 190You may access the repository over the web. This allows you to browse
47ef154c 191the tree, see recent commits, subscribe to repository notifications,
531e2078 192search for particular commits and more. You may access it at
47ef154c 193L<https://github.com/Perl/perl5>.
7205a85d 194
04c692a8 195=head2 Write access via git
7205a85d 196
04c692a8
DR
197If you have a commit bit, please see L<perlgit> for more details on
198using git.
7205a85d 199
04c692a8 200=head1 PATCHING PERL
7205a85d 201
04c692a8 202If you're planning to do more extensive work than a single small fix,
531e2078 203we encourage you to read the documentation below. This will help you
04c692a8
DR
204focus your work and make your patches easier to incorporate into the
205Perl source.
244d9cb7 206
04c692a8 207=head2 Submitting patches
244d9cb7 208
617d9ec4
DB
209If you have a small patch to submit, please submit it via the GitHub
210Pull Request workflow. You may also send patches to the p5p list.
244d9cb7 211
617d9ec4 212Patches are reviewed and discussed on GitHub or the p5p list. Simple,
04c692a8
DR
213uncontroversial patches will usually be applied without any discussion.
214When the patch is applied, the ticket will be updated and you will
617d9ec4 215receive email.
244d9cb7 216
617d9ec4 217In other cases, the patch will need more work or discussion.
04c692a8 218You are encouraged to participate in the discussion and advocate for
531e2078 219your patch. Sometimes your patch may get lost in the shuffle. It's
04c692a8 220appropriate to send a reminder email to p5p if no action has been taken
531e2078 221in a month. Please remember that the Perl 5 developers are all
04c692a8 222volunteers, and be polite.
244d9cb7 223
04c692a8 224Changes are always applied directly to the main development branch,
a44b8c28 225called "blead". Some patches may be backported to a maintenance
30454452 226branch. If you think your patch is appropriate for the maintenance
839a0e5a 227branch (see L<perlpolicy/MAINTENANCE BRANCHES>), please explain why
d0bba22e 228when you submit it.
244d9cb7 229
04c692a8 230=head2 Getting your patch accepted
244d9cb7 231
84c2f6fd
DR
232If you are submitting a code patch there are several things that you
233can do to help the Perl 5 Porters accept your patch.
244d9cb7 234
a126fb62
DR
235=head3 Patch style
236
617d9ec4
DB
237Using the GitHub Pull Request workflow, your patch will automatically
238be available in a suitable format. If you wish to submit a patch to
239the p5p list for review, make sure to create it appropriately.
240
a126fb62 241If you used git to check out the Perl source, then using C<git
531e2078 242format-patch> will produce a patch in a style suitable for Perl. The
a126fb62 243C<format-patch> command produces one patch file for each commit you
a44b8c28
S
244made. If you prefer to send a single patch for all commits, you can
245use C<git diff>.
a126fb62 246
9d440a18 247 % git checkout blead
a126fb62
DR
248 % git pull
249 % git diff blead my-branch-name
250
251This produces a patch based on the difference between blead and your
531e2078 252current branch. It's important to make sure that blead is up to date
a126fb62
DR
253before producing the diff, that's why we call C<git pull> first.
254
531e2078 255We strongly recommend that you use git if possible. It will make your
a126fb62
DR
256life easier, and ours as well.
257
258However, if you're not using git, you can still produce a suitable
531e2078
FC
259patch. You'll need a pristine copy of the Perl source to diff against.
260The porters prefer unified diffs. Using GNU C<diff>, you can produce a
a126fb62
DR
261diff like this:
262
263 % diff -Npurd perl.pristine perl.mine
264
265Make sure that you C<make realclean> in your copy of Perl to remove any
266build artifacts, or you may get a confusing result.
267
04c692a8 268=head3 Commit message
244d9cb7 269
04c692a8 270As you craft each patch you intend to submit to the Perl core, it's
531e2078 271important to write a good commit message. This is especially important
04c692a8 272if your submission will consist of a series of commits.
244d9cb7 273
04c692a8 274The first line of the commit message should be a short description
531e2078 275without a period. It should be no longer than the subject line of an
a8d15a22 276email, 50 characters being a good rule of thumb.
f7e1e956 277
a8d15a22 278A lot of Git tools (Gitweb, GitHub, git log --pretty=oneline, ...) will
04c692a8
DR
279only display the first line (cut off at 50 characters) when presenting
280commit summaries.
7cd58830 281
04c692a8
DR
282The commit message should include a description of the problem that the
283patch corrects or new functionality that the patch adds.
7cd58830 284
04c692a8
DR
285As a general rule of thumb, your commit message should help a
286programmer who knows the Perl core quickly understand what you were
287trying to do, how you were trying to do it, and why the change matters
288to Perl.
7cd58830 289
04c692a8 290=over 4
7cd58830 291
04c692a8 292=item * Why
7cd58830 293
04c692a8 294Your commit message should describe why the change you are making is
531e2078 295important. When someone looks at your change in six months or six
04c692a8 296years, your intent should be clear.
7cd58830 297
04c692a8 298If you're deprecating a feature with the intent of later simplifying
531e2078 299another bit of code, say so. If you're fixing a performance problem or
04c692a8
DR
300adding a new feature to support some other bit of the core, mention
301that.
7cd58830 302
04c692a8 303=item * What
7cd58830 304
04c692a8
DR
305Your commit message should describe what part of the Perl core you're
306changing and what you expect your patch to do.
7cd58830 307
04c692a8 308=item * How
7cd58830 309
04c692a8
DR
310While it's not necessary for documentation changes, new tests or
311trivial patches, it's often worth explaining how your change works.
312Even if it's clear to you today, it may not be clear to a porter next
313month or next year.
d7889f52 314
04c692a8 315=back
d7889f52 316
04c692a8 317A commit message isn't intended to take the place of comments in your
531e2078 318code. Commit messages should describe the change you made, while code
04c692a8 319comments should describe the current state of the code.
d7889f52 320
04c692a8 321If you've just implemented a new feature, complete with doc, tests and
531e2078 322well-commented code, a brief commit message will often suffice. If,
04c692a8
DR
323however, you've just changed a single character deep in the parser or
324lexer, you might need to write a small novel to ensure that future
325readers understand what you did and why you did it.
d7889f52 326
04c692a8 327=head3 Comments, Comments, Comments
d7889f52 328
a44b8c28
S
329Be sure to adequately comment your code. While commenting every line
330is unnecessary, anything that takes advantage of side effects of
04c692a8
DR
331operators, that creates changes that will be felt outside of the
332function being patched, or that others may find confusing should be
a44b8c28
S
333documented. If you are going to err, it is better to err on the side
334of adding too many comments than too few.
d7889f52 335
04c692a8
DR
336The best comments explain I<why> the code does what it does, not I<what
337it does>.
d7889f52 338
04c692a8 339=head3 Style
d7889f52 340
04c692a8
DR
341In general, please follow the particular style of the code you are
342patching.
d7889f52 343
04c692a8
DR
344In particular, follow these general guidelines for patching Perl
345sources:
cce04beb 346
04c692a8 347=over 4
d7889f52
JH
348
349=item *
350
0529658c
AL
3514-wide indents for code, 2-wide indents for nested CPP C<#define>s,
352with 8-wide tabstops.
d7889f52
JH
353
354=item *
355
0529658c
AL
356Use spaces for indentation, not tab characters.
357
358The codebase is a mixture of tabs and spaces for indentation, and we
359are moving to spaces only. Converting lines you're patching from 8-wide
360tabs to spaces will help this migration.
ee9468a2 361
cce04beb 362=item *
ee9468a2 363
931014b9
RS
364Try not to exceed 79 columns
365
366In general, we target 80 column lines. When sticking to 80 columns would lead
367to torturous code or rework, it's fine to go longer. Try to keep your excess
368past 80 to a minimum.
bc028b6b 369
ee9468a2
RGS
370=item *
371
04c692a8 372ANSI C prototypes
d7889f52
JH
373
374=item *
375
04c692a8 376Uncuddled elses and "K&R" style for indenting control constructs
0bec6c03 377
04c692a8 378=item *
d7889f52 379
04c692a8 380No C++ style (//) comments
d7889f52
JH
381
382=item *
383
04c692a8 384Mark places that need to be revisited with XXX (and revisit often!)
27565cb6
JH
385
386=item *
387
04c692a8
DR
388Opening brace lines up with "if" when conditional spans multiple lines;
389should be at end-of-line otherwise
27565cb6 390
04c692a8 391=item *
27565cb6 392
15c526cb 393In function definitions, name starts in column 0 (return value-type is on
04c692a8 394previous line)
27565cb6 395
04c692a8 396=item *
27565cb6 397
04c692a8
DR
398Single space after keywords that are followed by parens, no space
399between function name and following paren
606fd33d 400
27565cb6
JH
401=item *
402
04c692a8
DR
403Avoid assignments in conditionals, but if they're unavoidable, use
404extra paren, e.g. "if (a && (b = c)) ..."
27565cb6
JH
405
406=item *
407
04c692a8 408"return foo;" rather than "return(foo);"
27565cb6
JH
409
410=item *
411
04c692a8 412"if (!foo) ..." rather than "if (foo == FALSE) ..." etc.
606fd33d 413
a8bd0d47
KW
414=item *
415
416Do not declare variables using "register". It may be counterproductive
417with modern compilers, and is deprecated in C++, under which the Perl
418source is regularly compiled.
419
5b48d9bb
KW
420=item *
421
422In-line functions that are in headers that are accessible to XS code
423need to be able to compile without warnings with commonly used extra
424compilation flags, such as gcc's C<-Wswitch-default> which warns
425whenever a switch statement does not have a "default" case. The use of
a44b8c28
S
426these extra flags is to catch potential problems in legal C code, and
427is often used by Perl aggregators, such as Linux distributors.
5b48d9bb 428
606fd33d 429=back
27565cb6 430
04c692a8 431=head3 Test suite
d7889f52 432
a8d15a22 433If your patch changes code (rather than just changing documentation),
04c692a8 434you should also include one or more test cases which illustrate the bug
531e2078 435you're fixing or validate the new functionality you're adding. In
04c692a8
DR
436general, you should update an existing test file rather than create a
437new one.
2bbc8d55 438
04c692a8
DR
439Your test suite additions should generally follow these guidelines
440(courtesy of Gurusamy Sarathy <gsar@activestate.com>):
2bbc8d55 441
04c692a8 442=over 4
0bec6c03 443
04c692a8 444=item *
0bec6c03 445
531e2078 446Know what you're testing. Read the docs, and the source.
ee9468a2
RGS
447
448=item *
449
04c692a8 450Tend to fail, not succeed.
0bec6c03 451
04c692a8 452=item *
0bec6c03 453
04c692a8 454Interpret results strictly.
27565cb6 455
04c692a8 456=item *
27565cb6 457
04c692a8 458Use unrelated features (this will flush out bizarre interactions).
27565cb6 459
04c692a8 460=item *
27565cb6 461
04c692a8 462Use non-standard idioms (otherwise you are not testing TIMTOWTDI).
27565cb6 463
04c692a8 464=item *
d7889f52 465
04c692a8
DR
466Avoid using hardcoded test numbers whenever possible (the EXPECTED/GOT
467found in t/op/tie.t is much more maintainable, and gives better failure
468reports).
d7889f52 469
04c692a8 470=item *
d7889f52 471
04c692a8 472Give meaningful error messages when a test fails.
d7889f52 473
04c692a8 474=item *
d7889f52 475
531e2078 476Avoid using qx// and system() unless you are testing for them. If you
04c692a8 477do use them, make sure that you cover _all_ perl platforms.
d7889f52 478
04c692a8 479=item *
0bec6c03 480
04c692a8 481Unlink any temporary files you create.
63796a85 482
04c692a8 483=item *
0bec6c03 484
04c692a8 485Promote unforeseen warnings to errors with $SIG{__WARN__}.
0bec6c03 486
04c692a8 487=item *
0bec6c03 488
04c692a8
DR
489Be sure to use the libraries and modules shipped with the version being
490tested, not those that were already installed.
d7889f52 491
04c692a8 492=item *
d7889f52 493
04c692a8 494Add comments to the code explaining what you are testing for.
d7889f52 495
04c692a8 496=item *
d7889f52 497
531e2078 498Make updating the '1..42' string unnecessary. Or make sure that you
04c692a8 499update it.
d7889f52 500
04c692a8 501=item *
d7889f52 502
04c692a8 503Test _all_ behaviors of a given operator, library, or function.
d7889f52 504
04c692a8 505Test all optional arguments.
d7889f52 506
04c692a8 507Test return values in various contexts (boolean, scalar, list, lvalue).
d7889f52 508
04c692a8 509Use both global and lexical variables.
d7889f52 510
04c692a8 511Don't forget the exceptional, pathological cases.
0bec6c03 512
cce04beb 513=back
0bec6c03 514
04c692a8 515=head2 Patching a core module
ee9468a2 516
04c692a8
DR
517This works just like patching anything else, with one extra
518consideration.
63796a85 519
a8d15a22 520Modules in the F<cpan/> directory of the source tree are maintained
531e2078 521outside of the Perl core. When the author updates the module, the
24b68a05 522updates are simply copied into the core. See that module's
5e17962d 523documentation or its listing on L<https://metacpan.org/> for more
24b68a05
DG
524information on reporting bugs and submitting patches.
525
526In most cases, patches to modules in F<cpan/> should be sent upstream
9e6670f3
DR
527and should not be applied to the Perl core individually. If a patch to
528a file in F<cpan/> absolutely cannot wait for the fix to be made
7e5887a1
DG
529upstream, released to CPAN and copied to blead, you must add (or
530update) a C<CUSTOMIZED> entry in the F<"Porting/Maintainers.pl"> file
531to flag that a local modification has been made. See
532F<"Porting/Maintainers.pl"> for more details.
63796a85 533
04c692a8
DR
534In contrast, modules in the F<dist/> directory are maintained in the
535core.
63796a85 536
04c692a8 537=head2 Updating perldelta
63796a85 538
04c692a8
DR
539For changes significant enough to warrant a F<pod/perldelta.pod> entry,
540the porters will greatly appreciate it if you submit a delta entry
a44b8c28
S
541along with your actual change. Significant changes include, but are
542not limited to:
63796a85 543
04c692a8 544=over 4
63796a85 545
04c692a8 546=item *
63796a85 547
04c692a8 548Adding, deprecating, or removing core features
ee9468a2 549
04c692a8 550=item *
ee9468a2 551
04c692a8 552Adding, deprecating, removing, or upgrading core or dual-life modules
ee9468a2 553
04c692a8 554=item *
ee9468a2 555
04c692a8 556Adding new core tests
ee9468a2 557
04c692a8 558=item *
ee9468a2 559
04c692a8 560Fixing security issues and user-visible bugs in the core
cce04beb 561
04c692a8 562=item *
ad7244db 563
04c692a8 564Changes that might break existing code, either on the perl or C level
ad7244db
JH
565
566=item *
567
04c692a8 568Significant performance improvements
ad7244db
JH
569
570=item *
571
04c692a8
DR
572Adding, removing, or significantly changing documentation in the
573F<pod/> directory
ad7244db 574
cce04beb 575=item *
ad7244db 576
04c692a8 577Important platform-specific changes
d7889f52 578
cce04beb
DG
579=back
580
04c692a8 581Please make sure you add the perldelta entry to the right section
531e2078 582within F<pod/perldelta.pod>. More information on how to write good
04c692a8
DR
583perldelta entries is available in the C<Style> section of
584F<Porting/how_to_write_a_perldelta.pod>.
d7889f52 585
04c692a8 586=head2 What makes for a good patch?
d7889f52 587
531e2078 588New features and extensions to the language can be contentious. There
04c692a8
DR
589is no specific set of criteria which determine what features get added,
590but here are some questions to consider when developing a patch:
d7889f52 591
04c692a8 592=head3 Does the concept match the general goals of Perl?
d7889f52 593
04c692a8 594Our goals include, but are not limited to:
d7889f52 595
04c692a8 596=over 4
d7889f52 597
04c692a8 598=item 1.
d7889f52 599
04c692a8 600Keep it fast, simple, and useful.
cce04beb 601
04c692a8 602=item 2.
cce04beb 603
04c692a8 604Keep features/concepts as orthogonal as possible.
902b9dbf 605
04c692a8 606=item 3.
902b9dbf 607
04c692a8 608No arbitrary limits (platforms, data sizes, cultures).
a958818a 609
04c692a8 610=item 4.
ac036724 611
04c692a8 612Keep it open and exciting to use/patch/advocate Perl everywhere.
a958818a 613
04c692a8 614=item 5.
a958818a 615
04c692a8 616Either assimilate new technologies, or build bridges to them.
a958818a 617
04c692a8 618=back
a958818a 619
04c692a8 620=head3 Where is the implementation?
a958818a 621
531e2078 622All the talk in the world is useless without an implementation. In
04c692a8 623almost every case, the person or people who argue for a new feature
531e2078 624will be expected to be the ones who implement it. Porters capable of
04c692a8
DR
625coding new features have their own agendas, and are not available to
626implement your (possibly good) idea.
a1b65709 627
04c692a8 628=head3 Backwards compatibility
37c0adeb 629
531e2078 630It's a cardinal sin to break existing Perl programs. New warnings can
04c692a8 631be contentious--some say that a program that emits warnings is not
531e2078 632broken, while others say it is. Adding keywords has the potential to
04c692a8
DR
633break programs, changing the meaning of existing token sequences or
634functions might break programs.
f50e5b73 635
04c692a8
DR
636The Perl 5 core includes mechanisms to help porters make backwards
637incompatible changes more compatible such as the L<feature> and
531e2078 638L<deprecate> modules. Please use them when appropriate.
902b9dbf 639
04c692a8 640=head3 Could it be a module instead?
902b9dbf 641
04c692a8 642Perl 5 has extension mechanisms, modules and XS, specifically to avoid
531e2078 643the need to keep changing the Perl interpreter. You can write modules
04c692a8
DR
644that export functions, you can give those functions prototypes so they
645can be called like built-in functions, you can even write XS code to
646mess with the runtime data structures of the Perl interpreter if you
647want to implement really complicated things.
902b9dbf 648
04c692a8
DR
649Whenever possible, new features should be prototyped in a CPAN module
650before they will be considered for the core.
902b9dbf 651
04c692a8 652=head3 Is the feature generic enough?
902b9dbf 653
04c692a8
DR
654Is this something that only the submitter wants added to the language,
655or is it broadly useful? Sometimes, instead of adding a feature with a
656tight focus, the porters might decide to wait until someone implements
657the more generalized feature.
902b9dbf 658
04c692a8 659=head3 Does it potentially introduce new bugs?
902b9dbf 660
04c692a8
DR
661Radical rewrites of large chunks of the Perl interpreter have the
662potential to introduce new bugs.
902b9dbf 663
04c692a8 664=head3 How big is it?
902b9dbf 665
531e2078 666The smaller and more localized the change, the better. Similarly, a
04c692a8 667series of small patches is greatly preferred over a single large patch.
902b9dbf 668
04c692a8 669=head3 Does it preclude other desirable features?
902b9dbf 670
04c692a8 671A patch is likely to be rejected if it closes off future avenues of
531e2078 672development. For instance, a patch that placed a true and final
04c692a8
DR
673interpretation on prototypes is likely to be rejected because there are
674still options for the future of prototypes that haven't been addressed.
902b9dbf 675
04c692a8 676=head3 Is the implementation robust?
902b9dbf 677
04c692a8 678Good patches (tight code, complete, correct) stand more chance of going
531e2078 679in. Sloppy or incorrect patches might be placed on the back burner
66c65f79 680until fixes can be made, or they might be discarded altogether
04c692a8 681without further notice.
902b9dbf 682
04c692a8 683=head3 Is the implementation generic enough to be portable?
902b9dbf 684
531e2078 685The worst patches make use of system-specific features. It's highly
04c692a8
DR
686unlikely that non-portable additions to the Perl language will be
687accepted.
902b9dbf 688
04c692a8 689=head3 Is the implementation tested?
902b9dbf 690
04c692a8
DR
691Patches which change behaviour (fixing bugs or introducing new
692features) must include regression tests to verify that everything works
693as expected.
902b9dbf 694
04c692a8
DR
695Without tests provided by the original author, how can anyone else
696changing perl in the future be sure that they haven't unwittingly
697broken the behaviour the patch implements? And without tests, how can
698the patch's author be confident that his/her hard work put into the
699patch won't be accidentally thrown away by someone in the future?
902b9dbf 700
04c692a8 701=head3 Is there enough documentation?
902b9dbf 702
04c692a8 703Patches without documentation are probably ill-thought out or
531e2078 704incomplete. No features can be added or changed without documentation,
04c692a8
DR
705so submitting a patch for the appropriate pod docs as well as the
706source code is important.
902b9dbf 707
04c692a8 708=head3 Is there another way to do it?
902b9dbf 709
04c692a8 710Larry said "Although the Perl Slogan is I<There's More Than One Way to
531e2078 711Do It>, I hesitate to make 10 ways to do something". This is a tricky
04c692a8
DR
712heuristic to navigate, though--one man's essential addition is another
713man's pointless cruft.
902b9dbf 714
04c692a8 715=head3 Does it create too much work?
902b9dbf 716
66c65f79 717Work for the committers, work for Perl programmers, work for module
04c692a8 718authors, ... Perl is supposed to be easy.
902b9dbf 719
04c692a8 720=head3 Patches speak louder than words
902b9dbf 721
531e2078 722Working code is always preferred to pie-in-the-sky ideas. A patch to
04c692a8
DR
723add a feature stands a much higher chance of making it to the language
724than does a random feature request, no matter how fervently argued the
a44b8c28
S
725request might be. This ties into "Will it be useful?", as the fact
726that someone took the time to make the patch demonstrates a strong
727desire for the feature.
c406981e 728
04c692a8 729=head1 TESTING
c406981e 730
04c692a8
DR
731The core uses the same testing style as the rest of Perl, a simple
732"ok/not ok" run through Test::Harness, but there are a few special
733considerations.
c406981e 734
531e2078 735There are three ways to write a test in the core: L<Test::More>,
a44b8c28
S
736F<t/test.pl> and ad hoc C<print $test ? "ok 42\n" : "not ok 42\n">.
737The decision of which to use depends on what part of the test suite
738you're working on. This is a measure to prevent a high-level failure
739(such as Config.pm breaking) from causing basic functionality tests to
740fail.
c406981e 741
04c692a8
DR
742The F<t/test.pl> library provides some of the features of
743L<Test::More>, but avoids loading most modules and uses as few core
744features as possible.
902b9dbf 745
9e6670f3 746If you write your own test, use the L<Test Anything
71c89d21 747Protocol|https://testanything.org>.
902b9dbf
MLF
748
749=over 4
750
bb52f720 751=item * F<t/base>, F<t/comp> and F<t/opbasic>
902b9dbf 752
15c526cb 753Since we don't know if C<require> works, or even subroutines, use ad hoc
531e2078 754tests for these three. Step carefully to avoid using the feature being
a44b8c28
S
755tested. Tests in F<t/opbasic>, for instance, have been placed there
756rather than in F<t/op> because they test functionality which
757F<t/test.pl> presumes has already been demonstrated to work.
902b9dbf 758
070720ff 759=item * All other subdirectories of F<t/>
902b9dbf 760
04c692a8
DR
761Now that basic require() and subroutines are tested, you can use the
762F<t/test.pl> library.
902b9dbf 763
070720ff 764You can also use certain libraries like L<Config> conditionally, but be
04c692a8 765sure to skip the test gracefully if it's not there.
902b9dbf 766
070720ff 767=item * Test files not found under F<t/>
902b9dbf 768
070720ff
JK
769This category includes F<.t> files underneath directories such as F<dist>,
770F<ext> and F<lib>. Since the core of Perl has now been tested, L<Test::More>
771can and now should be used. You can also use the full suite of core modules
772in the tests. (As noted in L<"Patching a core module"> above, changes to
773F<.t> files found under F<cpan/> should be submitted to the upstream
774maintainers of those modules.)
902b9dbf
MLF
775
776=back
777
a8d15a22 778When you say "make test", Perl uses the F<t/TEST> program to run the
a44b8c28
S
779test suite (except under Win32 where it uses F<t/harness> instead).
780All tests are run from the F<t/> directory, B<not> the directory which
781contains the test. This causes some problems with the tests in
782F<lib/>, so here's some opportunity for some patching.
902b9dbf 783
531e2078 784You must be triply conscious of cross-platform concerns. This usually
eb9df707
KW
785boils down to using L<File::Spec>, avoiding things like C<fork()>
786and C<system()> unless absolutely necessary, and not assuming that a
787given character has a particular ordinal value (code point) or that its
788UTF-8 representation is composed of particular bytes.
789
790There are several functions available to specify characters and code
791points portably in tests. The always-preloaded functions
792C<utf8::unicode_to_native()> and its inverse
793C<utf8::native_to_unicode()> take code points and translate
794appropriately. The file F<t/charset_tools.pl> has several functions
795that can be useful. It has versions of the previous two functions
796that take strings as inputs -- not single numeric code points:
797C<uni_to_native()> and C<native_to_uni()>. If you must look at the
798individual bytes comprising a UTF-8 encoded string,
799C<byte_utf8a_to_utf8n()> takes as input a string of those bytes encoded
800for an ASCII platform, and returns the equivalent string in the native
801platform. For example, C<byte_utf8a_to_utf8n("\xC2\xA0")> returns the
802byte sequence on the current platform that form the UTF-8 for C<U+00A0>,
803since C<"\xC2\xA0"> are the UTF-8 bytes on an ASCII platform for that
804code point. This function returns C<"\xC2\xA0"> on an ASCII platform, and
805C<"\x80\x41"> on an EBCDIC 1047 one.
806
15c526cb 807But easiest is, if the character is specifiable as a literal, like
a3815e44 808C<"A"> or C<"%">, to use that; if not so specificable, you can use
15c526cb
KW
809C<\N{}> , if the side effects aren't troublesome. Simply specify all
810your characters in hex, using C<\N{U+ZZ}> instead of C<\xZZ>. C<\N{}>
811is the Unicode name, and so it
eb9df707
KW
812always gives you the Unicode character. C<\N{U+41}> is the character
813whose Unicode code point is C<0x41>, hence is C<'A'> on all platforms.
814The side effects are:
815
816=over 4
817
3f9568ff 818=item *
eb9df707
KW
819
820These select Unicode rules. That means that in double-quotish strings,
821the string is always converted to UTF-8 to force a Unicode
822interpretation (you can C<utf8::downgrade()> afterwards to convert back
823to non-UTF8, if possible). In regular expression patterns, the
824conversion isn't done, but if the character set modifier would
825otherwise be C</d>, it is changed to C</u>.
826
3f9568ff 827=item *
eb9df707
KW
828
829If you use the form C<\N{I<character name>}>, the L<charnames> module
830gets automatically loaded. This may not be suitable for the test level
831you are doing.
832
833=back
7a834142 834
15c526cb
KW
835If you are testing locales (see L<perllocale>), there are helper
836functions in F<t/loc_tools.pl> to enable you to see what locales there
837are on the current platform.
838
04c692a8 839=head2 Special C<make test> targets
07aa3531 840
04c692a8 841There are various special make targets that can be used to test Perl
531e2078
FC
842slightly differently than the standard "test" target. Not all them are
843expected to give a 100% success rate. Many of them have several
04c692a8
DR
844aliases, and many of them are not available on certain operating
845systems.
07aa3531 846
04c692a8 847=over 4
d44161bf 848
04c692a8 849=item * test_porting
7a834142 850
04c692a8
DR
851This runs some basic sanity tests on the source tree and helps catch
852basic errors before you submit a patch.
7a834142 853
04c692a8 854=item * minitest
51a35ef1 855
04c692a8
DR
856Run F<miniperl> on F<t/base>, F<t/comp>, F<t/cmd>, F<t/run>, F<t/io>,
857F<t/op>, F<t/uni> and F<t/mro> tests.
51a35ef1 858
f9d2c26d
TC
859F<miniperl> is a minimalistic perl built to bootstrap building
860extensions, utilties, documentation etc. It doesn't support dynamic
861loading and depending on the point in the build process will only have
862access to a limited set of core modules. F<miniperl> is not intended
863for day to day use.
864
499cea6b 865=item * test.valgrind check.valgrind
51a35ef1 866
04c692a8 867(Only in Linux) Run all the tests using the memory leak + naughty
531e2078 868memory access tool "valgrind". The log files will be named
04c692a8 869F<testname.valgrind>.
83f0ef60 870
04c692a8 871=item * test_harness
83f0ef60 872
04c692a8 873Run the test suite with the F<t/harness> controlling program, instead
531e2078 874of F<t/TEST>. F<t/harness> is more sophisticated, and uses the
04c692a8 875L<Test::Harness> module, thus using this test target supposes that perl
531e2078 876mostly works. The main advantage for our purposes is that it prints a
a44b8c28
S
877detailed summary of failed tests at the end. Also, unlike F<t/TEST>,
878it doesn't redirect stderr to stdout.
83f0ef60 879
04c692a8
DR
880Note that under Win32 F<t/harness> is always used instead of F<t/TEST>,
881so there is no special "test_harness" target.
83f0ef60 882
04c692a8
DR
883Under Win32's "test" target you may use the TEST_SWITCHES and
884TEST_FILES environment variables to control the behaviour of
531e2078 885F<t/harness>. This means you can say
83f0ef60 886
04c692a8
DR
887 nmake test TEST_FILES="op/*.t"
888 nmake test TEST_SWITCHES="-torture" TEST_FILES="op/*.t"
83f0ef60 889
78087e0a
R
890=item * test-notty test_notty
891
892Sets PERL_SKIP_TTY_TEST to true before running normal test.
893
83f0ef60
JH
894=back
895
04c692a8 896=head2 Parallel tests
83f0ef60 897
04c692a8 898The core distribution can now run its regression tests in parallel on
730797bb
KW
899Unix-like and Windows platforms. On Unix, instead of running C<make
900test>, set C<TEST_JOBS> in your environment to the number of tests to
901run in parallel, and run C<make test_harness>. On a Bourne-like shell,
902this can be done as
07aa3531 903
04c692a8 904 TEST_JOBS=3 make test_harness # Run 3 tests in parallel
07aa3531 905
04c692a8
DR
906An environment variable is used, rather than parallel make itself,
907because L<TAP::Harness> needs to be able to schedule individual
908non-conflicting test scripts itself, and there is no standard interface
909to C<make> utilities to interact with their job schedulers.
51a35ef1 910
730797bb
KW
911Tests are normally run in a logical order, with the sanity tests first,
912then the main tests of the Perl core functionality, then the tests for
913the non-core modules. On many-core systems, this may not use the
914hardware as effectively as possible. By also specifying
915
916 TEST_JOBS=19 PERL_TEST_HARNESS_ASAP=1 make -j19 test_harness
917
918you signal that you want the tests to finish in wall-clock time as short
919as possible. After the sanity tests are completed, this causes the
920remaining ones to be packed into the available cores as tightly as
921we know how. This has its greatest effect on slower, many-core systems.
922Throughput was sped up by 20% on an outmoded 24-core system; less on
923more recent faster ones with fewer cores.
924
925Note that the command line above added a C<-j> parameter to make, so as
926to cause parallel compilation. This may or may not work on your
927platform.
51a35ef1 928
04c692a8 929=head2 Running tests by hand
51a35ef1 930
9e6670f3
DR
931You can run part of the test suite by hand by using one of the
932following commands from the F<t/> directory:
51a35ef1 933
04c692a8 934 ./perl -I../lib TEST list-of-.t-files
51a35ef1 935
04c692a8 936or
51a35ef1 937
04c692a8 938 ./perl -I../lib harness list-of-.t-files
51a35ef1 939
a8d15a22 940(If you don't specify test scripts, the whole test suite will be run.)
51a35ef1 941
04c692a8 942=head2 Using F<t/harness> for testing
51a35ef1 943
9e6670f3 944If you use C<harness> for testing, you have several command line
531e2078 945options available to you. The arguments are as follows, and are in the
9e6670f3 946order that they must appear if used together.
51a35ef1 947
04c692a8
DR
948 harness -v -torture -re=pattern LIST OF FILES TO TEST
949 harness -v -torture -re LIST OF PATTERNS TO MATCH
07aa3531 950
a8d15a22 951If C<LIST OF FILES TO TEST> is omitted, the file list is obtained from
531e2078 952the manifest. The file list may include shell wildcards which will be
04c692a8 953expanded out.
07aa3531 954
04c692a8 955=over 4
4ae3d70a 956
04c692a8 957=item * -v
4ae3d70a 958
04c692a8
DR
959Run the tests under verbose mode so you can see what tests were run,
960and debug output.
51a35ef1 961
04c692a8 962=item * -torture
4ae3d70a 963
04c692a8 964Run the torture tests as well as the normal set.
4ae3d70a 965
04c692a8 966=item * -re=PATTERN
6c41479b 967
a44b8c28
S
968Filter the file list so that all the test files run match PATTERN.
969Note that this form is distinct from the B<-re LIST OF PATTERNS> form
970below in that it allows the file list to be provided as well.
6c41479b 971
04c692a8 972=item * -re LIST OF PATTERNS
6c41479b 973
04c692a8 974Filter the file list so that all the test files run match
531e2078 975/(LIST|OF|PATTERNS)/. Note that with this form the patterns are joined
04c692a8
DR
976by '|' and you cannot supply a list of files, instead the test files
977are obtained from the MANIFEST.
6c41479b 978
04c692a8 979=back
6c41479b 980
04c692a8 981You can run an individual test by a command similar to
6c41479b 982
a8d15a22 983 ./perl -I../lib path/to/foo.t
6c41479b 984
04c692a8
DR
985except that the harnesses set up some environment variables that may
986affect the execution of the test:
6c41479b
JH
987
988=over 4
989
04c692a8 990=item * PERL_CORE=1
6c41479b 991
a8d15a22 992indicates that we're running this test as part of the perl core test
531e2078 993suite. This is useful for modules that have a dual life on CPAN.
6c41479b 994
04c692a8 995=item * PERL_DESTRUCT_LEVEL=2
6c41479b 996
04c692a8 997is set to 2 if it isn't set already (see
a8d15a22 998L<perlhacktips/PERL_DESTRUCT_LEVEL>).
6c41479b 999
04c692a8 1000=item * PERL
6c41479b 1001
04c692a8
DR
1002(used only by F<t/TEST>) if set, overrides the path to the perl
1003executable that should be used to run the tests (the default being
1004F<./perl>).
6c41479b 1005
04c692a8 1006=item * PERL_SKIP_TTY_TEST
6c41479b 1007
a44b8c28
S
1008if set, tells to skip the tests that need a terminal. It's actually
1009set automatically by the Makefile, but can also be forced artificially
1010by running 'make test_notty'.
6c41479b 1011
04c692a8 1012=back
6c41479b 1013
04c692a8 1014=head3 Other environment variables that may influence tests
6c41479b 1015
04c692a8 1016=over 4
6c41479b 1017
04c692a8 1018=item * PERL_TEST_Net_Ping
6c41479b 1019
04c692a8 1020Setting this variable runs all the Net::Ping modules tests, otherwise
531e2078 1021some tests that interact with the outside world are skipped. See
04c692a8 1022L<perl58delta>.
6c41479b 1023
04c692a8 1024=item * PERL_TEST_NOVREXX
cce04beb 1025
04c692a8 1026Setting this variable skips the vrexx.t tests for OS2::REXX.
cce04beb 1027
04c692a8 1028=item * PERL_TEST_NUMCONVERTS
cce04beb 1029
04c692a8 1030This sets a variable in op/numconvert.t.
cce04beb 1031
ff5db609
TC
1032=item * PERL_TEST_MEMORY
1033
1034Setting this variable includes the tests in F<t/bigmem/>. This should
a44b8c28
S
1035be set to the number of gigabytes of memory available for testing, eg.
1036C<PERL_TEST_MEMORY=4> indicates that tests that require 4GiB of
ff5db609
TC
1037available memory can be run safely.
1038
04c692a8 1039=back
cce04beb 1040
04c692a8
DR
1041See also the documentation for the Test and Test::Harness modules, for
1042more environment variables that affect testing.
cce04beb 1043
9e7973fa
DM
1044=head2 Performance testing
1045
1046The file F<t/perf/benchmarks> contains snippets of perl code which are
1047intended to be benchmarked across a range of perls by the
1048F<Porting/bench.pl> tool. If you fix or enhance a performance issue, you
1049may want to add a representative code sample to the file, then run
1050F<bench.pl> against the previous and current perls to see what difference
1051it has made, and whether anything else has slowed down as a consequence.
1052
1053The file F<t/perf/opcount.t> is designed to test whether a particular
1054code snippet has been compiled into an optree containing specified
1055numbers of particular op types. This is good for testing whether
1056optimisations which alter ops, such as converting an C<aelem> op into an
1057C<aelemfast> op, are really doing that.
1058
1059The files F<t/perf/speed.t> and F<t/re/speed.t> are designed to test
1060things that run thousands of times slower if a particular optimisation
1061is broken (for example, the utf8 length cache on long utf8 strings).
1062Add a test that will take a fraction of a second normally, and minutes
1063otherwise, causing the test file to time out on failure.
1064
ca31f56c
JK
1065=head2 Building perl at older commits
1066
1067In the course of hacking on the Perl core distribution, you may have occasion
1068to configure, build and test perl at an old commit. Sometimes C<make> will
1069fail during this process. If that happens, you may be able to salvage the
1070situation by using the Devel::PatchPerl library from CPAN (not included in the
1071core) to bring the source code at that commit to a buildable state.
1072
1073Here's a real world example, taken from work done to resolve
8034715d 1074L<perl #10118|https://github.com/Perl/perl5/issues/10118>.
ca31f56c
JK
1075Use of F<Porting/bisect.pl> had identified commit
1076C<ba77e4cc9d1ceebf472c9c5c18b2377ee47062e6> as the commit in which a bug was
1077corrected. To confirm, a P5P developer wanted to configure and build perl at
1078commit C<ba77e4c^> (presumably "bad") and then at C<ba77e4c> (presumably
1079"good"). Normal configuration and build was attempted:
1080
1081 $ sh ./Configure -des -Dusedevel
1082 $ make test_prep
1083
1084C<make>, however, failed with output (excerpted) like this:
1085
1086 cc -fstack-protector -L/usr/local/lib -o miniperl \
1087 gv.o toke.o perly.o pad.o regcomp.o dump.o util.o \
1088 mg.o reentr.o mro.o hv.o av.o run.o pp_hot.o sv.o \
1089 pp.o scope.o pp_ctl.o pp_sys.o doop.o doio.o regexec.o \
1090 utf8.o taint.o deb.o universal.o globals.o perlio.o \
8c3a0f6c 1091 numeric.o mathoms.o locale.o pp_pack.o pp_sort.o \
ca31f56c
JK
1092 miniperlmain.o opmini.o perlmini.o
1093 pp.o: In function `Perl_pp_pow':
1094 pp.c:(.text+0x2db9): undefined reference to `pow'
1095 ...
1096 collect2: error: ld returned 1 exit status
1097 makefile:348: recipe for target 'miniperl' failed
1098 make: *** [miniperl] Error 1
1099
1100Another P5P contributor recommended installation and use of Devel::PatchPerl
1101for this situation, first to determine the version of perl at the commit in
1102question, then to patch the source code at that point to facilitate a build.
1103
1104 $ perl -MDevel::PatchPerl -e \
1105 'print Devel::PatchPerl->determine_version("/path/to/sourcecode"), "\n";'
1106 5.11.1
1107 $ perl -MDevel::PatchPerl -e \
1108 'Devel::PatchPerl->patch_source("5.11.1", "/path/to/sourcecode");'
1109
1110Once the source was patched, C<./Configure> and C<make test_prep> were called
1111and completed successfully, enabling confirmation of the findings in RT
1112#72414.
1113
04c692a8 1114=head1 MORE READING FOR GUTS HACKERS
cce04beb 1115
04c692a8 1116To hack on the Perl guts, you'll need to read the following things:
cce04beb 1117
04c692a8 1118=over 4
cce04beb 1119
04c692a8 1120=item * L<perlsource>
b8ddf6b3 1121
531e2078 1122An overview of the Perl source tree. This will help you find the files
04c692a8 1123you're looking for.
b8ddf6b3 1124
04c692a8 1125=item * L<perlinterp>
b8ddf6b3 1126
04c692a8
DR
1127An overview of the Perl interpreter source code and some details on how
1128Perl does what it does.
b8ddf6b3 1129
04c692a8 1130=item * L<perlhacktut>
b8ddf6b3 1131
04c692a8 1132This document walks through the creation of a small patch to Perl's C
531e2078 1133code. If you're just getting started with Perl core hacking, this will
04c692a8 1134help you understand how it works.
b8ddf6b3 1135
04c692a8 1136=item * L<perlhacktips>
b8ddf6b3 1137
531e2078 1138More details on hacking the Perl core. This document focuses on lower
04c692a8
DR
1139level details such as how to write tests, compilation issues,
1140portability, debugging, etc.
b8ddf6b3 1141
04c692a8 1142If you plan on doing serious C hacking, make sure to read this.
b8ddf6b3 1143
04c692a8 1144=item * L<perlguts>
b8ddf6b3 1145
04c692a8 1146This is of paramount importance, since it's the documentation of what
531e2078 1147goes where in the Perl source. Read it over a couple of times and it
04c692a8
DR
1148might start to make sense - don't worry if it doesn't yet, because the
1149best way to study it is to read it in conjunction with poking at Perl
1150source, and we'll do that later on.
b8ddf6b3 1151
04c692a8
DR
1152Gisle Aas's "illustrated perlguts", also known as I<illguts>, has very
1153helpful pictures:
9965345d 1154
082a0fe7 1155L<https://metacpan.org/release/RURBAN/illguts-0.49>
9965345d 1156
04c692a8 1157=item * L<perlxstut> and L<perlxs>
f1fac472 1158
04c692a8
DR
1159A working knowledge of XSUB programming is incredibly useful for core
1160hacking; XSUBs use techniques drawn from the PP code, the portion of
531e2078 1161the guts that actually executes a Perl program. It's a lot gentler to
04c692a8
DR
1162learn those techniques from simple examples and explanation than from
1163the core itself.
f1fac472 1164
04c692a8 1165=item * L<perlapi>
f1fac472 1166
04c692a8
DR
1167The documentation for the Perl API explains what some of the internal
1168functions do, as well as the many macros used in the source.
f1fac472 1169
04c692a8 1170=item * F<Porting/pumpkin.pod>
f1fac472 1171
04c692a8 1172This is a collection of words of wisdom for a Perl porter; some of it
66c65f79 1173is only useful to the pumpkin holders, but most of it applies to anyone
04c692a8 1174wanting to go about Perl development.
f1fac472 1175
04c692a8 1176=back
f1fac472 1177
04c692a8 1178=head1 CPAN TESTERS AND PERL SMOKERS
f1fac472 1179
71c89d21 1180The CPAN testers ( L<http://cpantesters.org/> ) are a group of volunteers
04c692a8 1181who test CPAN modules on a variety of platforms.
b8ddf6b3 1182
71c89d21
MM
1183Perl Smokers ( L<https://www.nntp.perl.org/group/perl.daily-build/> and
1184L<https://www.nntp.perl.org/group/perl.daily-build.reports/> )
04c692a8
DR
1185automatically test Perl source releases on platforms with various
1186configurations.
f1fac472 1187
531e2078 1188Both efforts welcome volunteers. In order to get involved in smoke
04c692a8 1189testing of the perl itself visit
c23f766f 1190L<https://metacpan.org/release/Test-Smoke>. In order to start smoke
04c692a8 1191testing CPAN modules visit
c23f766f
DB
1192L<https://metacpan.org/release/CPANPLUS-YACSmoke> or
1193L<https://metacpan.org/release/minismokebox> or
1194L<https://metacpan.org/release/CPAN-Reporter>.
f1fac472 1195
04c692a8 1196=head1 WHAT NEXT?
a422fd2d 1197
04c692a8
DR
1198If you've read all the documentation in the document and the ones
1199listed above, you're more than ready to hack on Perl.
a422fd2d 1200
04c692a8 1201Here's some more recommendations
a422fd2d 1202
04c692a8 1203=over 4
a422fd2d
SC
1204
1205=item *
1206
1207Subscribe to perl5-porters, follow the patches and try and understand
1208them; don't be afraid to ask if there's a portion you're not clear on -
1209who knows, you may unearth a bug in the patch...
1210
1211=item *
1212
04c692a8 1213Do read the README associated with your operating system, e.g.
531e2078 1214README.aix on the IBM AIX OS. Don't hesitate to supply patches to that
04c692a8 1215README if you find anything missing or changed over a new OS release.
a1f349fd
MB
1216
1217=item *
1218
a422fd2d 1219Find an area of Perl that seems interesting to you, and see if you can
a44b8c28
S
1220work out how it works. Scan through the source, and step over it in
1221the debugger. Play, poke, investigate, fiddle! You'll probably get to
04c692a8
DR
1222understand not just your chosen area but a much wider range of
1223F<perl>'s activity as well, and probably sooner than you'd think.
a422fd2d
SC
1224
1225=back
1226
04c692a8 1227=head2 "The Road goes ever on and on, down from the door where it began."
a422fd2d 1228
04c692a8 1229If you can do these things, you've started on the long road to Perl
531e2078 1230porting. Thanks for wanting to help make Perl better - and happy
04c692a8 1231hacking!
a422fd2d 1232
4ac71550
TC
1233=head2 Metaphoric Quotations
1234
1235If you recognized the quote about the Road above, you're in luck.
1236
04c692a8 1237Most software projects begin each file with a literal description of
531e2078 1238each file's purpose. Perl instead begins each with a literary allusion
04c692a8 1239to that file's purpose.
4ac71550 1240
04c692a8 1241Like chapters in many books, all top-level Perl source files (along
9e6670f3
DR
1242with a few others here and there) begin with an epigrammatic
1243inscription that alludes, indirectly and metaphorically, to the
1244material you're about to read.
4ac71550 1245
a8d15a22 1246Quotations are taken from writings of J.R.R. Tolkien pertaining to his
531e2078 1247Legendarium, almost always from I<The Lord of the Rings>. Chapters and
4ac71550
TC
1248page numbers are given using the following editions:
1249
1250=over 4
1251
04c692a8 1252=item *
4ac71550 1253
531e2078 1254I<The Hobbit>, by J.R.R. Tolkien. The hardcover, 70th-anniversary
04c692a8
DR
1255edition of 2007 was used, published in the UK by Harper Collins
1256Publishers and in the US by the Houghton Mifflin Company.
4ac71550
TC
1257
1258=item *
1259
531e2078 1260I<The Lord of the Rings>, by J.R.R. Tolkien. The hardcover,
04c692a8
DR
126150th-anniversary edition of 2004 was used, published in the UK by
1262Harper Collins Publishers and in the US by the Houghton Mifflin
1263Company.
4ac71550
TC
1264
1265=item *
1266
04c692a8
DR
1267I<The Lays of Beleriand>, by J.R.R. Tolkien and published posthumously
1268by his son and literary executor, C.J.R. Tolkien, being the 3rd of the
531e2078 126912 volumes in Christopher's mammoth I<History of Middle Earth>. Page
04c692a8
DR
1270numbers derive from the hardcover edition, first published in 1983 by
1271George Allen & Unwin; no page numbers changed for the special 3-volume
1272omnibus edition of 2002 or the various trade-paper editions, all again
1273now by Harper Collins or Houghton Mifflin.
4ac71550
TC
1274
1275=back
1276
04c692a8
DR
1277Other JRRT books fair game for quotes would thus include I<The
1278Adventures of Tom Bombadil>, I<The Silmarillion>, I<Unfinished Tales>,
1279and I<The Tale of the Children of Hurin>, all but the first
531e2078 1280posthumously assembled by CJRT. But I<The Lord of the Rings> itself is
04c692a8
DR
1281perfectly fine and probably best to quote from, provided you can find a
1282suitable quote there.
4ac71550 1283
04c692a8
DR
1284So if you were to supply a new, complete, top-level source file to add
1285to Perl, you should conform to this peculiar practice by yourself
1286selecting an appropriate quotation from Tolkien, retaining the original
1287spelling and punctuation and using the same format the rest of the
531e2078 1288quotes are in. Indirect and oblique is just fine; remember, it's a
04c692a8 1289metaphor, so being meta is, after all, what it's for.
4ac71550 1290
e8cd7eae
GS
1291=head1 AUTHOR
1292
04c692a8
DR
1293This document was originally written by Nathan Torkington, and is
1294maintained by the perl5-porters mailing list.