This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
Update IO-Compress to CPAN version 2.040
[perl5.git] / pod / perlhack.pod
CommitLineData
04c692a8 1=encoding utf8
35c336e6 2
04c692a8
DR
3=for comment
4Consistent formatting of this file is achieved with:
5 perl ./Porting/podtidy pod/perlhack.pod
35c336e6 6
04c692a8 7=head1 NAME
35c336e6 8
04c692a8 9perlhack - How to hack on Perl
35c336e6 10
04c692a8 11=head1 DESCRIPTION
35c336e6 12
04c692a8
DR
13This document explains how Perl development works. It includes details
14about the Perl 5 Porters email list, the Perl repository, the Perlbug
15bug tracker, patch guidelines, and commentary on Perl development
16philosophy.
f7e1e956 17
04c692a8 18=head1 SUPER QUICK PATCH GUIDE
f7e1e956 19
04c692a8
DR
20If you just want to submit a single small patch like a pod fix, a test
21for a bug, comment fixes, etc., it's easy! Here's how:
f7e1e956 22
04c692a8 23=over 4
e018f8be 24
04c692a8 25=item * Check out the source repository
e018f8be 26
04c692a8
DR
27The perl source is in a git repository. You can clone the repository
28with the following command:
e018f8be 29
04c692a8 30 % git clone git://perl5.git.perl.org/perl.git perl
e018f8be 31
04c692a8 32=item * Make your change
e018f8be 33
04c692a8 34Hack, hack, hack.
7205a85d 35
04c692a8 36=item * Test your change
e018f8be 37
04c692a8 38You can run all the tests with the following commands:
b26492ee 39
04c692a8
DR
40 % ./Configure -des -Dusedevel
41 % make test
7205a85d 42
04c692a8 43Keep hacking until the tests pass.
b26492ee 44
04c692a8 45=item * Commit your change
e018f8be 46
b6538e4f 47Committing your work will save the change I<on your local system>:
7205a85d 48
04c692a8 49 % git commit -a -m 'Commit message goes here'
e018f8be 50
04c692a8
DR
51Make sure the commit message describes your change in a single
52sentence. For example, "Fixed spelling errors in perlhack.pod".
e018f8be 53
04c692a8 54=item * Send your change to perlbug
7a834142 55
04c692a8
DR
56The next step is to submit your patch to the Perl core ticket system
57via email.
7a834142 58
5c70016e
JC
59Assuming your patch consists of a single git commit, the following
60writes the file as a MIME attachment, and sends it with a meaningful
61subject:
e018f8be 62
5c70016e 63 % git format-patch -1 --attach
d23ed4f3 64 % perlbug -s "[PATCH] $(git log -1 --oneline HEAD)" -f 0001-*.patch
e018f8be 65
04c692a8 66The perlbug program will ask you a few questions about your email
84b19098
DR
67address and the patch you're submitting. Once you've answered them it
68will submit your patch via email.
e018f8be 69
04c692a8 70=item * Thank you
e018f8be 71
04c692a8
DR
72The porters appreciate the time you spent helping to make Perl better.
73Thank you!
e018f8be 74
cce04beb 75=back
e018f8be 76
04c692a8 77=head1 BUG REPORTING
cc0710ff 78
9e6670f3
DR
79If you want to report a bug in Perl, you must use the F<perlbug>
80command line tool. This tool will ensure that your bug report includes
81all the relevant system and configuration information.
7205a85d 82
04c692a8 83To browse existing Perl bugs and patches, you can use the web interface
a8d15a22 84at L<http://rt.perl.org/>.
244d9cb7 85
04c692a8
DR
86Please check the archive of the perl5-porters list (see below) and/or
87the bug tracking system before submitting a bug report. Often, you'll
88find that the bug has been reported already.
244d9cb7 89
04c692a8
DR
90You can log in to the bug tracking system and comment on existing bug
91reports. If you have additional information regarding an existing bug,
92please add it. This will help the porters fix the bug.
7205a85d 93
04c692a8 94=head1 PERL 5 PORTERS
7205a85d 95
04c692a8
DR
96The perl5-porters (p5p) mailing list is where the Perl standard
97distribution is maintained and developed. The people who maintain Perl
9e6670f3
DR
98are also referred to as the "Perl 5 Porters", "p5p" or just the
99"porters".
a75f557c 100
04c692a8
DR
101A searchable archive of the list is available at
102L<http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/>. There is
103also another archive at
104L<http://archive.develooper.com/perl5-porters@perl.org/>.
7205a85d 105
04c692a8 106=head2 perl-changes mailing list
7205a85d 107
04c692a8
DR
108The perl5-changes mailing list receives a copy of each patch that gets
109submitted to the maintenance and development branches of the perl
110repository. See L<http://lists.perl.org/list/perl5-changes.html> for
111subscription and archive information.
244d9cb7 112
37bf3a91
DR
113=head2 #p5p on IRC
114
115Many porters are also active on the L<irc://irc.perl.org/#p5p> channel.
116Feel free to join the channel and ask questions about hacking on the
117Perl core.
118
04c692a8 119=head1 GETTING THE PERL SOURCE
244d9cb7 120
04c692a8
DR
121All of Perl's source code is kept centrally in a Git repository at
122I<perl5.git.perl.org>. The repository contains many Perl revisions from
123Perl 1 onwards and all the revisions from Perforce, the previous
124version control system.
244d9cb7 125
04c692a8
DR
126For much more detail on using git with the Perl repository, please see
127L<perlgit>.
244d9cb7 128
04c692a8 129=head2 Read access via Git
244d9cb7 130
04c692a8
DR
131You will need a copy of Git for your computer. You can fetch a copy of
132the repository using the git protocol:
244d9cb7 133
04c692a8 134 % git clone git://perl5.git.perl.org/perl.git perl
244d9cb7 135
04c692a8
DR
136This clones the repository and makes a local copy in the F<perl>
137directory.
7205a85d 138
04c692a8
DR
139If you cannot use the git protocol for firewall reasons, you can also
140clone via http, though this is much slower:
7205a85d 141
04c692a8 142 % git clone http://perl5.git.perl.org/perl.git perl
7205a85d 143
04c692a8 144=head2 Read access via the web
7205a85d 145
04c692a8
DR
146You may access the repository over the web. This allows you to browse
147the tree, see recent commits, subscribe to RSS feeds for the changes,
148search for particular commits and more. You may access it at
149L<http://perl5.git.perl.org/perl.git>. A mirror of the repository is
a8d15a22 150found at L<http://github.com/mirrors/perl>.
7205a85d 151
04c692a8 152=head2 Read access via rsync
7205a85d 153
04c692a8
DR
154You can also choose to use rsync to get a copy of the current source
155tree for the bleadperl branch and all maintenance branches:
7205a85d 156
efdea7e2
R
157 % rsync -avz rsync://perl5.git.perl.org/perl-current .
158 % rsync -avz rsync://perl5.git.perl.org/perl-5.12.x .
159 % rsync -avz rsync://perl5.git.perl.org/perl-5.10.x .
160 % rsync -avz rsync://perl5.git.perl.org/perl-5.8.x .
161 % rsync -avz rsync://perl5.git.perl.org/perl-5.6.x .
162 % rsync -avz rsync://perl5.git.perl.org/perl-5.005xx .
7205a85d 163
a8d15a22 164(Add the C<--delete> option to remove leftover files.)
7205a85d 165
04c692a8 166To get a full list of the available sync points:
7205a85d 167
efdea7e2 168 % rsync perl5.git.perl.org::
7205a85d 169
04c692a8 170=head2 Write access via git
7205a85d 171
04c692a8
DR
172If you have a commit bit, please see L<perlgit> for more details on
173using git.
7205a85d 174
04c692a8 175=head1 PATCHING PERL
7205a85d 176
04c692a8
DR
177If you're planning to do more extensive work than a single small fix,
178we encourage you to read the documentation below. This will help you
179focus your work and make your patches easier to incorporate into the
180Perl source.
244d9cb7 181
04c692a8 182=head2 Submitting patches
244d9cb7 183
04c692a8
DR
184If you have a small patch to submit, please submit it via perlbug. You
185can also send email directly to perlbug@perl.org. Please note that
186messages sent to perlbug may be held in a moderation queue, so you
187won't receive a response immediately.
244d9cb7 188
04c692a8
DR
189You'll know your submission has been processed when you receive an
190email from our ticket tracking system. This email will give you a
191ticket number. Once your patch has made it to the ticket tracking
192system, it will also be sent to the perl5-porters@perl.org list.
244d9cb7 193
04c692a8
DR
194Patches are reviewed and discussed on the p5p list. Simple,
195uncontroversial patches will usually be applied without any discussion.
196When the patch is applied, the ticket will be updated and you will
197receive email. In addition, an email will be sent to the p5p list.
244d9cb7 198
04c692a8
DR
199In other cases, the patch will need more work or discussion. That will
200happen on the p5p list.
244d9cb7 201
04c692a8
DR
202You are encouraged to participate in the discussion and advocate for
203your patch. Sometimes your patch may get lost in the shuffle. It's
204appropriate to send a reminder email to p5p if no action has been taken
205in a month. Please remember that the Perl 5 developers are all
206volunteers, and be polite.
244d9cb7 207
04c692a8
DR
208Changes are always applied directly to the main development branch,
209called "blead". Some patches may be backported to a maintenance branch.
210If you think your patch is appropriate for the maintenance branch,
211please explain why when you submit it.
244d9cb7 212
04c692a8 213=head2 Getting your patch accepted
244d9cb7 214
84c2f6fd
DR
215If you are submitting a code patch there are several things that you
216can do to help the Perl 5 Porters accept your patch.
244d9cb7 217
a126fb62
DR
218=head3 Patch style
219
220If you used git to check out the Perl source, then using C<git
221format-patch> will produce a patch in a style suitable for Perl. The
222C<format-patch> command produces one patch file for each commit you
223made. If you prefer to send a single patch for all commits, you can use
224C<git diff>.
225
9d440a18 226 % git checkout blead
a126fb62
DR
227 % git pull
228 % git diff blead my-branch-name
229
230This produces a patch based on the difference between blead and your
231current branch. It's important to make sure that blead is up to date
232before producing the diff, that's why we call C<git pull> first.
233
234We strongly recommend that you use git if possible. It will make your
235life easier, and ours as well.
236
237However, if you're not using git, you can still produce a suitable
238patch. You'll need a pristine copy of the Perl source to diff against.
239The porters prefer unified diffs. Using GNU C<diff>, you can produce a
240diff like this:
241
242 % diff -Npurd perl.pristine perl.mine
243
244Make sure that you C<make realclean> in your copy of Perl to remove any
245build artifacts, or you may get a confusing result.
246
04c692a8 247=head3 Commit message
244d9cb7 248
04c692a8
DR
249As you craft each patch you intend to submit to the Perl core, it's
250important to write a good commit message. This is especially important
251if your submission will consist of a series of commits.
244d9cb7 252
04c692a8
DR
253The first line of the commit message should be a short description
254without a period. It should be no longer than the subject line of an
a8d15a22 255email, 50 characters being a good rule of thumb.
f7e1e956 256
a8d15a22 257A lot of Git tools (Gitweb, GitHub, git log --pretty=oneline, ...) will
04c692a8
DR
258only display the first line (cut off at 50 characters) when presenting
259commit summaries.
7cd58830 260
04c692a8
DR
261The commit message should include a description of the problem that the
262patch corrects or new functionality that the patch adds.
7cd58830 263
04c692a8
DR
264As a general rule of thumb, your commit message should help a
265programmer who knows the Perl core quickly understand what you were
266trying to do, how you were trying to do it, and why the change matters
267to Perl.
7cd58830 268
04c692a8 269=over 4
7cd58830 270
04c692a8 271=item * Why
7cd58830 272
04c692a8
DR
273Your commit message should describe why the change you are making is
274important. When someone looks at your change in six months or six
275years, your intent should be clear.
7cd58830 276
04c692a8
DR
277If you're deprecating a feature with the intent of later simplifying
278another bit of code, say so. If you're fixing a performance problem or
279adding a new feature to support some other bit of the core, mention
280that.
7cd58830 281
04c692a8 282=item * What
7cd58830 283
04c692a8
DR
284Your commit message should describe what part of the Perl core you're
285changing and what you expect your patch to do.
7cd58830 286
04c692a8 287=item * How
7cd58830 288
04c692a8
DR
289While it's not necessary for documentation changes, new tests or
290trivial patches, it's often worth explaining how your change works.
291Even if it's clear to you today, it may not be clear to a porter next
292month or next year.
d7889f52 293
04c692a8 294=back
d7889f52 295
04c692a8
DR
296A commit message isn't intended to take the place of comments in your
297code. Commit messages should describe the change you made, while code
298comments should describe the current state of the code.
d7889f52 299
04c692a8
DR
300If you've just implemented a new feature, complete with doc, tests and
301well-commented code, a brief commit message will often suffice. If,
302however, you've just changed a single character deep in the parser or
303lexer, you might need to write a small novel to ensure that future
304readers understand what you did and why you did it.
d7889f52 305
04c692a8 306=head3 Comments, Comments, Comments
d7889f52 307
04c692a8
DR
308Be sure to adequately comment your code. While commenting every line is
309unnecessary, anything that takes advantage of side effects of
310operators, that creates changes that will be felt outside of the
311function being patched, or that others may find confusing should be
312documented. If you are going to err, it is better to err on the side of
313adding too many comments than too few.
d7889f52 314
04c692a8
DR
315The best comments explain I<why> the code does what it does, not I<what
316it does>.
d7889f52 317
04c692a8 318=head3 Style
d7889f52 319
04c692a8
DR
320In general, please follow the particular style of the code you are
321patching.
d7889f52 322
04c692a8
DR
323In particular, follow these general guidelines for patching Perl
324sources:
cce04beb 325
04c692a8 326=over 4
d7889f52
JH
327
328=item *
329
04c692a8 3308-wide tabs (no exceptions!)
d7889f52
JH
331
332=item *
333
04c692a8 3344-wide indents for code, 2-wide indents for nested CPP #defines
ee9468a2 335
cce04beb 336=item *
ee9468a2 337
04c692a8 338Try hard not to exceed 79-columns
bc028b6b 339
ee9468a2
RGS
340=item *
341
04c692a8 342ANSI C prototypes
d7889f52
JH
343
344=item *
345
04c692a8 346Uncuddled elses and "K&R" style for indenting control constructs
0bec6c03 347
04c692a8 348=item *
d7889f52 349
04c692a8 350No C++ style (//) comments
d7889f52
JH
351
352=item *
353
04c692a8 354Mark places that need to be revisited with XXX (and revisit often!)
27565cb6
JH
355
356=item *
357
04c692a8
DR
358Opening brace lines up with "if" when conditional spans multiple lines;
359should be at end-of-line otherwise
27565cb6 360
04c692a8 361=item *
27565cb6 362
04c692a8
DR
363In function definitions, name starts in column 0 (return value is on
364previous line)
27565cb6 365
04c692a8 366=item *
27565cb6 367
04c692a8
DR
368Single space after keywords that are followed by parens, no space
369between function name and following paren
606fd33d 370
27565cb6
JH
371=item *
372
04c692a8
DR
373Avoid assignments in conditionals, but if they're unavoidable, use
374extra paren, e.g. "if (a && (b = c)) ..."
27565cb6
JH
375
376=item *
377
04c692a8 378"return foo;" rather than "return(foo);"
27565cb6
JH
379
380=item *
381
04c692a8 382"if (!foo) ..." rather than "if (foo == FALSE) ..." etc.
606fd33d
JH
383
384=back
27565cb6 385
04c692a8 386=head3 Test suite
d7889f52 387
a8d15a22 388If your patch changes code (rather than just changing documentation),
04c692a8
DR
389you should also include one or more test cases which illustrate the bug
390you're fixing or validate the new functionality you're adding. In
391general, you should update an existing test file rather than create a
392new one.
2bbc8d55 393
04c692a8
DR
394Your test suite additions should generally follow these guidelines
395(courtesy of Gurusamy Sarathy <gsar@activestate.com>):
2bbc8d55 396
04c692a8 397=over 4
0bec6c03 398
04c692a8 399=item *
0bec6c03 400
04c692a8 401Know what you're testing. Read the docs, and the source.
ee9468a2
RGS
402
403=item *
404
04c692a8 405Tend to fail, not succeed.
0bec6c03 406
04c692a8 407=item *
0bec6c03 408
04c692a8 409Interpret results strictly.
27565cb6 410
04c692a8 411=item *
27565cb6 412
04c692a8 413Use unrelated features (this will flush out bizarre interactions).
27565cb6 414
04c692a8 415=item *
27565cb6 416
04c692a8 417Use non-standard idioms (otherwise you are not testing TIMTOWTDI).
27565cb6 418
04c692a8 419=item *
d7889f52 420
04c692a8
DR
421Avoid using hardcoded test numbers whenever possible (the EXPECTED/GOT
422found in t/op/tie.t is much more maintainable, and gives better failure
423reports).
d7889f52 424
04c692a8 425=item *
d7889f52 426
04c692a8 427Give meaningful error messages when a test fails.
d7889f52 428
04c692a8 429=item *
d7889f52 430
04c692a8
DR
431Avoid using qx// and system() unless you are testing for them. If you
432do use them, make sure that you cover _all_ perl platforms.
d7889f52 433
04c692a8 434=item *
0bec6c03 435
04c692a8 436Unlink any temporary files you create.
63796a85 437
04c692a8 438=item *
0bec6c03 439
04c692a8 440Promote unforeseen warnings to errors with $SIG{__WARN__}.
0bec6c03 441
04c692a8 442=item *
0bec6c03 443
04c692a8
DR
444Be sure to use the libraries and modules shipped with the version being
445tested, not those that were already installed.
d7889f52 446
04c692a8 447=item *
d7889f52 448
04c692a8 449Add comments to the code explaining what you are testing for.
d7889f52 450
04c692a8 451=item *
d7889f52 452
04c692a8
DR
453Make updating the '1..42' string unnecessary. Or make sure that you
454update it.
d7889f52 455
04c692a8 456=item *
d7889f52 457
04c692a8 458Test _all_ behaviors of a given operator, library, or function.
d7889f52 459
04c692a8 460Test all optional arguments.
d7889f52 461
04c692a8 462Test return values in various contexts (boolean, scalar, list, lvalue).
d7889f52 463
04c692a8 464Use both global and lexical variables.
d7889f52 465
04c692a8 466Don't forget the exceptional, pathological cases.
0bec6c03 467
cce04beb 468=back
0bec6c03 469
04c692a8 470=head2 Patching a core module
ee9468a2 471
04c692a8
DR
472This works just like patching anything else, with one extra
473consideration.
63796a85 474
a8d15a22 475Modules in the F<cpan/> directory of the source tree are maintained
24b68a05
DG
476outside of the Perl core. When the author updates the module, the
477updates are simply copied into the core. See that module's
478documentation or its listing on L<http://search.cpan.org/> for more
479information on reporting bugs and submitting patches.
480
481In most cases, patches to modules in F<cpan/> should be sent upstream
9e6670f3
DR
482and should not be applied to the Perl core individually. If a patch to
483a file in F<cpan/> absolutely cannot wait for the fix to be made
7e5887a1
DG
484upstream, released to CPAN and copied to blead, you must add (or
485update) a C<CUSTOMIZED> entry in the F<"Porting/Maintainers.pl"> file
486to flag that a local modification has been made. See
487F<"Porting/Maintainers.pl"> for more details.
63796a85 488
04c692a8
DR
489In contrast, modules in the F<dist/> directory are maintained in the
490core.
63796a85 491
04c692a8 492=head2 Updating perldelta
63796a85 493
04c692a8
DR
494For changes significant enough to warrant a F<pod/perldelta.pod> entry,
495the porters will greatly appreciate it if you submit a delta entry
496along with your actual change. Significant changes include, but are not
497limited to:
63796a85 498
04c692a8 499=over 4
63796a85 500
04c692a8 501=item *
63796a85 502
04c692a8 503Adding, deprecating, or removing core features
ee9468a2 504
04c692a8 505=item *
ee9468a2 506
04c692a8 507Adding, deprecating, removing, or upgrading core or dual-life modules
ee9468a2 508
04c692a8 509=item *
ee9468a2 510
04c692a8 511Adding new core tests
ee9468a2 512
04c692a8 513=item *
ee9468a2 514
04c692a8 515Fixing security issues and user-visible bugs in the core
cce04beb 516
04c692a8 517=item *
ad7244db 518
04c692a8 519Changes that might break existing code, either on the perl or C level
ad7244db
JH
520
521=item *
522
04c692a8 523Significant performance improvements
ad7244db
JH
524
525=item *
526
04c692a8
DR
527Adding, removing, or significantly changing documentation in the
528F<pod/> directory
ad7244db 529
cce04beb 530=item *
ad7244db 531
04c692a8 532Important platform-specific changes
d7889f52 533
cce04beb
DG
534=back
535
04c692a8
DR
536Please make sure you add the perldelta entry to the right section
537within F<pod/perldelta.pod>. More information on how to write good
538perldelta entries is available in the C<Style> section of
539F<Porting/how_to_write_a_perldelta.pod>.
d7889f52 540
04c692a8 541=head2 What makes for a good patch?
d7889f52 542
04c692a8
DR
543New features and extensions to the language can be contentious. There
544is no specific set of criteria which determine what features get added,
545but here are some questions to consider when developing a patch:
d7889f52 546
04c692a8 547=head3 Does the concept match the general goals of Perl?
d7889f52 548
04c692a8 549Our goals include, but are not limited to:
d7889f52 550
04c692a8 551=over 4
d7889f52 552
04c692a8 553=item 1.
d7889f52 554
04c692a8 555Keep it fast, simple, and useful.
cce04beb 556
04c692a8 557=item 2.
cce04beb 558
04c692a8 559Keep features/concepts as orthogonal as possible.
902b9dbf 560
04c692a8 561=item 3.
902b9dbf 562
04c692a8 563No arbitrary limits (platforms, data sizes, cultures).
a958818a 564
04c692a8 565=item 4.
ac036724 566
04c692a8 567Keep it open and exciting to use/patch/advocate Perl everywhere.
a958818a 568
04c692a8 569=item 5.
a958818a 570
04c692a8 571Either assimilate new technologies, or build bridges to them.
a958818a 572
04c692a8 573=back
a958818a 574
04c692a8 575=head3 Where is the implementation?
a958818a 576
04c692a8
DR
577All the talk in the world is useless without an implementation. In
578almost every case, the person or people who argue for a new feature
579will be expected to be the ones who implement it. Porters capable of
580coding new features have their own agendas, and are not available to
581implement your (possibly good) idea.
a1b65709 582
04c692a8 583=head3 Backwards compatibility
37c0adeb 584
04c692a8
DR
585It's a cardinal sin to break existing Perl programs. New warnings can
586be contentious--some say that a program that emits warnings is not
587broken, while others say it is. Adding keywords has the potential to
588break programs, changing the meaning of existing token sequences or
589functions might break programs.
f50e5b73 590
04c692a8
DR
591The Perl 5 core includes mechanisms to help porters make backwards
592incompatible changes more compatible such as the L<feature> and
593L<deprecate> modules. Please use them when appropriate.
902b9dbf 594
04c692a8 595=head3 Could it be a module instead?
902b9dbf 596
04c692a8
DR
597Perl 5 has extension mechanisms, modules and XS, specifically to avoid
598the need to keep changing the Perl interpreter. You can write modules
599that export functions, you can give those functions prototypes so they
600can be called like built-in functions, you can even write XS code to
601mess with the runtime data structures of the Perl interpreter if you
602want to implement really complicated things.
902b9dbf 603
04c692a8
DR
604Whenever possible, new features should be prototyped in a CPAN module
605before they will be considered for the core.
902b9dbf 606
04c692a8 607=head3 Is the feature generic enough?
902b9dbf 608
04c692a8
DR
609Is this something that only the submitter wants added to the language,
610or is it broadly useful? Sometimes, instead of adding a feature with a
611tight focus, the porters might decide to wait until someone implements
612the more generalized feature.
902b9dbf 613
04c692a8 614=head3 Does it potentially introduce new bugs?
902b9dbf 615
04c692a8
DR
616Radical rewrites of large chunks of the Perl interpreter have the
617potential to introduce new bugs.
902b9dbf 618
04c692a8 619=head3 How big is it?
902b9dbf 620
04c692a8
DR
621The smaller and more localized the change, the better. Similarly, a
622series of small patches is greatly preferred over a single large patch.
902b9dbf 623
04c692a8 624=head3 Does it preclude other desirable features?
902b9dbf 625
04c692a8
DR
626A patch is likely to be rejected if it closes off future avenues of
627development. For instance, a patch that placed a true and final
628interpretation on prototypes is likely to be rejected because there are
629still options for the future of prototypes that haven't been addressed.
902b9dbf 630
04c692a8 631=head3 Is the implementation robust?
902b9dbf 632
04c692a8
DR
633Good patches (tight code, complete, correct) stand more chance of going
634in. Sloppy or incorrect patches might be placed on the back burner
635until the pumpking has time to fix, or might be discarded altogether
636without further notice.
902b9dbf 637
04c692a8 638=head3 Is the implementation generic enough to be portable?
902b9dbf 639
a8d15a22 640The worst patches make use of system-specific features. It's highly
04c692a8
DR
641unlikely that non-portable additions to the Perl language will be
642accepted.
902b9dbf 643
04c692a8 644=head3 Is the implementation tested?
902b9dbf 645
04c692a8
DR
646Patches which change behaviour (fixing bugs or introducing new
647features) must include regression tests to verify that everything works
648as expected.
902b9dbf 649
04c692a8
DR
650Without tests provided by the original author, how can anyone else
651changing perl in the future be sure that they haven't unwittingly
652broken the behaviour the patch implements? And without tests, how can
653the patch's author be confident that his/her hard work put into the
654patch won't be accidentally thrown away by someone in the future?
902b9dbf 655
04c692a8 656=head3 Is there enough documentation?
902b9dbf 657
04c692a8
DR
658Patches without documentation are probably ill-thought out or
659incomplete. No features can be added or changed without documentation,
660so submitting a patch for the appropriate pod docs as well as the
661source code is important.
902b9dbf 662
04c692a8 663=head3 Is there another way to do it?
902b9dbf 664
04c692a8
DR
665Larry said "Although the Perl Slogan is I<There's More Than One Way to
666Do It>, I hesitate to make 10 ways to do something". This is a tricky
667heuristic to navigate, though--one man's essential addition is another
668man's pointless cruft.
902b9dbf 669
04c692a8 670=head3 Does it create too much work?
902b9dbf 671
04c692a8
DR
672Work for the pumpking, work for Perl programmers, work for module
673authors, ... Perl is supposed to be easy.
902b9dbf 674
04c692a8 675=head3 Patches speak louder than words
902b9dbf 676
04c692a8
DR
677Working code is always preferred to pie-in-the-sky ideas. A patch to
678add a feature stands a much higher chance of making it to the language
679than does a random feature request, no matter how fervently argued the
680request might be. This ties into "Will it be useful?", as the fact that
681someone took the time to make the patch demonstrates a strong desire
682for the feature.
c406981e 683
04c692a8 684=head1 TESTING
c406981e 685
04c692a8
DR
686The core uses the same testing style as the rest of Perl, a simple
687"ok/not ok" run through Test::Harness, but there are a few special
688considerations.
c406981e 689
04c692a8
DR
690There are three ways to write a test in the core. L<Test::More>,
691F<t/test.pl> and ad hoc C<print $test ? "ok 42\n" : "not ok 42\n">. The
692decision of which to use depends on what part of the test suite you're
693working on. This is a measure to prevent a high-level failure (such as
694Config.pm breaking) from causing basic functionality tests to fail.
c406981e 695
04c692a8
DR
696The F<t/test.pl> library provides some of the features of
697L<Test::More>, but avoids loading most modules and uses as few core
698features as possible.
902b9dbf 699
9e6670f3
DR
700If you write your own test, use the L<Test Anything
701Protocol|http://testanything.org>.
902b9dbf
MLF
702
703=over 4
704
04c692a8 705=item * F<t/base> and F<t/comp>
902b9dbf 706
04c692a8
DR
707Since we don't know if require works, or even subroutines, use ad hoc
708tests for these two. Step carefully to avoid using the feature being
709tested.
902b9dbf 710
a8d15a22 711=item * F<t/cmd>, F<t/run>, F<t/io> and F<t/op>
902b9dbf 712
04c692a8
DR
713Now that basic require() and subroutines are tested, you can use the
714F<t/test.pl> library.
902b9dbf 715
a8d15a22 716You can also use certain libraries like Config conditionally, but be
04c692a8 717sure to skip the test gracefully if it's not there.
902b9dbf 718
04c692a8 719=item * Everything else
902b9dbf 720
04c692a8
DR
721Now that the core of Perl is tested, L<Test::More> can and should be
722used. You can also use the full suite of core modules in the tests.
902b9dbf
MLF
723
724=back
725
a8d15a22
R
726When you say "make test", Perl uses the F<t/TEST> program to run the
727test suite (except under Win32 where it uses F<t/harness> instead). All
04c692a8
DR
728tests are run from the F<t/> directory, B<not> the directory which
729contains the test. This causes some problems with the tests in F<lib/>,
730so here's some opportunity for some patching.
902b9dbf 731
04c692a8
DR
732You must be triply conscious of cross-platform concerns. This usually
733boils down to using L<File::Spec> and avoiding things like C<fork()>
734and C<system()> unless absolutely necessary.
7a834142 735
04c692a8 736=head2 Special C<make test> targets
07aa3531 737
04c692a8
DR
738There are various special make targets that can be used to test Perl
739slightly differently than the standard "test" target. Not all them are
740expected to give a 100% success rate. Many of them have several
741aliases, and many of them are not available on certain operating
742systems.
07aa3531 743
04c692a8 744=over 4
d44161bf 745
04c692a8 746=item * test_porting
7a834142 747
04c692a8
DR
748This runs some basic sanity tests on the source tree and helps catch
749basic errors before you submit a patch.
7a834142 750
04c692a8 751=item * coretest
7a834142 752
04c692a8 753Run F<perl> on all core tests (F<t/*> and F<lib/[a-z]*> pragma tests).
09187cb1 754
04c692a8 755(Not available on Win32)
09187cb1 756
04c692a8 757=item * test.deparse
09187cb1 758
04c692a8 759Run all the tests through L<B::Deparse>. Not all tests will succeed.
64cea5fd 760
04c692a8 761(Not available on Win32)
64cea5fd 762
04c692a8 763=item * test.taintwarn
64cea5fd 764
04c692a8
DR
765Run all tests with the B<-t> command-line switch. Not all tests are
766expected to succeed (until they're specifically fixed, of course).
51a35ef1 767
04c692a8 768(Not available on Win32)
51a35ef1 769
04c692a8 770=item * minitest
51a35ef1 771
04c692a8
DR
772Run F<miniperl> on F<t/base>, F<t/comp>, F<t/cmd>, F<t/run>, F<t/io>,
773F<t/op>, F<t/uni> and F<t/mro> tests.
51a35ef1 774
04c692a8 775=item * test.valgrind check.valgrind utest.valgrind ucheck.valgrind
51a35ef1 776
04c692a8
DR
777(Only in Linux) Run all the tests using the memory leak + naughty
778memory access tool "valgrind". The log files will be named
779F<testname.valgrind>.
83f0ef60 780
04c692a8 781=item * test.torture torturetest
83f0ef60 782
9e6670f3
DR
783Run all the usual tests and some extra tests. As of Perl 5.8.0, the
784only extra tests are Abigail's JAPHs, F<t/japh/abigail.t>.
83f0ef60 785
04c692a8
DR
786You can also run the torture test with F<t/harness> by giving
787C<-torture> argument to F<t/harness>.
83f0ef60 788
04c692a8 789=item * utest ucheck test.utf8 check.utf8
83f0ef60 790
04c692a8 791Run all the tests with -Mutf8. Not all tests will succeed.
83f0ef60 792
04c692a8 793(Not available on Win32)
83f0ef60 794
04c692a8 795=item * minitest.utf16 test.utf16
83f0ef60 796
04c692a8
DR
797Runs the tests with UTF-16 encoded scripts, encoded with different
798versions of this encoding.
83f0ef60 799
04c692a8
DR
800C<make utest.utf16> runs the test suite with a combination of C<-utf8>
801and C<-utf16> arguments to F<t/TEST>.
83f0ef60 802
04c692a8 803(Not available on Win32)
83f0ef60 804
04c692a8 805=item * test_harness
83f0ef60 806
04c692a8
DR
807Run the test suite with the F<t/harness> controlling program, instead
808of F<t/TEST>. F<t/harness> is more sophisticated, and uses the
809L<Test::Harness> module, thus using this test target supposes that perl
810mostly works. The main advantage for our purposes is that it prints a
811detailed summary of failed tests at the end. Also, unlike F<t/TEST>, it
812doesn't redirect stderr to stdout.
83f0ef60 813
04c692a8
DR
814Note that under Win32 F<t/harness> is always used instead of F<t/TEST>,
815so there is no special "test_harness" target.
83f0ef60 816
04c692a8
DR
817Under Win32's "test" target you may use the TEST_SWITCHES and
818TEST_FILES environment variables to control the behaviour of
819F<t/harness>. This means you can say
83f0ef60 820
04c692a8
DR
821 nmake test TEST_FILES="op/*.t"
822 nmake test TEST_SWITCHES="-torture" TEST_FILES="op/*.t"
83f0ef60 823
78087e0a
R
824=item * test-notty test_notty
825
826Sets PERL_SKIP_TTY_TEST to true before running normal test.
827
83f0ef60
JH
828=back
829
04c692a8 830=head2 Parallel tests
83f0ef60 831
04c692a8
DR
832The core distribution can now run its regression tests in parallel on
833Unix-like platforms. Instead of running C<make test>, set C<TEST_JOBS>
834in your environment to the number of tests to run in parallel, and run
835C<make test_harness>. On a Bourne-like shell, this can be done as
07aa3531 836
04c692a8 837 TEST_JOBS=3 make test_harness # Run 3 tests in parallel
07aa3531 838
04c692a8
DR
839An environment variable is used, rather than parallel make itself,
840because L<TAP::Harness> needs to be able to schedule individual
841non-conflicting test scripts itself, and there is no standard interface
842to C<make> utilities to interact with their job schedulers.
51a35ef1 843
9e6670f3
DR
844Note that currently some test scripts may fail when run in parallel
845(most notably F<ext/IO/t/io_dir.t>). If necessary, run just the failing
846scripts again sequentially and see if the failures go away.
51a35ef1 847
04c692a8 848=head2 Running tests by hand
51a35ef1 849
9e6670f3
DR
850You can run part of the test suite by hand by using one of the
851following commands from the F<t/> directory:
51a35ef1 852
04c692a8 853 ./perl -I../lib TEST list-of-.t-files
51a35ef1 854
04c692a8 855or
51a35ef1 856
04c692a8 857 ./perl -I../lib harness list-of-.t-files
51a35ef1 858
a8d15a22 859(If you don't specify test scripts, the whole test suite will be run.)
51a35ef1 860
04c692a8 861=head2 Using F<t/harness> for testing
51a35ef1 862
9e6670f3
DR
863If you use C<harness> for testing, you have several command line
864options available to you. The arguments are as follows, and are in the
865order that they must appear if used together.
51a35ef1 866
04c692a8
DR
867 harness -v -torture -re=pattern LIST OF FILES TO TEST
868 harness -v -torture -re LIST OF PATTERNS TO MATCH
07aa3531 869
a8d15a22 870If C<LIST OF FILES TO TEST> is omitted, the file list is obtained from
04c692a8
DR
871the manifest. The file list may include shell wildcards which will be
872expanded out.
07aa3531 873
04c692a8 874=over 4
4ae3d70a 875
04c692a8 876=item * -v
4ae3d70a 877
04c692a8
DR
878Run the tests under verbose mode so you can see what tests were run,
879and debug output.
51a35ef1 880
04c692a8 881=item * -torture
4ae3d70a 882
04c692a8 883Run the torture tests as well as the normal set.
4ae3d70a 884
04c692a8 885=item * -re=PATTERN
6c41479b 886
04c692a8
DR
887Filter the file list so that all the test files run match PATTERN. Note
888that this form is distinct from the B<-re LIST OF PATTERNS> form below
889in that it allows the file list to be provided as well.
6c41479b 890
04c692a8 891=item * -re LIST OF PATTERNS
6c41479b 892
04c692a8
DR
893Filter the file list so that all the test files run match
894/(LIST|OF|PATTERNS)/. Note that with this form the patterns are joined
895by '|' and you cannot supply a list of files, instead the test files
896are obtained from the MANIFEST.
6c41479b 897
04c692a8 898=back
6c41479b 899
04c692a8 900You can run an individual test by a command similar to
6c41479b 901
a8d15a22 902 ./perl -I../lib path/to/foo.t
6c41479b 903
04c692a8
DR
904except that the harnesses set up some environment variables that may
905affect the execution of the test:
6c41479b
JH
906
907=over 4
908
04c692a8 909=item * PERL_CORE=1
6c41479b 910
a8d15a22 911indicates that we're running this test as part of the perl core test
04c692a8 912suite. This is useful for modules that have a dual life on CPAN.
6c41479b 913
04c692a8 914=item * PERL_DESTRUCT_LEVEL=2
6c41479b 915
04c692a8 916is set to 2 if it isn't set already (see
a8d15a22 917L<perlhacktips/PERL_DESTRUCT_LEVEL>).
6c41479b 918
04c692a8 919=item * PERL
6c41479b 920
04c692a8
DR
921(used only by F<t/TEST>) if set, overrides the path to the perl
922executable that should be used to run the tests (the default being
923F<./perl>).
6c41479b 924
04c692a8 925=item * PERL_SKIP_TTY_TEST
6c41479b 926
04c692a8
DR
927if set, tells to skip the tests that need a terminal. It's actually set
928automatically by the Makefile, but can also be forced artificially by
929running 'make test_notty'.
6c41479b 930
04c692a8 931=back
6c41479b 932
04c692a8 933=head3 Other environment variables that may influence tests
6c41479b 934
04c692a8 935=over 4
6c41479b 936
04c692a8 937=item * PERL_TEST_Net_Ping
6c41479b 938
04c692a8
DR
939Setting this variable runs all the Net::Ping modules tests, otherwise
940some tests that interact with the outside world are skipped. See
941L<perl58delta>.
6c41479b 942
04c692a8 943=item * PERL_TEST_NOVREXX
cce04beb 944
04c692a8 945Setting this variable skips the vrexx.t tests for OS2::REXX.
cce04beb 946
04c692a8 947=item * PERL_TEST_NUMCONVERTS
cce04beb 948
04c692a8 949This sets a variable in op/numconvert.t.
cce04beb 950
04c692a8 951=back
cce04beb 952
04c692a8
DR
953See also the documentation for the Test and Test::Harness modules, for
954more environment variables that affect testing.
cce04beb 955
04c692a8 956=head1 MORE READING FOR GUTS HACKERS
cce04beb 957
04c692a8 958To hack on the Perl guts, you'll need to read the following things:
cce04beb 959
04c692a8 960=over 4
cce04beb 961
04c692a8 962=item * L<perlsource>
b8ddf6b3 963
04c692a8
DR
964An overview of the Perl source tree. This will help you find the files
965you're looking for.
b8ddf6b3 966
04c692a8 967=item * L<perlinterp>
b8ddf6b3 968
04c692a8
DR
969An overview of the Perl interpreter source code and some details on how
970Perl does what it does.
b8ddf6b3 971
04c692a8 972=item * L<perlhacktut>
b8ddf6b3 973
04c692a8
DR
974This document walks through the creation of a small patch to Perl's C
975code. If you're just getting started with Perl core hacking, this will
976help you understand how it works.
b8ddf6b3 977
04c692a8 978=item * L<perlhacktips>
b8ddf6b3 979
04c692a8
DR
980More details on hacking the Perl core. This document focuses on lower
981level details such as how to write tests, compilation issues,
982portability, debugging, etc.
b8ddf6b3 983
04c692a8 984If you plan on doing serious C hacking, make sure to read this.
b8ddf6b3 985
04c692a8 986=item * L<perlguts>
b8ddf6b3 987
04c692a8
DR
988This is of paramount importance, since it's the documentation of what
989goes where in the Perl source. Read it over a couple of times and it
990might start to make sense - don't worry if it doesn't yet, because the
991best way to study it is to read it in conjunction with poking at Perl
992source, and we'll do that later on.
b8ddf6b3 993
04c692a8
DR
994Gisle Aas's "illustrated perlguts", also known as I<illguts>, has very
995helpful pictures:
9965345d 996
04c692a8 997L<http://search.cpan.org/dist/illguts/>
9965345d 998
04c692a8 999=item * L<perlxstut> and L<perlxs>
f1fac472 1000
04c692a8
DR
1001A working knowledge of XSUB programming is incredibly useful for core
1002hacking; XSUBs use techniques drawn from the PP code, the portion of
1003the guts that actually executes a Perl program. It's a lot gentler to
1004learn those techniques from simple examples and explanation than from
1005the core itself.
f1fac472 1006
04c692a8 1007=item * L<perlapi>
f1fac472 1008
04c692a8
DR
1009The documentation for the Perl API explains what some of the internal
1010functions do, as well as the many macros used in the source.
f1fac472 1011
04c692a8 1012=item * F<Porting/pumpkin.pod>
f1fac472 1013
04c692a8
DR
1014This is a collection of words of wisdom for a Perl porter; some of it
1015is only useful to the pumpkin holder, but most of it applies to anyone
1016wanting to go about Perl development.
f1fac472 1017
04c692a8 1018=item * The perl5-porters FAQ
f1fac472 1019
04c692a8
DR
1020This should be available from
1021http://dev.perl.org/perl5/docs/p5p-faq.html . It contains hints on
1022reading perl5-porters, information on how perl5-porters works and how
1023Perl development in general works.
f1fac472 1024
04c692a8 1025=back
f1fac472 1026
04c692a8 1027=head1 CPAN TESTERS AND PERL SMOKERS
f1fac472 1028
04c692a8
DR
1029The CPAN testers ( http://testers.cpan.org/ ) are a group of volunteers
1030who test CPAN modules on a variety of platforms.
b8ddf6b3 1031
a8d15a22 1032Perl Smokers ( http://www.nntp.perl.org/group/perl.daily-build/ and
04c692a8
DR
1033http://www.nntp.perl.org/group/perl.daily-build.reports/ )
1034automatically test Perl source releases on platforms with various
1035configurations.
f1fac472 1036
04c692a8
DR
1037Both efforts welcome volunteers. In order to get involved in smoke
1038testing of the perl itself visit
a8d15a22 1039L<http://search.cpan.org/dist/Test-Smoke/>. In order to start smoke
04c692a8
DR
1040testing CPAN modules visit
1041L<http://search.cpan.org/dist/CPANPLUS-YACSmoke/> or
1042L<http://search.cpan.org/dist/minismokebox/> or
1043L<http://search.cpan.org/dist/CPAN-Reporter/>.
f1fac472 1044
04c692a8 1045=head1 WHAT NEXT?
a422fd2d 1046
04c692a8
DR
1047If you've read all the documentation in the document and the ones
1048listed above, you're more than ready to hack on Perl.
a422fd2d 1049
04c692a8 1050Here's some more recommendations
a422fd2d 1051
04c692a8 1052=over 4
a422fd2d
SC
1053
1054=item *
1055
1056Subscribe to perl5-porters, follow the patches and try and understand
1057them; don't be afraid to ask if there's a portion you're not clear on -
1058who knows, you may unearth a bug in the patch...
1059
1060=item *
1061
04c692a8
DR
1062Do read the README associated with your operating system, e.g.
1063README.aix on the IBM AIX OS. Don't hesitate to supply patches to that
1064README if you find anything missing or changed over a new OS release.
a1f349fd
MB
1065
1066=item *
1067
a422fd2d
SC
1068Find an area of Perl that seems interesting to you, and see if you can
1069work out how it works. Scan through the source, and step over it in the
1070debugger. Play, poke, investigate, fiddle! You'll probably get to
04c692a8
DR
1071understand not just your chosen area but a much wider range of
1072F<perl>'s activity as well, and probably sooner than you'd think.
a422fd2d
SC
1073
1074=back
1075
04c692a8 1076=head2 "The Road goes ever on and on, down from the door where it began."
a422fd2d 1077
04c692a8
DR
1078If you can do these things, you've started on the long road to Perl
1079porting. Thanks for wanting to help make Perl better - and happy
1080hacking!
a422fd2d 1081
4ac71550
TC
1082=head2 Metaphoric Quotations
1083
1084If you recognized the quote about the Road above, you're in luck.
1085
04c692a8
DR
1086Most software projects begin each file with a literal description of
1087each file's purpose. Perl instead begins each with a literary allusion
1088to that file's purpose.
4ac71550 1089
04c692a8 1090Like chapters in many books, all top-level Perl source files (along
9e6670f3
DR
1091with a few others here and there) begin with an epigrammatic
1092inscription that alludes, indirectly and metaphorically, to the
1093material you're about to read.
4ac71550 1094
a8d15a22 1095Quotations are taken from writings of J.R.R. Tolkien pertaining to his
04c692a8 1096Legendarium, almost always from I<The Lord of the Rings>. Chapters and
4ac71550
TC
1097page numbers are given using the following editions:
1098
1099=over 4
1100
04c692a8 1101=item *
4ac71550 1102
04c692a8
DR
1103I<The Hobbit>, by J.R.R. Tolkien. The hardcover, 70th-anniversary
1104edition of 2007 was used, published in the UK by Harper Collins
1105Publishers and in the US by the Houghton Mifflin Company.
4ac71550
TC
1106
1107=item *
1108
04c692a8
DR
1109I<The Lord of the Rings>, by J.R.R. Tolkien. The hardcover,
111050th-anniversary edition of 2004 was used, published in the UK by
1111Harper Collins Publishers and in the US by the Houghton Mifflin
1112Company.
4ac71550
TC
1113
1114=item *
1115
04c692a8
DR
1116I<The Lays of Beleriand>, by J.R.R. Tolkien and published posthumously
1117by his son and literary executor, C.J.R. Tolkien, being the 3rd of the
111812 volumes in Christopher's mammoth I<History of Middle Earth>. Page
1119numbers derive from the hardcover edition, first published in 1983 by
1120George Allen & Unwin; no page numbers changed for the special 3-volume
1121omnibus edition of 2002 or the various trade-paper editions, all again
1122now by Harper Collins or Houghton Mifflin.
4ac71550
TC
1123
1124=back
1125
04c692a8
DR
1126Other JRRT books fair game for quotes would thus include I<The
1127Adventures of Tom Bombadil>, I<The Silmarillion>, I<Unfinished Tales>,
1128and I<The Tale of the Children of Hurin>, all but the first
1129posthumously assembled by CJRT. But I<The Lord of the Rings> itself is
1130perfectly fine and probably best to quote from, provided you can find a
1131suitable quote there.
4ac71550 1132
04c692a8
DR
1133So if you were to supply a new, complete, top-level source file to add
1134to Perl, you should conform to this peculiar practice by yourself
1135selecting an appropriate quotation from Tolkien, retaining the original
1136spelling and punctuation and using the same format the rest of the
1137quotes are in. Indirect and oblique is just fine; remember, it's a
1138metaphor, so being meta is, after all, what it's for.
4ac71550 1139
e8cd7eae
GS
1140=head1 AUTHOR
1141
04c692a8
DR
1142This document was originally written by Nathan Torkington, and is
1143maintained by the perl5-porters mailing list.
b16c2e4a 1144