From aede6a0450b5f9e2edd1c2fbd17dabeb526d8098 Mon Sep 17 00:00:00 2001 From: Father Chrysostomos Date: Sun, 12 Oct 2014 11:22:49 -0700 Subject: [PATCH] =?utf8?q?Revert=20"op.c:=20Don=E2=80=99t=20keep=20looping?= =?utf8?q?=20when=20we=20see=20potential=20common=20vars"?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This reverts commit bd2688c4c50527e5796ba4bc132c379f11e57112. It seemed like an obvious optimisation, until it dawned on me that this loop is doing two things, not just searching for common vars. --- op.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/op.c b/op.c index 1de26ae..7b8c176 100644 --- a/op.c +++ b/op.c @@ -6072,10 +6072,7 @@ Perl_newASSIGNOP(pTHX_ I32 flags, OP *left, I32 optype, OP *right) lop->op_type == OP_PADHV || lop->op_type == OP_PADANY) { if (!(lop->op_private & OPpLVAL_INTRO)) - { maybe_common_vars = TRUE; - break; - } if (lop->op_private & OPpPAD_STATE) { if (left->op_private & OPpLVAL_INTRO) { @@ -6097,7 +6094,6 @@ Perl_newASSIGNOP(pTHX_ I32 flags, OP *left, I32 optype, OP *right) } else { /* Other ops in the list. */ maybe_common_vars = TRUE; - break; } lop = OP_SIBLING(lop); } -- 1.8.3.1