From 2aa629fafc4af31b65bb83bf556fee79269eec05 Mon Sep 17 00:00:00 2001 From: Father Chrysostomos Date: Tue, 7 Jun 2011 17:56:06 -0700 Subject: [PATCH] Remove unnecessary TAINT_NOT (Ignore this for perldelta.) *++newsp = *MARK obviously does no tainting. The TAINT_NOT following it was unnecessarily copied to S_return_lvalues from pp_return when the former came into existence. (pp_return does need TAINT_NOT, as it uses sv_mortalcopy, which calls sv_setsv_flags, which does tainting.) --- pp_ctl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/pp_ctl.c b/pp_ctl.c index 868ef01..c600a91 100644 --- a/pp_ctl.c +++ b/pp_ctl.c @@ -2261,7 +2261,6 @@ S_return_lvalues(pTHX_ SV **mark, SV **sp, SV **newsp, I32 gimme, : sv_2mortal(SvREFCNT_inc_simple_NN(*MARK)); else while (++MARK <= SP) { *++newsp = *MARK; - TAINT_NOT; /* Each item is independent */ } } PL_stack_sp = newsp; -- 1.8.3.1