From 16a77b27e2d2b59233235b74ce1f2c90ac18d675 Mon Sep 17 00:00:00 2001 From: Father Chrysostomos Date: Tue, 17 May 2016 13:00:08 -0700 Subject: [PATCH] bisect-runner: Only run ./Configure -S when needed We only need to run it when config.sh has been modified, which only happens before 5.10. From v5.23.4-46-g41d7307 onwards ./Configure -S did not work, until v5.23.5-90-g473edb6, so we need to skip this if we want to bisect in that region. (Or we could just skip the die, but we might as well skip the system call, too.) --- Porting/bisect-runner.pl | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Porting/bisect-runner.pl b/Porting/bisect-runner.pl index 4c1cce9..e7aca65 100755 --- a/Porting/bisect-runner.pl +++ b/Porting/bisect-runner.pl @@ -1399,10 +1399,9 @@ run_with_options({stdin => '/dev/null', name => 'Configure'}, patch_SH() unless $options{'all-fixups'}; apply_fixups($options{'late-fixup'}); -if (-f 'config.sh') { +if (-f 'config.sh' && $major < 10 && $defines{noextensions}) { # Emulate noextensions if Configure doesn't support it. - fake_noextensions() - if $major < 10 && $defines{noextensions}; + fake_noextensions(); system_or_die('./Configure -S'); } -- 1.8.3.1