This is a live mirror of the Perl 5 development currently hosted at
5 years agoUpgrade to threads 2.06
jdhedden [Fri, 22 Apr 2016 18:28:09 +0000 (14:28 -0400)]
Upgrade to threads 2.06

5 years agocorelist: updated for File::Copy doc updates
Ricardo Signes [Sat, 30 Apr 2016 18:26:42 +0000 (14:26 -0400)]
corelist: updated for File::Copy doc updates

5 years agoAdd cross-reference to perldata in scalar's documentation origin/dom/doc-fixes
Dominic Hargreaves [Sat, 30 Apr 2016 18:01:19 +0000 (19:01 +0100)]
Add cross-reference to perldata in scalar's documentation


5 years agoperlrun: note the existence of find's -delete switch
Dominic Hargreaves [Sat, 30 Apr 2016 17:58:06 +0000 (18:58 +0100)]
perlrun: note the existence of find's -delete switch


5 years agoBump $File::Copy::VERSION
Dominic Hargreaves [Sat, 30 Apr 2016 17:53:13 +0000 (18:53 +0100)]
Bump $File::Copy::VERSION

5 years agoFile::Copy: add a warning about flushing writes
Dominic Hargreaves [Sat, 30 Apr 2016 17:03:01 +0000 (18:03 +0100)]
File::Copy: add a warning about flushing writes


5 years agoperl.pod: @INC is being displayed as intended
Dominic Hargreaves [Sat, 30 Apr 2016 16:49:04 +0000 (17:49 +0100)]
perl.pod: @INC is being displayed as intended

The previous presentation looked a bit like an incomplete placeholder


5 years agoTick off 5.22.2
Steve Hay [Fri, 29 Apr 2016 23:09:15 +0000 (00:09 +0100)]
Tick off 5.22.2

5 years ago5.22.2 today
Steve Hay [Fri, 29 Apr 2016 23:07:42 +0000 (00:07 +0100)]
5.22.2 today

(Manually cherry picked from commit 72ccbefa77099a0bf1b7c2cb9f29685ed7d9938d)

5 years agoImport 5.22.2's perldelta
Steve Hay [Fri, 29 Apr 2016 23:05:46 +0000 (00:05 +0100)]
Import 5.22.2's perldelta

5 years agoImport 5.22.2's Module::CoreList data
Steve Hay [Fri, 29 Apr 2016 23:02:05 +0000 (00:02 +0100)]
Import 5.22.2's Module::CoreList data

5 years agotrivial s/or/of/ doc patch
Jim Cromie [Wed, 27 Apr 2016 12:22:22 +0000 (06:22 -0600)]
trivial s/or/of/ doc patch

5 years agoperlpolicy: add Sawyer X to list moderators
Ricardo Signes [Thu, 28 Apr 2016 20:56:06 +0000 (16:56 -0400)]
perlpolicy: add Sawyer X to list moderators

5 years agobump version to v5.24.0-RC3 v5.24.0-RC3
Ricardo Signes [Tue, 26 Apr 2016 22:10:34 +0000 (18:10 -0400)]
bump version to v5.24.0-RC3

5 years agocorelist: silence deep recursion warning with %version
Niko Tyni [Tue, 26 Apr 2016 21:34:51 +0000 (17:34 -0400)]
corelist: silence deep recursion warning with %version

5 years agoRemove some data detritus from CoreList
Aristotle Pagaltzis [Tue, 26 Apr 2016 21:32:43 +0000 (17:32 -0400)]
Remove some data detritus from CoreList

5 years agoDocument exports policy within POSIX
Aristotle Pagaltzis [Tue, 26 Apr 2016 09:53:54 +0000 (11:53 +0200)]
Document exports policy within POSIX

5 years agoCorrect lround situation comment in POSIX
Aristotle Pagaltzis [Tue, 26 Apr 2016 09:53:21 +0000 (11:53 +0200)]
Correct lround situation comment in POSIX

5 years agobump perl version to v5.24.0-RC2 v5.24.0-RC2
Ricardo Signes [Sat, 23 Apr 2016 17:51:26 +0000 (18:51 +0100)]
bump perl version to v5.24.0-RC2

5 years agocorelist: update Time::HiRes for v5.24.0
Ricardo Signes [Sat, 23 Apr 2016 17:38:01 +0000 (18:38 +0100)]
corelist: update Time::HiRes for v5.24.0

5 years agoSynchronize with CPAN Time-HiRes 1.9733
Jarkko Hietaniemi [Sat, 23 Apr 2016 16:21:41 +0000 (12:21 -0400)]
Synchronize with CPAN Time-HiRes 1.9733

5 years agolib/ Fix pod error.
Karl Williamson [Sat, 23 Apr 2016 15:47:41 +0000 (09:47 -0600)]
lib/ Fix pod error.

5 years agoApple Xcode / clang version updates and additions
Jarkko Hietaniemi [Sat, 23 Apr 2016 15:23:44 +0000 (11:23 -0400)]
Apple Xcode / clang version updates and additions

5 years agodarwin (OS X) hints comments alignment
Jarkko Hietaniemi [Sat, 23 Apr 2016 15:20:56 +0000 (11:20 -0400)]
darwin (OS X) hints comments alignment

(preparing for the next change)

5 years agoTime-HiRes version bump
Jarkko Hietaniemi [Sat, 23 Apr 2016 03:09:31 +0000 (23:09 -0400)]
Time-HiRes version bump

5 years ago[PATCH] Time-Hires: Fix declaration-after-statement error with darwin threads
Reini Urban [Mon, 18 Apr 2016 07:38:13 +0000 (09:38 +0200)]
[PATCH] Time-Hires: Fix declaration-after-statement error with darwin threads

rt #113856: the flag -Werror=declaration-after-statement is seemingly
not working for clang (in OS X, not yet tested elsewhere), but working
as intended for gcc.  Since the system cc for OS X is clang (via Apple),
this failure to fail has been masked.

To restate: without this patch the Time-HiRes does not build in OS X
with gcc under usethreads.

5 years agoRegenerate Configure and related parts after backports
Aaron Crane [Sat, 23 Apr 2016 11:17:59 +0000 (12:17 +0100)]
Regenerate Configure and related parts after backports

perl5.git is now in sync with metaconfig.git commit

5 years agoBring Configure back into sync again with meta
H.Merijn Brand [Fri, 22 Apr 2016 07:57:01 +0000 (09:57 +0200)]
Bring Configure back into sync again with meta

Work done at the QAH in Rugby.
Multi-thanks to Aaron for helping out here. You're doing a great job!

5 years agoAllow Encode to be built on static perls
Leon Timmermans [Fri, 25 Mar 2016 17:01:48 +0000 (18:01 +0100)]
Allow Encode to be built on static perls

Previously there were build failures because cp1252 was defined both
in the default set of encodings an in the byte set.

5 years agoRevert "document that sigs in future may not populate @_"
Ricardo Signes [Sat, 23 Apr 2016 10:50:24 +0000 (11:50 +0100)]
Revert "document that sigs in future may not populate @_"

This reverts commit 19d6c3854e96d89bf4dc2d874df433beac27ee8b.

5 years agoFix some pod errors
Karl Williamson [Fri, 22 Apr 2016 19:00:22 +0000 (13:00 -0600)]
Fix some pod errors

These were discovered while testing the Pod::Checker that is intended to
be used in 5.25.

5 years ago[perl #127936] fix typo
Tony Cook [Wed, 20 Apr 2016 00:49:23 +0000 (10:49 +1000)]
[perl #127936] fix typo

5 years agoperldelta for ab462c7d2d
Tony Cook [Wed, 20 Apr 2016 00:39:00 +0000 (10:39 +1000)]
perldelta for ab462c7d2d

5 years ago[perl #127894] ensure alignbytes is correct for -Dusequadmath
Dagfinn Ilmari Mannsåker [Wed, 20 Apr 2016 00:15:23 +0000 (10:15 +1000)]
[perl #127894] ensure alignbytes is correct for -Dusequadmath

5 years agoCorrect typo in JJORE's name in todo.pod.
Matthew Horsfall [Tue, 19 Apr 2016 20:58:44 +0000 (16:58 -0400)]
Correct typo in JJORE's name in todo.pod.

5 years agoAvoid passing non-literal to format function
Aaron Crane [Thu, 14 Apr 2016 10:23:12 +0000 (11:23 +0100)]
Avoid passing non-literal to format function

This avoids the following error, reported by Jitka Plesníková
<> in a test of RC1:

op.c: In function 'Perl_ck_ftst':
op.c:9754:58: error: format not a string literal and no format arguments [-Werror=format-security]
                 Perl_warner(aTHX_ packWARN(WARN_SYNTAX), array_passed_to_stat);

In addition, the string in question is now made const.

5 years agodocument that sigs in future may not populate @_
David Mitchell [Tue, 19 Apr 2016 11:57:50 +0000 (12:57 +0100)]
document that sigs in future may not populate @_

Give people a heads up that in the next major perl release, subroutine
signatures may no longer populate @_ by default.


5 years agoperldelta: Remove error/warning explanations
Karl Williamson [Tue, 19 Apr 2016 00:06:52 +0000 (18:06 -0600)]
perldelta: Remove error/warning explanations

Only the text of these should be present in a delta, with a link to the
full explanation.  Most of perldelta conformed to this, but not all.

5 years agoperldelta: Add some C<>
Karl Williamson [Tue, 19 Apr 2016 00:06:31 +0000 (18:06 -0600)]
perldelta: Add some C<>

5 years agoperldelta: Clarifications, corrections, wordsmithing
Karl Williamson [Tue, 19 Apr 2016 00:04:03 +0000 (18:04 -0600)]
perldelta: Clarifications, corrections, wordsmithing

I also removed one instance of a 5.23-only bug, which isn't relevant to
a dot zero delta

5 years agoAdd perldelta for d9fc04ee
Leon Timmermans [Mon, 18 Apr 2016 23:04:49 +0000 (01:04 +0200)]
Add perldelta for d9fc04ee

5 years agoperldelta: IO-Compress is a dist, no link possible
Ricardo Signes [Mon, 18 Apr 2016 22:59:06 +0000 (18:59 -0400)]
perldelta: IO-Compress is a dist, no link possible

5 years agoperldelta: generate the module update section
Ricardo Signes [Mon, 18 Apr 2016 21:59:03 +0000 (17:59 -0400)]
perldelta: generate the module update section

5 years agoperldelta: various fixes
Matthew Horsfall [Mon, 18 Apr 2016 21:41:53 +0000 (17:41 -0400)]
perldelta: various fixes

 * behaviour -> behavior
 * =over -> =over 4
 * Add =items for consistency
 * Capitalization fixes

5 years agoperldelta: Fix typo
Matthew Horsfall [Mon, 18 Apr 2016 21:22:27 +0000 (17:22 -0400)]
perldelta: Fix typo

5 years agoperldelta: Revise wording
Karl Williamson [Mon, 18 Apr 2016 17:18:41 +0000 (11:18 -0600)]
perldelta: Revise wording

Some of this was suggested by Jarkko Hietaniemi

5 years agoperldelta: Remove typo extra '/'
Karl Williamson [Thu, 14 Apr 2016 16:46:42 +0000 (10:46 -0600)]
perldelta: Remove typo extra '/'

This fixes the 5.24 part of [perl #127899].

5 years agoperldelta: minor tweak to fix awkward prose
Ricardo Signes [Thu, 14 Apr 2016 11:47:54 +0000 (07:47 -0400)]
perldelta: minor tweak to fix awkward prose

(Thanks, Ed Avis!)

5 years agopatchlevel: we are now RC1 v5.24.0-RC1
Ricardo Signes [Thu, 14 Apr 2016 02:16:10 +0000 (22:16 -0400)]
patchlevel: we are now RC1

5 years agoremove the v5.23.x perldeltas
Ricardo Signes [Thu, 14 Apr 2016 02:02:23 +0000 (22:02 -0400)]
remove the v5.23.x perldeltas

5 years agoperlpolicy: update the supported versions for v5.24 on
Ricardo Signes [Thu, 14 Apr 2016 01:59:39 +0000 (21:59 -0400)]
perlpolicy: update the supported versions for v5.24 on

5 years agoperlhist: add v5.24.0 data
Ricardo Signes [Thu, 14 Apr 2016 01:54:27 +0000 (21:54 -0400)]
perlhist: add v5.24.0 data

5 years agocorelist: set a (tentative) release date for 5.24.0
Ricardo Signes [Thu, 14 Apr 2016 01:46:28 +0000 (21:46 -0400)]
corelist: set a (tentative) release date for 5.24.0

5 years agofix IO::Handle documentation mangled by a manually applied patch
Tony Cook [Tue, 12 Apr 2016 23:39:27 +0000 (09:39 +1000)]
fix IO::Handle documentation mangled by a manually applied patch

5 years agoperllocale: Unicode has changed their data; fix references
Karl Williamson [Tue, 12 Apr 2016 19:50:12 +0000 (13:50 -0600)]
perllocale: Unicode has changed their data; fix references

We say something here that is no longer true; update it.

5 years agoperldelta: Some minor fixes.
Karl Williamson [Tue, 12 Apr 2016 19:37:21 +0000 (13:37 -0600)]
perldelta: Some minor fixes.

This includes deleting some bug fixes for things introduced in the 5.23
series, and so not relevant to a dot zero perldelta

5 years agopod/perldelta: Fixes to pedantic failures
Karl Williamson [Tue, 12 Apr 2016 19:13:56 +0000 (13:13 -0600)]
pod/perldelta: Fixes to pedantic failures

5 years agoperldelta: Add note about recent doc change
Karl Williamson [Tue, 12 Apr 2016 18:55:21 +0000 (12:55 -0600)]
perldelta: Add note about recent doc change

5 years agoMerge branch 'release-5.24' into blead
Ricardo Signes [Mon, 11 Apr 2016 00:49:39 +0000 (20:49 -0400)]
Merge branch 'release-5.24' into blead

This commit is just prep, turning blead into the branch from which
v5.24.0 will be released, after suitable testing.

5 years agoCoreList: update for v5.24.0
Ricardo Signes [Thu, 7 Apr 2016 13:33:41 +0000 (09:33 -0400)]
CoreList: update for v5.24.0

5 years agofix versions of generated perldelta
Ricardo Signes [Thu, 7 Apr 2016 12:47:52 +0000 (08:47 -0400)]
fix versions of generated perldelta

5 years agoput perl5240delta into place
Ricardo Signes [Thu, 7 Apr 2016 12:39:20 +0000 (08:39 -0400)]
put perl5240delta into place

5 years agoregen META.json for v5.24.0-RC
Ricardo Signes [Thu, 7 Apr 2016 12:37:06 +0000 (08:37 -0400)]
regen META.json for v5.24.0-RC

5 years agoregen: B::Op_private and uconfig.h
Ricardo Signes [Thu, 7 Apr 2016 12:28:18 +0000 (08:28 -0400)]
regen: B::Op_private and uconfig.h

5 years agoversion bump: this is now v5.24.0-RC0!
Ricardo Signes [Thu, 7 Apr 2016 12:27:26 +0000 (08:27 -0400)]
version bump: this is now v5.24.0-RC0!

5 years agoperldelta: merge in perl5239delta
Ricardo Signes [Thu, 7 Apr 2016 12:20:49 +0000 (08:20 -0400)]
perldelta: merge in perl5239delta

5 years agoperldelta: remove unneeded entries, do more merge and sort
Ricardo Signes [Mon, 14 Mar 2016 00:17:10 +0000 (20:17 -0400)]
perldelta: remove unneeded entries, do more merge and sort

5 years agoperldelta: merge in changes from perl5238delta
Ricardo Signes [Sun, 13 Mar 2016 23:22:56 +0000 (19:22 -0400)]
perldelta: merge in changes from perl5238delta

5 years agoperldelta: merge in changes from perl5237delta
Ricardo Signes [Sun, 13 Mar 2016 22:36:39 +0000 (18:36 -0400)]
perldelta: merge in changes from perl5237delta

5 years agoperldelta: merge in changes from perl5236delta
Ricardo Signes [Sun, 13 Mar 2016 22:27:34 +0000 (18:27 -0400)]
perldelta: merge in changes from perl5236delta

5 years agoperldelta: merge in changes from perl5235delta
Ricardo Signes [Fri, 11 Mar 2016 01:03:27 +0000 (20:03 -0500)]
perldelta: merge in changes from perl5235delta

5 years agoperldelta: merge in changes from perl5234delta
Ricardo Signes [Fri, 11 Mar 2016 00:50:06 +0000 (19:50 -0500)]
perldelta: merge in changes from perl5234delta

5 years agoperldelta: merge in changes from perl5233delta
Ricardo Signes [Fri, 11 Mar 2016 00:30:11 +0000 (19:30 -0500)]
perldelta: merge in changes from perl5233delta

5 years agoperldelta: merge in changes from perl5232delta
Ricardo Signes [Fri, 11 Mar 2016 00:24:33 +0000 (19:24 -0500)]
perldelta: merge in changes from perl5232delta

5 years agoperldelta: merge in changes from perl5231delta
Ricardo Signes [Fri, 11 Mar 2016 00:19:43 +0000 (19:19 -0500)]
perldelta: merge in changes from perl5231delta

5 years agoperldelta: bootstrap perl5240delta with perl5230delta
Ricardo Signes [Fri, 11 Mar 2016 00:12:50 +0000 (19:12 -0500)]
perldelta: bootstrap perl5240delta with perl5230delta

5 years agoAdd 5.22.2-RC1 epigraph
Steve Hay [Sun, 10 Apr 2016 17:44:59 +0000 (18:44 +0100)]
Add 5.22.2-RC1 epigraph

5 years ago5.22.2-RC1 today
Steve Hay [Sun, 10 Apr 2016 13:11:23 +0000 (14:11 +0100)]
5.22.2-RC1 today

5 years agoPATCH: [perl #127708] segfault in "$!" in threads
Karl Williamson [Sat, 9 Apr 2016 17:55:58 +0000 (11:55 -0600)]
PATCH: [perl #127708] segfault in "$!" in threads

This was showing up on Darwin because its setlocale is particularly not
thread safe.  But the problem is more generic.  Using locales just
isn't a good idea in a threaded application, as locales are
process-wide, not thread-specific.  Calling setlocale() changes the
locale of all threads at the same time.  Further the return of
setlocale() is a pointer to internal storage.  If you call setlocale()
just to learn what it currently is without actually changing the locale,
there is no guarantee that another thread won't interrupt your thread,
switching the locale to something else before you've had a chance to
copy it somewhere else for safekeeping, and the internal storage may
have been freed during that interruption, leading to things like

This is a problem that has been around in the locale handling code for a
long time.  I don't know why it hasn't shown up before, or maybe it has
and is not reproducible because it's timing dependent, and so any
problems didn't have tickets written for them, or were rejected as not

But the problem has been made worse in recent releases.  Only fairly
recently has perl changed so this problem can occur in programs that
don't use locale explicitly: ones that don't 'use locale' nor call
setlocale().  This ticket is for such a program that gets a
locale-related segfault, without ever touching locales itself.

I have done an audit of the perl source, looking for all such
occurrences, and this patch fixes all of them that I found.  The only
other ones, besides "$!", is in converting to/from UTF-8 in cygwin.c.
In all such cases, perl briefly switches the locale, does an operation,
then switches back.  The solution here is to add mutexes to make these
areas of code uninterruptible critical sections, so that they can rely
on having the locale be what they expect it to be during the entirety of
the operation, and can't have a setlocale() from another thread free
internal storage.  But this is not a general solution.  A thread
executing these sections can interrupt some other thread doing a
setlocale() and zap that.  However, we have long cautioned against doing
setlocales() in a thread, and that caution was strengthened in a commit
made yesterday, fc82b82ef4784a38877f35f56ee16f14934460ce.

The current commit should make safe all threaded programs that don't use
locales explicitly.

It's too close to the 5.24 release to do the rearchitecting required for
a general solution.  That would involve adding more critical sections.

POSIX 2008 introduced new locale handling functions that are
thread-safe, and affect only a single thread, and don't require mutexes.
The ultimate solution would be to use those tools where available, and
to hide from the outer code which set is being used.  Thus, perl would
be thread-safe on such platforms, while remaining problematic on older
ones, though fixed so segfaults wouldn't occur.  Tony Cook believes we
could emulate the newer behavior on all platforms at a significant
performance penalty.  I think this would require a lot of code, and
suspect there would be glitches in it for XS code.  But he may have
some ideas about how to do it simply.  In any case, this has to wait
until post 5.24.

Three other notes:

It seems to me that the cygwin code could be replaced by equivalent code
that doesn't use locales at all.  The comments in the source seem to
even indicate that.  I'll look into doing this in 5.25.

Another possible reason that this hasn't shown up in earlier perls is
that the problems may have been entirely affecting I/O operations and
there are already mutexes involving I/O, and so those could be
inadvertently protecting from, or at least minimizing, the problems
found here.  I haven't investigated to verify this.

This commit doesn't add a test.  I am asking on p5p for assistance in
writing one

5 years agoAdd locale mutex
Karl Williamson [Thu, 7 Apr 2016 03:46:28 +0000 (21:46 -0600)]
Add locale mutex

This adds a new mutex for use in the next commit for use with locale

5 years agomove perf test from re/pat.t to re/speed.t
David Mitchell [Sat, 9 Apr 2016 15:43:20 +0000 (16:43 +0100)]
move perf test from re/pat.t to re/speed.t

These days we generally put re tests which rely on timing in a separate
file, t/re/speed.t; move a recently-added test there.

5 years agonew perf test in pat.t: avoid timing failure
David Mitchell [Sat, 9 Apr 2016 12:17:21 +0000 (13:17 +0100)]
new perf test in pat.t: avoid timing failure

A new performance test in re/pat.t added by v5.23.9-58-gd14d585 could
occasionally fails to a timing issue. It was checking that the the
test took less than 1 sec to run; but since the clock usually has a
granularity of 1 sec, it could fail if the test ran over a tick boundary.

Change the condition to <= 1 sec, and increase the time the test takes on
a bad perl - it was taking 4sec on my system; it now takes about 14sec,
so there's less chance of a bad perl passing.

5 years agoStrengthen cautions about locale use with threads
Karl Williamson [Fri, 8 Apr 2016 19:46:44 +0000 (13:46 -0600)]
Strengthen cautions about locale use with threads

This comes from our increased understanding of their perils, given
ticket #127708

5 years agoMore generalized fix for #127855, overallocate in SvGROW and not just sv_grow()
Yves Orton [Fri, 8 Apr 2016 19:25:20 +0000 (21:25 +0200)]
More generalized fix for #127855, overallocate in SvGROW and not just sv_grow()

If we overallocate in SvGROW() and not just sv_grow() we can ensure
we have more cases where we can COW. We need to ensure we always
have room for a null and a reference count.

5 years agofix #127855, in Perl_sv_setpvn() we have to overallocate to enable COW
Yves Orton [Fri, 8 Apr 2016 18:46:43 +0000 (20:46 +0200)]
fix #127855, in Perl_sv_setpvn() we have to overallocate to enable COW

We need to overallocate by 2 to do COW strings. One for the null,
one for the refcount.

5 years agotest for #127855 - Slowdown in m//g on COW strings of certain lengths
Yves Orton [Fri, 8 Apr 2016 19:17:34 +0000 (21:17 +0200)]
test for #127855 - Slowdown in m//g on COW strings of certain lengths

5 years agoRevert "Make instr() a macro"
Karl Williamson [Fri, 8 Apr 2016 18:21:24 +0000 (12:21 -0600)]
Revert "Make instr() a macro"

This reverts commit fea1d2dd5d210564d442a09fe034b62f262f35f9 due to it
causing problems so close to the release of 5.24.  See

5 years agoupdate security contact information.
David Mitchell [Fri, 8 Apr 2016 10:14:10 +0000 (11:14 +0100)]
update security contact information.

Point out that the security-reporting email address now creates an RT
ticket. Also, consolidate this information purely within perlsec.pod, and
make all the other places link to it with L<>.

5 years agoAdd another missing link to epigraphs.pod
Steve Hay [Thu, 7 Apr 2016 12:18:45 +0000 (13:18 +0100)]
Add another missing link to epigraphs.pod

5 years ago(perl #126162) improve stat @array handling
Tony Cook [Thu, 31 Mar 2016 00:18:53 +0000 (11:18 +1100)]
(perl #126162) improve stat @array handling

- warn on lexical arrays too

- limit the warning to under C<use warnings 'syntax';>

- test the warnings

- include the (correct) variable name where possible

5 years agoerror messages vary between platforms, use errno values instead
Tony Cook [Wed, 30 Mar 2016 23:40:25 +0000 (10:40 +1100)]
error messages vary between platforms, use errno values instead

5 years agoadd the new stat(@array) diagnostic to perldiag
Tony Cook [Wed, 30 Mar 2016 05:48:40 +0000 (16:48 +1100)]
add the new stat(@array) diagnostic to perldiag

5 years ago(perl #126162) warn if stat() is called on an array
Dan Collins [Wed, 30 Mar 2016 05:42:39 +0000 (16:42 +1100)]
(perl #126162) warn if stat() is called on an array

5 years ago5.22.2 should appear this month, starting with RC1 on Sunday 10th
Steve Hay [Thu, 7 Apr 2016 08:01:30 +0000 (09:01 +0100)]
5.22.2 should appear this month, starting with RC1 on Sunday 10th

5 years agoAdd SILENT_NO_TAINT_SUPPORT to S_Internals_V ()
Yves Orton [Wed, 6 Apr 2016 09:33:15 +0000 (11:33 +0200)]

NO_TAINT_SUPPORT was added in 3b0e4ee2077, but SILENT_NO_TAINT_SUPPORT was overlooked.

5 years agoGet -Accflags=-DPERL_MEM_LOG compiling again
Matthew Horsfall [Fri, 1 Apr 2016 16:44:49 +0000 (12:44 -0400)]
Get -Accflags=-DPERL_MEM_LOG compiling again

It had rotted a bit Well, more than one probably.

Move the declarations of the functions Perl_mem_log_alloc etc from handy.h
into embed.fnc where whey belong, and where Malloc_t will have already
been defined.

5 years agoss_dup: make new savestack have SS_MAXPUSH extra
David Mitchell [Tue, 5 Apr 2016 08:26:21 +0000 (09:26 +0100)]
ss_dup: make new savestack have SS_MAXPUSH extra

This fixes RT #perl #127799

My commit v5.23.7-261-g3caf026 made PL_savestack_max claim to have
allocated less than had actually been claimed (by a margin of SS_MAXPUSH).
This made the 'check whether the stack needs extending code' slightly
simpler, and errs on the side of safety. Except:

Perl_ss_dup(), when duplicating the savestack, makes the new stack
PL_savestack_max in size, which is large enough to duplicate the existing
stack, but the new stack no longer has a SS_MAXPUSH margin at the top.

The dSS_ADD family of macros work by assuming there is always such a
margin: they push their args onto the stack and only then check whether
the stack needs growing. This makes the code much more efficient, but of
course breaks if no margin is present.

5 years agoFollow-up to previous Solaris/S_regmatch commit
David Mitchell [Mon, 4 Apr 2016 13:51:40 +0000 (14:51 +0100)]
Follow-up to previous Solaris/S_regmatch commit

PL_charclass is the thing being temporarily #defined to something else, so
it's the thing that needs #undeffing at the end, not pl_charclass_dup.

Doesn't make any difference at the moment, but would if at some point
a function following S_regmatch() started making use of PL_charclass.

5 years agoS_regmatch(): work around Solaris optimiser bug
David Mitchell [Mon, 4 Apr 2016 12:27:35 +0000 (13:27 +0100)]
S_regmatch(): work around Solaris optimiser bug

Recently these test scripts started failing on Solaris i386 with


The first failure is due to a Solaris Studio optimiser bug; this commit
works around that failure. It may or may not also fix the other failures
(all tests pass now on the development box I was using, but I didn't
confirm whether the other tests failed before the fix).

The basic problem is that within the main while loop in S_regmatch(),
the expression PL_charclass['\n'] returns the wrong value.

Looking at the disassembled code, it appears that looking up this value
just before the while loop correctly does it by getting the address of the
global array PL_charclass, adding 40 to it (ord('\n')*sizeof(U32)), then
dereffing it.

Within the loop however, it just reads the value from a local var. The
optimiser is under the misapprehension that this value has previously been
read in and assigned to a local var, but it certainly hasn't been at the
point where the while loop is first entered.

This commit works round the problem on builds with -Duse64bitall and the
bad version of Solaris Studio compiler (12.3), by making a copy of
PL_charclass's address.

This is a bit of hack. For one thing, I don't know whether other versions
of the compiler also need this workaround.

The failures were seen on a 32-bit system with -Duse64bitall: this created
a 64-bit executable (i.e. with 64-bit pointers) with the -m64 compiler
flag. I would speculate that the bug in the compiler relates to to
this particular circumstance (i.e. the bug might not appear for a build
done on a 64-bit OS host with or without -Duse64bitall).

5 years agoepigraphs.pod - Add missing link, plus minor formatting corrections
Steve Hay [Mon, 4 Apr 2016 12:35:55 +0000 (13:35 +0100)]
epigraphs.pod - Add missing link, plus minor formatting corrections