This is a live mirror of the Perl 5 development currently hosted at
10 years agoFix up vms/vms.c for C++.
Craig A. Berry [Thu, 24 May 2012 21:54:28 +0000 (16:54 -0500)]
Fix up vms/vms.c for C++.

Almost all of this consists of casting the return values from
PerlMem_malloc, which inexpicably we weren't doing.

There are also some prototypes that have to be at file scope and
declare with extern "C".

And there was some embarrassing dead code in Perl_my_localtime
that the C++ compiler spotted.

10 years agoUse the (START|END)_EXTERN_C macros.
Craig A. Berry [Thu, 24 May 2012 18:35:34 +0000 (13:35 -0500)]
Use the (START|END)_EXTERN_C macros.

We seem to use them everywhere else in core.

10 years agohandy.h: Fix definition of isOCTAL_A()
Karl Williamson [Thu, 24 May 2012 17:18:03 +0000 (11:18 -0600)]
handy.h: Fix definition of isOCTAL_A()

Commit  c2da0b36ccf7393a329af732fac4153ddf6ab42e changed this macro, and
created a syntax error.  But it turns out that there were no current
calls to it in the Perl core.  When I tried adding one, it showed the

10 years agoThe reentrant API should always have prototypes.
Craig A. Berry [Sun, 6 May 2012 20:09:07 +0000 (15:09 -0500)]
The reentrant API should always have prototypes.

reentr.c always defines and exports its functions even when
USE_REENTRANT_API is not defined (though they'll be empty functions
in that case).  In general we shouldn't be exporting functions
without providing prototypes for them, but specifically, when
compiling with C++, the prototype-less functions get their names
mangled.  So the purpose of defining the functions when we aren't
using them (to have a consistent API) is defeated because no one
looking for those functions under their proper names would be able
to find them.

So this makes us stop hiding the prototypes when USE_REENTRANT_API
is not defined.

10 years agoUnmangle mathoms under C++.
Craig A. Berry [Sun, 6 May 2012 13:50:43 +0000 (08:50 -0500)]
Unmangle mathoms under C++.

In order to actually provide binary compatibility, we have to
serve up these functions under the names they were known by
before making their way into mathoms.c.  We've always done that
under C, but not C++.

10 years ago[perl #112786] Fix build under clang++
Craig A. Berry [Thu, 24 May 2012 07:54:57 +0000 (00:54 -0700)]
[perl #112786] Fix build under clang++

A line of code in sv.c last modified at
causes clang++ to fall down hard when building blead:

sv.c:13969:32: error: unexpected ':' in nested name specifier
        CV * const cv = gv ? (CV *)gv : find_runcv(NULL);
sv.c:13969:34: error: no member named 'Perl_find_runcv' in 'gv'
        CV * const cv = gv ? (CV *)gv : find_runcv(NULL);
                                   ~~~~ ^
./embed.h:137:24: note: expanded from macro 'find_runcv'
#define find_runcv(a)           Perl_find_runcv(aTHX_ a)
sv.c:13969:50: error: expected ':'
        CV * const cv = gv ? (CV *)gv : find_runcv(NULL);
sv.c:13969:21: note: to match this '?'
        CV * const cv = gv ? (CV *)gv : find_runcv(NULL);
sv.c:13969:50: error: expected expression
        CV * const cv = gv ? (CV *)gv : find_runcv(NULL);
14 warnings and 4 errors generated.
make: *** [sv.o] Error 1

clang++ seems to need only an extra set of parentheses to calm down
and let go of its anxieties.

[Committer’s note: Leon Timmermans points out that it's struct gv
that's confusing clang++.  So a struct name used as a variable cannot
be followed by a colon.]

10 years agoAdd perldelta for Unicode CCC132 fix
Karl Williamson [Thu, 24 May 2012 02:30:17 +0000 (20:30 -0600)]
Add perldelta for Unicode CCC132 fix

10 years agoAdd another address for Ronald Kimball to
Father Chrysostomos [Thu, 24 May 2012 01:19:56 +0000 (18:19 -0700)]
Add another address for Ronald Kimball to

10 years ago[perl #112604] perlre man page contains suspect example of recursion
Ronald J Kimball [Thu, 24 May 2012 01:17:16 +0000 (18:17 -0700)]
[perl #112604] perlre man page contains suspect example of recursion

Jim Avera wrote:
> This seems incorrect because the \s++ eats all white space without
> backtracking, preventing the following \s+ from matching.
> Thus the pattern always fails for any input.

It should be \s+ \+ \s+

10 years ago[perl #112522] Mildly incorrect wording in "perldoc perlre"
Aristotle Pagaltzis [Thu, 24 May 2012 01:12:43 +0000 (18:12 -0700)]
[perl #112522] Mildly incorrect wording in "perldoc perlre"

10 years ago[perl #60204] Unhelpful error message from unpack
Marcus Holland-Moritz [Wed, 23 May 2012 21:50:31 +0000 (14:50 -0700)]
[perl #60204] Unhelpful error message from unpack

Nigel Sandever said:
> The error message produced by the following snippets is very unhelpful:
> c:\>perl -wle"print unpack 'v/a*', qq[a]"
> '/' must follow a numeric type in unpack at -e line 1.
> c:\>perl -wle"print unpack 'v/a*', ''"
> '/' must follow a numeric type in unpack at -e line 1.
> c:\>perl -wle"print unpack 'v/a*', ' '"
> '/' must follow a numeric type in unpack at -e line 1.

The "problem" is that the data string is too short. But
unpack doesn't generate a warning (or croak) in this case
for simple patterns:

mhx@r2d2 $ perl -MData::Dumper -we'print Dumper([unpack "n", "a"])'
$VAR1 = [];

So, I'd say your code should just behave in exactly the
same way. No warning, no return values.

10 years agoCorrect perldelta entry for fallback entry
Father Chrysostomos [Wed, 23 May 2012 20:42:09 +0000 (13:42 -0700)]
Correct perldelta entry for fallback entry

10 years agoperldelta for PL_amagic_generation removal
Father Chrysostomos [Wed, 23 May 2012 20:17:17 +0000 (13:17 -0700)]
perldelta for PL_amagic_generation removal

10 years agomktables: Handle typo in Unicode 6.1 data file
Karl Williamson [Wed, 23 May 2012 23:14:36 +0000 (17:14 -0600)]
mktables: Handle typo in Unicode 6.1 data file

Unicode has published a correction to their data files for version 6.1.
This patch applies that correction.

10 years agoRevert "Fix mktables bug due to the previous overload fix"
Karl Williamson [Wed, 23 May 2012 23:01:11 +0000 (17:01 -0600)]
Revert "Fix mktables bug due to the previous overload fix"

mktables had unknowingly been relying on a bug in the overloading code.
That bug was fixed by commit f041cf0f9c6469c41de8b73d5f7b426710c3ff8b.
Commit 5f9f83be9cdcd54449f7f40db078fe367d780475 is a minimal commit to
get mktables to pass its tests as a result of the fixed bug.  However,
it did not address the underlying problem, which doesn't show up in the
typical tests, but does occur when tracing is added or things go wrong
and mktables tries to output any of a number of messages, which fail
because there is no ".=" operator.  A previous commit added the proper
overloaded ".=", and so this one is no longer needed, and would be
confusing to someone who doesn't know the history.

10 years agomktables: Add sanity check
Karl Williamson [Thu, 19 Apr 2012 18:25:08 +0000 (12:25 -0600)]
mktables: Add sanity check

Since mktables works only on Unicode code points so far, a range outside
that space is probably erroneous.  Raise a warning

10 years agomktables: Add overloaded .=
Karl Williamson [Mon, 16 Apr 2012 17:32:43 +0000 (11:32 -0600)]
mktables: Add overloaded .=

This was automatically getting generated due to a bug in perl which
ignored fallback=>0, but that has been fixed by commit
f041cf0f9c6469c41de8b73d5f7b426710c3ff8b, so we have to have our own

10 years agomktables: Add error check
Karl Williamson [Mon, 16 Apr 2012 17:31:50 +0000 (11:31 -0600)]
mktables: Add error check

+= is not a commutative operator, and so the overloaded version should
not accept the parameters being swapped.

10 years agomktables: Add overloaded '+='
Karl Williamson [Mon, 16 Apr 2012 17:28:20 +0000 (11:28 -0600)]
mktables: Add overloaded '+='

This was automatically generated before, in spite of fallback => 0, but
that has now been fixed by commit
f041cf0f9c6469c41de8b73d5f7b426710c3ff8b.  However, that change caused
another overloaded += to be used with the parameters swapped, resulting
in the table generated for Gc=Cs (the surrogates) to be wrong.  This
creates the proper overload.

10 years agopodcheck.t: Try harder to avoid transitory failure
Karl Williamson [Tue, 27 Mar 2012 04:20:59 +0000 (22:20 -0600)]
podcheck.t: Try harder to avoid transitory failure

It may be that a file that looks like a pod is transitory.  podcheck.t
catches and handles some of these, but there are cases where it doesn't
catch these.  This commit adds code to try harder to detect such
instances and recover properly.

I know of two instances in the months since this code has been in
service where this has happened, so it's not a common occurrence, and
re-running it makes the failure go away.  Still, if it can be easily
avoided, do so.

10 years agopodcheck.t: Add label to 'next' stmts for clarity
Karl Williamson [Tue, 27 Mar 2012 04:18:01 +0000 (22:18 -0600)]
podcheck.t: Add label to 'next' stmts for clarity

10 years agoMerge branch 'rgs/overload' into blead
Rafael Garcia-Suarez [Wed, 23 May 2012 13:53:31 +0000 (15:53 +0200)]
Merge branch 'rgs/overload' into blead

10 years ago[perl #113050] Put fallback back under "()"
Father Chrysostomos [Wed, 23 May 2012 08:05:20 +0000 (01:05 -0700)]
[perl #113050] Put fallback back under "()"

Unfortunately, there is code all over CPAN that assumes fallback is
stored under the "()" stash entry.  And that code also assumes that
the overloadedness flag (the existence of the CV) is in the same spot.
So much for encapsulation.

This commit changes overloading itself to use a different key, "((",
while having it search for "()" first, and then "((" only if "()" is
not found, to preserve compatibility with encapsulation-breaking code.

So the "((" key will only be used by gv.c if there is no fallback
value specified at all.

10 years agoIncrease $ExtUtils::ParseXS::Utilities::VERSION to 3.17
Father Chrysostomos [Wed, 23 May 2012 06:54:39 +0000 (23:54 -0700)]
Increase $ExtUtils::ParseXS::Utilities::VERSION to 3.17

10 years agoIncrease $ExtUtils::ParseXS::VERSION to 3.17
Father Chrysostomos [Wed, 23 May 2012 05:46:27 +0000 (22:46 -0700)]
Increase $ExtUtils::ParseXS::VERSION to 3.17

10 years Only inc PL_amagic_generation before 5.9
Father Chrysostomos [Wed, 23 May 2012 05:46:05 +0000 (22:46 -0700)] Only inc PL_amagic_generation before 5.9

Originally, overload would not oven be checked for if
amagic_generation was 0, so it was necessary to do
PL_amagic_generation++, in case this was the first class to have over-
loading.  Ever since perl-5.8.0-87-g439cb1c, PL_amagic_generation++
has been unnecessary, since the boot code for version objects incre-
ments it.  Furthermore, newXS was already doing PL_sub_generation++
before that, and now does mro_method_changed_in.  The code for check-
ing the staleness of the overload tables has always checked
sub_generation (and, later, the stash-specific generation numbers).

10 years agoExcise PL_amagic_generation
Father Chrysostomos [Wed, 23 May 2012 05:22:32 +0000 (22:22 -0700)]
Excise PL_amagic_generation

The core is not using it any more.  Every CPAN module that increments
it also does newXS, which triggers mro_method_changed_in, which is
sufficient; so nothing will break.

So, to keep those modules compiling, PL_amagic_generation is now an
alias to PL_na outside the core.

10 years agoop.c: One less func call for newXS
Father Chrysostomos [Wed, 23 May 2012 03:46:52 +0000 (20:46 -0700)]
op.c: One less func call for newXS

newXS calls newXS_flags, which calls newXS_len_flags.  This commit
makes newXS call the underlying function directly.

10 years agoperlfunc: long lines
Father Chrysostomos [Wed, 23 May 2012 03:41:12 +0000 (20:41 -0700)]
perlfunc: long lines

10 years agoAdd Igor Zaytsev to AUTHORS
Father Chrysostomos [Wed, 23 May 2012 03:10:47 +0000 (20:10 -0700)]
Add Igor Zaytsev to AUTHORS

10 years ago[perl #111918] Fix thawing seen objects in STORABLE_attach hook
Igor Zaytsev [Wed, 23 May 2012 01:02:02 +0000 (18:02 -0700)]
[perl #111918] Fix thawing seen objects in STORABLE_attach hook

Before any thaw hook is called Storable creates a new blessed object that
is stored in a seen cache and then is provided to the hook. That is fine
for STORABLE_thaw which fills in this object and returns it. STORABLE_attach
on the other hand can create entirely new object by itself, so one
memoized before should be thrown out to be replaced by that new object.

10 years agoMake CV * typemap entry support overloading
Steffen Mueller [Tue, 22 May 2012 21:04:06 +0000 (23:04 +0200)]
Make CV * typemap entry support overloading

See RT #96872.

10 years agoPurported equivalency isn't.
Eric Brine [Tue, 22 May 2012 19:29:48 +0000 (15:29 -0400)]
Purported equivalency isn't.

10 years agoreplace B::COP::stashflags by B::COP::stashlen
Reini Urban [Tue, 22 May 2012 15:57:03 +0000 (10:57 -0500)]
replace B::COP::stashflags by B::COP::stashlen

6379d4a9a (between 5.15.9 and 5.16.0) broke B::COP::stashflags which was added
in 5.15.4.

10 years agoFix mktables bug due to the previous overload fix
Rafael Garcia-Suarez [Tue, 22 May 2012 15:23:20 +0000 (17:23 +0200)]
Fix mktables bug due to the previous overload fix

Due to the previous patch, perl can't generate the operator for .= in
package Property anymore (because fallback is '0' in that package), so
we need to work around that; this patch implements the least intrusive
workaround possible.

10 years agorefactor macro to avoid compiler warning in regcomp.c
Robin Barker (via RT) [Thu, 1 Mar 2012 15:20:33 +0000 (07:20 -0800)]
refactor macro to avoid compiler warning in regcomp.c

The compiler warning in regcomp.c (as noted in recent comment)
can be avoided by refactoring DO_POSIX_LATIN1_ONLY_KNOWN
to separate the case where sourcelist==l1_sourcelist

The committer changed the name of the new macro so he could understand
it better, and added a couple comments

10 years agoperlebcdic: make verbatim line fit in 79 cols
Karl Williamson [Mon, 21 May 2012 03:45:15 +0000 (21:45 -0600)]
perlebcdic: make verbatim line fit in 79 cols

10 years agoregen/ Fail if inversion list not found
Karl Williamson [Sun, 20 May 2012 22:22:44 +0000 (16:22 -0600)]
regen/ Fail if inversion list not found

This is instead of silently returning nothing.

10 years agoperlebcdic: Narrow table to fit in 79 columns
Karl Williamson [Sun, 20 May 2012 21:52:13 +0000 (15:52 -0600)]
perlebcdic: Narrow table to fit in 79 columns

This uses the abbreviations for control characters available officially
in Unicode 6.1, instead of the much longer names, thus enabling this
table to be narrowed.  With some space changes, it will fit in 79
columns.  The differences look large, but most go away under 'diff -b'.

The recipes are changed to correspond.

10 years agoperlebcdic: Add a few commas for clarity
Karl Williamson [Sun, 20 May 2012 21:50:25 +0000 (15:50 -0600)]
perlebcdic: Add a few commas for clarity

10 years agoperlebcdic: remove trailing white space
Karl Williamson [Sun, 20 May 2012 21:47:32 +0000 (15:47 -0600)]
perlebcdic: remove trailing white space

10 years agoregcomp.c: #define shorter synonym
Karl Williamson [Sun, 20 May 2012 14:55:08 +0000 (08:55 -0600)]
regcomp.c: #define shorter synonym

The longer name is used to discourage XS writers from using this public
defined value, but is unwieldy.  It is clearer to create a shorter
synonym for it.

10 years agohandy.h: New defn of isOCTAL_A() to free up bit
Karl Williamson [Sun, 20 May 2012 13:55:51 +0000 (07:55 -0600)]
handy.h: New defn of isOCTAL_A() to free up bit

The new definition is likely slightly faster, as it replaces an array
lookup with a mask.

Comments are also added, listing the other possible candidates for this
treatment, though the speed differential is unclear as they would also
add an extra test.

A U32 is used to store the information about the various properties for
a character.  This frees up one bit of that for future other use.

10 years agoutf8.c: Add nomix-ASCII option to to_fold functions
Karl Williamson [Sun, 6 May 2012 15:28:01 +0000 (09:28 -0600)]
utf8.c: Add nomix-ASCII option to to_fold functions

Under /iaa regex matching, folds that cross the ASCII/non-ASCII
boundary are prohibited.  This changes _to_uni_fold_flags() and
_to_utf8_fold_flags() functions to take a new flag which, when set,
tells them to not accept such folds.

This allows us to later move the intelligence for handling this
situation to these centralized functions.

10 years agoutf8.c: Add assertion
Karl Williamson [Sun, 6 May 2012 15:12:19 +0000 (09:12 -0600)]
utf8.c: Add assertion

10 years agoregexec.c: Use foldcase instead of lower/upper
Karl Williamson [Sun, 29 Apr 2012 15:33:19 +0000 (09:33 -0600)]
regexec.c: Use foldcase instead of lower/upper

The way Perl deals with folds of ASCII-range characters, is to have an
array that maps to the opposite case character.  For example, fold[a] is
A, and fold[A] is a.  To see if a character matches a pattern character
case-insensitively, you compare it against the pattern character itself,
and if that fails, against the fold[pattern character].

Unfortunately that breaks down outside of ASCII, where the folds are not
necessarily one-to-one.  This code is a vestige of that original
paradim, and I'm converting it to use the more modern.  The apparent
reason it doesn't fail in fold_grind.t is that it is for CURLY nodes,
and CURLY is not currently set on EXACTish nodes unless the node
contains a single UTF-8 invariant character.   Effectively, that means
a character in the ASCII range.

I think parts of this could be simplified further, but I don't
understand the whole context of this code to undertake that.

10 years agoutf8.c: Re-order if branches for speed
Karl Williamson [Sun, 29 Apr 2012 15:26:36 +0000 (09:26 -0600)]
utf8.c: Re-order if branches for speed

Probably the C optimizer does this anyway, but do the uncomplicated test
before the (mutually exclusive) complicated test (though the
complications are hidden in a macro).  The new first test is a
pre-requisite for the new 2nd test anyway.

10 years agoregcomp.c: Wrap long comment to 80 columns
Karl Williamson [Sun, 29 Apr 2012 15:26:06 +0000 (09:26 -0600)]
regcomp.c: Wrap long comment to 80 columns

10 years agopp_pack.c: Use macro instead of its expansion
Karl Williamson [Sun, 29 Apr 2012 01:49:06 +0000 (19:49 -0600)]
pp_pack.c: Use macro instead of its expansion

There is a macro that means this code; use it.

10 years agoregexec.c: Don't allow malformations under EBCDIC
Karl Williamson [Sun, 29 Apr 2012 01:36:53 +0000 (19:36 -0600)]
regexec.c: Don't allow malformations under EBCDIC

Previously, only under EBCDIC, malformed input was allowed here if
warnings are off.  This code probably needs to be rewritten, to do
proper folding, but I am not up to that right now.

10 years agoutf8.c: Add comment
Karl Williamson [Sun, 29 Apr 2012 01:29:04 +0000 (19:29 -0600)]
utf8.c: Add comment

10 years agoutf8n_to_uvuni(): Add a few compiler hints
Karl Williamson [Sun, 29 Apr 2012 01:25:40 +0000 (19:25 -0600)]
utf8n_to_uvuni(): Add a few compiler hints

Tell the compiler that malformed input is not likely, so it can optimize

10 years agopodcheck.t: Allow checking old perldelta
Karl Williamson [Sun, 29 Apr 2012 01:20:24 +0000 (19:20 -0600)]
podcheck.t: Allow checking old perldelta

The test was wrong, causing it to croak when an old perldelta file was
passed explicitly to podcheck.

10 years agoutf8.c: Skip extraneous function call
Karl Williamson [Sun, 29 Apr 2012 00:49:52 +0000 (18:49 -0600)]
utf8.c: Skip extraneous function call

This eliminates an intermediate function call by calling the base level
one directly.

10 years agoutf8.c: Remove unnecessary validation
Karl Williamson [Sun, 29 Apr 2012 00:48:52 +0000 (18:48 -0600)]
utf8.c: Remove unnecessary validation

These two functions are to be called only on strings known to be valid,
so we can skip the validation.

10 years agoutf8.c: Extra branch to avoid others in the typical case
Karl Williamson [Sun, 29 Apr 2012 00:40:40 +0000 (18:40 -0600)]
utf8.c: Extra branch to avoid others in the typical case

This test eliminates all code points less than U+D800 from having to be
checked more than once, at the expense of an extra test for code points
that are larger

10 years agoutf8.h, pp.c: Add UTF8_IS_REPLACEMENT macro, and use it
Karl Williamson [Sun, 29 Apr 2012 00:38:24 +0000 (18:38 -0600)]
utf8.h, pp.c: Add UTF8_IS_REPLACEMENT macro, and use it

This should speed things up slightly, as it looks directly at the UTF-8
source, instead of having to decode it first.

10 years agoutf8.h: Simplify expressions
Karl Williamson [Sun, 29 Apr 2012 00:30:27 +0000 (18:30 -0600)]
utf8.h: Simplify expressions

These expressions, while valid, are overly complicated in order to make
it easy to separate out problematic code points in the future, such as
surrogates.  But we made a decision in 5.12 to not go in that direction,
but to accept such problematic code points in general.  I  haven't
heard any cause to regret that decision; if we ever want to go back, the
blame log will easily allow us to.

10 years agoutf8.h: Comment improvementes, white-space
Karl Williamson [Sun, 29 Apr 2012 00:26:22 +0000 (18:26 -0600)]
utf8.h: Comment improvementes, white-space

10 years agoembed.fnc: Change formal param name to match docs
Karl Williamson [Fri, 23 Mar 2012 02:00:26 +0000 (20:00 -0600)]
embed.fnc: Change formal param name to match docs

This is purely so that perlapi will be accurate in this regard.

10 years agodoio.c: Add some comments
Karl Williamson [Wed, 21 Mar 2012 14:41:44 +0000 (08:41 -0600)]
doio.c: Add some comments

10 years agoperlfunc: Add reference to simple folding docs
Karl Williamson [Wed, 28 Mar 2012 16:53:42 +0000 (10:53 -0600)]
perlfunc: Add reference to simple folding docs

10 years agoExperimentally add VT to \s definition
Karl Williamson [Thu, 29 Mar 2012 01:28:04 +0000 (19:28 -0600)]
Experimentally add VT to \s definition

This commit is the minimal necessary to get \s to match the vertical
tab.  It is being done early in the 5.17 series in order to see what
repercussions there might be from doing this.

It may well be that we decide that this change will require a 'use
feature' to activate.  In any event there is significant documentation
of the behavior without the VT that this patch does not address at all.

Tom Christiansen asked Larry Wall why \s did not include VT, and
reported that Larry replied that he did not remember, but had no
objections to adding it.

10 years Don't use \w, \s
Karl Williamson [Thu, 29 Mar 2012 01:23:19 +0000 (19:23 -0600)] Don't use \w, \s

Now that these are partially compiled into the Perl core, we have a
chicken and egg problem if one changes.  Instead, use the \p{}
equivalent which doesn't have this problem.

10 years agoSynchronise Module-CoreList in with teh CPAN
Chris 'BinGOs' Williams [Tue, 22 May 2012 12:23:38 +0000 (13:23 +0100)]
Synchronise Module-CoreList in with teh CPAN

10 years agoLookup overloaded assignment operators when trying to swap the arguments
Rafael Garcia-Suarez [Tue, 20 Mar 2012 08:17:02 +0000 (09:17 +0100)]
Lookup overloaded assignment operators when trying to swap the arguments

This is in the case where we search for an overloaded operator when
passing the AMGf_assign flag (we're executing an assignment operator
like +=).

At the very beginning of Perl_amagic_call, if the flag AMGf_noleft is
not passed, we first try to look up the overload method corresponding
to the assignment operator, then the normal one if fallback is
authorized. However, if this fails, when trying later to find
overload magic with the arguments swapped (if AMGf_noright is not
passed), this procedure was not used and we looked up directly the base
operation from which the assignment operator might be derived.
As a consequence of what an operator like += might have looked
autogenerated even when fallback=>0 was passed.

This change only necessitates a minor adjustment in lib/overload.t,
where an overloaded += method wasn't corresponding semantically to the
overloaded + method of the same class, which can be seen as a
pathological case.

10 years agoClose the filehandle actually being tested in uni/readline.t
Steve Hay [Tue, 22 May 2012 07:37:01 +0000 (08:37 +0100)]
Close the filehandle actually being tested in uni/readline.t
(Also allows the tempfile() to be unlink()ed :-)

10 years agoperldelta for undef *_, &CORE::time crash
Father Chrysostomos [Tue, 22 May 2012 05:53:26 +0000 (22:53 -0700)]
perldelta for undef *_, &CORE::time crash

10 years agoperldelta for while(each %h)
Father Chrysostomos [Tue, 22 May 2012 05:52:11 +0000 (22:52 -0700)]
perldelta for while(each %h)

10 years agoperldelta for pos %foo
Father Chrysostomos [Tue, 22 May 2012 05:50:41 +0000 (22:50 -0700)]
perldelta for pos %foo

10 years agoperldelta for ‘no overload "invalid"’ warnings
Father Chrysostomos [Tue, 22 May 2012 05:49:31 +0000 (22:49 -0700)]
perldelta for ‘no overload "invalid"’ warnings

10 years agoperldelta for overload fallback inheritance
Father Chrysostomos [Tue, 22 May 2012 05:48:29 +0000 (22:48 -0700)]
perldelta for overload fallback inheritance

10 years agoperldelta for overload caching bug fixes
Father Chrysostomos [Tue, 22 May 2012 05:47:24 +0000 (22:47 -0700)]
perldelta for overload caching bug fixes

10 years agoperldelta for changed AMAGIC table mechanism
Father Chrysostomos [Tue, 22 May 2012 05:44:35 +0000 (22:44 -0700)]
perldelta for changed AMAGIC table mechanism

10 years agoperldelta for File::stat’s -p
Father Chrysostomos [Tue, 22 May 2012 05:36:55 +0000 (22:36 -0700)]
perldelta for File::stat’s -p

10 years agoperldelta for vec w/2GB offsets
Father Chrysostomos [Tue, 22 May 2012 05:32:17 +0000 (22:32 -0700)]
perldelta for vec w/2GB offsets

10 years agoperldelta for File::stat -r warning
Father Chrysostomos [Tue, 22 May 2012 05:30:31 +0000 (22:30 -0700)]
perldelta for File::stat -r warning

10 years agoperldelta for method{}
Father Chrysostomos [Tue, 22 May 2012 05:24:00 +0000 (22:24 -0700)]
perldelta for method{}

10 years agoperldelta for CORE:: and TARG
Father Chrysostomos [Tue, 22 May 2012 05:20:41 +0000 (22:20 -0700)]
perldelta for CORE:: and TARG

10 years agoperldelta for undef *^H non-ambiguity
Father Chrysostomos [Tue, 22 May 2012 05:15:33 +0000 (22:15 -0700)]
perldelta for undef *^H non-ambiguity

10 years agoperldelta for Hash::Util changes
Father Chrysostomos [Tue, 22 May 2012 05:12:24 +0000 (22:12 -0700)]
perldelta for Hash::Util changes

10 years agoperldelta for modding $_[0] in STORABLE_freeze
Father Chrysostomos [Tue, 22 May 2012 05:02:20 +0000 (22:02 -0700)]
perldelta for modding $_[0] in STORABLE_freeze

10 years agoperldelta for setting $^N
Father Chrysostomos [Tue, 22 May 2012 05:01:02 +0000 (22:01 -0700)]
perldelta for setting $^N

10 years agoperldelta for copying call checkers to closures
Father Chrysostomos [Tue, 22 May 2012 04:59:31 +0000 (21:59 -0700)]
perldelta for copying call checkers to closures

10 years agoperldelta for hvstore and %^H
Father Chrysostomos [Tue, 22 May 2012 04:57:11 +0000 (21:57 -0700)]
perldelta for hvstore and %^H

10 years agoperldelta for goto "\0"
Father Chrysostomos [Tue, 22 May 2012 04:55:36 +0000 (21:55 -0700)]
perldelta for goto "\0"

10 years agoperldelta for goto ""
Father Chrysostomos [Tue, 22 May 2012 04:52:16 +0000 (21:52 -0700)]
perldelta for goto ""

10 years agoIncrease $Pod::Functions::VERSION to 1.06
Father Chrysostomos [Tue, 22 May 2012 03:42:26 +0000 (20:42 -0700)]
Increase $Pod::Functions::VERSION to 1.06

The previous commit modified Pod::Functions by modifying perlfunc.pod,
but we have things set up in such a way that cmp_version.t won’t
see it.

10 years agoRemove double space from Pod::Functions descr
Father Chrysostomos [Tue, 22 May 2012 03:41:14 +0000 (20:41 -0700)]
Remove double space from Pod::Functions descr

10 years agoConsistent spaces after dots in CORE.pod
Father Chrysostomos [Tue, 15 May 2012 22:01:53 +0000 (15:01 -0700)]
Consistent spaces after dots in CORE.pod

10 years agoop.c: Remove redundant assignment
Father Chrysostomos [Sun, 13 May 2012 06:10:58 +0000 (23:10 -0700)]
op.c: Remove redundant assignment

This was added unnecessarily in commit ddeae0f14c.  It is a local
variable assigned to just before the function returns, so the value
is never used in the OP_UNDEF case.

10 years agoDon’t crash with &CORE::foo after undefining *_
Father Chrysostomos [Sun, 13 May 2012 01:43:13 +0000 (18:43 -0700)]
Don’t crash with &CORE::foo after undefining *_

When a sub is called with & and no parentheses, no @_ is set up.  This
means the sub call sees the existing @_.  It also means that, if *_
has been undefined, there is no @_.

pp_coreargs was not accounting for this, and was doing
AvARRAY(GvAV(PL_defgv)) without checking that GvAV(PL_defgv) was non-
null.  It crashed as a result.

10 years agoTest that ‘require v5’ ignores sub named v5
Father Chrysostomos [Sat, 12 May 2012 03:27:46 +0000 (20:27 -0700)]
Test that ‘require v5’ ignores sub named v5

This is something I broke in my first (unapplied) attempt to clean up
require’s parsing madness.

10 years agoMake while(each ...) imply defined($_ = ...)
Father Chrysostomos [Sat, 12 May 2012 03:13:01 +0000 (20:13 -0700)]
Make while(each ...) imply defined($_ = ...)

This came up in ticket #108286.

Quoting Nicholas Clark:
>     while (<STDIN>)
>     while (<*>)
> These both always implicitly assigned to $_, always implicitly
> added defined.
>     while ($_ = <STDIN>)
>     while ($a = <STDIN>)
>     while ($_ = <*>)
>     while ($a = <*>)
>     while ($_ = readdir D)
>     while ($a = readdir D)
>     while ($_ = each %h)
>     while ($a = each %h)
> The implicit defined added was by commit 4b161ae29769b4a3,
> //depot/maint-5.004/perl@949
> BUT:
>     while (readdir D)
> The implicit assignment to $_ and defined test were both added in
> *2009* (by commit 114c60ecb1f7)
> leaving:
>     while (each %h)
> So it is the odd one out. And in 2009 we felt comfortable to add
> both the implicit assignment and the defined test in blead for
> readdir, as a bug fix, and have had no reports of it caus-
> ing problems.

[He asked:]
> > > So that's a bug?

[And I responded:]
> > That's what I was trying to ask. :-)
> OK, after a quite a bit of deliberation and digging, I'm of the opinion that
> 1: yes, it's a bug


> So, there's only one use of while(each %...) on CPAN outside of
> debugging or test code, and that's only go the potential to break
> due to assignment now happening to to $_. Compared with 29 matches
> for while\s*\(\s*readdir of which 4 are .pm files. So
> 2: I think it's safe to fix it, just like readdir was fixed.

Just *as* readdir was fixed! :-)

10 years agooverride.t: Remove obsolete comment
Father Chrysostomos [Thu, 3 May 2012 16:12:03 +0000 (09:12 -0700)]
override.t: Remove obsolete comment

10 years agorequire_errors.t: Test <> error
Father Chrysostomos [Thu, 3 May 2012 03:37:12 +0000 (20:37 -0700)]
require_errors.t: Test <> error

10 years agoAllow require_errors.t to be run from the top level
Father Chrysostomos [Thu, 3 May 2012 03:36:20 +0000 (20:36 -0700)]
Allow require_errors.t to be run from the top level

10 years agoRemove OPpCONST_WARNING from B::Concise
Father Chrysostomos [Tue, 1 May 2012 01:04:23 +0000 (18:04 -0700)]
Remove OPpCONST_WARNING from B::Concise

10 years agoRemove OPpCONST_WARNING
Father Chrysostomos [Tue, 1 May 2012 00:46:48 +0000 (17:46 -0700)]

This was added to op.h in commit 599cee73:

commit 599cee73f2261c5e09cde7ceba3f9a896989e117
Author: Paul Marquess <>
Date:   Wed Jul 29 10:28:45 1998 +0100

    lexical warnings; tweaks to places that didn't apply correctly
     Message-Id: <>
     Subject: lexical warnings patch for 5.005_50

    p4raw-id: //depot/perl@1773

dump.c was modified to dump in, in this commit:

commit bf91b999b25fa75a3ef7a327742929592a2e7e9c
Author: Simon Cozens <>
Date:   Sun May 13 21:20:36 2001 +0100

    Op private flags
    Message-ID: <>

    p4raw-id: //depot/perl@10117

But is apparently completely unused anywhere.  And I want that bit.

10 years agocoreamp.t: rename badly-named tests
Father Chrysostomos [Mon, 30 Apr 2012 04:16:51 +0000 (21:16 -0700)]
coreamp.t: rename badly-named tests