This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
perl5.git
12 years agoRemove the entry about removing Perl_deprecate()
Nicholas Clark [Mon, 19 Oct 2009 14:18:32 +0000 (15:18 +0100)]
Remove the entry about removing Perl_deprecate()

As a minor C function, I feel that at most it should be in "changed internals".
However, as it was not part of the public API, and searches showed that nothing
was using it, likely nothing is going to break if it goes. And if any naughty
code does break:
a: It will be at link time
b: It will be easy to find the cause from git log

I also feel that it's worth removing it, as existing perldeltas are the most
obvious guide for new volunteers in terms of "write something like this".
So having bad examples isn't going to help educate future authors.

12 years agoFix minor pod formatting error in perl5111delta.pod
Nicholas Clark [Mon, 19 Oct 2009 14:17:10 +0000 (15:17 +0100)]
Fix minor pod formatting error in perl5111delta.pod

12 years agoupdate perl5111delta to mark our current release point.
Jesse Vincent [Mon, 19 Oct 2009 14:14:21 +0000 (10:14 -0400)]
update perl5111delta to mark our current release point.

12 years agoperldelta editing
Jesse Vincent [Mon, 19 Oct 2009 14:09:19 +0000 (10:09 -0400)]
perldelta editing

12 years agoHP/UX should have been HP-UX
Jesse Vincent [Mon, 19 Oct 2009 14:08:16 +0000 (10:08 -0400)]
HP/UX should have been HP-UX

12 years agoFirst pass at updating perlport.pod with data from p5p for 5.12
Jesse Vincent [Mon, 19 Oct 2009 14:00:43 +0000 (10:00 -0400)]
First pass at updating perlport.pod with data from p5p for 5.12

12 years agoAdd two (U8 *) casts to placate C++.
Nicholas Clark [Mon, 19 Oct 2009 10:04:54 +0000 (11:04 +0100)]
Add two (U8 *) casts to placate C++.

12 years agoIn utf16_to_utf8(), fix off-by-one errors for the range of valid surrogates.
Nicholas Clark [Sun, 18 Oct 2009 21:09:14 +0000 (22:09 +0100)]
In utf16_to_utf8(), fix off-by-one errors for the range of valid surrogates.

Both high ends were one too low.

12 years agoutf16_to_utf8() should croak on encountering a bare low surrogate.
Nicholas Clark [Sun, 18 Oct 2009 21:01:49 +0000 (22:01 +0100)]
utf16_to_utf8() should croak on encountering a bare low surrogate.

12 years agoutf16_to_utf8() should croak if the buffer ends without the second surrogate.
Nicholas Clark [Sun, 18 Oct 2009 20:55:52 +0000 (21:55 +0100)]
utf16_to_utf8() should croak if the buffer ends without the second surrogate.

12 years agoutf16_to_utf8_reversed() should croak early when passed an odd byte length.
Nicholas Clark [Sun, 18 Oct 2009 20:30:41 +0000 (21:30 +0100)]
utf16_to_utf8_reversed() should croak early when passed an odd byte length.

Rather than transposing n + 1 bytes, including 1 it was not passed, before
calling utf16_to_utf8() and having that croak.
e 69422~

12 years agoExpose utf16_to_utf8{,reversed} via XS::APItest, and provide some basic tests.
Nicholas Clark [Sun, 18 Oct 2009 20:06:06 +0000 (21:06 +0100)]
Expose utf16_to_utf8{,reversed} via XS::APItest, and provide some basic tests.

12 years agoAnother pass at getting the perldelta for 5.11.1 in shape
Jesse Vincent [Sun, 18 Oct 2009 20:21:32 +0000 (16:21 -0400)]
Another pass at getting the perldelta for 5.11.1 in shape

12 years agoEviscerate README.macos to match the state of the world
Jesse Vincent [Sun, 18 Oct 2009 19:05:50 +0000 (15:05 -0400)]
Eviscerate README.macos to match the state of the world

12 years agoRemove Mac OS Classic caveats from perlport.pod as Perl is no longer portable to...
Jesse Vincent [Sun, 18 Oct 2009 18:34:30 +0000 (14:34 -0400)]
Remove Mac OS Classic caveats from perlport.pod as Perl is no longer portable to Mac OS Classic

12 years agoAdded four new AUTHORS who hadn't yet been acknowledged
Jesse Vincent [Sun, 18 Oct 2009 18:22:19 +0000 (14:22 -0400)]
Added four new AUTHORS who hadn't yet been acknowledged

12 years agoRan into Bert Dvornik at a cafe - updated his AUTHORS file address
Jesse Vincent [Sun, 18 Oct 2009 18:12:04 +0000 (14:12 -0400)]
Ran into Bert Dvornik at a cafe - updated his AUTHORS file address

12 years agoMerge S_utf16_textfilter and S_utf16rev_textfilter().
Nicholas Clark [Sun, 18 Oct 2009 16:47:10 +0000 (17:47 +0100)]
Merge S_utf16_textfilter and S_utf16rev_textfilter().

Use IoLINES() on the filter's SV to determine which encoding is in use.

12 years agoNote why S_pending_ident's prototype can't be generated by embed.fnc
Nicholas Clark [Sun, 18 Oct 2009 16:10:02 +0000 (17:10 +0100)]
Note why S_pending_ident's prototype can't be generated by embed.fnc

12 years agoGenerate prototypes for utf16_textfilter and utf16rev_textfilter using embed.fnc
Nicholas Clark [Sun, 18 Oct 2009 16:06:55 +0000 (17:06 +0100)]
Generate prototypes for utf16_textfilter and utf16rev_textfilter using embed.fnc

12 years agoUse gmtime() instead of localtime(), as timezones hinder testing strtime().
Nicholas Clark [Sun, 18 Oct 2009 16:41:19 +0000 (17:41 +0100)]
Use gmtime() instead of localtime(), as timezones hinder testing strtime().

(Specifically negative timezones on operating systems without tzset(). Coming
from Washington State, you would have thought that they would have thought of
this.)

12 years agoFirst pass of weeding commit meesages from "git log v5.11.0..blead" into a perldelta.
Jesse Vincent [Sun, 18 Oct 2009 06:27:11 +0000 (02:27 -0400)]
First pass of weeding commit meesages from "git log v5.11.0..blead" into a perldelta.

perl5111delta.pod is synced up to 704e1b1ec3309aeb0e2629c93331ffd4c18c8183
but needs heavy editing and organization

12 years agoUpdate CPANPLUS to CPAN version 0.89_02
Chris Williams [Sat, 17 Oct 2009 15:37:54 +0000 (16:37 +0100)]
Update CPANPLUS to CPAN version 0.89_02

  Changes for 0.89_02     Sat Oct 17 13:04:59 2009
  ================================================
  * Core module prereqs should be dealt with correctly now.

  Changes for 0.89_01     Fri Oct 16 10:22:43 2009
  ================================================
  * Corrected spelling mistake in CPANPLUS::Configure documentation
  * Fixed a problem with the core module detection when sending
    NA reports
  * Internals::Report will use Parse::CPAN::Meta instead of
    YAML::Tiny for parsing CPAN Test report data
  * Address #50428 Fixed edge-case in the arbitary paths support in
    parse_module(), reported by Robert Krimen
  * Address #49104 Fixed the SYNOPSIS in CPANPLUS::Module::Author::Fake
    reported by Tyler MacDonald
  * Address #47820 Don't try to update custom sources if they are disabled
    in configuration, reported by Curtis Jewell

12 years agoUpgrade to threads::shared 1.32
Jerry D. Hedden [Fri, 16 Oct 2009 17:24:11 +0000 (13:24 -0400)]
Upgrade to threads::shared 1.32

Message-ID: <1ff86f510910161058y554bc05cra48c0c3decd60738@mail.gmail.com>

12 years agoHelp ExtUtils::Install's tests find PERL_SRC on VMS.
Craig A. Berry [Fri, 16 Oct 2009 21:24:35 +0000 (16:24 -0500)]
Help ExtUtils::Install's tests find PERL_SRC on VMS.

We're testing from one level deeper than when we were in lib/.

12 years agorefactor the special CC code in reg_try()
Yves Orton [Fri, 16 Oct 2009 18:52:58 +0000 (20:52 +0200)]
refactor the special CC code in reg_try()

this is a precursor step to fixing the re/pat_special_cc.t failures.

12 years agoEnable deprecation warnings by default.
Nicholas Clark [Tue, 13 Oct 2009 15:04:18 +0000 (16:04 +0100)]
Enable deprecation warnings by default.

12 years agolocked is deprecated, so use :lvalue instead.
Nicholas Clark [Tue, 13 Oct 2009 15:02:05 +0000 (16:02 +0100)]
locked is deprecated, so use :lvalue instead.

12 years agoCan't use C<shift INC> to avoid @ in a commandline now, so use eval and octal.
Nicholas Clark [Tue, 13 Oct 2009 14:59:58 +0000 (15:59 +0100)]
Can't use C<shift INC> to avoid @ in a commandline now, so use eval and octal.

12 years agoshift with barewords is deprecated, so this test from perl 1 needs updating.
Nicholas Clark [Tue, 13 Oct 2009 14:37:12 +0000 (15:37 +0100)]
shift with barewords is deprecated, so this test from perl 1 needs updating.

12 years agopush and pop on barewords are deprecated, so need no warnings 'deprecated';
Nicholas Clark [Tue, 13 Oct 2009 14:36:14 +0000 (15:36 +0100)]
push and pop on barewords are deprecated, so need no warnings 'deprecated';

12 years agoOpening dirhandle DIR also as a file needs no warnings 'deprecated';
Nicholas Clark [Tue, 13 Oct 2009 14:35:15 +0000 (15:35 +0100)]
Opening dirhandle DIR also as a file needs no warnings 'deprecated';

12 years agodefined @array and defined %hash need no warnings 'deprecated';
Nicholas Clark [Tue, 13 Oct 2009 14:33:16 +0000 (15:33 +0100)]
defined @array and defined %hash need no warnings 'deprecated';

12 years agolocalisation of $[ is deprecated, so needs no warnings 'deprecated';
Nicholas Clark [Tue, 13 Oct 2009 14:32:03 +0000 (15:32 +0100)]
localisation of $[ is deprecated, so needs no warnings 'deprecated';

12 years ago:locked is deprecated, so use :lvalue instead.
Nicholas Clark [Tue, 13 Oct 2009 15:39:16 +0000 (16:39 +0100)]
:locked is deprecated, so use :lvalue instead.

12 years agoTests for barewords and hash operators need no warnings 'deprecated';
Nicholas Clark [Tue, 13 Oct 2009 14:26:32 +0000 (15:26 +0100)]
Tests for barewords and hash operators need no warnings 'deprecated';

12 years agodo subname() is deprecated, so tests for it need no warnings 'deprecated';
Nicholas Clark [Tue, 13 Oct 2009 14:25:03 +0000 (15:25 +0100)]
do subname() is deprecated, so tests for it need no warnings 'deprecated';

12 years agodo subname() is deprecated, so update this hunk of test dating from perl 1.
Nicholas Clark [Tue, 13 Oct 2009 14:16:53 +0000 (15:16 +0100)]
do subname() is deprecated, so update this hunk of test dating from perl 1.

12 years agoBracket deprecated features with no warnings 'deprecated';
Nicholas Clark [Tue, 13 Oct 2009 14:16:16 +0000 (15:16 +0100)]
Bracket deprecated features with no warnings 'deprecated';

12 years agodo subname() is deprecated, so this test from perl 3 needs updating.
Nicholas Clark [Tue, 13 Oct 2009 14:14:12 +0000 (15:14 +0100)]
do subname() is deprecated, so this test from perl 3 needs updating.

12 years agoMove tests for $[ from comp/hints.t to op/array_base.t
Nicholas Clark [Tue, 13 Oct 2009 14:10:40 +0000 (15:10 +0100)]
Move tests for $[ from comp/hints.t to op/array_base.t

Tests in t/comp/ are too early to rely on pragmata working.

12 years agoMove tests for $[ from comp/parser.t to op/array_base.t
Nicholas Clark [Tue, 13 Oct 2009 13:33:38 +0000 (14:33 +0100)]
Move tests for $[ from comp/parser.t to op/array_base.t

Tests in t/comp/ are too early to rely on pragmata working.

12 years agodo subname() is deprecated, so this test from perl 1 needs updating.
Nicholas Clark [Tue, 13 Oct 2009 12:56:06 +0000 (13:56 +0100)]
do subname() is deprecated, so this test from perl 1 needs updating.

12 years agoMove the test for the deprecated feature <<; out of t/base/lext.t
Nicholas Clark [Tue, 13 Oct 2009 12:44:50 +0000 (13:44 +0100)]
Move the test for the deprecated feature <<; out of t/base/lext.t

Tests in base can't utilise pragmata, specifically no warnings 'deprecated';

12 years agoAdd no warnings 'deprecated' to a test that assigns to $[
Nicholas Clark [Tue, 13 Oct 2009 12:32:50 +0000 (13:32 +0100)]
Add no warnings 'deprecated' to a test that assigns to $[

12 years agoMake the watchdog create a valid command for spawning.
Craig A. Berry [Fri, 16 Oct 2009 15:58:43 +0000 (10:58 -0500)]
Make the watchdog create a valid command for spawning.

It was inserting a newline in the command string, which
causes a syntax error (at least on VMS).

12 years agoConvert sv_2mortal(newSVpvn()) to newSVpvn_flags(), for 5.11.0 and later.
Nicholas Clark [Fri, 16 Oct 2009 10:59:48 +0000 (11:59 +0100)]
Convert sv_2mortal(newSVpvn()) to newSVpvn_flags(), for 5.11.0 and later.

12 years agoConvert sv_2mortal(newSVpvn_utf8(...)) to newSVpvn_flags()
Nicholas Clark [Fri, 16 Oct 2009 10:41:10 +0000 (11:41 +0100)]
Convert sv_2mortal(newSVpvn_utf8(...)) to newSVpvn_flags()

12 years agoConvert sv_2mortal(newSVpvn(...)) to newSVpvs_flags(..., SVs_TEMP)
Nicholas Clark [Fri, 16 Oct 2009 09:47:14 +0000 (10:47 +0100)]
Convert sv_2mortal(newSVpvn(...)) to newSVpvs_flags(..., SVs_TEMP)

Optionally use ppport.h to provide it for us.

12 years agoAdd missing MANIFEST entries
Steve Hay [Fri, 16 Oct 2009 09:11:16 +0000 (10:11 +0100)]
Add missing MANIFEST entries

Missed by commit 55b77936aef50881a71470fd06e66edffd66d9de

12 years agoRestore 8d2345e02f493825c3e22467caf8508ee3a19450.
Craig A. Berry [Thu, 15 Oct 2009 23:05:50 +0000 (18:05 -0500)]
Restore 8d2345e02f493825c3e22467caf8508ee3a19450.

Also reported upstream this time (oops):

https://rt.cpan.org/Ticket/Display.html?id=50542

12 years agoSkip testing the be_BY.CP1131 locale on Darwin 10, as it's still buggy.
Nicholas Clark [Thu, 15 Oct 2009 22:37:41 +0000 (23:37 +0100)]
Skip testing the be_BY.CP1131 locale on Darwin 10, as it's still buggy.

Correct infelicities in the regexp used to identify buggy locales on Darwin 8
and 9.

12 years agoReplace sv_2mortal(newSVpvn(...)) with newSVpvn_flags(..., SVs_TEMP)
Nicholas Clark [Thu, 15 Oct 2009 22:17:02 +0000 (23:17 +0100)]
Replace sv_2mortal(newSVpvn(...)) with newSVpvn_flags(..., SVs_TEMP)

12 years agoUse newSVpvn(), newSVpvs() and gv_fetchpvs(), the later with proper arguments.
Nicholas Clark [Thu, 15 Oct 2009 19:02:51 +0000 (20:02 +0100)]
Use newSVpvn(), newSVpvs() and gv_fetchpvs(), the later with proper arguments.

Brought to you by the Campaign for the Elimination of strlen().

12 years agoUse gv_stashsv() and gv_fetchpvs(), the later with proper arguments.
Nicholas Clark [Thu, 15 Oct 2009 18:38:08 +0000 (19:38 +0100)]
Use gv_stashsv() and gv_fetchpvs(), the later with proper arguments.

Brought to you by the Campaign for the Elimination of strlen().
(And the elimination of accidental bugs due to typos in lenghts of constants,
and the elimination of abuse of boolean constants for parameters with more than
2 values.)

12 years agoUse sv_catpvs(), newSVpvs(), newSVpvn(), newSVhek(), gv_stashpvs() and the
Nicholas Clark [Thu, 15 Oct 2009 17:51:16 +0000 (18:51 +0100)]
Use sv_catpvs(), newSVpvs(), newSVpvn(), newSVhek(), gv_stashpvs() and the
return value of sprintf().

Brought to you by the Campaign for the Elimination of strlen().
(And the elimination of accidental bugs due to typos in lengths of constant
strings.)

12 years agoIn strftime(), save a malloc()/free() by using sv_usepvn_flags().
Nicholas Clark [Thu, 15 Oct 2009 15:26:51 +0000 (16:26 +0100)]
In strftime(), save a malloc()/free() by using sv_usepvn_flags().

12 years agoPOSIX::strftime() should be able to handle Unicode characters in the format
Nicholas Clark [Thu, 15 Oct 2009 16:09:12 +0000 (17:09 +0100)]
POSIX::strftime() should be able to handle Unicode characters in the format
string.

(Restore the intent of 9e8c01f558a03902ff2f54935fd7e6dcc7ec656c, but with non-
buggy tests. Improve the implementation so that it doesn't always upgrade the
format string to UTF-8.)

12 years agoFix 2 pod errors in perlvms.pod.
Craig A. Berry [Thu, 15 Oct 2009 16:01:33 +0000 (11:01 -0500)]
Fix 2 pod errors in perlvms.pod.

12 years agoMake p_tainted.t find its tests on VMS.
Craig A. Berry [Thu, 15 Oct 2009 15:59:09 +0000 (10:59 -0500)]
Make p_tainted.t find its tests on VMS.

Reported upstream at:

https://rt.cpan.org/Ticket/Display.html?id=50528

12 years agoHmmm... this may be a heisenbug. Works on some terminals but not
Steve Peters [Thu, 15 Oct 2009 14:50:42 +0000 (09:50 -0500)]
Hmmm... this may be a heisenbug.  Works on some terminals but not
others.

This reverts commit 9e8c01f558a03902ff2f54935fd7e6dcc7ec656c.

12 years agoMerge branch 'blead' of ssh://stevep@perl5.git.perl.org/gitroot/perl into blead
Steve Peters [Thu, 15 Oct 2009 14:14:47 +0000 (09:14 -0500)]
Merge branch 'blead' of ssh://stevep@perl5.git.perl.org/gitroot/perl into blead

12 years agoPOSIX::strftime() should be able to handle Unicode characters in the
Steve Peters [Thu, 15 Oct 2009 14:12:57 +0000 (09:12 -0500)]
POSIX::strftime() should be able to handle Unicode characters in the
format string the same as ASCII ones.

12 years agoMove the boolkeys op to the group of hash ops.
Nicholas Clark [Thu, 15 Oct 2009 14:12:49 +0000 (15:12 +0100)]
Move the boolkeys op to the group of hash ops.

This breaks binary compatibility.

12 years agoOptimise if (%foo) to be faster than if(keys %foo)
demerphq [Thu, 15 Oct 2009 13:27:30 +0000 (14:27 +0100)]
Optimise if (%foo) to be faster than if(keys %foo)

Thread was "[PATCH] Make if (%hash) {} act the same as if (keys %hash) {}"
http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2006-11/msg00432.html
but the implementation evolved from the approach described in the subject, to
instead add a new opcode pp_boolkeys, to exactly preserve the existing
behaviour.

Various conflicts with the passage of time resolved, 'register' removed, and a
$VERSION bump.

12 years agoSupport for pp_boolkeys in B::Deparse.
demerphq [Thu, 15 Oct 2009 13:22:47 +0000 (14:22 +0100)]
Support for pp_boolkeys in B::Deparse.

Part of "[PATCH] Make if (%hash) {} act the same as if (keys %hash) {}"
http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2006-11/msg00432.html
which evolved from the approach described in the subject, to instead add a new
opcode pp_boolkeys, to exactly preserve the existing behaviour.

Plus a $VERSION bump.

12 years agoUpdated a comment in Porting/makerel
Jesse Vincent [Wed, 14 Oct 2009 19:24:54 +0000 (15:24 -0400)]
Updated a comment in Porting/makerel

12 years agoAdd mingw64 support for win32
Sisyphus [Wed, 14 Oct 2009 14:02:16 +0000 (10:02 -0400)]
Add mingw64 support for win32

12 years agoRemove old code dealing with installing 5.003's perldiag
Rafael Garcia-Suarez [Wed, 14 Oct 2009 09:40:35 +0000 (11:40 +0200)]
Remove old code dealing with installing 5.003's perldiag

12 years agoIgnore files installed by Parse::CPAN::Meta
Rafael Garcia-Suarez [Wed, 14 Oct 2009 09:36:44 +0000 (11:36 +0200)]
Ignore files installed by Parse::CPAN::Meta

12 years agoDon't install uupacktool.pl
Rafael Garcia-Suarez [Wed, 14 Oct 2009 09:35:10 +0000 (11:35 +0200)]
Don't install uupacktool.pl

12 years agoPatch t/win32/system.t for mingw32/64
Sisyphus [Wed, 14 Oct 2009 10:58:49 +0000 (06:58 -0400)]
Patch t/win32/system.t for mingw32/64

12 years agoFix {$^MATCH} typo in perlre
brian d foy [Wed, 14 Oct 2009 08:08:25 +0000 (03:08 -0500)]
Fix {$^MATCH} typo in perlre

12 years agoThe winsock select() implementation doesn't support all empty 'fd_set's.
Jan Dubois [Tue, 13 Oct 2009 23:46:58 +0000 (16:46 -0700)]
The winsock select() implementation doesn't support all empty 'fd_set's.

The code already contained a workaround for the special case

    select(undef, undef, undef, $sleep);

but didn't handle the case when actual bit vectors were passed in
that didn't have any bits set.

Fixes http://rt.perl.org/rt3/Public/Bug/Display.html?id=54544

12 years agoSort MANIFEST following commit 9bc662c9c4c134e4.
Nicholas Clark [Tue, 13 Oct 2009 17:05:09 +0000 (18:05 +0100)]
Sort MANIFEST following commit 9bc662c9c4c134e4.

12 years agoNote that a test that regen.pl was run is TODO.
Nicholas Clark [Tue, 13 Oct 2009 17:02:46 +0000 (18:02 +0100)]
Note that a test that regen.pl was run is TODO.

12 years agoMinor podification nit. *2 legs bad* B<4 legs good>.
Nicholas Clark [Tue, 13 Oct 2009 15:51:09 +0000 (16:51 +0100)]
Minor podification nit. *2 legs bad* B<4 legs good>.

12 years agoIncorrect warning category case
Eric Brine [Tue, 13 Oct 2009 16:14:51 +0000 (12:14 -0400)]
Incorrect warning category case

12 years agoFix minor typo in perlpolicy.pod
Steve Hay [Tue, 13 Oct 2009 16:44:41 +0000 (17:44 +0100)]
Fix minor typo in perlpolicy.pod

12 years agoWork around Parse-CPAN-Meta's desire to run a command at 'make test' time. - Commit...
Jesse Vincent [Tue, 13 Oct 2009 15:14:03 +0000 (11:14 -0400)]
Work around Parse-CPAN-Meta's desire to run a command at 'make test' time.  - Commit the generated file

12 years agoMove the new "perl policy" document into pod/
Jesse Vincent [Tue, 13 Oct 2009 14:36:34 +0000 (10:36 -0400)]
Move the new "perl policy" document into pod/

12 years agoPodify the social contract about contributed modules
Jesse Vincent [Tue, 13 Oct 2009 14:32:38 +0000 (10:32 -0400)]
Podify the social contract about contributed modules

12 years agoperlvar $1 clarification
Smylers [Tue, 13 Oct 2009 12:14:46 +0000 (14:14 +0200)]
perlvar $1 clarification

$1 is currently documented as being set by the "last pattern match".
But it is left alone by unsuccessful pattern match attempts (continuing
to hold a value from an earlier successful match).

Saying "last successful pattern match" clarifies this; it's also the
phrase used to document $&.

Second, the entry for $1 in perlvar doesn't actually contain the text
"$1" anywhere.  As such, doing man perlvar then using /\$1 to search for
it in less doesn't locate it (though does match other places in that
file where $1 happens to be used).

12 years agoChange S_ckwarn_common() to looping over the packed warning value.
Nicholas Clark [Tue, 13 Oct 2009 12:01:52 +0000 (13:01 +0100)]
Change S_ckwarn_common() to looping over the packed warning value.

The core never uses WARN3() or WARN4(), and rarely uses WARN2(), so the
previous code, effectively an unwrapped loop, wasn't a speed up. Functionally
equivalent smaller code fits better into CPU caches.

12 years agoMigrate common code in Perl_ckwarn() and Perl_ckwarn_d() to S_ckwarn_common()
Nicholas Clark [Tue, 13 Oct 2009 10:41:36 +0000 (11:41 +0100)]
Migrate common code in Perl_ckwarn() and Perl_ckwarn_d() to S_ckwarn_common()

12 years agoIn Perl_ckwarn() and Perl_ckwarn_d() disentangle the complex conditionals.
Nicholas Clark [Tue, 13 Oct 2009 10:30:14 +0000 (11:30 +0100)]
In Perl_ckwarn() and Perl_ckwarn_d() disentangle the complex conditionals.

It's much easier to see what is going on, if we use multiple return statements.

12 years agoReplace Perl_deprecate() with a macro that calls Perl_ck_warner()
Nicholas Clark [Tue, 13 Oct 2009 10:05:49 +0000 (11:05 +0100)]
Replace Perl_deprecate() with a macro that calls Perl_ck_warner()

Perl_deprecate was not part of the public API, and did not have a deprecate()
shortcut macro defined without -DPERL_CORE. Neither codesearch.google.com nor
CPAN::Unpack show any users outside the core.

12 years agoMove the code related to deprecate("comma-less variable list") into a function.
Nicholas Clark [Tue, 13 Oct 2009 09:27:36 +0000 (10:27 +0100)]
Move the code related to deprecate("comma-less variable list") into a function.

This makes all calls to deprecate() string constants.

12 years agoRemove category 'syntax' from 5 warnings that should just be in 'deprecated'.
Nicholas Clark [Tue, 13 Oct 2009 06:37:35 +0000 (07:37 +0100)]
Remove category 'syntax' from 5 warnings that should just be in 'deprecated'.

None were documented as also being in 'syntax'. Effectively, this completes the
reorganisation of commits 12bcd1a617c74d6e and 9014280dc8264580. See
http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2009-10/msg00601.html and
http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2002-03/msg00850.html

12 years agoUse deprecate() in place of deprecate_old(), and remove S_deprecate_old().
Nicholas Clark [Tue, 13 Oct 2009 06:12:04 +0000 (07:12 +0100)]
Use deprecate() in place of deprecate_old(), and remove S_deprecate_old().

12 years agockWARNreg() and ckWARNregdep() now use string concatenation, like their brethren
Nicholas Clark [Mon, 12 Oct 2009 17:48:38 +0000 (18:48 +0100)]
ckWARNreg() and ckWARNregdep() now use string concatenation, like their brethren

They had been concatenating "%s" REPORT_LOCATION, as they weren't passing in a
format string, which wasn't consistent with the 2-5 argument versions. None of
the strings passed in have % characters in them, so this is safe (and any static
analyser will be able to see this).

12 years agoReplace "%s"/SvPVX(sv_name) with "%"SVf/SVfARG(sv_name), which is UTF-8 safe.
Nicholas Clark [Mon, 12 Oct 2009 17:32:12 +0000 (18:32 +0100)]
Replace "%s"/SvPVX(sv_name) with "%"SVf/SVfARG(sv_name), which is UTF-8 safe.

12 years agoIn regcomp.c, where possible replace vWARN* with ckWARN*, using Perl_ck_warner.
Nicholas Clark [Mon, 12 Oct 2009 16:59:49 +0000 (17:59 +0100)]
In regcomp.c, where possible replace vWARN* with ckWARN*, using Perl_ck_warner.

This folds many pairs of ckWARN*() && Perl_warner() calls into singles call to
Perl_ck_warner(). vWARN(), vWARNdep() and vWARN2() are no longer used, so are
removed.

12 years agooverload no longer implicitly unsets fallback on repeated 'use overload' lines -...
Geoffrey T. Dairiki [Wed, 5 Aug 2009 00:54:34 +0000 (17:54 -0700)]
overload no longer implicitly unsets fallback on repeated 'use overload' lines - Fix for RT#68916

Subject: overload::import resets the setting of 'fallback'
Date: Tue, 04 Aug 2009 17:54:34 -0700
From: "Geoffrey T. Dairiki" <dairiki at dairiki.org>

12 years agoRemove Test-Simple's 00compile.t from core
Steve Hay [Mon, 12 Oct 2009 16:21:05 +0000 (17:21 +0100)]
Remove Test-Simple's 00compile.t from core

It required a hand-edited version of Test-Simple's MANIFEST due to the
exclusion of a .pm file from core, but we shouldn't have edited versions
of CPAN files in core. The presence of the MANIFEST file also caused
warnings from the Makefile.PL due to other files being excluded from core,
so rather than further editing of the MANIFEST it is simplest to just
remove it and the test that requires it.

12 years agoAdd Perl_ck_warner_d(), which combines Perl_ckwarn_d() and Perl_warner().
Nicholas Clark [Mon, 12 Oct 2009 15:39:02 +0000 (16:39 +0100)]
Add Perl_ck_warner_d(), which combines Perl_ckwarn_d() and Perl_warner().

Replace ckWARN_d{,2,3,4}() && Perl_warner() with it, which trades reduced code
size for 1 more function call if warnings are not enabled.

12 years agoAdd Perl_ck_warner(), which combines Perl_ckwarn() and Perl_warner().
Nicholas Clark [Mon, 12 Oct 2009 15:06:20 +0000 (16:06 +0100)]
Add Perl_ck_warner(), which combines Perl_ckwarn() and Perl_warner().

Replace ckWARN{,2,3,4}() && Perl_warner() with it, which trades reduced code
size (about 0.2%), for 1 more function call if warnings are not enabled.
However, if we're now in the L1 or L2 cache when we weren't previously, that's
still going to be a speed win.

12 years agoNormalise 3 fatal pack/unpack error messages to "panic: %s"
Nicholas Clark [Mon, 12 Oct 2009 14:54:30 +0000 (15:54 +0100)]
Normalise 3 fatal pack/unpack error messages to "panic: %s"

12 years agoIn uni_to_bytes(), fix ckWARN() anomaly.
Nicholas Clark [Mon, 12 Oct 2009 14:28:29 +0000 (15:28 +0100)]
In uni_to_bytes(), fix ckWARN() anomaly.

12 years agoRe-order a conditional with ckWARN() last, as it is a function call.
Nicholas Clark [Mon, 12 Oct 2009 13:53:52 +0000 (14:53 +0100)]
Re-order a conditional with ckWARN() last, as it is a function call.