This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
perl5.git
11 years agoExtract _handle_p_command.
Shlomi Fish [Sat, 6 Oct 2012 14:47:39 +0000 (16:47 +0200)]
Extract _handle_p_command.

11 years agoExtract _handle_doc_command.
Shlomi Fish [Sat, 6 Oct 2012 14:23:35 +0000 (16:23 +0200)]
Extract _handle_doc_command.

11 years ago[perl5db] Extract _handle_H_command.
Shlomi Fish [Sat, 6 Oct 2012 12:33:41 +0000 (14:33 +0200)]
[perl5db] Extract _handle_H_command.

11 years ago[perldb] Extract _handle_rc_search_history_command.
Shlomi Fish [Sat, 6 Oct 2012 11:33:34 +0000 (13:33 +0200)]
[perldb] Extract _handle_rc_search_history_command.

11 years agoAdd quotes.
Shlomi Fish [Sat, 6 Oct 2012 11:19:27 +0000 (13:19 +0200)]
Add quotes.

Without quotes the vim syntax was broken.

11 years ago[perl5db] Get rid of leading ampersands.
Shlomi Fish [Sat, 6 Oct 2012 11:04:39 +0000 (13:04 +0200)]
[perl5db] Get rid of leading ampersands.

11 years ago[perl5db] Avoid some trailing expressions.
Shlomi Fish [Fri, 5 Oct 2012 14:48:46 +0000 (16:48 +0200)]
[perl5db] Avoid some trailing expressions.

11 years ago[perl5db] Remove leading ampersands in sub call.
Shlomi Fish [Fri, 5 Oct 2012 14:28:25 +0000 (16:28 +0200)]
[perl5db] Remove leading ampersands in sub call.

11 years agoAdd a reminder comment;
Shlomi Fish [Fri, 5 Oct 2012 11:07:11 +0000 (13:07 +0200)]
Add a reminder comment;

11 years agoExtract _handle_rc_recall_command.
Shlomi Fish [Fri, 5 Oct 2012 10:59:48 +0000 (12:59 +0200)]
Extract _handle_rc_recall_command.

11 years agoExtract _DB__handle_question_mark_command() .
Shlomi Fish [Fri, 5 Oct 2012 09:40:34 +0000 (11:40 +0200)]
Extract _DB__handle_question_mark_command() .

11 years agoExtract _DB__handle_forward_slash_command().
Shlomi Fish [Fri, 5 Oct 2012 09:16:32 +0000 (11:16 +0200)]
Extract _DB__handle_forward_slash_command().

Converted away from string eval in the process.

11 years agoExtract _handle_W_command .
Shlomi Fish [Fri, 5 Oct 2012 06:01:50 +0000 (08:01 +0200)]
Extract _handle_W_command .

11 years agoExtract _handle_w_command.
Shlomi Fish [Fri, 5 Oct 2012 05:54:30 +0000 (07:54 +0200)]
Extract _handle_w_command.

11 years agoExtract _handle_T_command.
Shlomi Fish [Fri, 5 Oct 2012 05:43:31 +0000 (07:43 +0200)]
Extract _handle_T_command.

11 years ago[perl5db] Extract _handle_r_command.
Shlomi Fish [Thu, 4 Oct 2012 18:29:48 +0000 (20:29 +0200)]
[perl5db] Extract _handle_r_command.

11 years ago[perl5db] Extract _handle_c_command.
Shlomi Fish [Thu, 4 Oct 2012 18:09:40 +0000 (20:09 +0200)]
[perl5db] Extract _handle_c_command.

11 years agoExtract _handle_s_command and refactored.
Shlomi Fish [Thu, 4 Oct 2012 17:42:08 +0000 (19:42 +0200)]
Extract _handle_s_command and refactored.

11 years ago[perl5db] Extract _handle_n_command.
Shlomi Fish [Thu, 4 Oct 2012 17:30:17 +0000 (19:30 +0200)]
[perl5db] Extract _handle_n_command.

11 years agoExtract _DB__handle_y_command .
Shlomi Fish [Thu, 4 Oct 2012 17:16:28 +0000 (19:16 +0200)]
Extract _DB__handle_y_command .

11 years ago[perl5db] Extract $obj->_handle_dash_command.
Shlomi Fish [Thu, 4 Oct 2012 17:03:57 +0000 (19:03 +0200)]
[perl5db] Extract $obj->_handle_dash_command.

11 years ago[perl5db] Extract another function.
Shlomi Fish [Thu, 4 Oct 2012 16:41:13 +0000 (18:41 +0200)]
[perl5db] Extract another function.

11 years agoExtract _DB__handle_f_command.
Shlomi Fish [Thu, 4 Oct 2012 14:38:45 +0000 (16:38 +0200)]
Extract _DB__handle_f_command.

11 years agoExtract _handle_V_command_and_X_command.
Shlomi Fish [Wed, 3 Oct 2012 13:28:29 +0000 (15:28 +0200)]
Extract _handle_V_command_and_X_command.

11 years agoExtract _handle_S_command.
Shlomi Fish [Wed, 3 Oct 2012 13:04:43 +0000 (15:04 +0200)]
Extract _handle_S_command.

11 years agoFix "a [command]" statement.
Shlomi Fish [Wed, 3 Oct 2012 12:28:28 +0000 (14:28 +0200)]
Fix "a [command]" statement.

Without a line number. See:

https://rt.perl.org/rt3/Ticket/Display.html?id=115110 .

11 years ago$slave_editor → our.
Shlomi Fish [Tue, 2 Oct 2012 17:37:19 +0000 (19:37 +0200)]
$slave_editor → our.

11 years agoPlaced declarations on one line and sorted.
Shlomi Fish [Tue, 2 Oct 2012 17:09:40 +0000 (19:09 +0200)]
Placed declarations on one line and sorted.

11 years agoMore variables to our.
Shlomi Fish [Tue, 2 Oct 2012 17:00:13 +0000 (19:00 +0200)]
More variables to our.

11 years ago[perl5db] Convert more global vars to our.
Shlomi Fish [Tue, 2 Oct 2012 16:34:52 +0000 (18:34 +0200)]
[perl5db] Convert more global vars to our.

11 years ago[perl5db] Convert variables to our.
Shlomi Fish [Tue, 2 Oct 2012 16:15:48 +0000 (18:15 +0200)]
[perl5db] Convert variables to our.

This helps avoid calling them with $DB::var_name.

11 years agoRefactoring - convert $trace to our.
Shlomi Fish [Tue, 2 Oct 2012 16:05:21 +0000 (18:05 +0200)]
Refactoring - convert $trace to our.

11 years ago[perl5db] Extract a method.
Shlomi Fish [Tue, 2 Oct 2012 15:59:07 +0000 (17:59 +0200)]
[perl5db] Extract a method.

11 years ago[perl5db] Refactoring.
Shlomi Fish [Tue, 2 Oct 2012 15:47:27 +0000 (17:47 +0200)]
[perl5db] Refactoring.

11 years agoperl5db: extract a function.
Shlomi Fish [Tue, 2 Oct 2012 15:13:21 +0000 (17:13 +0200)]
perl5db: extract a function.

11 years ago[perl5db] Convert tabs to spaces.
Shlomi Fish [Tue, 2 Oct 2012 14:15:32 +0000 (16:15 +0200)]
[perl5db] Convert tabs to spaces.

11 years agoperl5db: fix some indentation that was off.
Shlomi Fish [Tue, 2 Oct 2012 14:05:45 +0000 (16:05 +0200)]
perl5db: fix some indentation that was off.

11 years ago[perl5db] Extract a function in the condition.
Shlomi Fish [Tue, 2 Oct 2012 13:57:13 +0000 (15:57 +0200)]
[perl5db] Extract a function in the condition.

11 years agoConvert comma-separated expressions to do{}.
Shlomi Fish [Tue, 2 Oct 2012 13:48:57 +0000 (15:48 +0200)]
Convert comma-separated expressions to do{}.

11 years agoperl5db: remove leading ampersand.
Shlomi Fish [Tue, 2 Oct 2012 13:31:53 +0000 (15:31 +0200)]
perl5db: remove leading ampersand.

11 years ago[perl5db] extract a subroutine.
Shlomi Fish [Tue, 2 Oct 2012 13:22:02 +0000 (15:22 +0200)]
[perl5db] extract a subroutine.

11 years ago[perl5db] Missed one.
Shlomi Fish [Tue, 2 Oct 2012 12:46:14 +0000 (14:46 +0200)]
[perl5db] Missed one.

11 years agoperl5db: Avoid trailing ifs with 2 expressions.
Shlomi Fish [Tue, 2 Oct 2012 12:39:15 +0000 (14:39 +0200)]
perl5db: Avoid trailing ifs with 2 expressions.

11 years ago[perl5db-refactor] Avoid trailing ifs.
Shlomi Fish [Tue, 2 Oct 2012 12:08:09 +0000 (14:08 +0200)]
[perl5db-refactor] Avoid trailing ifs.

11 years agoperl5db: no longer passing arguments to DB::eval().
Shlomi Fish [Mon, 1 Oct 2012 18:40:13 +0000 (20:40 +0200)]
perl5db: no longer passing arguments to DB::eval().

It didn't accept any arguments anyway.

11 years agoExtract a function.
Shlomi Fish [Mon, 1 Oct 2012 18:29:23 +0000 (20:29 +0200)]
Extract a function.

11 years agoperl5db: refactored a regex match.
Shlomi Fish [Mon, 1 Oct 2012 18:14:21 +0000 (20:14 +0200)]
perl5db: refactored a regex match.

This may improve performance a little.

11 years agoperl5db refactor: avoid ampersands, and trailing.
Shlomi Fish [Mon, 1 Oct 2012 15:48:23 +0000 (17:48 +0200)]
perl5db refactor: avoid ampersands, and trailing.

11 years ago[perl5db] Extract some subroutines.
Shlomi Fish [Mon, 1 Oct 2012 15:29:05 +0000 (17:29 +0200)]
[perl5db] Extract some subroutines.

11 years ago[perl5db] More refactoring.
Shlomi Fish [Mon, 1 Oct 2012 13:50:23 +0000 (15:50 +0200)]
[perl5db] More refactoring.

11 years agoExtract a common closure.
Shlomi Fish [Mon, 1 Oct 2012 13:40:48 +0000 (15:40 +0200)]
Extract a common closure.

11 years ago[perl5db] Refactoring.
Shlomi Fish [Mon, 1 Oct 2012 13:13:16 +0000 (15:13 +0200)]
[perl5db] Refactoring.

Remove leading ampersands, convert to lexical captures and add
an explicit return.

11 years ago[perl5db] Refactoring.
Shlomi Fish [Mon, 1 Oct 2012 12:43:02 +0000 (14:43 +0200)]
[perl5db] Refactoring.

11 years ago[perl5db] Refactored argument passing.
Shlomi Fish [Mon, 1 Oct 2012 11:57:51 +0000 (13:57 +0200)]
[perl5db] Refactored argument passing.

11 years ago[perl5db] Add explicit empty returns.
Shlomi Fish [Mon, 1 Oct 2012 11:47:54 +0000 (13:47 +0200)]
[perl5db] Add explicit empty returns.

See Perl Best Practices.

11 years ago[perl5db] Fix a bug - with a test.
Shlomi Fish [Mon, 1 Oct 2012 11:16:33 +0000 (13:16 +0200)]
[perl5db] Fix a bug - with a test.

The problem was that the arguments in print_help were not extracted correctly.

11 years agoExtract $DB::dbline[$DB::line].
Shlomi Fish [Sun, 30 Sep 2012 21:31:34 +0000 (23:31 +0200)]
Extract $DB::dbline[$DB::line].

11 years agoExtract append_to_position and append_to_prefix.
Shlomi Fish [Sun, 30 Sep 2012 21:21:24 +0000 (23:21 +0200)]
Extract append_to_position and append_to_prefix.

11 years agoExtract method _my_print_lineinfo.
Shlomi Fish [Sun, 30 Sep 2012 20:39:05 +0000 (22:39 +0200)]
Extract method _my_print_lineinfo.

11 years agoExtract DB::Obj - a class.
Shlomi Fish [Sun, 30 Sep 2012 20:26:47 +0000 (22:26 +0200)]
Extract DB::Obj - a class.

Converted some of the functions to its methods.

However, one function could not be moved out of "package DB;" so it
was left as a function.

11 years agoExtract _DB__grab_control().
Shlomi Fish [Sun, 30 Sep 2012 17:33:07 +0000 (19:33 +0200)]
Extract _DB__grab_control().

I'm a bit unhappy with the interface - I'm planning to extract a class
and an object to instantiate.

11 years agoExtract _DB__handle_watch_expressions() .
Shlomi Fish [Sun, 30 Sep 2012 17:11:02 +0000 (19:11 +0200)]
Extract _DB__handle_watch_expressions() .

11 years agoExtract _DB__determine_if_we_should_break() .
Shlomi Fish [Sun, 30 Sep 2012 15:22:28 +0000 (17:22 +0200)]
Extract _DB__determine_if_we_should_break() .

11 years ago[perl5db] More refactoring.
Shlomi Fish [Sun, 30 Sep 2012 15:15:18 +0000 (17:15 +0200)]
[perl5db] More refactoring.

11 years agoExtract _restore_shared_globals_after_restart.
Shlomi Fish [Sun, 30 Sep 2012 14:27:39 +0000 (16:27 +0200)]
Extract _restore_shared_globals_after_restart.

11 years agoExtract _restore_globals_after_restart.
Shlomi Fish [Sun, 30 Sep 2012 14:14:15 +0000 (16:14 +0200)]
Extract _restore_globals_after_restart.

11 years ago[perl5db-refactor] Extract a function.
Shlomi Fish [Sun, 30 Sep 2012 13:56:49 +0000 (15:56 +0200)]
[perl5db-refactor] Extract a function.

_restore_options_after_restart() .

11 years ago[perl5db] Extract a subroutine.
Shlomi Fish [Sun, 30 Sep 2012 13:49:18 +0000 (15:49 +0200)]
[perl5db] Extract a subroutine.

11 years ago[perl5db-refactor] Refactoring.
Shlomi Fish [Sun, 30 Sep 2012 13:28:23 +0000 (15:28 +0200)]
[perl5db-refactor] Refactoring.

11 years ago[perl5db-refactor] convert to use vars and &s.
Shlomi Fish [Sun, 30 Sep 2012 13:14:09 +0000 (15:14 +0200)]
[perl5db-refactor] convert to use vars and &s.

11 years ago[perl5db] Extract a function.
Shlomi Fish [Sun, 30 Sep 2012 12:17:09 +0000 (14:17 +0200)]
[perl5db] Extract a function.

11 years ago[perl5db] Remove a stray declaration.
Shlomi Fish [Sun, 30 Sep 2012 11:42:13 +0000 (13:42 +0200)]
[perl5db] Remove a stray declaration.

11 years ago[perl5db-refactor] Extract a method.
Shlomi Fish [Sun, 30 Sep 2012 10:37:31 +0000 (12:37 +0200)]
[perl5db-refactor] Extract a method.

11 years ago[perl5db-refactor] Extract _delete_all_breakpoints.
Shlomi Fish [Sun, 30 Sep 2012 00:51:07 +0000 (02:51 +0200)]
[perl5db-refactor] Extract _delete_all_breakpoints.

11 years ago[perl5db] Remove leading ampersands in sub calls.
Shlomi Fish [Sun, 30 Sep 2012 00:36:09 +0000 (02:36 +0200)]
[perl5db] Remove leading ampersands in sub calls.

11 years agoMore refactoring.
Shlomi Fish [Sun, 30 Sep 2012 00:30:27 +0000 (02:30 +0200)]
More refactoring.

11 years ago[perl5db] Remove ampersand.
Shlomi Fish [Sat, 29 Sep 2012 23:31:27 +0000 (01:31 +0200)]
[perl5db] Remove ampersand.

11 years ago[perl5db-refactor] Merge two conditionals.
Shlomi Fish [Sat, 29 Sep 2012 23:24:07 +0000 (01:24 +0200)]
[perl5db-refactor] Merge two conditionals.

11 years agoAdd more.
Shlomi Fish [Sat, 29 Sep 2012 23:14:56 +0000 (01:14 +0200)]
Add more.

11 years agoRefactored a loop.
Shlomi Fish [Sat, 29 Sep 2012 23:09:02 +0000 (01:09 +0200)]
Refactored a loop.

11 years ago[perl5db] Avoid predeclaration.
Shlomi Fish [Sat, 29 Sep 2012 22:54:56 +0000 (00:54 +0200)]
[perl5db] Avoid predeclaration.

11 years ago[perl5db] Refactored more.
Shlomi Fish [Sat, 29 Sep 2012 22:46:07 +0000 (00:46 +0200)]
[perl5db] Refactored more.

11 years ago[perl5db-refactor] Remove leading ampersands.
Shlomi Fish [Sat, 29 Sep 2012 22:26:38 +0000 (00:26 +0200)]
[perl5db-refactor] Remove leading ampersands.

From subroutine calls.

11 years ago[perl5db] refactoring + minor bug-fix.
Shlomi Fish [Sat, 29 Sep 2012 22:18:40 +0000 (00:18 +0200)]
[perl5db] refactoring + minor bug-fix.

The regex h\s* matches for every string that starts with "h". It should
match only if h is the only thing so a \z is needed.

11 years ago[perl5db-refactoring] Refactored parse_options.
Shlomi Fish [Sat, 29 Sep 2012 22:08:22 +0000 (00:08 +0200)]
[perl5db-refactoring] Refactored parse_options.

11 years ago[perl5db] Convert $| to ->autoflush(1).
Shlomi Fish [Sat, 29 Sep 2012 21:42:02 +0000 (23:42 +0200)]
[perl5db] Convert $| to ->autoflush(1).

11 years ago[perl5db] Refactor the LineInfo function.
Shlomi Fish [Sat, 29 Sep 2012 21:33:59 +0000 (23:33 +0200)]
[perl5db] Refactor the LineInfo function.

11 years ago[perl5db-refactoring] Got rid of trailing whitespace.
Shlomi Fish [Sat, 29 Sep 2012 21:18:01 +0000 (23:18 +0200)]
[perl5db-refactoring] Got rid of trailing whitespace.

11 years ago[perl5db-Refactor] Convert $_ to a lexical.
Shlomi Fish [Sat, 29 Sep 2012 21:01:25 +0000 (23:01 +0200)]
[perl5db-Refactor] Convert $_ to a lexical.

11 years ago[perl5db] Extract a function.
Shlomi Fish [Sat, 29 Sep 2012 20:53:00 +0000 (22:53 +0200)]
[perl5db] Extract a function.

11 years ago[perl5db] Remove some trailing space.
Shlomi Fish [Sat, 29 Sep 2012 20:42:30 +0000 (22:42 +0200)]
[perl5db] Remove some trailing space.

11 years ago[perl5db] More refactoring.
Shlomi Fish [Sat, 29 Sep 2012 20:34:52 +0000 (22:34 +0200)]
[perl5db] More refactoring.

1. Got rid of a trailing block comment because the block is shorter.

2. Now using something more sensible than s/^/perl/.

11 years ago[perl5db] Convert @pods to a hash and moved it out.
Shlomi Fish [Sat, 29 Sep 2012 20:21:53 +0000 (22:21 +0200)]
[perl5db] Convert @pods to a hash and moved it out.

This is part of the refactoring.

11 years agoMove away from more "or do { ... }" statements.
Shlomi Fish [Sat, 29 Sep 2012 19:29:14 +0000 (21:29 +0200)]
Move away from more "or do { ... }" statements.

11 years ago[perl5db] Refactored do {...}s into ifs.
Shlomi Fish [Sat, 29 Sep 2012 19:10:05 +0000 (21:10 +0200)]
[perl5db] Refactored do {...}s into ifs.

11 years ago[perl5db] More refactoring.
Shlomi Fish [Sat, 29 Sep 2012 18:33:50 +0000 (20:33 +0200)]
[perl5db] More refactoring.

1. Made the POD better.

2. Converted more && do to ifs.

3. More eq conversions.

4. Captures in lexical variables.

5. Using /ms instead of [\x00-\xFF].

11 years agoMore refactoring.
Shlomi Fish [Sat, 29 Sep 2012 17:47:19 +0000 (19:47 +0200)]
More refactoring.

11 years agoConvert some COND() && do to ifs.
Shlomi Fish [Sat, 29 Sep 2012 17:26:27 +0000 (19:26 +0200)]
Convert some COND() && do to ifs.

Also converted "^" and "$" to the less ambiguous \A and \z and converted
an /^q$/ to the "eq" operator.

Here I am starting to refactor the perl debugger.

11 years agoAdd a test for the frame option.
Shlomi Fish [Fri, 28 Sep 2012 18:03:12 +0000 (20:03 +0200)]
Add a test for the frame option.

11 years ago[perl5db] o PrintRet=0 in void context.
Shlomi Fish [Thu, 27 Sep 2012 18:31:27 +0000 (20:31 +0200)]
[perl5db] o PrintRet=0 in void context.