This is a live mirror of the Perl 5 development currently hosted at
17 years agoTeach Perl_do_sv_dump how to cope with IOs that have bogus things in
Nicholas Clark [Sat, 15 Apr 2006 22:44:30 +0000 (22:44 +0000)]
Teach Perl_do_sv_dump how to cope with IOs that have bogus things in
GV slots. (Which source filters are prone to do to them).

p4raw-id: //depot/perl@27827

17 years agoCoverity was getting upset about an assignment from a function
Nicholas Clark [Sat, 15 Apr 2006 21:50:12 +0000 (21:50 +0000)]
Coverity was getting upset about an assignment from a function
returning int to a U8 variable. Curiously it was only getting upset
about the first of many.
However, we are doing NO ERROR CHECKING on whether we read in the
requested number of bytes of bytecode. All except BGET_op_tr_array
will now croak on a short read.

p4raw-id: //depot/perl@27826

17 years agoCoverity reports that Storable can potentially cause a NULL pointer
Nicholas Clark [Sat, 15 Apr 2006 21:43:13 +0000 (21:43 +0000)]
Coverity reports that Storable can potentially cause a NULL pointer
dereference while iterating a hash. This should never happen unless
the hash lies about how many keys it has, so croak if a fib is spotted.

p4raw-id: //depot/perl@27825

17 years agoCoverity notes that resource are leaked in the unfinished and never
Nicholas Clark [Sat, 15 Apr 2006 21:11:44 +0000 (21:11 +0000)]
Coverity notes that resource are leaked in the unfinished and never
called function _utf8_to_bytes.

p4raw-id: //depot/perl@27824

17 years agoCoverity correctly reports that gv might (just) be NULL. So don't
Nicholas Clark [Sat, 15 Apr 2006 20:55:20 +0000 (20:55 +0000)]
Coverity correctly reports that gv might (just) be NULL. So don't
derefernece it if it is.

p4raw-id: //depot/perl@27823

17 years agoUpdate the assertion to a croak "Out of range special SV number"
Nicholas Clark [Sat, 15 Apr 2006 20:54:44 +0000 (20:54 +0000)]
Update the assertion to a croak "Out of range special SV number"
to give ByteLoader more meaningful failure diagnostics.

p4raw-id: //depot/perl@27822

17 years agoI believe that it makes little sense for the simple user filters
Nicholas Clark [Sat, 15 Apr 2006 20:19:22 +0000 (20:19 +0000)]
I believe that it makes little sense for the simple user filters
provided by coderefs to be run in block mode. Hence always read from
the upstream filter in line mode, and always call the user's filter
with 1 line.

p4raw-id: //depot/perl@27821

17 years agoFix a bug - the introduction of the caching code means that we should
Nicholas Clark [Sat, 15 Apr 2006 20:01:58 +0000 (20:01 +0000)]
Fix a bug - the introduction of the caching code means that we should
initialise the SV upstream after it.
assert that filter_sub is always non-null now.

p4raw-id: //depot/perl@27820

17 years agoAugment the user filter caching code so that if the user filter returns
Nicholas Clark [Sat, 15 Apr 2006 19:37:32 +0000 (19:37 +0000)]
Augment the user filter caching code so that if the user filter returns
multiple lines, only one line at a time is returned.
Rename the variable len to status, as it is the status value.

p4raw-id: //depot/perl@27819

17 years agoDeep in the bowels of creating new and exciting bugs, I managed to
Nicholas Clark [Sat, 15 Apr 2006 19:17:51 +0000 (19:17 +0000)]
Deep in the bowels of creating new and exciting bugs, I managed to
segfault the uninitialised value reporting code. This protects against
the segfault.

p4raw-id: //depot/perl@27818

17 years ago$foo .= $bar doesn't warn if $foo is undefined, so simplify code.
Nicholas Clark [Sat, 15 Apr 2006 18:08:04 +0000 (18:08 +0000)]
$foo .= $bar doesn't warn if $foo is undefined, so simplify code.

p4raw-id: //depot/perl@27817

17 years agoIf the downstream caller wants block mode, and we're in line mode,
Nicholas Clark [Sat, 15 Apr 2006 18:05:12 +0000 (18:05 +0000)]
If the downstream caller wants block mode, and we're in line mode,
then don't return more bytes than they asked for. Hold bytes over
until next time if necessary.

p4raw-id: //depot/perl@27816

17 years agoEliminate the filter_child_proc hack from pp_require.
Nicholas Clark [Sat, 15 Apr 2006 17:00:54 +0000 (17:00 +0000)]
Eliminate the filter_child_proc hack from pp_require.

p4raw-id: //depot/perl@27815

17 years agoIf you return void from a filter subroutine, the caller's status is
Nicholas Clark [Sat, 15 Apr 2006 16:43:22 +0000 (16:43 +0000)]
If you return void from a filter subroutine, the caller's status is
used. If not, your last statement is the return value, and if it keeps
being +ve you'll never hit EOF.
The probably should be a sanity check for this in toke.c, but I'm not
sure how.

p4raw-id: //depot/perl@27814

17 years agoTests for having multiple pipes open simultaneously.
Nicholas Clark [Sat, 15 Apr 2006 16:42:23 +0000 (16:42 +0000)]
Tests for having multiple pipes open simultaneously.
(See comment added in change 3771 about this apparently being buggy)

p4raw-id: //depot/perl@27813

17 years agoAdd more tests for the builtin source filter implementation, and fix
Nicholas Clark [Sat, 15 Apr 2006 13:45:13 +0000 (13:45 +0000)]
Add more tests for the builtin source filter implementation, and fix
two bugs - it would loop infinitely if data were already in the read
buffer, and it would process those data twice.

p4raw-id: //depot/perl@27812

17 years agoAdd a test for source filters returned from code references in @INC.
Nicholas Clark [Sat, 15 Apr 2006 11:59:26 +0000 (11:59 +0000)]
Add a test for source filters returned from code references in @INC.

p4raw-id: //depot/perl@27811

17 years agoBump the expect file count in readdir.t. We keep writing more tests.
Nicholas Clark [Sat, 15 Apr 2006 11:22:29 +0000 (11:22 +0000)]
Bump the expect file count in readdir.t. We keep writing more tests.

p4raw-id: //depot/perl@27810

17 years agoperlio.c: layer data might be allocated and unused (Coverity)
Jarkko Hietaniemi [Sat, 15 Apr 2006 11:24:17 +0000 (14:24 +0300)]
perlio.c: layer data might be allocated and unused (Coverity)
Message-Id: <>

(with a correction)

p4raw-id: //depot/perl@27809

17 years agoFix bug in prime_env_iter where the terms of a comparison were reversed
juna [Fri, 24 Mar 2006 13:52:41 +0000 (05:52 -0800)]
Fix bug in prime_env_iter where the terms of a comparison were reversed
so we thought we didn't have a logical name table when we did.  Reported as:
Subject: LWP::Simple crashes on VMSperl
From: "juna" <>
Newsgroups: comp.os.vms,comp.lang.perl.misc
Message-ID: <>

p4raw-id: //depot/perl@27808

17 years agoHonor READALL privilege in cando_by_name (from Scott
Craig A. Berry [Sat, 15 Apr 2006 00:45:26 +0000 (00:45 +0000)]
Honor READALL privilege in cando_by_name (from Scott
Lepage of HP OpenVMS Engineering)

p4raw-id: //depot/perl@27807

17 years agoDon't die after SS$_NOPRIV in Perl_vmssetenv, courtesy
Craig A. Berry [Sat, 15 Apr 2006 00:42:41 +0000 (00:42 +0000)]
Don't die after SS$_NOPRIV in Perl_vmssetenv, courtesy
of Scott Lepage at HP.

p4raw-id: //depot/perl@27806

17 years agoChange SAVECOPWARNINGS(c) to SAVECOMPILEWARNINGS() - it's only used to
Nicholas Clark [Fri, 14 Apr 2006 20:44:27 +0000 (20:44 +0000)]
Change SAVECOPWARNINGS(c) to SAVECOMPILEWARNINGS() - it's only used to
save the warnings on PL_compiling, so constraining its use to what we
can test seems to make sense. Particularly as testing Perl_ss_dup is

p4raw-id: //depot/perl@27805

17 years agoIn the description of require, clarify the file handle return and why
Nicholas Clark [Fri, 14 Apr 2006 19:44:34 +0000 (19:44 +0000)]
In the description of require, clarify the file handle return and why
C<INC> must be qualified.

p4raw-id: //depot/perl@27804

17 years ago S_glob_2inpuv() did not check if lenp was NULL. Oops.
Nicholas Clark [Fri, 14 Apr 2006 16:43:03 +0000 (16:43 +0000)]
 S_glob_2inpuv() did not check if lenp was NULL. Oops.

p4raw-id: //depot/perl@27803

17 years agoReplace explict "/dev/null" with BIT_BUCKET, which varies by platform.
Nicholas Clark [Fri, 14 Apr 2006 16:18:30 +0000 (16:18 +0000)]
Replace explict "/dev/null" with BIT_BUCKET, which varies by platform.

p4raw-id: //depot/perl@27802

17 years agodoop.c: (Coverity) found a bug but not quite what Coverity thought it did (try valgri...
Jarkko Hietaniemi [Thu, 13 Apr 2006 19:20:46 +0000 (22:20 +0300)]
doop.c: (Coverity) found a bug but not quite what Coverity thought it did (try valgrind on the new bop.t without the doop.c patch)
Message-Id: <>

p4raw-id: //depot/perl@27801

17 years agoMark new_warnings_bitfield as XE, and add it to __DATA__ in
Nicholas Clark [Fri, 14 Apr 2006 14:45:04 +0000 (14:45 +0000)]
Mark new_warnings_bitfield as XE, and add it to __DATA__ in
Remove a reference to the deleted function Perl_refcounted_he_dup.

p4raw-id: //depot/perl@27800

17 years agoIO::Compress::*
Paul Marquess [Fri, 14 Apr 2006 09:05:39 +0000 (10:05 +0100)]
Message-ID: <004f01c65f9a$3871eb30$>

p4raw-id: //depot/perl@27799

17 years agoperlio.c: (Coverity) eliminate temp ptr that confuses Coverity into thinking there...
Jarkko Hietaniemi [Fri, 14 Apr 2006 11:56:44 +0000 (14:56 +0300)]
perlio.c: (Coverity) eliminate temp ptr that confuses Coverity into thinking there is a resource leak
Message-Id: <>
Date: Fri, 14 Apr 2006 11:56:44 +0300 (EEST)

p4raw-id: //depot/perl@27798

17 years agoReverting change #27791 which may cause corruption addition corruption
Steve Peters [Fri, 14 Apr 2006 11:26:59 +0000 (11:26 +0000)]
Reverting change #27791 which may cause corruption addition corruption
within a regular expression.
p4raw-link: @27791 on //depot/perl: 4ae2f9814731932908f61ce4a79c6da6063584e7

p4raw-id: //depot/perl@27797

17 years agoFix implementation of threads->_handle on unixes.
Jerry D. Hedden [Tue, 4 Apr 2006 09:25:20 +0000 (02:25 -0700)]
Fix implementation of threads->_handle on unixes.
See :
Subject: RE: [PATCH] 2nd patch to sync blead 'threads' with CPAN [REPOST]
From: "Jerry D. Hedden" <>
Message-ID: <>

p4raw-id: //depot/perl@27796

17 years ago(Hopefully) fix coredumps in ByteLoader, which were a side effect of
Nicholas Clark [Thu, 13 Apr 2006 21:59:52 +0000 (21:59 +0000)]
(Hopefully) fix coredumps in ByteLoader, which were a side effect of
fixing a bug in B, and non-robust autogenerated code. When
autogenerating initialiser statements for an array, it's a bad plan to
have the size of that array hard coded.

p4raw-id: //depot/perl@27795

17 years agoeliminate PL_regbol PL_regtill PL_regnarrate PL_reg_ganch PL_reg_sv
Dave Mitchell [Thu, 13 Apr 2006 18:31:54 +0000 (18:31 +0000)]
eliminate PL_regbol PL_regtill PL_regnarrate PL_reg_ganch PL_reg_sv
(only another 434 to go ...)

p4raw-id: //depot/perl@27794

17 years agodisable 'split /(?{ split "" })/' test until recursive split is fixed
Dave Mitchell [Thu, 13 Apr 2006 17:16:41 +0000 (17:16 +0000)]
disable 'split /(?{ split "" })/' test until recursive split is fixed

p4raw-id: //depot/perl@27793

17 years agoRemove SAVEt_FREESHAREDPV, as nothing is using it, and it isn't catered
Nicholas Clark [Thu, 13 Apr 2006 16:14:23 +0000 (16:14 +0000)]
Remove SAVEt_FREESHAREDPV, as nothing is using it, and it isn't catered
for in Perl_ss_dup, hence nothing is testing it and nothing will alert
us if it breaks.

p4raw-id: //depot/perl@27792

17 years agoAdd another NULL check thanks to Coverity.
Steve Peters [Thu, 13 Apr 2006 15:08:04 +0000 (15:08 +0000)]
Add another NULL check thanks to Coverity.

p4raw-id: //depot/perl@27791

17 years agoFor duping SAVEHINTS it rather helps if you pay attention to what is
Nicholas Clark [Thu, 13 Apr 2006 14:14:57 +0000 (14:14 +0000)]
For duping SAVEHINTS it rather helps if you pay attention to what is
actually being pushed onto the save stack.

p4raw-id: //depot/perl@27790

17 years agoregexec.c: (Coverity) add NULL check
Jarkko Hietaniemi [Thu, 13 Apr 2006 15:52:15 +0000 (18:52 +0300)]
regexec.c: (Coverity) add NULL check
Message-Id: <>
Date: Thu, 13 Apr 2006 15:52:15 +0300 (EEST)

p4raw-id: //depot/perl@27789

17 years agoregexec.c: (Coverity) move NULL check even earlier
Jarkko Hietaniemi [Thu, 13 Apr 2006 15:39:33 +0000 (18:39 +0300)]
regexec.c: (Coverity) move NULL check even earlier
Message-Id: <>
Date: Thu, 13 Apr 2006 15:39:33 +0300 (EEST)

p4raw-id: //depot/perl@27788

17 years agoAdd a break; to the end of the SAVEt_COP_WARNINGS case, and don't try
Nicholas Clark [Thu, 13 Apr 2006 13:02:30 +0000 (13:02 +0000)]
Add a break; to the end of the SAVEt_COP_WARNINGS case, and don't try
to dereference cop_hints if it's NULL.

p4raw-id: //depot/perl@27787

17 years agoFix B and ByteLoader to cope with cop_warnings no longer being an SV.
Nicholas Clark [Thu, 13 Apr 2006 12:40:24 +0000 (12:40 +0000)]
Fix B and ByteLoader to cope with cop_warnings no longer being an SV.

p4raw-id: //depot/perl@27786

17 years agoAdd SAVEt_COP_WARNINGS to ss_dup.
Nicholas Clark [Thu, 13 Apr 2006 10:46:32 +0000 (10:46 +0000)]
Add SAVEt_COP_WARNINGS to ss_dup.

p4raw-id: //depot/perl@27785

17 years agoRe: [PATCH] add pTHX_ parameter to new_warnings_bitfield()
Steve Hay [Thu, 13 Apr 2006 10:27:52 +0000 (11:27 +0100)]
Re: [PATCH] add pTHX_ parameter to new_warnings_bitfield()
Message-ID: <>
Date: Thu, 13 Apr 2006 10:27:52 +0100

p4raw-id: //depot/perl@27784

17 years agoeliminate PL_reg_re
Dave Mitchell [Thu, 13 Apr 2006 02:20:33 +0000 (02:20 +0000)]
eliminate PL_reg_re
(only another 439 to go ...)

p4raw-id: //depot/perl@27783

17 years ago[perl #38906] Regex engine does not release MINMOD
Animator [Wed, 12 Apr 2006 15:27:41 +0000 (08:27 -0700)]
[perl #38906] Regex engine does not release MINMOD
From: "Animator via RT" <>
Message-ID: <>

zero-length minimum matches that failed could leak into a following
maximal match

p4raw-id: //depot/perl@27782

17 years agoD'oh! Don't try to do #ifdefs inside "functions" that are actually
Nicholas Clark [Wed, 12 Apr 2006 23:17:18 +0000 (23:17 +0000)]
D'oh! Don't try to do #ifdefs inside "functions" that are actually

p4raw-id: //depot/perl@27781

17 years agoAdd tests for all the other types that %^H serialisation is supposed
Nicholas Clark [Wed, 12 Apr 2006 22:49:58 +0000 (22:49 +0000)]
Add tests for all the other types that %^H serialisation is supposed
to support. In the process, found and corrected a bug.
Tests are good, m'kay.

p4raw-id: //depot/perl@27780

17 years agoChange cop_warnings from an SV holding the warnings bitmask to a
Nicholas Clark [Wed, 12 Apr 2006 22:45:12 +0000 (22:45 +0000)]
Change cop_warnings from an SV holding the warnings bitmask to a
directly (shared) malloc()ed buffer holding the warnings bitmask.
This avoids bugs/crashes when the interpreter that created an optree
is freed but the optree remains in use by other interpreters.

p4raw-id: //depot/perl@27779

17 years agoRemove the final recursion path from S_regmatch: (??{...})
Dave Mitchell [Wed, 12 Apr 2006 22:43:03 +0000 (22:43 +0000)]
Remove the final recursion path from S_regmatch:  (??{...})
Also put PUSH/POP_STATE infastructure in place
Also eliminate PL_reg_call_cc
       (only another 440 global vars to go ...)

p4raw-id: //depot/perl@27778

17 years agoTest that we can do embedded 0 bytes in hints.
Nicholas Clark [Wed, 12 Apr 2006 16:18:30 +0000 (16:18 +0000)]
Test that we can do embedded 0 bytes in hints.

p4raw-id: //depot/perl@27777

17 years agoStore cop_hints as a shared structure without using any SVs (on
Nicholas Clark [Wed, 12 Apr 2006 16:01:08 +0000 (16:01 +0000)]
Store cop_hints as a shared structure without using any SVs (on

p4raw-id: //depot/perl@27776

17 years agoRemove Perl_refcounted_he_copy and Perl_refcounted_he_dup.
Nicholas Clark [Wed, 12 Apr 2006 14:14:50 +0000 (14:14 +0000)]
Remove Perl_refcounted_he_copy and Perl_refcounted_he_dup.

p4raw-id: //depot/perl@27775

17 years agoNewxz() can use calloc() rather than malloc(), as the implementation
Nicholas Clark [Wed, 12 Apr 2006 12:31:29 +0000 (12:31 +0000)]
Newxz() can use calloc() rather than malloc(), as the implementation
of calloc() may know that it has fresh pages from the OS, and so
doesn't need to zero them itself. Plus our object code should be
slightly smaller.

p4raw-id: //depot/perl@27774

17 years agoAs OPs are shared between threads, they should be using
Nicholas Clark [Wed, 12 Apr 2006 12:01:38 +0000 (12:01 +0000)]
As OPs are shared between threads, they should be using
PerlMemShared_*alloc functions, rather than per-thread *alloc()s.

p4raw-id: //depot/perl@27773

17 years agoregexec.c: move NULL check earlier to make Coverity happier
Jarkko Hietaniemi [Tue, 11 Apr 2006 23:04:48 +0000 (02:04 +0300)]
regexec.c: move NULL check earlier to make Coverity happier
Message-Id: <>
Date: Tue, 11 Apr 2006 23:04:48 +0300 (EEST)

p4raw-id: //depot/perl@27772

17 years agoregcomp.c (try II): use &PL_sv_undef for listsv as suggested by Nick
Jarkko Hietaniemi [Tue, 11 Apr 2006 23:53:25 +0000 (02:53 +0300)]
regcomp.c (try II): use &PL_sv_undef for listsv as suggested by Nick
Message-Id: <>
Date: Tue, 11 Apr 2006 23:53:25 +0300 (EEST)

p4raw-id: //depot/perl@27771

17 years agoperlio.c: false Coverity finding (it cannot see that two pointers are the same):...
Jarkko Hietaniemi [Tue, 11 Apr 2006 23:39:32 +0000 (02:39 +0300)]
perlio.c: false Coverity finding (it cannot see that two pointers are the same): but help Coverity by removing the temp ptr
Message-Id: <>
Date: Tue, 11 Apr 2006 23:39:32 +0300 (EEST)

p4raw-id: //depot/perl@27770

17 years agolocale.c: more Safefree() (Coverity finding)
Jarkko Hietaniemi [Tue, 11 Apr 2006 22:08:40 +0000 (01:08 +0300)]
locale.c: more Safefree() (Coverity finding)
Message-Id: <>
Date: Tue, 11 Apr 2006 22:08:40 +0300 (EEST)

p4raw-id: //depot/perl@27769

17 years agoFirst stab at using the pad to store the serialised hints data.
Nicholas Clark [Tue, 11 Apr 2006 19:26:48 +0000 (19:26 +0000)]
First stab at using the pad to store the serialised hints data.
This approach is almost certainly not only wrong, but also doomed.
But it's needed to build a correct solution.

p4raw-id: //depot/perl@27768

17 years agoWithin Perl_newSVhek, inline most of newSVpvn_share(), because
Nicholas Clark [Tue, 11 Apr 2006 18:06:30 +0000 (18:06 +0000)]
Within Perl_newSVhek, inline most of newSVpvn_share(), because
share_hek_hek() is far more efficient than sharepvn().

p4raw-id: //depot/perl@27767

17 years agoStop Perl_newSVpvn_share() potentially leaking the return result from
Nicholas Clark [Tue, 11 Apr 2006 16:17:13 +0000 (16:17 +0000)]
Stop Perl_newSVpvn_share() potentially leaking the return result from

p4raw-id: //depot/perl@27766

17 years agoNeed to migrate the refcounted_he structure to be properly shared.
Nicholas Clark [Tue, 11 Apr 2006 13:47:05 +0000 (13:47 +0000)]
Need to migrate the refcounted_he structure to be properly shared.
Add a mutex for manipulated their reference counts.
Unwrap the structure, so that for ithreads it can store SVs in pads.

p4raw-id: //depot/perl@27764

17 years agoQuiet a coverity problem
Andy Lester [Mon, 10 Apr 2006 23:51:50 +0000 (18:51 -0500)]
Quiet a coverity problem
Message-ID: <>

p4raw-id: //depot/perl@27763

17 years agoAll S_dumpuntil()'s regnode pointer arguments can be const.
Nicholas Clark [Mon, 10 Apr 2006 19:55:49 +0000 (19:55 +0000)]
All S_dumpuntil()'s regnode pointer arguments can be const.

p4raw-id: //depot/perl@27762

17 years agoPerl_unsharepvn() was no longer being used in core, and changes to
Nicholas Clark [Mon, 10 Apr 2006 17:48:04 +0000 (17:48 +0000)]
Perl_unsharepvn() was no longer being used in core, and changes to
S_unshare_hek_or_pvn() had broken it. Now fixed and tested.

p4raw-id: //depot/perl@27761

17 years agoconfig_H being the last part of my mkglossary work
H.Merijn Brand [Mon, 10 Apr 2006 16:35:30 +0000 (16:35 +0000)]
config_H being the last part of my mkglossary work

p4raw-id: //depot/perl@27760

17 years agoRegeneration of Glossary and the underlying tools.
H.Merijn Brand [Mon, 10 Apr 2006 16:14:32 +0000 (16:14 +0000)]
Regeneration of Glossary and the underlying tools.

p4raw-id: //depot/perl@27758

17 years agoFix coverity warning in utf8.c
Andy Dougherty [Mon, 10 Apr 2006 11:18:35 +0000 (07:18 -0400)]
Fix coverity warning in utf8.c
Message-ID: <>

p4raw-id: //depot/perl@27757

17 years agopp_sys.c: some Coverity findings: NULL guards for format cv
Jarkko Hietaniemi [Sat, 8 Apr 2006 18:55:41 +0000 (21:55 +0300)]
pp_sys.c: some Coverity findings: NULL guards for format cv
Message-Id: <>
Date: Sat,  8 Apr 2006 18:55:41 +0300 (EEST)

p4raw-id: //depot/perl@27756

17 years agopp_sys.c: some Coverity findings: NULL guards for io pointers
Jarkko Hietaniemi [Sat, 8 Apr 2006 18:52:32 +0000 (21:52 +0300)]
pp_sys.c: some Coverity findings: NULL guards for io pointers
Message-Id: <>
Date: Sat,  8 Apr 2006 18:52:32 +0300 (EEST)

p4raw-id: //depot/perl@27755

17 years agoes: quiet some warnings (with a free AIX cpp insanity avoidance tip)
Jarkko Hietaniemi [Sat, 8 Apr 2006 09:58:43 +0000 (12:58 +0300)]
es: quiet some warnings (with a free AIX cpp insanity avoidance tip)
Message-ID: <>
Date: Sat, 08 Apr 2006 09:58:43 +0300

p4raw-id: //depot/perl@27754

17 years agoTrue consting goodness in regexes
Andy Lester [Mon, 10 Apr 2006 02:15:58 +0000 (21:15 -0500)]
True consting goodness in regexes
Message-Id:  <>

p4raw-id: //depot/perl@27753

17 years agoFix pointer error in change 27741, spotted by John E. Malmberg.
Nicholas Clark [Sun, 9 Apr 2006 21:07:48 +0000 (21:07 +0000)]
Fix pointer error in change 27741, spotted by John E. Malmberg.

p4raw-id: //depot/perl@27752

17 years agoRe: [PATCH] perlio.c: Coverity finding: finding false (Coverity notable to follow...
Jarkko Hietaniemi [Sun, 9 Apr 2006 10:18:52 +0000 (13:18 +0300)]
Re: [PATCH] perlio.c: Coverity finding: finding false (Coverity notable to follow vtable logic) but adding an assert
Message-ID: <>

p4raw-id: //depot/perl@27751

17 years agoRe: [PATCH] locale.c: Coverity finding
Jarkko Hietaniemi [Sun, 9 Apr 2006 10:31:32 +0000 (13:31 +0300)]
Re: [PATCH] locale.c: Coverity finding
Message-ID: <>

p4raw-id: //depot/perl@27750

17 years agoRename variables in some mg_* funcs
Andy Lester [Sun, 9 Apr 2006 00:20:12 +0000 (19:20 -0500)]
Rename variables in some mg_* funcs
Message-ID: <>

p4raw-id: //depot/perl@27749

17 years agofix potential null deref introduced by change #27716
Dave Mitchell [Sat, 8 Apr 2006 23:58:51 +0000 (23:58 +0000)]
fix potential null deref introduced by change #27716
p4raw-link: @27716 on //depot/perl: 4f639d21b5c9a079a204ea1a0168f3c1a4ed5214

p4raw-id: //depot/perl@27746

17 years agoperlio.c: Coverity finding: finding false (Coverity not able to follow vtable logic...
Jarkko Hietaniemi [Sat, 8 Apr 2006 19:11:36 +0000 (22:11 +0300)]
perlio.c: Coverity finding: finding false (Coverity not able to follow vtable logic) but adding an assert
Message-Id: <>
Date: Sat,  8 Apr 2006 19:11:36 +0300 (EEST)

p4raw-id: //depot/perl@27745

17 years agosv.c, rs.t, perlvar.pod (Coverity finding: did you know what happens with $/=\0?)
Jarkko Hietaniemi [Sat, 8 Apr 2006 18:25:33 +0000 (21:25 +0300)]
sv.c, rs.t, perlvar.pod (Coverity finding: did you know what happens with $/=\0?)
Message-Id: <>

(although I should add that this version of Coverity is actually
raising a false positive here, albeit something still interesting)

p4raw-id: //depot/perl@27744

17 years agoAs av_dup, gv_dup and hv_dup are the same as sv_dup, code in various
Nicholas Clark [Sat, 8 Apr 2006 15:14:13 +0000 (15:14 +0000)]
As av_dup, gv_dup and hv_dup are the same as sv_dup, code in various
branches of Perl_ss_dup() is actually duplicated, so can be merged.

p4raw-id: //depot/perl@27741

17 years agoBy swapping the order of pushes onto the save stack for
Nicholas Clark [Sat, 8 Apr 2006 14:46:53 +0000 (14:46 +0000)]
By swapping the order of pushes onto the save stack for
SAVEt_GENERIC_PVREF, we can merge it with SAVEt_PPTR in Perl_ss_dup().

p4raw-id: //depot/perl@27740

17 years agoTeach ss_dup about SAVEt_RE_STATE. (As correctly as it ever was before)
Nicholas Clark [Sat, 8 Apr 2006 13:43:46 +0000 (13:43 +0000)]
Teach ss_dup about SAVEt_RE_STATE. (As correctly as it ever was before)

p4raw-id: //depot/perl@27739

17 years agoss_dup of SAVEt_COP_ARYBASE can use the same code as SAVEt_I8.
Nicholas Clark [Sat, 8 Apr 2006 12:50:13 +0000 (12:50 +0000)]
ss_dup of SAVEt_COP_ARYBASE can use the same code as SAVEt_I8.

p4raw-id: //depot/perl@27738

17 years agoGive more information in the panic in ss_dup. (Although I'm not sure
Nicholas Clark [Fri, 7 Apr 2006 21:24:35 +0000 (21:24 +0000)]
Give more information in the panic in ss_dup. (Although I'm not sure
if croak() works at this point, given PerlIO's dependency on a
functional interpreter.)

p4raw-id: //depot/perl@27737

17 years agoMake perl_fini() run when compiling perl with
Gisle Aas [Fri, 7 Apr 2006 16:08:26 +0000 (16:08 +0000)]
Make perl_fini() run when compiling perl with
the Sun WorkShop compiler.

p4raw-id: //depot/perl@27736

17 years agoPatch from Jarkko to fix breakage caused by change #27649
Steve Hay [Fri, 7 Apr 2006 14:55:41 +0000 (14:55 +0000)]
Patch from Jarkko to fix breakage caused by change #27649
p4raw-link: @27649 on //depot/perl: 9ddc1e7af8675795ad0346c1274fd40d4096c50f

p4raw-id: //depot/perl@27735

17 years agoOops. Being too terse for my own good - it's not a great idea to chain
Nicholas Clark [Fri, 7 Apr 2006 12:49:11 +0000 (12:49 +0000)]
Oops. Being too terse for my own good - it's not a great idea to chain
assignment of char * to struct pmop *, even when the value is NULL.

p4raw-id: //depot/perl@27734

17 years ago[patch@27694] VMS RMSEXPAND/PERL_CANDO fixes
John E. Malmberg [Mon, 3 Apr 2006 07:39:10 +0000 (03:39 -0400)]
[patch@27694] VMS RMSEXPAND/PERL_CANDO fixes
From: "John E. Malmberg" <>
Message-id: <>

p4raw-id: //depot/perl@27733

17 years agoMove all the regexp state variables into a single structure.
Nicholas Clark [Thu, 6 Apr 2006 15:52:37 +0000 (15:52 +0000)]
Move all the regexp state variables into a single structure.
This allows it to be saved, restored and cloned with a single Copy()
(but inevitably still some fixup)

p4raw-id: //depot/perl@27732

17 years agoRe: Smoke [5.9.4] 27728 FAIL(F) MSWin32 WinXP/.Net SP2 (x86/2 cpu)
Rafael Garcia-Suarez [Thu, 6 Apr 2006 14:32:50 +0000 (16:32 +0200)]
Re: Smoke [5.9.4] 27728 FAIL(F) MSWin32 WinXP/.Net SP2 (x86/2 cpu)
Message-ID: <>

p4raw-id: //depot/perl@27731

17 years agoFix skip count in ext\B\t\lint.t
Steve Hay [Thu, 6 Apr 2006 12:16:53 +0000 (12:16 +0000)]
Fix skip count in ext\B\t\lint.t

p4raw-id: //depot/perl@27729

17 years agoSave the regexp engine state as 1 block on the save stack.
Nicholas Clark [Wed, 5 Apr 2006 21:40:11 +0000 (21:40 +0000)]
Save the regexp engine state as 1 block on the save stack.

p4raw-id: //depot/perl@27728

17 years agoRe: expr foreach (...) isn't a B::Lint warning anymore
Joshua ben Jore [Wed, 5 Apr 2006 01:11:11 +0000 (20:11 -0500)]
Re: expr foreach (...) isn't a B::Lint warning anymore
From: "Joshua ben Jore" <>
Message-ID: <>

p4raw-id: //depot/perl@27727

17 years agoPerl_save_alloc can use the new(er) SSGROW rather than looping.
Nicholas Clark [Wed, 5 Apr 2006 20:19:34 +0000 (20:19 +0000)]
Perl_save_alloc can use the new(er) SSGROW rather than looping.

p4raw-id: //depot/perl@27726

17 years agoAssigning undef to an entry in %ENV shouldn't produce warnings, even
Rafael Garcia-Suarez [Wed, 5 Apr 2006 19:45:42 +0000 (19:45 +0000)]
Assigning undef to an entry in %ENV shouldn't produce warnings, even
though it's silently converted to ""

p4raw-id: //depot/perl@27725

17 years agoTry not to use negative values when accessing arrays in C. Yet another
Steve Peters [Wed, 5 Apr 2006 16:15:41 +0000 (16:15 +0000)]
Try not to use negative values when accessing arrays in C.  Yet another
Coverity catch.

p4raw-id: //depot/perl@27724

17 years agoInitializing variables is good. This is another Coverity catch.
Steve Peters [Wed, 5 Apr 2006 15:31:18 +0000 (15:31 +0000)]
Initializing variables is good.  This is another Coverity catch.

p4raw-id: //depot/perl@27723

17 years agoperlio.c breaks on Solaris/gcc when > 256 FDs are available
Alan Burlison [Wed, 5 Apr 2006 15:52:14 +0000 (16:52 +0100)]
perlio.c breaks on Solaris/gcc when > 256 FDs are available
Message-ID: <>

p4raw-id: //depot/perl@27722

17 years agoThere should be only one META.yml file
Rafael Garcia-Suarez [Wed, 5 Apr 2006 12:56:10 +0000 (12:56 +0000)]
There should be only one META.yml file

p4raw-id: //depot/perl@27721