This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
perl5.git
9 years agoMention the fix to perlfunc.html in "Configuration and Compilation" as well.
Abigail [Mon, 19 Mar 2012 21:04:14 +0000 (22:04 +0100)]
Mention the fix to perlfunc.html in "Configuration and Compilation" as well.

Also, fix the spelling of html.

9 years agoNote in the source of perlhist.pod that "cow orker" is no typo.
Nicholas Clark [Mon, 19 Mar 2012 13:43:15 +0000 (14:43 +0100)]
Note in the source of perlhist.pod that "cow orker" is no typo.

This won't change the rendered pod, but will clarify to anyone thinking to
patch the "mistake" that the seeming typo is intentional.

9 years agoMention Porting/bisect.pl in perlgit.pod, before describing git bisect.
Nicholas Clark [Mon, 19 Mar 2012 13:22:32 +0000 (14:22 +0100)]
Mention Porting/bisect.pl in perlgit.pod, before describing git bisect.

Porting/bisect.pl is intended to cover 90% of use cases, whilst being simpler
to use than git bisect, so mention it first. Condense the description of
git bisect slightly - it's giving implementation details which duplicate
git help bisect, which we already refer the reader to.

9 years agoAdd two missing "file"s to the documentation of Porting/bisect.pl
Nicholas Clark [Mon, 19 Mar 2012 12:58:47 +0000 (13:58 +0100)]
Add two missing "file"s to the documentation of Porting/bisect.pl

9 years agoMove the example git bisect shell script from perlgit.pod to Porting/
Nicholas Clark [Mon, 19 Mar 2012 12:27:28 +0000 (13:27 +0100)]
Move the example git bisect shell script from perlgit.pod to Porting/

This both avoids cluttering the flow of manpage with auxiliary data, and
saves the user from having to extract the script from within the pod file.

9 years agobisect-runner.pl should detect ccache with -V, not --version
Nicholas Clark [Mon, 19 Mar 2012 11:48:31 +0000 (12:48 +0100)]
bisect-runner.pl should detect ccache with -V, not --version

ccache 2.4 doesn't support the --version parameter, only -V. ccache 3
supports both.

9 years agoAdd a placeholder man page for perltodo, directing people to look at git.
Nicholas Clark [Mon, 19 Mar 2012 11:18:18 +0000 (12:18 +0100)]
Add a placeholder man page for perltodo, directing people to look at git.

(Done as a second commit to avoid confusing git's rename detection.)

9 years agoMove the todo list from pod/ to Porting/
Nicholas Clark [Mon, 19 Mar 2012 10:42:15 +0000 (11:42 +0100)]
Move the todo list from pod/ to Porting/

Installing the Perl 5 to-do list as a manpage isn't that useful to anyone, as
it's a snapshot that becomes increasingly out of date. Much better to point
anyone interested in contributing direct to git HEAD, to view the current list.

9 years agoAdd a TODO test for RT 111842
Abigail [Mon, 19 Mar 2012 16:16:21 +0000 (17:16 +0100)]
Add a TODO test for RT 111842

9 years agoBail out if it looks scary.
Abigail [Mon, 19 Mar 2012 13:40:02 +0000 (14:40 +0100)]
Bail out if it looks scary.

Porting/sync-with-cpan hasn't automated all situations yet. In particular,
it assumes the FILE entry has just one element, and that element is a
directory. It also does not know what to do with MAP. If we determine
this situation, we terminate the program before making any changes.
Although there's the --force option for the braves.

9 years agoDon't remove --tarball
Abigail [Mon, 19 Mar 2012 13:26:12 +0000 (14:26 +0100)]
Don't remove --tarball

By default, the script removes the tarball of the new distributions.
However, if the --tarball option was given (and hence, the file was not
downloaded from CPAN), we opt to keep this file around.

9 years agoUse #!/usr/bin/env
Abigail [Mon, 19 Mar 2012 13:23:12 +0000 (14:23 +0100)]
Use #!/usr/bin/env

/usr/bin/perl on dromedary is 5.8.8; but the script requires 5.10.
By using #!/usr/bin/env, we give the user more control over which perl
should be used. (And this benefits not just dromedary usesr)

9 years agoMore work on perldelta
Abigail [Mon, 19 Mar 2012 10:14:15 +0000 (11:14 +0100)]
More work on perldelta

9 years agoMerge the feature and B::Deparse refactoring to blead.
Nicholas Clark [Mon, 19 Mar 2012 09:30:34 +0000 (10:30 +0100)]
Merge the feature and B::Deparse refactoring to blead.

9 years agoNote the improvements to B::Deparse and feature in perldelta.
Nicholas Clark [Mon, 19 Mar 2012 09:29:48 +0000 (10:29 +0100)]
Note the improvements to B::Deparse and feature in perldelta.

9 years agoIn feature.pm, inline current_bundle() into __common(), its only caller.
Nicholas Clark [Tue, 28 Feb 2012 22:54:10 +0000 (23:54 +0100)]
In feature.pm, inline current_bundle() into __common(), its only caller.

current_bundle() was added after 5.14.0 was released, so has never been in
a stable release. Hence it's totally safe to kill it.

9 years agoIn feature.pm, inline normalise_hints() into __common(), its only caller.
Nicholas Clark [Mon, 27 Feb 2012 17:33:08 +0000 (18:33 +0100)]
In feature.pm, inline normalise_hints() into __common(), its only caller.

normalise_hints() was added after 5.14.0 was released, so has never been in
a stable release. Hence it's totally safe to kill it.

9 years agoMerge the code common to feature::import and feature::unimport.
Nicholas Clark [Mon, 27 Feb 2012 17:24:57 +0000 (18:24 +0100)]
Merge the code common to feature::import and feature::unimport.

9 years agoIn feature.pm, use a consistent code style in import() and unimport().
Nicholas Clark [Mon, 27 Feb 2012 16:57:54 +0000 (17:57 +0100)]
In feature.pm, use a consistent code style in import() and unimport().

There were a couple of inconsistencies (shift with/without an explicit @_,
exists with/without(), !@_ vs @_ == 0) which turn out to date back to
before 5.10.0

Also fix an inadvertent use of a single element array slice with a simple
array lookup in current_bundle().

9 years agoIn B::Deparse::_features_from_bundle(), don't call feature::current_bundle()
Nicholas Clark [Tue, 28 Feb 2012 22:30:30 +0000 (23:30 +0100)]
In B::Deparse::_features_from_bundle(), don't call feature::current_bundle()

Instead, directly access feature's package variables, as B::Deparse already
does in 14 other places. (It also has its tentacles firmly into strict
and warning's package variables - it's not fussy)

feature::current_bundle() was not part of the documented API of feature
either, so B::Deparse wasn't clean previously.

9 years agoIn Deparse, use $feature::hint_mask directly, instead of copying its value.
Nicholas Clark [Tue, 28 Feb 2012 10:11:02 +0000 (11:11 +0100)]
In Deparse, use $feature::hint_mask directly, instead of copying its value.

Also, require feature unconditionally.

Deparse already directly uses data from feature, switch and warnings, so
this isn't a new trend in encapsulation breakage. Previously Deparse copied
the value of $feature::hint_mask, and lazily loaded require in 4 places.

9 years agoIn B::Deparse, refactor common code into _features_from_bundle().
Nicholas Clark [Tue, 28 Feb 2012 22:09:02 +0000 (23:09 +0100)]
In B::Deparse, refactor common code into _features_from_bundle().

9 years agoIn B::Deparse, refactor the two places that feature::current_bundle()
Nicholas Clark [Tue, 28 Feb 2012 21:57:31 +0000 (22:57 +0100)]
In B::Deparse, refactor the two places that feature::current_bundle()

Converge the code, so that it's easy to extract out into a subroutine.

9 years agoFix regression in deparsing say (etc) under use 5.10.0
Nicholas Clark [Tue, 28 Feb 2012 16:32:08 +0000 (17:32 +0100)]
Fix regression in deparsing say (etc) under use 5.10.0

Commit 6634bb9d0ed117be introduced a regression, causing this

    use 5.10.0;
    say "Perl rules";

to be deparsed as C<CORE::say>, not C<say>, etc. It wasn't actually possible
to write tests for this within the t/deparse.t framework until the recent
refactoring.

9 years agoAdd tests for deparsing C<say> under various combinations of pragmas.
Nicholas Clark [Tue, 28 Feb 2012 15:44:51 +0000 (16:44 +0100)]
Add tests for deparsing C<say> under various combinations of pragmas.

These mostly codify the current output of B::Deparse, which is not invalid,
but might not be considered to be the optimal output. (It's defensive, in
that it uses C<no feature;> which will ensure consistent behaviour whatever
pragma context the output is evaluated in.)

Some are TODO for the cases where B::Deparse is wrongly outputting
C<CORE::say> instead of plain C<say> and C<CORE::__SUB__> instead of plain
C<__SUB__>.

9 years agoAvoid deparse.t testing everything under use feature ':5.10'
Nicholas Clark [Tue, 28 Feb 2012 13:00:56 +0000 (14:00 +0100)]
Avoid deparse.t testing everything under use feature ':5.10'

Only use feature ':5.10' in those tests that actually need it. This will let
us add tests for deparsing without any features enabled.

9 years agoAdd a 'context' feature to deparse.t, to better test ambient pragmas.
Nicholas Clark [Tue, 28 Feb 2012 12:49:18 +0000 (13:49 +0100)]
Add a 'context' feature to deparse.t, to better test ambient pragmas.

Call ambient_pragmas() before each deparse test. This will allow use to remove
the constraints of the current default, which is to always run under
use feature ":5.10";

9 years agoIn deparse.t, rename %reason to %meta.
Nicholas Clark [Tue, 28 Feb 2012 11:43:02 +0000 (12:43 +0100)]
In deparse.t, rename %reason to %meta.

Whilst skip and todo both have "reason"s, subsequent refactoring will use it
for other purposes.

9 years agoNote in perldelta that C<no feature;> now means reset to default.
Nicholas Clark [Mon, 19 Mar 2012 09:20:42 +0000 (10:20 +0100)]
Note in perldelta that C<no feature;> now means reset to default.

The behaviour was changed with commit 39ec54a59ce332fc.

9 years agoRetry first shot at perldelta.pod.
Abigail [Mon, 19 Mar 2012 02:20:09 +0000 (03:20 +0100)]
Retry first shot at perldelta.pod.

Documents the differences between 5.15.8 and 5.15.9.

9 years agoUpdate Pod::Perldoc to version 3.17
Abigail [Sun, 18 Mar 2012 23:53:14 +0000 (00:53 +0100)]
Update Pod::Perldoc to version 3.17

9 years agoAdd a --tarball option
Abigail [Sun, 18 Mar 2012 23:51:14 +0000 (00:51 +0100)]
Add a --tarball option

This allows to do the cpan/ upgrade without having to contact CPAN.
For instance, from dromedary, it seems to be impossible to fetch
files from CPAN. With the --tarball option, you can pass the location
of the tarball, and this will used instead of fetching it automatically
from CPAN.

9 years agoSome backslashes turn out not to be always there.
Abigail [Sun, 18 Mar 2012 22:36:42 +0000 (23:36 +0100)]
Some backslashes turn out not to be always there.

9 years agoFix a cut-and-paste error
Abigail [Sun, 18 Mar 2012 22:36:03 +0000 (23:36 +0100)]
Fix a cut-and-paste error

9 years agoRevert "First shot at perl5159delta.pod"
Abigail [Sun, 18 Mar 2012 22:32:17 +0000 (23:32 +0100)]
Revert "First shot at perl5159delta.pod"

This reverts commit 21ffc8459b739cc13a32f22a2edb7be485a062e0.

Until I can figure out how to add a new perldelta and make all tests pass.

9 years agoRevert "Paste in the output of Porting/acknowledgements.pl in pod/perl5159delta.pod"
Abigail [Sun, 18 Mar 2012 22:31:28 +0000 (23:31 +0100)]
Revert "Paste in the output of Porting/acknowledgements.pl in pod/perl5159delta.pod"

This reverts commit 98f0737d71a92167bf1aace8a8d8411b985e3200.

Until I can figure out how to add a new perldelta and make all tests pass.

9 years agoPaste in the output of Porting/acknowledgements.pl in pod/perl5159delta.pod
Abigail [Sun, 18 Mar 2012 17:26:59 +0000 (18:26 +0100)]
Paste in the output of Porting/acknowledgements.pl in pod/perl5159delta.pod

9 years agoAttempt to find an author if (s)he comes via RT.
Abigail [Sun, 18 Mar 2012 17:24:23 +0000 (18:24 +0100)]
Attempt to find an author if (s)he comes via RT.

In the case of commits, it maybe that the reporter used RT, which results
in a generic RT email address. Instead of just reporting the author as '!',
we'll do an attempt to see whether he's named in the AUTHORS file.

9 years agoFirst shot at perl5159delta.pod
Abigail [Sun, 18 Mar 2012 16:20:03 +0000 (17:20 +0100)]
First shot at perl5159delta.pod

9 years agoUpdate CPANPLUS to CPAN version 0.9121
Chris 'BinGOs' Williams [Sat, 17 Mar 2012 23:50:17 +0000 (23:50 +0000)]
Update CPANPLUS to CPAN version 0.9121

This resolves a regression introduced with v0.9109
which was included with perl version v5.15.2 and is
therefore a regression since v5.14.x

  [DELTA]

  Changes for 0.9121      Sat Mar 17 23:23:42 2012
  ================================================
  * Resolved a regression with dev '_' version
    numbers since 0.9109

9 years agoIn S_parse_body(), don't "leak" linestr_sv until global destruction.
Nicholas Clark [Sat, 25 Feb 2012 23:22:41 +0000 (00:22 +0100)]
In S_parse_body(), don't "leak" linestr_sv until global destruction.

This commit ensures that linestr_sv is properly cleaned up, if allocated.

The local variable linestr_sv was added by commit 009d90df4e17a415 in 2007,
to replace use of PL_linestr in S_parse_body(). However, that commit didn't
add any code to free linestr_sv at the end of S_parse_body(), meaning that
the SV sticks around until global destruction.

Subsequent code simplification possible by the removal of suidperl reveals
that linestr_sv is only needed for the '-x' option, so it's safe to avoid
allocating it up front. Additionally, during '-x' processing, Perl_sv_gets()
will upgrade the target SV to SVt_PV and allocate the string buffer as needed,
so there's no need to pre-upgrade or pre-allocate the SV in S_parse_body().
This slightly reduces the amount of code.

9 years agoRemove all the never used parameters from the macro validate_suid()
Nicholas Clark [Sat, 25 Feb 2012 22:50:49 +0000 (23:50 +0100)]
Remove all the never used parameters from the macro validate_suid()

Several parameters are unused in either remaining variant of the
validate_suid() macro. The two variants which used the extra parameters
were removed with suidperl by commit cc69b689ee7c2745 in Jan 2009.

9 years agoIn perlfunc, don't have functions in "Misc" and a second category.
Nicholas Clark [Wed, 22 Feb 2012 13:00:41 +0000 (14:00 +0100)]
In perlfunc, don't have functions in "Misc" and a second category.

dump, eval, evalbytes and wantarray are now only in "flow control".
local, my, our and state are only in "scoping".
prototype is now only in "misc". Whilst *prototypes* affect parsing, and
hence indirectly flow control, the prototype function is for introspecting
prototypes.

9 years agoDe-emphasise switch-related keywords in perlfunc.
Nicholas Clark [Sun, 19 Feb 2012 18:54:38 +0000 (19:54 +0100)]
De-emphasise switch-related keywords in perlfunc.

Move the 3 non-function keywords into the summary cross reference section
at the end of perlfunc. Eliminate the examples which duplicate examples in
perlsyn. Merge the remaining 2 keywords into the "control flow" group.
Note that the switch feature is considered experimental.

With these changes, `perldoc -f default`, `perldoc -f given` and
`perldoc -f when` will still return a helpful result, and as before will
refer the reader to perlsyn for full information.

9 years agoIn the perlfunc cross-reference sections, link to the section within a page.
Nicholas Clark [Sun, 19 Feb 2012 17:33:22 +0000 (18:33 +0100)]
In the perlfunc cross-reference sections, link to the section within a page.

perlfunc now has a section cross referencing keywords documented elsewhere.
Keywords are grouped by man page, and for most manpages, all the
cross-referenced keywords are in the same section. Hence make the L<> links
more specific by including the section.

9 years agoDESTROY is documented in perlobj - correct the cross-reference in perlfunc.
Nicholas Clark [Sun, 19 Feb 2012 15:49:44 +0000 (16:49 +0100)]
DESTROY is documented in perlobj - correct the cross-reference in perlfunc.

9 years agoignore new build result from splitting docs for Module::CoreList
Tony Cook [Sat, 17 Mar 2012 02:39:04 +0000 (13:39 +1100)]
ignore new build result from splitting docs for Module::CoreList

9 years agoUnicode::UCD: pod clarifications, corrections
Karl Williamson [Sun, 11 Mar 2012 19:32:04 +0000 (13:32 -0600)]
Unicode::UCD: pod clarifications, corrections

9 years agocharnames.t: Attempt to fix probable timing issue
Karl Williamson [Fri, 16 Mar 2012 16:14:05 +0000 (10:14 -0600)]
charnames.t: Attempt to fix probable timing issue

charnames.t sometimes fails on a test that is expecting a file to be
non-existent.  However, other tests in it briefly create a file by that
name.  When two instances of the .t are run in parallel, as happens in
some smokes, it could be that the file exists at the time it is expected
not to.  The result is a non-reproducible failure.  Anyway, that is my
theory.  And so this commit changes to use a filename that is used just
by the test for what happens when a file is non-existent, and hence
doesn't ever exist even transiently.

9 years agocherrymaint: Beef up --help option
Karl Williamson [Sun, 11 Mar 2012 16:44:19 +0000 (10:44 -0600)]
cherrymaint: Beef up --help option

I can never remember how to set the tunnel up for using this, so
add it to the help output

9 years agoRun podtidy on perlsource.pod
Dave Rolsky [Tue, 13 Mar 2012 16:37:33 +0000 (11:37 -0500)]
Run podtidy on perlsource.pod

9 years agoAdd a missing word to perlsource.pod
Dave Rolsky [Tue, 13 Mar 2012 16:37:18 +0000 (11:37 -0500)]
Add a missing word to perlsource.pod

9 years agoFix POD issues
Abigail [Thu, 15 Mar 2012 21:58:34 +0000 (22:58 +0100)]
Fix POD issues

9 years agoDocument upgrading a module in cpan/
Abigail [Thu, 15 Mar 2012 21:35:10 +0000 (22:35 +0100)]
Document upgrading a module in cpan/

9 years agoClearify this is for even numbered (BLEAD-FINAL) releases.
Abigail [Thu, 15 Mar 2012 21:05:50 +0000 (22:05 +0100)]
Clearify this is for even numbered (BLEAD-FINAL) releases.

9 years agocorrect argument handling in Term::ReadLine
Ricardo Signes [Wed, 14 Mar 2012 20:46:21 +0000 (16:46 -0400)]
correct argument handling in Term::ReadLine

https://rt.perl.org/rt3/Ticket/Display.html?id=111758

patch by Darin McBride

9 years agoSeparate the POD from the corelist data in Module::CoreList
Chris 'BinGOs' Williams [Sun, 4 Mar 2012 20:55:48 +0000 (20:55 +0000)]
Separate the POD from the corelist data in Module::CoreList

See https://github.com/CPAN-API/metacpan-web/issues/485

9 years agoRevert "Upgrade IO-Compress to 2.049"
Abigail [Wed, 14 Mar 2012 01:47:46 +0000 (02:47 +0100)]
Revert "Upgrade IO-Compress to 2.049"

This reverts commit 1d4b9cf3270c936605a07ecd7414f808755d3184.

This depends on the module that was reverted by Ricardo at the same time.

9 years agoUpgrade IO-Compress to 2.049
Abigail [Wed, 14 Mar 2012 01:39:16 +0000 (02:39 +0100)]
Upgrade IO-Compress to 2.049

9 years agoAllow passing the name of the CPAN module
Abigail [Wed, 14 Mar 2012 00:59:48 +0000 (01:59 +0100)]
Allow passing the name of the CPAN module

9 years agoUpgrade CPANPLUS to 0.9120
Abigail [Wed, 14 Mar 2012 00:43:58 +0000 (01:43 +0100)]
Upgrade CPANPLUS to 0.9120

9 years agoDeal with files in the CUSTOMIZED sections.
Abigail [Wed, 14 Mar 2012 00:40:23 +0000 (01:40 +0100)]
Deal with files in the CUSTOMIZED sections.

9 years agoUpgrade Socket to 2.000
Abigail [Wed, 14 Mar 2012 00:31:45 +0000 (01:31 +0100)]
Upgrade Socket to 2.000

9 years agoUpgrade Socket to version 2,000
Abigail [Wed, 14 Mar 2012 00:19:42 +0000 (01:19 +0100)]
Upgrade Socket to version 2,000

9 years agoFix the fixing of MANIFEST
Abigail [Wed, 14 Mar 2012 00:19:06 +0000 (01:19 +0100)]
Fix the fixing of MANIFEST

9 years agoUpgrade Unicode::Normalize to 1.14.
Abigail [Tue, 13 Mar 2012 23:56:07 +0000 (00:56 +0100)]
Upgrade Unicode::Normalize to 1.14.

9 years agoRevert changes to compression libraries
Ricardo Signes [Wed, 14 Mar 2012 01:01:00 +0000 (21:01 -0400)]
Revert changes to compression libraries

Revert "Ran zlib2ansi script against zlib-src/ to fix K&R-isms"
This reverts commit a7026383bc5a2ca5f518f670ee6d74d55cd994aa.

Revert "Some files in cpan/Compress-Raw-Zlib have the x bit set."
This reverts commit adace0595a25c5339a4c1fff6b4704945abf8814.

Revert "Fixes type in commit 14c554185"
This reverts commit d588a46d9335dc093e4046b68ae0e2c7925ef095.

Revert "Upgrade Compress::Raw::Zlib to 2.051."
This reverts commit 14c554185b51c8646198cbf62fe6e94e9890b3a5.

Revert "Upgrade Compress-Raw-Bzip2 to version 2.049."
This reverts commit 616f340ab90cf805b145b81fd31c2017a4e7783f.

Revert "Upgrade cpan/Archive-Tar to 1.84"
This reverts commit c06ee8c824f270b42cb440453df0e44858492aed.

Revert "Upgrade Archive-Extract to 0.60"
This reverts commit dc16b9e468c516c95140dc2b6eac778872c79239.

9 years agoUpgrade Unicode-Collate to 0.89
Abigail [Tue, 13 Mar 2012 18:57:38 +0000 (19:57 +0100)]
Upgrade Unicode-Collate to 0.89

9 years agoList one more TODO
Abigail [Tue, 13 Mar 2012 18:53:02 +0000 (19:53 +0100)]
List one more TODO

9 years agoUpgrade Digest-SHA to 5.71.
Abigail [Tue, 13 Mar 2012 18:46:56 +0000 (19:46 +0100)]
Upgrade Digest-SHA to 5.71.

9 years agoMore tests, and more exec-bit removal.
Abigail [Tue, 13 Mar 2012 18:44:47 +0000 (19:44 +0100)]
More tests, and more exec-bit removal.

Checks all the files in the new directory that have the exec bit set.
If the file isn't new, and if the old file doesn't have the exec bit set,
disable it.

Runs the tests that come with the package as well.

9 years agoDisambiguate map { }
Abigail [Tue, 13 Mar 2012 17:37:49 +0000 (18:37 +0100)]
Disambiguate map { }

9 years agoMention Porting/sync-with-cpan
Abigail [Tue, 13 Mar 2012 17:34:32 +0000 (18:34 +0100)]
Mention Porting/sync-with-cpan

9 years agoAdd Porting/sync-with-cpan
Abigail [Tue, 13 Mar 2012 16:44:42 +0000 (17:44 +0100)]
Add Porting/sync-with-cpan

It helps if you actually commit the changes you make. :(

9 years agoScript to help out upgrading a cpan/ distro.
Abigail [Tue, 13 Mar 2012 16:14:21 +0000 (17:14 +0100)]
Script to help out upgrading a cpan/ distro.

This one is not complete yet, and its portability can be much improved.
But it helps me out right now, and it wouldn't be fair to keep it all to
myself.

9 years agoUpgrade Locale-Codes to 3.21
Abigail [Tue, 13 Mar 2012 14:01:17 +0000 (15:01 +0100)]
Upgrade Locale-Codes to 3.21

9 years agostop S_forget_pmop() SEGVing
David Mitchell [Tue, 13 Mar 2012 14:24:15 +0000 (14:24 +0000)]
stop S_forget_pmop() SEGVing

Commit 5bec93be re-purposed the SvMAGIC field of hashes being freed, on
the grounds that (a) any magic had been freed, (b) the refcnt was zero, so
no-one else could mess with the hash.

Unfortunately in the non-threaded case, PMOPs for m?? regexes have a
non-refcounted link back to their stash. When the stash is freed, any subs
in the stash are freed, which frees the PMOPs, which then see the freed
stash, and assume it still has magic because SvMAGIC is non-null.

The quick fix is to check the SvMAGICAL flags first; a longer term fix
would be to avoid the weak ref (e.g. by always using the threaded variant
of PmopSTASH, which stores the stash's *name* rather than a pointer to the
stash).

9 years agoMerge branch 'blead' of ssh://perl5.git.perl.org/gitroot/perl into blead
Abigail [Tue, 13 Mar 2012 12:22:28 +0000 (13:22 +0100)]
Merge branch 'blead' of ssh://perl5.git.perl.org/gitroot/perl into blead

9 years agoExclude perlcritic.rc files.
Abigail [Tue, 13 Mar 2012 12:20:31 +0000 (13:20 +0100)]
Exclude perlcritic.rc files.

Listed perlcritic.rc in the @IGNORABLE array of Porting/Maintainers.pl,
and removed the files from the new cpan/CPAN-Meta and cpan/HTTP-Tiny distros.

9 years agoList the new files that came with the upgrade of CPAN-Meta
Abigail [Tue, 13 Mar 2012 12:20:03 +0000 (13:20 +0100)]
List the new files that came with the upgrade of CPAN-Meta

9 years agoRan zlib2ansi script against zlib-src/ to fix K&R-isms
Chris 'BinGOs' Williams [Tue, 13 Mar 2012 09:43:17 +0000 (09:43 +0000)]
Ran zlib2ansi script against zlib-src/ to fix K&R-isms

9 years agoUpgrade HTTP::Tiny to 0.017.
Abigail [Tue, 13 Mar 2012 01:32:44 +0000 (02:32 +0100)]
Upgrade HTTP::Tiny to 0.017.

9 years agoUpgrade cpan/CPAN-Meta to 2.120630
Abigail [Tue, 13 Mar 2012 01:02:18 +0000 (02:02 +0100)]
Upgrade cpan/CPAN-Meta to 2.120630

9 years agoSome files in cpan/Compress-Raw-Zlib have the x bit set.
Abigail [Tue, 13 Mar 2012 00:24:16 +0000 (01:24 +0100)]
Some files in cpan/Compress-Raw-Zlib have the x bit set.

9 years agoFixes type in commit 14c554185
Abigail [Mon, 12 Mar 2012 23:59:16 +0000 (00:59 +0100)]
Fixes type in commit 14c554185

In commit 14c554185, I updated the version of the wrong distro in
Porting/Maintainers.pl. This fixes this error.

9 years agoMerge branch 'blead' of ssh://perl5.git.perl.org/gitroot/perl into blead
Abigail [Mon, 12 Mar 2012 23:54:14 +0000 (00:54 +0100)]
Merge branch 'blead' of ssh://perl5.git.perl.org/gitroot/perl into blead

9 years agoUpgrade Compress::Raw::Zlib to 2.051.
Abigail [Mon, 12 Mar 2012 23:53:07 +0000 (00:53 +0100)]
Upgrade Compress::Raw::Zlib to 2.051.

9 years agoUpgrade Compress-Raw-Bzip2 to version 2.049.
Abigail [Mon, 12 Mar 2012 21:49:31 +0000 (22:49 +0100)]
Upgrade Compress-Raw-Bzip2 to version 2.049.

9 years agoload Algorithm::Diff later in corelist-perldelta
Max Maischein [Sat, 10 Mar 2012 16:28:08 +0000 (17:28 +0100)]
load Algorithm::Diff later in corelist-perldelta

corelist-perldelta.pl is a bit schizophrenic. The part to generate the
new Perldelta text does not need Algorithm::Diff, but wants to be
run with the freshly built Perl. Ideally, the two usages get
clarified and split up into two separate programs. The added documentation
tries to give two helpful usages of the program.

9 years agoavoid some long-line errors in podcheck of Term-Readline
Ricardo Signes [Sat, 10 Mar 2012 21:21:49 +0000 (16:21 -0500)]
avoid some long-line errors in podcheck of Term-Readline

9 years agonew patch for Term::ReadLine event loop support
Ricardo Signes [Sat, 10 Mar 2012 17:14:42 +0000 (12:14 -0500)]
new patch for Term::ReadLine event loop support

  https://rt.perl.org/rt3/Ticket/Display.html?id=108470

This is more work from Darin McBride and Rocco Caputo to get the event
loop code offered earlier working, tested, and documented.

9 years agoUpgrade cpan/Archive-Tar to 1.84
Abigail [Mon, 12 Mar 2012 20:47:00 +0000 (21:47 +0100)]
Upgrade cpan/Archive-Tar to 1.84

9 years agoUpgrade Archive-Extract to 0.60
Abigail [Mon, 12 Mar 2012 20:12:26 +0000 (21:12 +0100)]
Upgrade Archive-Extract to 0.60

9 years agomake the pod2html tests work with fs with vols
Ricardo Signes [Mon, 12 Mar 2012 17:19:23 +0000 (13:19 -0400)]
make the pod2html tests work with fs with vols

  my $cwd = Cwd::cwd();
  my $new_dir  = catdir $cwd, "t";
  my $infile   = catfile $new_dir, "$podfile.pod";

Prior to these changes, we were getting the volume from $cwd, above, and
then basically ignoring it.  When the cwd was c:\foo, ignoring the
volume in the catdir/catfile operations would munge things to C:\foo,
which meant that later a native check of path prefix would fail:
C:\foo is not a prefix of c:\foo\bar because of the case difference in
the volume name.

The is a legitimate fix, but the code is still problematic in other
places because (a) it tends to do path operations with no consideration
for volumes and (b) it has at least one place where it decides whether
path X is below path Y by using substr/index instead of path checking
routines.

9 years agoSisyphus's fix for pod2html
Ricardo Signes [Tue, 6 Mar 2012 03:31:52 +0000 (22:31 -0500)]
Sisyphus's fix for pod2html

9 years agoperldelta for die propgation fix
Tony Cook [Sun, 11 Mar 2012 23:16:38 +0000 (10:16 +1100)]
perldelta for die propgation fix

9 years ago[rt #111654] properly propgate tainted errors
Tony Cook [Sun, 11 Mar 2012 03:38:57 +0000 (14:38 +1100)]
[rt #111654] properly propgate tainted errors

A magic value (such as a tainted string) may not have POK set, so call
SvPV() to find out if there's something in ERRSV to report.

Possibly this should be using SvPV_nomg(), but this is the first
request for magic in this code.  Maybe the code above should be
calling SvGETMAGIC() before checking SvROK().

9 years ago[rt #111654] TODO test for tainted die propagation
Tony Cook [Sun, 11 Mar 2012 03:27:29 +0000 (14:27 +1100)]
[rt #111654] TODO test for tainted die propagation

9 years agoDocument the updated version of Pod::Simple
Abigail [Sun, 11 Mar 2012 22:25:49 +0000 (23:25 +0100)]
Document the updated version of Pod::Simple

9 years agoUpgrade Pod-Simple to 3.20. This should fix issue 111520.
Abigail [Sun, 11 Mar 2012 17:05:18 +0000 (18:05 +0100)]
Upgrade Pod-Simple to 3.20. This should fix issue 111520.