This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
Karl Williamson [Tue, 19 Dec 2017 18:43:46 +0000 (11:43 -0700)]
reg_mesg.t: Move some tests to proper places
This was detected in [perl #131522]. Some tests were in the death
section, but don't die. The next commit will add tests that actually
work to detect death.
David Mitchell [Tue, 19 Dec 2017 15:40:41 +0000 (15:40 +0000)]
[MERGE] s/// return value fixups
David Mitchell [Tue, 19 Dec 2017 15:28:06 +0000 (15:28 +0000)]
s/// in boolean context: simplify return value
Normally s/// returns a count of the number of iterations, but
as an optimisation, in boolean context it returns PL_sv_yes/PL_sv_zero
instead. But in the places where it decides which immortal var to return,
the number of iterations is always > 0, so PL_sv_zero never gets returned.
So skip testing whether iters > 0 and always just return PL_sv_yes.
(In non-boolean scalar context, it still returns the iteration count as
before.)
David Mitchell [Tue, 19 Dec 2017 14:52:49 +0000 (14:52 +0000)]
avoid tainting boolean return value of s///
RT #132385
s/// normally returns an integer count, but sometimes for efficiency it
will return a boolean instead (PL_sv_yes/PL_sv_zero).
In these cases, don't try to taint the return value, since it will die
with 'Modification of a read-only value'.
David Mitchell [Tue, 19 Dec 2017 12:09:15 +0000 (12:09 +0000)]
s///: return boolean in not-in-place branch
A while back, s/// (and other ops) were optimised to return
PL_sv_yes/PL_sv_zero rather than an iteration count in boolean context.
This optimisation was missed in one place in pp_subst(): the 'can modify
in place' branch was done, but the other branch was missed.
This commit fixes that.
Karen Etheridge [Tue, 19 Dec 2017 03:01:26 +0000 (19:01 -0800)]
minor punctuation improvement
Karl Williamson [Tue, 19 Dec 2017 02:04:56 +0000 (19:04 -0700)]
Forbid literal \v in /[]/ under re strict, except under /x
Vertical space in a bracketed character class is likely to be an error;
either a typo or omission of /x. It will match literally, but be
displayed like /x is in effect.
For now, just add this check to re 'strict', which is experimental,
designed to catch things the current regex parser doesn't.
Karl Williamson [Tue, 19 Dec 2017 02:03:26 +0000 (19:03 -0700)]
perldiag: Fix obsolete text
Since 5.26.0, code points must fit in a signed integer, not unsigned.
This commit should be considered for backporting to a future 5.26.x
release
Karl Williamson [Tue, 19 Dec 2017 02:02:37 +0000 (19:02 -0700)]
reg_mesg.t: Fix comment
Karl Williamson [Tue, 19 Dec 2017 02:01:37 +0000 (19:01 -0700)]
reg_mesg.t: Fix typo
James E Keenan [Mon, 18 Dec 2017 22:02:55 +0000 (17:02 -0500)]
Demonstrate how File::Spec->catfile('.', @other_args) works.
For: RT # 131296
Karl Williamson [Fri, 8 Dec 2017 05:10:52 +0000 (22:10 -0700)]
Emulate C99 int_fast8_t, etc typedefs
These are useful if you know you have a variable with a restricted range,
and so could fit in a byte or 16 bits, but speed is more important.
These C99 typedefs allows you to specify the minimal size you need, and
allows the compiler to substitute a wider type if it is faster.
This commit adds typedefs spelled the same as the C99 ones, but upper
cased. On non-C99 compilers, it just uses 'int' behind the scenes,
which should be safe.
These are currently restricted to core to be sure these aren't a bad
idea before they are made public.
Karl Williamson [Mon, 18 Dec 2017 19:49:55 +0000 (12:49 -0700)]
mktables: Use already set variable
The value for this variable is already known; use that instead of
rederiving it.
Karl Williamson [Sat, 16 Dec 2017 06:41:51 +0000 (23:41 -0700)]
Change number to mnemonic
This is in preparation for future commits that will use it in multiple
places
Father Chrysostomos [Mon, 18 Dec 2017 17:37:08 +0000 (09:37 -0800)]
perlxs: Document bitwise calling conventions
Chris 'BinGOs' Williams [Mon, 18 Dec 2017 13:31:43 +0000 (13:31 +0000)]
Customisations for Digest-SHA tests
Chris 'BinGOs' Williams [Mon, 18 Dec 2017 13:15:34 +0000 (13:15 +0000)]
Update Digest-SHA to CPAN version 6.00
[DELTA]
6.00 Fri Dec 8 22:44:44 MST 2017
- added "tag" option (BSD-style checksums) to shasum
-- consistent with GNU sha1sum, sha224sum, etc.
-- thanks to Christopher Tubbs for suggestion
- modified SHA.pm to use XSLoader
-- falls back to DynaLoader if necessary
- decoupled Digest::SHA and Digest::SHA::PurePerl
-- scripts/tests in each module now fully independent
-- Digest::SHA::PurePerl to be phased out eventually
-- past versions will remain available
David Mitchell [Mon, 18 Dec 2017 11:50:03 +0000 (11:50 +0000)]
enable PERL_OP_PARENT always
Remove support for PERL_NO_OP_PARENT, which was a way of turning off the
(on by default) PERL_OP_PARENT define.
See http://nntp.perl.org/group/perl.perl5.porters/248072.
Zefram [Mon, 18 Dec 2017 03:21:05 +0000 (03:21 +0000)]
align version numbers in the PathTools distro
Zefram [Mon, 18 Dec 2017 03:18:39 +0000 (03:18 +0000)]
remove support for running PathTools on MacOS
MacOS Classic hasn't been a supported platform since 5.14. Note that
the code for processing MacOS-style paths remains, and can be run on
supported platforms. [perl #130818]
Zefram [Mon, 18 Dec 2017 03:12:04 +0000 (03:12 +0000)]
fix pod markup in warnings.pm
Commit
c4583f59133164b3f392c31e9b9573276ec17e74 introduced a pod error.
Zefram [Mon, 18 Dec 2017 03:08:31 +0000 (03:08 +0000)]
remove support for running PathTools on EPOC
EPOC hasn't been a supported platform since 5.18. Note that the code
for processing EPOC-style paths remains, and can be run on supported
platforms. [perl #130818]
Father Chrysostomos [Mon, 18 Dec 2017 02:43:55 +0000 (18:43 -0800)]
perldelta: Avoid ‘deprecated’ for non-deprecated module
Saying the module is deprecated (in core) can easily be misunder-
stood. The module itself is certainly not deprecated.
Father Chrysostomos [Mon, 18 Dec 2017 02:00:33 +0000 (18:00 -0800)]
perldelta for #132468 warnings functions
Father Chrysostomos [Mon, 18 Dec 2017 01:59:33 +0000 (17:59 -0800)]
perldelta: Alphabetise modules
Father Chrysostomos [Mon, 18 Dec 2017 01:56:52 +0000 (17:56 -0800)]
[perl #132468] At _at_level warnings functions
Father Chrysostomos [Mon, 11 Dec 2017 21:38:24 +0000 (13:38 -0800)]
pp_ctl.c: Add -D output for inward goto
Zefram [Sun, 17 Dec 2017 11:02:23 +0000 (11:02 +0000)]
merge branch zefram/dumb_match
Karl Williamson [Fri, 10 Nov 2017 01:31:15 +0000 (18:31 -0700)]
Unicode::UCD: max code point is now IV_MAX
Return the correct value when asked.
Karl Williamson [Sat, 16 Dec 2017 19:13:01 +0000 (12:13 -0700)]
regcomp.sym: Clarify regnode comment
Karl Williamson [Sat, 16 Dec 2017 18:53:15 +0000 (11:53 -0700)]
regen/mk_invlists.pl: reformulate a branch and outdent
This turns a test whose one branch dies into a postfix type, which means
there is no need for an else, and that code can be outdented.
Karl Williamson [Sat, 16 Dec 2017 18:48:12 +0000 (11:48 -0700)]
regen/mk_invlists.pl: Outdent code
This was unnecessarily indented. This commit also removes an
unnecessary {...} block, and outdents the interior as well.
No other changes are made
Karl Williamson [Sat, 16 Dec 2017 18:37:21 +0000 (11:37 -0700)]
regen/mk_invlists.pl: Fix typo
Karl Williamson [Sun, 17 Dec 2017 00:05:50 +0000 (17:05 -0700)]
perlre: '#' is a metacharacter under /x
Zefram [Sat, 16 Dec 2017 22:46:33 +0000 (22:46 +0000)]
make dNOOP usable outside function in C++
Commit
7db66e12883f0832ca80164b723768b848187bda changed dNOOP in C++ from
an external function declaration (which was running into inconsistent
linkage) to a no-op statement. The no-op statement is only valid where
statements are valid, i.e., inside a function, so this doesn't actually
work everywhere that a declaration is expected.
Switch dNOOP to be an incomplete struct declaration, regardless of
language. This can certainly be used both inside and outside functions,
is valid to repeat, and does not have the linkage problem of a function
declaration. It should also be as unlikely to attract an "unused"
warning as an external function declaration.
Zefram [Sat, 16 Dec 2017 09:30:16 +0000 (09:30 +0000)]
typo fix in doc
Zefram [Sat, 16 Dec 2017 08:34:25 +0000 (08:34 +0000)]
show modern usage for {XS,Dyna}Loader
Fixes [perl #132247].
Zefram [Sat, 16 Dec 2017 07:12:48 +0000 (07:12 +0000)]
semicolon-friendly diagnostic control
New macros {GCC,CLANG}_DIAG_{IGNORE,RESTORE}_{DECL,STMT}, which take a
following semicolon. It is necessary to use the _DECL or _STMT version
as appropriate to the context. Fixes [perl #130726].
Zefram [Sat, 16 Dec 2017 05:33:20 +0000 (05:33 +0000)]
perform system() arg processing before fork
A lot of things can happen when stringifying an argument list: side
effects, warnings, exceptions. In the case of system(), these effects
should happen in the context of the parent process. The stringification
can also depend on which process it happens in, as in the case of
$$, and in that case it should also happen in the parent process.
Therefore reduce the argument scalars to strings first thing in pp_system.
Fixes [perl #121105].
Zefram [Sat, 16 Dec 2017 04:47:08 +0000 (04:47 +0000)]
update and clarify "die" and "warn" doc
They didn't fully describe the handling of reference operands, and
there were other errors in their description of the treatment of the
operand list. Fixes [perl #121372].
Zefram [Sat, 16 Dec 2017 02:17:08 +0000 (02:17 +0000)]
retry gdbm_open() upon block size error
It is reported that gdbm_open() with default block size can fail on
filesystems with a non-power-of-two block size. In that event, retry
opening, forcing a power-of-two block size. Fixes [perl #119623].
Zefram [Sat, 16 Dec 2017 01:48:22 +0000 (01:48 +0000)]
add ticket number to perldelta entry
Zefram [Sat, 16 Dec 2017 01:44:32 +0000 (01:44 +0000)]
widen size-type variables in pack/unpack
Most size-type variables in pp_pack.c were of type I32, with a
smattering of other types. Use SSize_t in place of I32, and generally
use size_t-width variables as appropriate. Fixes [perl #119367].
Marco Fontani [Fri, 15 Dec 2017 17:16:31 +0000 (10:16 -0700)]
perlfunc: remove stray plus from start of line
Looks to be an artifact of applying my original patch, which was
amended as part of
e135ff695231a81e2a70a739e8d813525432fd4d, whereby
the text was slightly amended.
Zefram [Fri, 15 Dec 2017 09:51:33 +0000 (09:51 +0000)]
document GDBM_File's delete vs each conflict
Fixes [perl #117449].
Zefram [Fri, 15 Dec 2017 07:00:11 +0000 (07:00 +0000)]
rewrite "ref" documentation for clarity
Zefram [Fri, 15 Dec 2017 05:12:32 +0000 (05:12 +0000)]
clean up directories of split pod files
Fixes [perl #114316].
Zefram [Fri, 15 Dec 2017 02:14:25 +0000 (02:14 +0000)]
Zefram [Fri, 15 Dec 2017 02:12:42 +0000 (02:12 +0000)]
Zefram [Fri, 15 Dec 2017 02:11:13 +0000 (02:11 +0000)]
Zefram [Fri, 15 Dec 2017 02:09:15 +0000 (02:09 +0000)]
Zefram [Fri, 15 Dec 2017 02:06:54 +0000 (02:06 +0000)]
Zefram [Fri, 15 Dec 2017 02:03:33 +0000 (02:03 +0000)]
Zefram [Fri, 15 Dec 2017 02:00:05 +0000 (02:00 +0000)]
Zefram [Fri, 15 Dec 2017 01:58:26 +0000 (01:58 +0000)]
Zefram [Fri, 15 Dec 2017 01:55:17 +0000 (01:55 +0000)]
Zefram [Fri, 15 Dec 2017 01:53:56 +0000 (01:53 +0000)]
Zefram [Fri, 15 Dec 2017 01:50:55 +0000 (01:50 +0000)]
Zefram [Fri, 15 Dec 2017 01:48:41 +0000 (01:48 +0000)]
Zefram [Fri, 15 Dec 2017 01:46:30 +0000 (01:46 +0000)]
Zefram [Fri, 15 Dec 2017 01:44:39 +0000 (01:44 +0000)]
Zefram [Fri, 15 Dec 2017 01:43:34 +0000 (01:43 +0000)]
Zefram [Fri, 15 Dec 2017 01:39:19 +0000 (01:39 +0000)]
Zefram [Fri, 15 Dec 2017 01:32:39 +0000 (01:32 +0000)]
Zefram [Fri, 15 Dec 2017 01:30:38 +0000 (01:30 +0000)]
Zefram [Fri, 15 Dec 2017 01:29:23 +0000 (01:29 +0000)]
Zefram [Fri, 15 Dec 2017 01:27:12 +0000 (01:27 +0000)]
Zefram [Fri, 15 Dec 2017 01:24:36 +0000 (01:24 +0000)]
Zefram [Fri, 15 Dec 2017 01:20:03 +0000 (01:20 +0000)]
Zefram [Fri, 15 Dec 2017 01:16:14 +0000 (01:16 +0000)]
Zefram [Fri, 15 Dec 2017 01:14:01 +0000 (01:14 +0000)]
Zefram [Fri, 15 Dec 2017 01:11:47 +0000 (01:11 +0000)]
Zefram [Fri, 15 Dec 2017 01:09:48 +0000 (01:09 +0000)]
Zefram [Fri, 15 Dec 2017 01:08:38 +0000 (01:08 +0000)]
Zefram [Fri, 15 Dec 2017 01:07:08 +0000 (01:07 +0000)]
Zefram [Fri, 15 Dec 2017 01:04:32 +0000 (01:04 +0000)]
Zefram [Fri, 15 Dec 2017 01:02:39 +0000 (01:02 +0000)]
Zefram [Fri, 15 Dec 2017 00:59:13 +0000 (00:59 +0000)]
Zefram [Fri, 15 Dec 2017 00:56:11 +0000 (00:56 +0000)]
Zefram [Fri, 15 Dec 2017 00:51:21 +0000 (00:51 +0000)]
Zefram [Fri, 15 Dec 2017 00:47:10 +0000 (00:47 +0000)]
Zefram [Wed, 6 Dec 2017 21:27:15 +0000 (21:27 +0000)]
make exec keep its argument list more reliably
Bits of exec code were putting the constructed commands into globals
PL_Argv and PL_Cmd, which could then be clobbered by reentrancy.
These are only global in order to manage their freeing, but that's
better managed by using the scope stack. So replace them with automatic
variables, with ENTER/SAVEFREEPV/LEAVE to free the memory. Also copy
the strings acquired from SVs, to avoid magic clobbering the buffers of
SVs already read. Fixes [perl #129888].
Marco Fontani [Wed, 13 Dec 2017 10:11:44 +0000 (11:11 +0100)]
refer to perldiag from perlfunc
Rather than duplicating information as to which keyword, function, or
operator generates which warning, point the reader to the proper place
to read about which warnings Perl generates in which scenario, which are
well described in the POD for "warnings". [perl #116080]
Zefram [Fri, 8 Dec 2017 19:23:29 +0000 (19:23 +0000)]
don't lose mark when pp_reverse extends stack
Nullary reverse needs to extend the stack to push its result scalar.
It was actually extending the stack, but doing so invalidated MARK,
which it relied upon to place the stack pointer afterwards. Upon stack
reallocation it was therefore leaving the stack pointer pointing to the
freed stack memory. Reformulate stack manipulation to not rely on MARK
after extending. Fixes [perl #132544].
David Mitchell [Thu, 14 Dec 2017 09:32:46 +0000 (09:32 +0000)]
Revert "re_intuit_start(): rename some local vars"
This reverts commit
ea569f0097183cb2c1b98852f31b47264605f0b7.
This was just a cosmetic (if useful) change and clashes with a branch
Yves is working on. So I'll redo it some other time.
Zefram [Thu, 14 Dec 2017 04:23:58 +0000 (04:23 +0000)]
warn on $a.$b.$c in void context
$a.$b.$c gets transformed early on to execute as ($a.$b).=$c, which didn't
warn about void context becuase .= looks like a useful side effect.
Happily, the recently-added OPpCONCAT_NESTED flag identifies that this
has happened. Make scalarvoid() pay attention to this flag when a concat
op is put into void context. Fixes [perl #6997]
Karl Williamson [Thu, 9 Mar 2017 19:06:34 +0000 (12:06 -0700)]
Cwd: Change strcmp into strEQ
The latter is easier to read
Karl Williamson [Thu, 14 Dec 2017 03:28:53 +0000 (20:28 -0700)]
Karl Williamson [Thu, 9 Mar 2017 17:54:20 +0000 (10:54 -0700)]
Data::Dumper: Change a strncmp to memBEGINs
The latter is much clearer as to what's going on
Karl Williamson [Mon, 27 Mar 2017 20:24:41 +0000 (14:24 -0600)]
Data::Dumper: Change strcpy to strlcpy
strlcpy is safer. This reverts to using strcpy if no version of strlcpy
is available (but one has been available in Perl since 5.9.4)
Zefram [Thu, 14 Dec 2017 02:37:03 +0000 (02:37 +0000)]
add preload to .gitignore
Zefram [Thu, 14 Dec 2017 02:27:28 +0000 (02:27 +0000)]
fix links in generated HTML documentation
Invoke installhtml in the right way for it to generate relative links.
Fix installhtml's code for creating relative links in the index for
split documents. Update Pod::Html's section name transformer to
match the actual output seen via Pod::Simple::XHTML. Incidentally
update split-on-head code for the new style of HTML generated by
Pod::Simple::XHTML. Fixes [perl #110056].
Karl Williamson [Thu, 14 Dec 2017 02:07:04 +0000 (19:07 -0700)]
Add PERL_REENTRANT for XS modules
This allows them to get the reentrant versions of libc functions
automatically. Previously if they wanted to do this, they had to
declare themselves (shudder) as PERL_CORE or PERL_EXT.
Karl Williamson [Thu, 14 Dec 2017 01:36:02 +0000 (18:36 -0700)]
perlfunc: Add note about reentrant functions
perl automatically and silently uses reentrant versions of some
functions in threaded perls when such functions are available. Note
this.
Zefram [Wed, 13 Dec 2017 22:59:28 +0000 (22:59 +0000)]
automatic titling in Pod::Html
Automatic extraction of a title from the content was lost with the
switch to using Pod::Simple::XHTML for rendering. It would be tricky
to add in Pod::Simple::XHTML, or anything else integrated into that
parser, because the stream-oriented approach plays poorly with any kind
of lookahead. Instead go to a two-stage conversion, parsing the input
to tree form using Pod::Simple::SimpleTree and later feeding the tree
to the stream-oriented Pod::Simple::XHTML for output. Between the two
stages, extract a default title from the tree, in time to use it when
setting options for Pod::Simple::XHTML. Fixes [perl #110520].
Karl Williamson [Thu, 23 Nov 2017 06:10:58 +0000 (23:10 -0700)]
pp_multiconcat() Use faster UTF-8 variant counting
David Mitchell [Wed, 13 Dec 2017 15:53:51 +0000 (15:53 +0000)]
re_intuit_start()/S_reghop3(): don't go beyond end
RT #132552
when hopping N characters along a string, if the 'end stop' lim wasn't
on a char boundary, the value returned by S_reghop3() could be up to
(but not including) one char's worth of bytes beyond lim.
This is fairly harmless, but gave valgrind/ASan palpitations.
So fixed by this commit.
David Mitchell [Wed, 13 Dec 2017 13:14:59 +0000 (13:14 +0000)]
re_intuit_start(): rename some local vars
(no functional changes)
For local variables which hold a length, rename that var with a _c or _b
suffix to indicate whether it holds a byte or character count.
There is a mixture of the two, and it's easy to get confused.
Also, in places, rename vars to more closely match the field they're
extracted from. For example, start_shift is set from the min_offset field
of the check slot of the substrings array, so it makes more sense to call
it check_min_offset_c.
Also add some code comments about what the vars are for.
Steve Hay [Wed, 13 Dec 2017 08:37:43 +0000 (08:37 +0000)]
Upgrade Time::Piece from vesion 1.3202 to 1.3203
Karl Williamson [Wed, 13 Dec 2017 06:01:02 +0000 (23:01 -0700)]
inline.h: Fix wrong order of shift and mask
I realized that one should mask before the shift in this macro that is
used in is_utf8_invariant_string_loc() and variant_under_utf8_count().
This would only show up on a 32-bit platform that doesn't have 64-bit
ability at all.