This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
perl5.git
19 months agoregcomp.c: Create fail-safe for reading out of bounds
Karl Williamson [Mon, 26 Aug 2019 22:15:38 +0000 (16:15 -0600)]
regcomp.c: Create fail-safe for reading out of bounds

It shouldn't happen that the pointer passed to this macro causes
out-of-bound reads, but there have been problems with this area in the
past, and we know the bounds for this non-time-critical function, so it
is a simple matter to make sure.

19 months agoLink directly to the -M section of perlrun from perlfunc/use
Dagfinn Ilmari Mannsåker [Wed, 23 Oct 2019 10:31:22 +0000 (11:31 +0100)]
Link directly to the -M section of perlrun from perlfunc/use

19 months agoperlretut - missing quote in example
Dan Book [Tue, 22 Oct 2019 20:25:23 +0000 (16:25 -0400)]
perlretut - missing quote in example

20 months agoPATCH: #17196, Assertion failure in /l pattern
Karl Williamson [Tue, 22 Oct 2019 14:00:28 +0000 (08:00 -0600)]
PATCH: #17196, Assertion failure in /l pattern

This was from an earlier change that modified some logic without paying
sufficient attention to the consequences of those modifications.

20 months agoperldelta for 10934390253ed18c48f144735ad3c6a508caabc1
James E Keenan [Tue, 22 Oct 2019 05:32:11 +0000 (07:32 +0200)]
perldelta for 10934390253ed18c48f144735ad3c6a508caabc1

20 months agoUpdate Sys-Syslog to CPAN version 0.36
Chris 'BinGOs' Williams [Tue, 22 Oct 2019 00:08:30 +0000 (01:08 +0100)]
Update Sys-Syslog to CPAN version 0.36

  [DELTA]

0.36 -- 2019-10-22 -- Sebastien Aperghis-Tramoni (SAPER)

  [Tests]
  - RT #127454 / GitHub PR #8: Intermittent failures on OpenBSD and other
    platforms (Jim Keenan).

20 months agoFix Johan Vromans CPAN URL
Max Maischein [Sun, 20 Oct 2019 18:58:36 +0000 (20:58 +0200)]
Fix Johan Vromans CPAN URL

20 months agoUpdate URL for Weebls Stuff
Max Maischein [Sun, 20 Oct 2019 18:58:19 +0000 (20:58 +0200)]
Update URL for Weebls Stuff

20 months agoImport dead URLs from my last analysis
Max Maischein [Sun, 20 Oct 2019 18:58:03 +0000 (20:58 +0200)]
Import dead URLs from my last analysis

Unfortunately, I haven't been able to find the content for these
URLs elsewhere.

Maybe we should add "Find one more URL from that list" to the release
manager guide so we regain one URL per month.

20 months agoFix y2038 project homepage
Max Maischein [Sun, 20 Oct 2019 18:56:50 +0000 (20:56 +0200)]
Fix y2038 project homepage

Googlecode.com is dead

20 months agoFully spell out "subroutine" and "variable"
Dagfinn Ilmari Mannsåker [Sat, 19 Oct 2019 13:36:30 +0000 (15:36 +0200)]
Fully spell out "subroutine" and "variable"

A bunch of places were using "%se" and "subroutin" or "variabl" when
generating error messages that could refer to either a subroutine or
variable.  Spell the words out and use plain "%s" instead.

20 months ago[MERGE] Factor out Perl_yylex() into a bunch of smaller functions
Aaron Crane [Mon, 21 Oct 2019 10:11:30 +0000 (12:11 +0200)]
[MERGE] Factor out Perl_yylex() into a bunch of smaller functions

This factors lots of code out of Perl_yylex(), which started at 4166
lines. It's now split into multiple functions; the largest remaining one
is 2159 lines. There's still plenty of work that could be done here, but
I hope this makes it easier to understand the lexer without having to
understand the whole thing simultaneously.

20 months agotoke.c: factor out static yyl_my()
Aaron Crane [Sun, 20 Oct 2019 13:03:36 +0000 (15:03 +0200)]
toke.c: factor out static yyl_my()

20 months agotoke.c: factor out static yyl_eol()
Aaron Crane [Sun, 20 Oct 2019 12:54:23 +0000 (14:54 +0200)]
toke.c: factor out static yyl_eol()

20 months agotoke.c: factor out static yyl_do()
Aaron Crane [Sun, 20 Oct 2019 12:48:06 +0000 (14:48 +0200)]
toke.c: factor out static yyl_do()

20 months agotoke.c: factor out static yyl_foreach()
Aaron Crane [Sun, 20 Oct 2019 12:36:50 +0000 (14:36 +0200)]
toke.c: factor out static yyl_foreach()

20 months agotoke.c: factor out static yyl_require()
Aaron Crane [Sun, 20 Oct 2019 12:33:37 +0000 (14:33 +0200)]
toke.c: factor out static yyl_require()

20 months agotoke.c: factor out static yyl_croak_unrecognised()
Aaron Crane [Mon, 21 Oct 2019 08:38:14 +0000 (10:38 +0200)]
toke.c: factor out static yyl_croak_unrecognised()

20 months agotoke.c: factor out static yyl_data_handle()
Aaron Crane [Sun, 20 Oct 2019 12:13:47 +0000 (14:13 +0200)]
toke.c: factor out static yyl_data_handle()

20 months agotoke.c: remove needless `if (0)`
Aaron Crane [Sun, 20 Oct 2019 12:02:34 +0000 (14:02 +0200)]
toke.c: remove needless `if (0)`

20 months agotoke.c: reorder to put static function before its caller
Aaron Crane [Sun, 20 Oct 2019 11:57:56 +0000 (13:57 +0200)]
toke.c: reorder to put static function before its caller

20 months agotoke.c: remove the "retry" label
Aaron Crane [Sun, 20 Oct 2019 11:36:47 +0000 (13:36 +0200)]
toke.c: remove the "retry" label

We can just use recursive calls instead — which compilers will compile to a
goto anyay!

20 months agotoke.c: factor most of Perl_yylex() out into static yyl_try()
Aaron Crane [Sun, 20 Oct 2019 10:19:02 +0000 (12:19 +0200)]
toke.c: factor most of Perl_yylex() out into static yyl_try()

20 months agotoke.c: factor out static yyl_backslash()
Aaron Crane [Sun, 20 Oct 2019 09:53:03 +0000 (11:53 +0200)]
toke.c: factor out static yyl_backslash()

20 months agotoke.c: factor out static yyl_backtick()
Aaron Crane [Sun, 20 Oct 2019 09:51:27 +0000 (11:51 +0200)]
toke.c: factor out static yyl_backtick()

20 months agotoke.c: factor out static yyl_sglquote()
Aaron Crane [Sun, 20 Oct 2019 09:51:17 +0000 (11:51 +0200)]
toke.c: factor out static yyl_sglquote()

20 months agotoke.c: factor out static yyl_dblquote()
Aaron Crane [Sun, 20 Oct 2019 09:48:46 +0000 (11:48 +0200)]
toke.c: factor out static yyl_dblquote()

20 months agotoke.c: factor out static yyl_rightpointy()
Aaron Crane [Sun, 20 Oct 2019 11:49:18 +0000 (13:49 +0200)]
toke.c: factor out static yyl_rightpointy()

20 months agotoke.c: factor out static yyl_leftpointy()
Aaron Crane [Sun, 20 Oct 2019 09:40:06 +0000 (11:40 +0200)]
toke.c: factor out static yyl_leftpointy()

20 months agotoke.c: simplify conflict-marker detection
Aaron Crane [Sun, 20 Oct 2019 09:35:57 +0000 (11:35 +0200)]
toke.c: simplify conflict-marker detection

Since doing this involves a `goto`, hoisting the check to the top of each
relevant `case` will make it easier to perform further refactoring.

20 months agotoke.c: factor out static yyl_rightparen()
Aaron Crane [Sun, 20 Oct 2019 09:17:57 +0000 (11:17 +0200)]
toke.c: factor out static yyl_rightparen()

20 months agotoke.c: factor out static yyl_leftparen()
Aaron Crane [Sun, 20 Oct 2019 09:17:43 +0000 (11:17 +0200)]
toke.c: factor out static yyl_leftparen()

20 months agotoke.c: factor out static yyl_rightsquare()
Aaron Crane [Sun, 20 Oct 2019 09:13:36 +0000 (11:13 +0200)]
toke.c: factor out static yyl_rightsquare()

20 months agotoke.c: factor out static yyl_tilde()
Aaron Crane [Sun, 20 Oct 2019 09:11:57 +0000 (11:11 +0200)]
toke.c: factor out static yyl_tilde()

20 months agotoke.c: factor out static yyl_leftsquare()
Aaron Crane [Sun, 20 Oct 2019 09:09:49 +0000 (11:09 +0200)]
toke.c: factor out static yyl_leftsquare()

20 months agotoke.c: factor out static yyl_slash()
Aaron Crane [Sun, 20 Oct 2019 08:44:42 +0000 (10:44 +0200)]
toke.c: factor out static yyl_slash()

20 months agotoke.c: factor out static yyl_snail()
Aaron Crane [Sun, 20 Oct 2019 08:43:03 +0000 (10:43 +0200)]
toke.c: factor out static yyl_snail()

20 months agotoke.c: factor out static yyl_bang()
Aaron Crane [Sun, 20 Oct 2019 08:38:26 +0000 (10:38 +0200)]
toke.c: factor out static yyl_bang()

20 months agotoke.c: factor out static yyl_verticalbar()
Aaron Crane [Sun, 20 Oct 2019 08:33:39 +0000 (10:33 +0200)]
toke.c: factor out static yyl_verticalbar()

20 months agotoke.c: factor out static yyl_ampersand()
Aaron Crane [Sun, 20 Oct 2019 08:29:47 +0000 (10:29 +0200)]
toke.c: factor out static yyl_ampersand()

20 months agotoke.c: factor out static yyl_rightcurly()
Aaron Crane [Sun, 20 Oct 2019 08:23:45 +0000 (10:23 +0200)]
toke.c: factor out static yyl_rightcurly()

20 months agotoke.c: factor out static yyl_leftcurly()
Aaron Crane [Sun, 20 Oct 2019 08:21:25 +0000 (10:21 +0200)]
toke.c: factor out static yyl_leftcurly()

20 months agotoke.c: factor out static yyl_colon()
Aaron Crane [Sun, 20 Oct 2019 08:10:04 +0000 (10:10 +0200)]
toke.c: factor out static yyl_colon()

20 months agotoke.c: factor out static yyl_caret()
Aaron Crane [Sat, 19 Oct 2019 15:57:12 +0000 (17:57 +0200)]
toke.c: factor out static yyl_caret()

20 months agotoke.c: factor out static yyl_percent()
Aaron Crane [Sat, 19 Oct 2019 15:55:12 +0000 (17:55 +0200)]
toke.c: factor out static yyl_percent()

20 months agotoke.c: factor out static yyl_star()
Aaron Crane [Sat, 19 Oct 2019 15:55:00 +0000 (17:55 +0200)]
toke.c: factor out static yyl_star()

20 months agotoke.c: factor out static yyl_plus()
Aaron Crane [Sat, 19 Oct 2019 15:48:06 +0000 (17:48 +0200)]
toke.c: factor out static yyl_plus()

20 months agoPerl_yylex(): merge two conditions for readability
Aaron Crane [Sat, 19 Oct 2019 15:42:43 +0000 (17:42 +0200)]
Perl_yylex(): merge two conditions for readability

20 months agotoke.c: factor out static yyl_subproto()
Aaron Crane [Sat, 19 Oct 2019 14:32:56 +0000 (16:32 +0200)]
toke.c: factor out static yyl_subproto()

20 months agotoke.c: factor out static yyl_hyphen()
Aaron Crane [Sat, 19 Oct 2019 14:10:17 +0000 (16:10 +0200)]
toke.c: factor out static yyl_hyphen()

20 months agotoke.c: factor out static yyl_qw()
Aaron Crane [Sat, 19 Oct 2019 13:57:52 +0000 (15:57 +0200)]
toke.c: factor out static yyl_qw()

20 months agotoke.c: factor out static yyl_secondclass_keyword()
Aaron Crane [Sat, 19 Oct 2019 13:48:03 +0000 (15:48 +0200)]
toke.c: factor out static yyl_secondclass_keyword()

20 months agotoke.c: factor out static yyl_lexinterpcasemod()
Aaron Crane [Sat, 19 Oct 2019 13:06:50 +0000 (15:06 +0200)]
toke.c: factor out static yyl_lexinterpcasemod()

20 months agotoke.c: factor out static yyl_dollar()
Aaron Crane [Sat, 19 Oct 2019 12:52:01 +0000 (14:52 +0200)]
toke.c: factor out static yyl_dollar()

20 months agotoke.c: delete needless assignment
Aaron Crane [Sat, 19 Oct 2019 12:51:12 +0000 (14:51 +0200)]
toke.c: delete needless assignment

Subsequent code will always `return` before consulting the variable.

20 months agotoke.c: factor out static yyl_sub()
Aaron Crane [Sat, 19 Oct 2019 12:17:02 +0000 (14:17 +0200)]
toke.c: factor out static yyl_sub()

20 months agotoke.c: format DEBUG_T() like a statement
Aaron Crane [Sat, 19 Oct 2019 10:19:38 +0000 (12:19 +0200)]
toke.c: format DEBUG_T() like a statement

This will make it easier to write trivial text-analysis tools to assist with
refactoring Perl_yylex().

20 months agotoke.c: hoist an ifdef out of Perl_yylex()
Aaron Crane [Sat, 19 Oct 2019 10:15:55 +0000 (12:15 +0200)]
toke.c: hoist an ifdef out of Perl_yylex()

This also means we no longer have two open-curlies corresponding to a single
close-curly.

20 months agotoke.c: factor out static yyl_sigvar()
Aaron Crane [Sat, 19 Oct 2019 09:16:41 +0000 (11:16 +0200)]
toke.c: factor out static yyl_sigvar()

20 months agoFix porting test failures: make manisort
Aaron Crane [Mon, 21 Oct 2019 08:57:15 +0000 (10:57 +0200)]
Fix porting test failures: make manisort

20 months agoUpdate documentation, comments, metadata to reference GitHub as canonical repository...
Dan Book [Sun, 20 Oct 2019 16:47:10 +0000 (12:47 -0400)]
Update documentation, comments, metadata to reference GitHub as canonical repository (#1186)

* Update repository and bugtracker URLs to GitHub in makemeta

regen META files

* Update POD and comments to reference GitHub as canonical repository

* Update Porting/corelist.pl to recognize GitHub issue tracker

* remove "A note on camel and dromedary"

* Remove redundant 'Committing your changes' section

20 months agoAdd GitHub security template
Nicolas R [Sun, 20 Oct 2019 15:25:48 +0000 (17:25 +0200)]
Add GitHub security template

Add a SECURITY.md file, so GitHub will
show a 'Report a security vulnerability' pointing
to the Policy when trying to create one issue.

20 months agoAaron Crane is no longer a p5p moderator
Aaron Crane [Fri, 18 Oct 2019 07:58:31 +0000 (09:58 +0200)]
Aaron Crane is no longer a p5p moderator

Sorry, everybody: I no longer have time to keep up with the list, and it's
therefore unreasonable to claim I can do an adequate job of moderation.

20 months agoModule::CoreList 5.20191020 is now on CPAN
Steve Hay [Sun, 20 Oct 2019 15:31:41 +0000 (16:31 +0100)]
Module::CoreList 5.20191020 is now on CPAN

20 months agoUpdate Module::CoreList for 5.31.6
Steve Hay [Sun, 20 Oct 2019 15:20:30 +0000 (16:20 +0100)]
Update Module::CoreList for 5.31.6

20 months agoBump version to 5.31.6
Steve Hay [Sun, 20 Oct 2019 15:11:56 +0000 (16:11 +0100)]
Bump version to 5.31.6

(includes regen/opcode.pl)

20 months agoCreate new perldelta for 5.31.6
Steve Hay [Sun, 20 Oct 2019 14:55:03 +0000 (15:55 +0100)]
Create new perldelta for 5.31.6

20 months agoTick off 5.31.5
Steve Hay [Sun, 20 Oct 2019 14:46:43 +0000 (15:46 +0100)]
Tick off 5.31.5

20 months agoAdd epigraph for 5.31.5
Steve Hay [Sun, 20 Oct 2019 14:45:47 +0000 (15:45 +0100)]
Add epigraph for 5.31.5

20 months ago5.31.5 today v5.31.5
Steve Hay [Sun, 20 Oct 2019 11:42:47 +0000 (12:42 +0100)]
5.31.5 today

20 months agoFinalize perldelta
Steve Hay [Sun, 20 Oct 2019 11:37:51 +0000 (12:37 +0100)]
Finalize perldelta

20 months agoUpdate Module::CoreList for 5.31.5
Steve Hay [Sun, 20 Oct 2019 11:32:55 +0000 (12:32 +0100)]
Update Module::CoreList for 5.31.5

20 months agoperldelta tidy-ups
Steve Hay [Sun, 20 Oct 2019 10:57:25 +0000 (11:57 +0100)]
perldelta tidy-ups

20 months agoperldelta - Remove boilerplate stuff
Steve Hay [Sun, 20 Oct 2019 10:45:28 +0000 (11:45 +0100)]
perldelta - Remove boilerplate stuff

20 months agoperldelta - Document changes not mentioned yet
Steve Hay [Sun, 20 Oct 2019 10:39:10 +0000 (11:39 +0100)]
perldelta - Document changes not mentioned yet

20 months agoperldelta - Documentation and Diagnostics
Steve Hay [Sun, 20 Oct 2019 10:21:31 +0000 (11:21 +0100)]
perldelta - Documentation and Diagnostics

20 months agoperldelta - Modules and Pragmata
Steve Hay [Sun, 20 Oct 2019 09:53:59 +0000 (10:53 +0100)]
perldelta - Modules and Pragmata

20 months agoFinish prepping Module::CoreList for 5.31.5
Steve Hay [Sun, 20 Oct 2019 09:52:06 +0000 (10:52 +0100)]
Finish prepping Module::CoreList for 5.31.5

These bits were missed from commit 3e14cc163c.

20 months agoFix a failing test in Math::BigInt with VC14 or higher
Steve Hay [Sun, 20 Oct 2019 09:30:08 +0000 (10:30 +0100)]
Fix a failing test in Math::BigInt with VC14 or higher

See CPAN RT #130736

20 months agoAdd GitHub issue templates
Nicolas R [Tue, 11 Jun 2019 17:48:40 +0000 (11:48 -0600)]
Add GitHub issue templates

These files should not be in the MANIFEST
adjust porting/manifest.t to ignore .github files
in addition to .gitignore files.

20 months agoRemove indentation of no-longer #ifdef-guarded #defines origin/HEAD origin/blead
Dagfinn Ilmari Mannsåker [Thu, 17 Oct 2019 11:48:00 +0000 (13:48 +0200)]
Remove indentation of no-longer #ifdef-guarded #defines

Commit 0f9a6232f0af0895807ddd0afae2d5512aa91bf9 removed the #ifdef
PERL_OP_PARENT, but left the #define directives indented.

20 months agoDelta entries for Configure related changes
H.Merijn Brand [Thu, 17 Oct 2019 07:42:49 +0000 (09:42 +0200)]
Delta entries for Configure related changes

20 months agoAdd RM for 5.31.5
Steve Hay [Thu, 17 Oct 2019 07:18:46 +0000 (08:18 +0100)]
Add RM for 5.31.5

20 months agoperldelta for 7adf247031
Steve Hay [Thu, 17 Oct 2019 07:15:37 +0000 (08:15 +0100)]
perldelta for 7adf247031

20 months agoThe VC6 Chainsaw Massacre
Steve Hay [Fri, 11 Oct 2019 07:10:26 +0000 (08:10 +0100)]
The VC6 Chainsaw Massacre

Remove MS Visual C++ 6.0 support as agreed in the thread starting here:
https://www.nntp.perl.org/group/perl.perl5.porters/2019/07/msg255625.html

20 months agoUpdate lists of CUSTOMIZED files
Steve Hay [Wed, 16 Oct 2019 07:43:11 +0000 (08:43 +0100)]
Update lists of CUSTOMIZED files

20 months agoWe are (almost) in sync with Devel::PPPort version 3.54
Steve Hay [Wed, 16 Oct 2019 07:16:08 +0000 (08:16 +0100)]
We are (almost) in sync with Devel::PPPort version 3.54

20 months agoUpgrade Math::BigInt::FastCalc from version 0.5008 to 0.5009
Steve Hay [Wed, 16 Oct 2019 07:09:35 +0000 (08:09 +0100)]
Upgrade Math::BigInt::FastCalc from version 0.5008 to 0.5009

20 months agoUpgrade Math::BigInt from version 1.999816 to 1.999817
Steve Hay [Wed, 16 Oct 2019 07:06:47 +0000 (08:06 +0100)]
Upgrade Math::BigInt from version 1.999816 to 1.999817

20 months agoDocument UTF8_MAXBYTES_CASE
Karl Williamson [Wed, 16 Oct 2019 06:48:33 +0000 (23:48 -0700)]
Document UTF8_MAXBYTES_CASE

20 months agoAdd missing epigraph for 5.31.3
Steve Hay [Mon, 14 Oct 2019 12:51:52 +0000 (13:51 +0100)]
Add missing epigraph for 5.31.3

20 months agoExtend test coverage for Dumpvalue.pm
James E Keenan [Sun, 13 Oct 2019 12:45:22 +0000 (08:45 -0400)]
Extend test coverage for Dumpvalue.pm

Improve coverage since version 1.18.

$ cat Dumpvalue.original.coverage
--------------------- ------ ------ ------ ------ ------ ------ ------
File                    stmt   bran   cond    sub    pod   time  total
--------------------- ------ ------ ------ ------ ------ ------ ------
blib/lib/Dumpvalue.pm   95.8   74.7   59.7  100.0   45.8  100.0   81.2
Total                   95.8   74.7   59.7  100.0   45.8  100.0   81.2
--------------------- ------ ------ ------ ------ ------ ------ ------

$ cat 8e07bd5a.coverage.txt
--------------------- ------ ------ ------ ------ ------ ------ ------
File                    stmt   bran   cond    sub    pod   time  total
--------------------- ------ ------ ------ ------ ------ ------ ------
blib/lib/Dumpvalue.pm   98.7   89.0   70.9  100.0   45.8  100.0   88.6
Total                   98.7   89.0   70.9  100.0   45.8  100.0   88.6
--------------------- ------ ------ ------ ------ ------ ------ ------

20 months agoFix UTF8_CHK_SKIP()
Karl Williamson [Sun, 13 Oct 2019 07:35:43 +0000 (00:35 -0700)]
Fix UTF8_CHK_SKIP()

I forgot an arg in a macro it calls.

20 months agoperldelta for recent changes to dist/Dumpvalue
James E Keenan [Sun, 13 Oct 2019 12:53:50 +0000 (08:53 -0400)]
perldelta for recent changes to dist/Dumpvalue

20 months agoDo not use 'exists' on arrays; use 'defined' instead
James E Keenan [Thu, 10 Oct 2019 22:49:20 +0000 (18:49 -0400)]
Do not use 'exists' on arrays; use 'defined' instead

pod/perlfunc.pod advises us:

       WARNING: Calling "exists" on array values is strongly
       discouraged. The notion of deleting or checking the existence of
       Perl array elements is not conceptually coherent, and can lead
       to surprising behavior.

While trying to extend the test coverage of Dumpvalue.pm, two instances
of 'exists ARRAYREF' were noted.  In the second of these two instances,
using 'exists ARRAYREF' resulted in the 'if' condition of an if/else
block always returning true, thereby making the corresponding 'else'
condition unreachable -- a situation which was confirmed by coverage
analysis.

We should only use best practices in modules maintained by Perl 5
Porters; this patch implements that.  When we do so, a different (but
actually better) error message appears in the second instance; so tests
are updated as well.

For: RT 134492

20 months agoUpdate p5p list archive links
Max Maischein [Sun, 13 Oct 2019 07:38:55 +0000 (09:38 +0200)]
Update p5p list archive links

xray.mpe.mpg.de does not serve archives anymore, archive.develooper.com redirects to www.nntp.perl.org

20 months agoSwitch from http://search.cpan.org/ as entry URL to https://metacpan.org/
Max Maischein [Wed, 9 Oct 2019 19:42:01 +0000 (21:42 +0200)]
Switch from search.cpan.org/ as entry URL to https://metacpan.org/

20 months agoAvoid gratuitous warning from -Wundef
Peter Eisentraut [Sat, 12 Oct 2019 19:32:13 +0000 (21:32 +0200)]
Avoid gratuitous warning from -Wundef

Use #ifdef instead of #if to avoid warning if a user of this header
file uses the gcc -Wundef option.

Committer: Peter Eisentraut is now a Perl author.

For: RT 134494

20 months agoDumpvalue: handle one more potential warning
James E Keenan [Sat, 12 Oct 2019 00:01:26 +0000 (20:01 -0400)]
Dumpvalue:  handle one more potential warning

While working on adding tests to this module, the following warning
sometimes appeared:

        Use of each() on hash after insertion without resetting hash
        iterator results in undefined behavior

Per perldiag, instead use 'keys' function to iterate over hash.

20 months agoUse warnings in Dumpvalue.pm; fix those found
James E Keenan [Wed, 9 Oct 2019 19:45:41 +0000 (15:45 -0400)]
Use warnings in Dumpvalue.pm; fix those found

Activating warnings showed many fixable warnings.  The suppression of
some of those warnings was obscuring other problems.