This is a live mirror of the Perl 5 development currently hosted at
11 years agomktables: Add error check
Karl Williamson [Tue, 4 Jan 2011 23:50:04 +0000 (16:50 -0700)]
mktables: Add error check

This makes sure that in certain cases when adding to a table that we
know should not have elements in the area that it actually does.

11 years agoUse Zero() rather than rely on C99 struct initialiser behaviour
Paul "LeoNerd" Evans [Tue, 4 Jan 2011 16:38:08 +0000 (16:38 +0000)]
Use Zero() rather than rely on C99 struct initialiser behaviour

Signed-off-by: Ævar Arnfjörð Bjarmason <>
11 years agoConvert tied WRITE to using S_tied_handle_method()
Nicholas Clark [Tue, 4 Jan 2011 16:59:46 +0000 (16:59 +0000)]
Convert tied WRITE to using S_tied_handle_method()

11 years agoConvert tied READ to using S_tied_handle_method()
Nicholas Clark [Tue, 4 Jan 2011 15:31:03 +0000 (15:31 +0000)]
Convert tied READ to using S_tied_handle_method()

11 years agoConvert tied PRINTF to using S_tied_handle_method()
Nicholas Clark [Tue, 4 Jan 2011 12:23:30 +0000 (12:23 +0000)]
Convert tied PRINTF to using S_tied_handle_method()

11 years agoConvert tied OPEN to using S_tied_handle_method()
Nicholas Clark [Tue, 4 Jan 2011 11:54:25 +0000 (11:54 +0000)]
Convert tied OPEN to using S_tied_handle_method()

Add a new flag ARGUMENTS_ON_STACK to S_tied_handle_method(), which methods
which take a list (OPEN, PRINTF, READ and WRITE) will need.

11 years agoIn pp_sys.c, move S_tied_handle_method() before pp_open.
Nicholas Clark [Tue, 4 Jan 2011 11:36:48 +0000 (11:36 +0000)]
In pp_sys.c, move S_tied_handle_method() before pp_open.

11 years agostash.t: make TODO tests only TODO under threads
David Mitchell [Tue, 4 Jan 2011 14:36:37 +0000 (14:36 +0000)]
stash.t: make TODO tests only TODO under threads

.. since they only fail under threads.

11 years agoRemove a long-vestigial PUTBACK from the tied OPEN code in pp_send.
Nicholas Clark [Tue, 4 Jan 2011 10:13:42 +0000 (10:13 +0000)]
Remove a long-vestigial PUTBACK from the tied OPEN code in pp_send.

Commit 4592e6caefc41a75, from 1999, added the PUTBACK as part of the initial
implementation of tied OPEN. At this time, pp_open (as then was) popped the
arguments off the stack (to local variables), so the new tie code pushed them
back onto the stack, before calling the method. The stack position was
manipulated, hence the local variable sp had potentially diverged from the
global PL_stack_sp, hence the latter needed updating.

Commit a567e93b903bc984, from 2001, which added support for
open $fh, '|-', @array; refactored pp_open to avoid all stack manipulation.
Hence sp (the local variable) never changes along this code path, hence it
never needs to be written back to PL_stack_sp.

11 years agoConverge the implementation of tied OPEN with PRINTF, READ and WRITE.
Nicholas Clark [Tue, 4 Jan 2011 09:48:27 +0000 (09:48 +0000)]
Converge the implementation of tied OPEN with PRINTF, READ and WRITE.

Consistency will make it easier to refactor.

11 years agobuild man pages on cygwin too
Reini Urban [Tue, 14 Sep 2010 16:04:22 +0000 (18:04 +0200)]
build man pages on cygwin too

11 years agoImprove cygwin rebase behaviour
Reini Urban [Tue, 14 Sep 2010 15:54:15 +0000 (17:54 +0200)]
Improve cygwin rebase behaviour

If a dll is updated on cygwin reuse the old imagebase address.
This solves most rebase errors, esp when updating on core dll's.

11 years agoRefactor filenames.t to use unlike() and cmp_ok() for better diagnostics.
Nicholas Clark [Tue, 4 Jan 2011 08:29:35 +0000 (08:29 +0000)]
Refactor filenames.t to use unlike() and cmp_ok() for better diagnostics.

Also, use regexs in place of the loops over @dont and @more_dont, the lists
of Win32 (was DOS (was CP/M)) reserved device filenames and of disallowed
characters. This makes the intent clearer, at the cost of some runtime.

11 years agoDon't install Cygwin code into other platforms
Jan Dubois [Tue, 4 Jan 2011 02:40:17 +0000 (18:40 -0800)]
Don't install Cygwin code into other platforms

DynaLoader already has its own preprocessor to filter out code that
is only relevant on other platforms, so use it for the change from
commit cc7e77fd

11 years agoupdate t/porting/filenames.t to check for path components contaning two
Jesse Vincent [Mon, 3 Jan 2011 17:24:05 +0000 (01:24 +0800)]
update t/porting/filenames.t to check for path components contaning two
"." characters or with lenghts exceeding 32 characters.

11 years agoregen/ add comments to overload.[ch]
David Mitchell [Mon, 3 Jan 2011 16:49:02 +0000 (16:49 +0000)]
regen/ add comments to overload.[ch]

In the auto-generated overload.c and overload.h files, add a comment to
each line mapping from the method name to the enumeration name and

11 years agoActuall excise 'Apollo DomainOS' support. We officially killed it in 5.11.0. It
Jesse Vincent [Mon, 3 Jan 2011 16:41:22 +0000 (00:41 +0800)]
Actuall excise 'Apollo DomainOS' support. We officially killed it in 5.11.0. It
hadn't worked for years before that.

11 years agoAdd link for v5.8.5-RC1 announcement
Zsbán Ambrus [Mon, 3 Jan 2011 16:41:35 +0000 (08:41 -0800)]
Add link for v5.8.5-RC1 announcement

11 years agoCYG14 Dynaloader without USEIMPORTLIB, and search cyg prefix
Reini Urban [Tue, 14 Sep 2010 15:48:32 +0000 (17:48 +0200)]
CYG14 Dynaloader without USEIMPORTLIB, and search cyg prefix

part1: Support the standard cyg dll prefix, which is e.g. needed for FFI's.
Ctypes and C::DynaLib use DynaLoader to find dlls.

part2: With -DUSEIMPORTLIB DynaLoader symbols link against the prefixed
symbol names for the .dll.a importlib, but we need to link against the
symbols directly. We don't link Dynaloader against libperl.dll.a.

$ g++-4 -o cygperl5_13_4.dll --shared perlsrc.o cygwin.o  DynaLoader.o -ldl -lcrypt
  Creating library file: libperl.dll.a
  DynaLoader.o: In function `XS_DynaLoader_dl_undef_symbols':
  ext/DynaLoader/DynaLoader.c:346: undefined reference to `__imp__PL_stack_sp'
  ext/DynaLoader/DynaLoader.c:346: undefined reference to `__imp__PL_markstack_ptr'
  ext/DynaLoader/DynaLoader.c:346: undefined reference to `__imp__PL_stack_base'

11 years agoUpdate cygwin hints
Reini Urban [Tue, 14 Sep 2010 16:06:38 +0000 (18:06 +0200)]
Update cygwin hints
do not use usemymalloc (double size + slow)
remove deprecated libcygipc info
remove overlarge stack size

11 years agoreindent tryAMAGICunTARGET after previous change
David Mitchell [Mon, 3 Jan 2011 12:56:51 +0000 (12:56 +0000)]
reindent tryAMAGICunTARGET after previous change

11 years agosimplify tryAMAGICunTARGET
David Mitchell [Mon, 3 Jan 2011 12:54:21 +0000 (12:54 +0000)]
simplify tryAMAGICunTARGET

Expecting the targ in sp[-1] rather than sp[0] is accomplished
cleanly using dATARGET.

11 years agofix a few typos in lib/overload.t
David Mitchell [Mon, 3 Jan 2011 12:51:27 +0000 (12:51 +0000)]
fix a few typos in lib/overload.t

11 years agoReindent pp_rv2av
Vincent Pit [Mon, 3 Jan 2011 11:05:57 +0000 (12:05 +0100)]
Reindent pp_rv2av

11 years agomissing article
Father Chrysostomos [Mon, 3 Jan 2011 07:49:17 +0000 (23:49 -0800)]
missing article

11 years ago(no commit message)
Father Chrysostomos [Mon, 3 Jan 2011 07:38:32 +0000 (23:38 -0800)]

11 years agoSilence a compiler warning
Father Chrysostomos [Mon, 3 Jan 2011 07:21:14 +0000 (23:21 -0800)]
Silence a compiler warning

11 years agoRestore the old description of $[
Father Chrysostomos [Mon, 3 Jan 2011 07:14:37 +0000 (23:14 -0800)]
Restore the old description of $[

The new entry is a bit too futuristic: assignment to $[ still works
and it is not read-only.

This does not fully restore the old description, as it contained
grammatical errors and parts of it were not updated when 5.10 changed
the scoping.

11 years agoRevert "[perl #68654] next::method doesn't see UNIVERSAL"
Father Chrysostomos [Mon, 3 Jan 2011 07:00:57 +0000 (23:00 -0800)]
Revert "[perl #68654] next::method doesn't see UNIVERSAL"

This reverts commit a5cd004dbd757df2bcf9e17aab6a8ed1272157d7.

11 years agoRevert "[perl #80098] Bleadperl breaks Attribute::Lexical"
Father Chrysostomos [Mon, 3 Jan 2011 07:00:53 +0000 (23:00 -0800)]
Revert "[perl #80098] Bleadperl breaks Attribute::Lexical"

This reverts commit 1726bc11330f7a943b1e12c6dd5fa5454b90abd6.

11 years ago[perl #45147] Issue with the exists function
Peter Martini [Mon, 3 Jan 2011 06:54:04 +0000 (22:54 -0800)]
[perl #45147] Issue with the exists function

Perl_av_exists tested to see if regdata magic was present,
but did not have any logic to fetch that data in the positive
key case.  Additionally, in the negative key case, if AvFILL
indicated the key existed, it wouldn't return, and would then
fall through to the logic that treated it like a real array.

11 years ago[perl #81032] Overhaul Porting/epigraphs.pod
Zsbán Ambrus [Mon, 3 Jan 2011 04:25:55 +0000 (20:25 -0800)]
[perl #81032] Overhaul Porting/epigraphs.pod

This patch makes multiple changes to Porting/epigraphs.pod and

For those that don't know, Porting/epigraphs.pod is a new document that
collects the quotes (chosen by Pumpkins) in perl release announcements.

The changes are the following.

1. Add a link pointing to each release announcement in the mailing
list archives.  These are from ysth's list, the source from which
Porting/epigraphs.pod was originally compiled, but they weren't in
Porting/epigraphs.pod so far.
2. Reorder Porting/epigraphs.pod chronologically, because I believe
that makes more sense -- pod/perlhist.pod is still sorted by version numbers.
3. Incidentally, some missing releases are added to pod/perlhist.pod too.
4. Fix a mistake where Porting/epigraphs.pod gives the wrong version number.
5. Add some epigraphs that appear in ysth's list but not in
6. I did some research in perl history before the part that ysth's list
covers, and added older perl announcements I found.  This work is not
complete: I stopped somewhere in 2000.

11 years agoGive a warning if pack_sockaddr_in6 is asked to pack a non-zero scope_id on machines...
Paul "LeoNerd" Evans [Thu, 30 Dec 2010 20:50:13 +0000 (20:50 +0000)]
Give a warning if pack_sockaddr_in6 is asked to pack a non-zero scope_id on machines that can't support it

11 years agoUse HAS_SIN6_SCOPE_ID rather than glibc version testing
Paul "LeoNerd" Evans [Thu, 30 Dec 2010 19:26:19 +0000 (19:26 +0000)]
Use HAS_SIN6_SCOPE_ID rather than glibc version testing

11 years agoBugfix to 's GAI fallback constants - use $name rather than $_
Paul "LeoNerd" Evans [Thu, 16 Dec 2010 11:49:49 +0000 (11:49 +0000)]
Bugfix to 's GAI fallback constants - use $name rather than $_

11 years agoCapture newly-created unit tests to MANIFEST
Paul "LeoNerd" Evans [Wed, 15 Dec 2010 16:02:19 +0000 (16:02 +0000)]
Capture newly-created unit tests to MANIFEST

11 years agoMake 'use strict' clean
Paul "LeoNerd" Evans [Wed, 15 Dec 2010 15:13:19 +0000 (15:13 +0000)]
Make 'use strict' clean

11 years agoProvide fallback implementation of getaddrinfo and getnameinfo in pure perl if libc...
Paul "LeoNerd" Evans [Wed, 15 Dec 2010 14:37:51 +0000 (14:37 +0000)]
Provide fallback implementation of getaddrinfo and getnameinfo in pure perl if libc doesn't provide one

11 years agoInitial documentation of getaddrinfo and getnameinfo functions
Paul "LeoNerd" Evans [Mon, 13 Dec 2010 18:13:10 +0000 (18:13 +0000)]
Initial documentation of getaddrinfo and getnameinfo functions

11 years agoUnit tests for Socket::getaddrinfo() and Socket::getnameinfo()
Paul "LeoNerd" Evans [Mon, 13 Dec 2010 17:50:56 +0000 (17:50 +0000)]
Unit tests for Socket::getaddrinfo() and Socket::getnameinfo()

11 years agoImplement Socket::getaddrinfo() and Socket::getnameinfo(), with related constants
Paul "LeoNerd" Evans [Mon, 13 Dec 2010 17:50:06 +0000 (17:50 +0000)]
Implement Socket::getaddrinfo() and Socket::getnameinfo(), with related constants

11 years agoConditionally set sa_len-type fields when packing sockaddr addresses
Paul "LeoNerd" Evans [Fri, 10 Dec 2010 15:02:30 +0000 (15:02 +0000)]
Conditionally set sa_len-type fields when packing sockaddr addresses

11 years agoAdd new test file t/porting/filenames.t
Nuno Carvalho [Fri, 24 Dec 2010 23:10:49 +0000 (23:10 +0000)]
Add new test file t/porting/filenames.t

Check portability of filenames from the MANIFEST.  Modified by
committer to remove check for multiple dots -- there are already
too many violations and there are workarounds to handle them.

Also tweaked to report full path so it's easier to find culprits.

Still need checks for dots in directory names and paths that
differ only by case.

11 years agoClever tests may fool with $^O.
Craig A. Berry [Mon, 3 Jan 2011 00:19:51 +0000 (18:19 -0600)]
Clever tests may fool with $^O.

So make t/ use its private version throughout.

11 years agoAdd JSON::PP to the Perl core
David Golden [Fri, 31 Dec 2010 04:43:44 +0000 (23:43 -0500)]
Add JSON::PP to the Perl core

Per discussions with Jesse Vincent, JSON::PP has been added
to the Perl core to support the new CPAN meta file specification

11 years agotests for [perl #36347] Object destruction incomplete
Father Chrysostomos [Mon, 3 Jan 2011 02:30:17 +0000 (18:30 -0800)]
tests for [perl #36347] Object destruction incomplete

11 years ago[perl #36347] Object destruction incomplete
Father Chrysostomos [Sun, 2 Jan 2011 22:51:21 +0000 (14:51 -0800)]
[perl #36347] Object destruction incomplete

do_clean_objs only looks for objects referenced by RVs, so blessed
array references and lexical variables (and probably other SVs, too)
are not DESTROYed.

This commit adds a new visit() call to sv_clean_objs, which curses
(DESTROYs and un-blesses, leaving the reference count as it is) any
objects that are still left after do_clean_named_io_objs. The new
do_curse routine (a pointer to which is passeds to visit()) follows
do_clean_named_io_objs’ example and explicitly skips the STDOUT and
STDERR handles, in case destructors need to use them.

The cursing code, which is now called from two places, is moved out of
sv_clear and put in its own routine. The check that the reference
count is zero does not apply when called from sv_clean_objs, so the
new S_curse routine takes a boolean argument that determines whether
that check should take place.

11 years agoMerge branch 'briandfoy/perlfaq' into blead
brian d foy [Mon, 3 Jan 2011 02:27:39 +0000 (20:27 -0600)]
Merge branch 'briandfoy/perlfaq' into blead

11 years agoperlfaq1: Adjust some of the language around the Perl 6 references
brian d foy [Mon, 3 Jan 2011 02:26:01 +0000 (20:26 -0600)]
perlfaq1: Adjust some of the language around the Perl 6 references

11 years ago[perl #73630] Build separate DTrace for miniperl
David Leadbeater [Sun, 2 Jan 2011 22:33:16 +0000 (14:33 -0800)]
[perl #73630] Build separate DTrace for miniperl

As outlined in the RT ticket due to miniperl's dependencies differing to
the final perl binary dtrace -G needs to be called separately for each.

Build tested on Mac OS X 10.6, Solaris 11 and Scientific Linux with
SystemTap from git.

(Solaris is the only system I have access to where DTRACE_O actually gets
defined. Neither the dtrace binary on OS X nor SystemTap's dtrace
compatibility layer accept the -G option.)

11 years agoUpdate CPAN::Meta::YAML to 0.003
David Golden [Sun, 2 Jan 2011 22:34:44 +0000 (17:34 -0500)]
Update CPAN::Meta::YAML to 0.003

This is a minor documentation change at Ingy's request.  Also,
the 0.003 CPAN release omits a test file that we were excluding
so I've removed it from the EXCLUDES list in

11 years ago[perl #81500] Make compilation work when NO_ENV_ARRAY_IN_MAIN is defined
David Leadbeater [Sun, 2 Jan 2011 21:38:21 +0000 (13:38 -0800)]
[perl #81500] Make compilation work when NO_ENV_ARRAY_IN_MAIN is defined

This is only normally defined if OEMVS is defined; the commit that added it
(2f3efc97) claims z/OS support. I guess no-one has tried this for awhile as
dd374669 broke this in 2005.

11 years ago[perl #81400] Fix bmodinv() part of RT 63237
Peter John Acklam [Sun, 2 Jan 2011 21:13:31 +0000 (13:13 -0800)]
[perl #81400] Fix bmodinv() part of RT 63237

The following standard definition is used: z is the modular inverse of
x (mod y) if and only if x*z (mod y) = 1 (mod y).

- dist/Math-BigInt/lib/Math/ Fix the code in bmodinv() so it can
  handle negative arguments. The code can be optimized further for speed,
  but correctnes first.

- dist/Math-BigInt/t/ Fix the test case for modinv(-3, -5).
  The output should be -3, since -3 * -3 (mod -5) = -9 (mod -5) = -4, and
  1 (mod -5) = -4.

- dist/Math-BigRat/t/ Fix same test case as above.
  Math::BigRat::bmodinv() only handles integers, and is essentially just a
  front-end to Math::BigInt::bmodinv().

11 years agoDon't clobber $^O when you're going to use it again.
Craig A. Berry [Sun, 2 Jan 2011 21:16:11 +0000 (15:16 -0600)]
Don't clobber $^O when you're going to use it again.

Even if using it means relying on t/ functionality such as

11 years agoGvIO(gv) returns NULL for a NULL gv, so refactor to take advantage of this.
Nicholas Clark [Sun, 2 Jan 2011 20:56:21 +0000 (20:56 +0000)]
GvIO(gv) returns NULL for a NULL gv, so refactor to take advantage of this.

Simplify tests of !gv || !io to just !io, avoid calling GvIO(gv) more than
once, and where possible initialise io at declaration time, to allow it to be

11 years agomake <expr> always overload if expr is overloaded
David Mitchell [Sun, 2 Jan 2011 19:38:30 +0000 (19:38 +0000)]
make <expr> always overload if expr is overloaded

Due to the way that '<> as glob' was parsed differently from
'<> as filehandle' from 5.6 onwards, something like <$foo[0]>
didn't handle overloading, even where $foo[0] was an overloaded object.
This was contrary to the docs for overload, and meant that <> couldn't
be used as a general overloaded iterator operator.

11 years agooverloaded <> sometimes left an extra stack arg
David Mitchell [Sun, 2 Jan 2011 15:04:50 +0000 (15:04 +0000)]
overloaded <> sometimes left an extra stack arg

11 years agocall pp_glob() even when its being skipped
David Mitchell [Fri, 31 Dec 2010 18:55:36 +0000 (18:55 +0000)]
call pp_glob() even when its being skipped

Currently when an external Perl glob function is used (which is most of
the time), the OP_GLOB op is removed and replaced with the pair:

This commit re-adds the OP_GLOB to the op tree, but with OPf_SPECIAL set;
and pp_glob() is updated to just return if OPf_SPECIAL is set.

Thus there's no change in outward functionality with this commit. However,
by always calling pp_glob(), it will allow us (in the next commit) to
handle iterator overloading consistently, regardless of whether the
internal globbing function is used or not.

11 years agock_glob() - add a little code comment
David Mitchell [Fri, 31 Dec 2010 14:53:24 +0000 (14:53 +0000)]
ck_glob() - add a little code comment

11 years ago1; is not a valid no-op for /bin/sh, but true is.
Nicholas Clark [Sun, 2 Jan 2011 17:01:49 +0000 (18:01 +0100)]
1; is not a valid no-op for /bin/sh, but true is.

b99c822f5c5b52c3 was not actually correct in identify the cause of the errors.
(although still a valid change to make for the sake of consistency)

11 years agoUpdate META.yml's no_index after the Time-Local move
Florian Ragwitz [Sun, 2 Jan 2011 17:08:26 +0000 (18:08 +0100)]
Update META.yml's no_index after the Time-Local move

We should probably write a porting test for that at some point.

11 years agoCPAN is upstream for Time::Local again
Florian Ragwitz [Sun, 2 Jan 2011 16:19:37 +0000 (17:19 +0100)]
CPAN is upstream for Time::Local again

11 years agoMake Time::Local run on perls older than 5.12 again
Florian Ragwitz [Sun, 2 Jan 2011 15:25:52 +0000 (16:25 +0100)]
Make Time::Local run on perls older than 5.12 again

With 5.12, this module was made y2038-safe, even on systems with a 32-bit
time_t. Unfortunately, that broke things on older perl versions and blead became
this module's upstream as the y2038-safety couldn't easily be backported.

This change also doesn't attempt to backport y2038 support. It merely restores
the old behaviour including the y2038 limitations on older versions of perl on
platforms without a 64-bit time_t.

With this, we can at least move Time::Locale's upstream back to CPAN. Making it
y2038-safe for old perls on 32-bit time_t platforms probably shouldn't be a
priority anyway. There's Time::y2038, which does everything this module does,
and then some, while being y2038-safe.

At some point, this module should probably be deprecated.

11 years agochmod +x metaconfig.SH.
Nicholas Clark [Sun, 2 Jan 2011 10:40:25 +0000 (10:40 +0000)]
chmod +x metaconfig.SH.

Otherwise ./Configure -S generates a diagnostic, as it expects to be able to
execute it.

11 years agoperlbug did not previously generate a From: header. While some MTAs do
Jesse Vincent [Sun, 2 Jan 2011 02:50:21 +0000 (10:50 +0800)]
perlbug did not previously generate a From: header. While some MTAs do
the "right" thing and insert a valid "From:", not all of them do,
potentially resulting in dropped mail.

11 years agoEnsure ExtUtils::CBuilder's 04-base.t cleans up its temporary directories.
Nicholas Clark [Sat, 1 Jan 2011 15:33:18 +0000 (15:33 +0000)]
Ensure ExtUtils::CBuilder's 04-base.t cleans up its temporary directories.

The tempdir() function has the rather confusing default of *not* cleaning up
("because of issues with backwards compatibility") so one needs the CLEANUP
flag. (The analogous newdir() method in the OO interface doesn't suffer this

11 years agoDocument 'test_porting' and start a section on how committing to blead
Jesse Vincent [Sat, 1 Jan 2011 10:46:20 +0000 (18:46 +0800)]
Document 'test_porting' and start a section on how committing to blead

11 years agoUpdate Encode to CPAN version 2.42
Chris 'BinGOs' Williams [Sat, 1 Jan 2011 10:37:04 +0000 (10:37 +0000)]
Update Encode to CPAN version 2.42


  $Revision: 2.42 $ $Date: 2010/12/31 22:48:48 $
  ! Encode.xs
  ! Unicode/Unicode.xs
    Applied: RT#64371: Update for 5.14 API changes

11 years agoAvoid using OP_NAME() in unimplemented_op(), as it won't give useful strings.
Nicholas Clark [Fri, 31 Dec 2010 16:20:11 +0000 (16:20 +0000)]
Avoid using OP_NAME() in unimplemented_op(), as it won't give useful strings.

Using OP_NAME() isn't going to be helpful here. Firstly, it doesn't cope
with out of range op numbers - it only "special" cases op_custom.  Secondly,
as the three ops we "panic" on are padmy, mapstart and custom, if we get
here for a custom op then that means that the custom op didn't have an
implementation. Given that OP_NAME() looks up the custom op by its pp_addr,
likely it will return NULL, unless someone (unhelpfully) registers
&PL_unimplemented_op as the address of their custom op.  NULL doesn't
generate a useful error message. "custom" does. */

11 years agoPorting/ add (MY)META.json to ignored files
David Golden [Fri, 31 Dec 2010 16:29:33 +0000 (11:29 -0500)]
Porting/ add (MY)META.json to ignored files

11 years agostandardise amagic method naming
David Mitchell [Thu, 30 Dec 2010 16:29:12 +0000 (16:29 +0000)]
standardise amagic method naming

Some amagic-related macros take the full method enumeration name,
(e.g. "add_amg"); while others "helpfully" allow you to pass a shortened
version, ("add"), and do a CAT2(meth,_amg) behind the scenes.

Standardise on passing the full name; this makes it less confusing and
allows you to grep for the enumeration name in the source.

It updates two macros to accept full enumeration names: tryAMAGICunTARGET
(which isn't used outside the core apparently), and AMG_CALLun, which is
replaced by a new AMG_CALLunary (since AMG_CALLun is used outside the

11 years agoVMS nits in cpan/Test-Harness/t/source.t
Craig A. Berry [Fri, 31 Dec 2010 01:45:13 +0000 (19:45 -0600)]
VMS nits in cpan/Test-Harness/t/source.t

1.)  Can't get the basename of a directory in native format.

2.)  Symlinks still a bit dodgy -- skip tests for now.

Submitted upstream at:

11 years agoSkip ExtUtils-CBuilder base tests expected and known to fail on VMS.
Craig A. Berry [Thu, 30 Dec 2010 22:29:50 +0000 (16:29 -0600)]
Skip ExtUtils-CBuilder base tests expected and known to fail on VMS.

11 years agoMerge the opcode bodies for pp_bind and pp_connect.
Nicholas Clark [Thu, 30 Dec 2010 17:45:53 +0000 (17:45 +0000)]
Merge the opcode bodies for pp_bind and pp_connect.

11 years agoMost socket ops weren't warning for unopened handles unless 'closed' was enabled
Nicholas Clark [Thu, 30 Dec 2010 17:30:24 +0000 (17:30 +0000)]
Most socket ops weren't warning for unopened handles unless 'closed' was enabled

They were checking that category 'closed' was enabled for warnings before
calling report_evil_fh(), which in turn was (correctly) checking category

11 years agoConvert a pp_sys test to use warnings 'closed', instead of the broader 'io'.
Nicholas Clark [Thu, 30 Dec 2010 17:14:15 +0000 (17:14 +0000)]
Convert a pp_sys test to use warnings 'closed', instead of the broader 'io'.

It's actually only testing warnings enabled by 'closed', so test using the
tighter category.

11 years agopp_leavewrite wasn't warning for unopened handles unless 'closed' was enabled.
Nicholas Clark [Thu, 30 Dec 2010 16:52:22 +0000 (16:52 +0000)]
pp_leavewrite wasn't warning for unopened handles unless 'closed' was enabled.

It was checking that category 'closed' was enabled for warnings before calling
report_evil_fh(), which in turn was (correctly) checking category 'unopened'.

11 years agoBetter handling of magic methods freeing the SV
David Mitchell [Thu, 30 Dec 2010 10:32:44 +0000 (10:32 +0000)]
Better handling of magic methods freeing the SV

This is a fix for RT #81230 (and more). Currently, mg_get() works around
the case where the called magic (e.g. FETCH) frees the magic SV. It does
this by unconditionally pushing the SV on the tmps stack before invoking
the method.

There are two issues with this. Firstly, it may artificially extend the
life of the SV. This was the root of the problem with #81230. There, the
DB_File code, under -T, created a tainted tied object. Accessing the
object (within FETCH as it happens), caused mg_get() to be invoked on the
object (due to the taint magic), and thus extend the life of the object.
This then caused c<untie %h if $h{k}> to give the warning
    untie attempted while 1 inner references still exist.
This only became noticeable after efaf36747029c85b4d8825318cb4d485a0bb350e,
which stopped wrapping magic method calls in SAVETMPS/FREETMPS.

The second issue issue that this protection only applies to mg_get();
functions like mg_set() can still segfault if the SV is deleted.

This commit fixes both problems as follows:

First, the protection mechanism is moved out of mg_get() and into
save_magic() / restore_magic(), so that it protects more things.
Secondly, the protection is now:

* in save_magic(), SvREFCNT_inc() the SV, thus protecting it from being
  freed during FETCH (or whatever)

* in restore_magic(), SvREFCNT_dec() the SV, undoing the protection
  without extending the life of the SV, *except* if the refcount is
  1 (ie FETCH tried to free it), then push it on the mortals stack
  to extend it life a bit so our callers wont choke on it.

11 years agoUpdate Renee Baeckers mail address
Renee Baecker [Wed, 29 Dec 2010 09:10:32 +0000 (01:10 -0800)]
Update Renee Baeckers mail address

Signed-off-by: David Golden <>
11 years agoproperly clean up work files from testing GDBM_File
Tony Cook [Wed, 29 Dec 2010 05:44:58 +0000 (16:44 +1100)]
properly clean up work files from testing GDBM_File

11 years agoclose the produced test file so win32 can unlink it
Tony Cook [Tue, 28 Dec 2010 11:39:14 +0000 (22:39 +1100)]
close the produced test file so win32 can unlink it

Previously runs would leave a GLOB(0x...) file in t/

11 years agoskip ExtUtils-CBuilder base tests expected and known to fail on Win32
Tony Cook [Tue, 28 Dec 2010 11:09:31 +0000 (22:09 +1100)]
skip ExtUtils-CBuilder base tests expected and known to fail on Win32

11 years agoAs report_evil_fh() checks WARN_{CLOSED,UNOPENED}, don't duplicate this.
Nicholas Clark [Tue, 28 Dec 2010 09:50:49 +0000 (09:50 +0000)]
As report_evil_fh() checks WARN_{CLOSED,UNOPENED}, don't duplicate this.

This trades reduced code size for an extra function call in the error path with
warnings disabled. (And removes a duplicated check for the case of taking the
error path *with* warnings enabled.)

Removing the check from Perl_do_close() does not change behaviour, as io is
NULL there, hence Perl_report_evil_fh() will always be checking WARN_UNOPENED
and setting vile to "unopened".

11 years agoAs report_wrongway_fh() checks ckWARN(WARN_IO) internally, don't duplicate this.
Nicholas Clark [Tue, 28 Dec 2010 09:30:31 +0000 (09:30 +0000)]
As report_wrongway_fh() checks ckWARN(WARN_IO) internally, don't duplicate this.

This trades reduced code size for an extra function call in the error path with
warnings disabled. (And removes a duplicated check for the case of taking the
error path *with* warnings enabled.)

11 years agoRemove OP_phoney_{IN,OUT}PUT_ONLY, as they are no longer used or supported.
Nicholas Clark [Tue, 28 Dec 2010 09:20:43 +0000 (09:20 +0000)]
Remove OP_phoney_{IN,OUT}PUT_ONLY, as they are no longer used or supported.

11 years agoArgument op to report_evil_fh() is always PL_op->op_type, so need not be passed
Nicholas Clark [Tue, 28 Dec 2010 09:09:44 +0000 (09:09 +0000)]
Argument op to report_evil_fh() is always PL_op->op_type, so need not be passed

11 years agoThe io argument to report_evil_fh() is always GvIO(gv), so need not be passed.
Nicholas Clark [Tue, 28 Dec 2010 08:56:36 +0000 (08:56 +0000)]
The io argument to report_evil_fh() is always GvIO(gv), so need not be passed.

11 years agoExtract the OP_phoney_* code from report_evil_fh() into report_wrongway_fh()
Nicholas Clark [Tue, 28 Dec 2010 07:55:45 +0000 (07:55 +0000)]
Extract the OP_phoney_* code from report_evil_fh() into report_wrongway_fh()

Previously Perl_report_evil_fh()'s body was just an if/else at the top level -
a good sign that it is actually implementing two disjoint functions.

11 years agoIn pp_sockpair, remove duplication of code to close the supplied file handles.
Nicholas Clark [Tue, 28 Dec 2010 08:32:44 +0000 (08:32 +0000)]
In pp_sockpair, remove duplication of code to close the supplied file handles.

It's not necessary to (also) test gv1 and gv2 before returning undef as an
error, because io1 will automatically be NULL if gv1 is NULL, and similarly
io2 if gv2 is.

11 years agoFix typo in warning code added to pp_sockpair in c289d2f7288798f8.
Nicholas Clark [Tue, 28 Dec 2010 08:19:03 +0000 (08:19 +0000)]
Fix typo in warning code added to pp_sockpair in c289d2f7288798f8.

That should be gv2, not gv1. However, I believe that it's impossible to reach
the warning code, given the structure of the optree that the perl 5
implementation produces, as gv1 and gv2 will never be NULL, and GvIOn() will
always return non-NULL. (Or croak, but that won't return).

11 years agoavoid undefined behaviour in fetch and modify of SP from 0a0e3cc51e
Tony Cook [Tue, 28 Dec 2010 02:58:29 +0000 (13:58 +1100)]
avoid undefined behaviour in fetch and modify of SP from 0a0e3cc51e

pp_sys.c: In function ‘Perl_pp_send’:
pp_sys.c:1845: warning: operation on ‘sp’ may be undefined

11 years agoAdd CPAN::Meta::YAML as a dual-life core module
David Golden [Mon, 27 Dec 2010 19:50:31 +0000 (14:50 -0500)]
Add CPAN::Meta::YAML as a dual-life core module

11 years agoSimplify return handling for tied handle OPEN/PRINTF/READ/WRITE.
Nicholas Clark [Mon, 27 Dec 2010 19:11:26 +0000 (19:11 +0000)]
Simplify return handling for tied handle OPEN/PRINTF/READ/WRITE.

Their code used to explicitly move the return value from its current position
on the stack, to the position that was top of top of the stack just before the
call was made. However, the POPBLOCK() in pp_leavesub will restore the stack
pointer, and passing G_SCALAR to call_method() will force exactly one return
value, so all of this is needless defensiveness.

11 years agoA perldelta entry describing the refactoring of the chop/chomp implementation.
Nicholas Clark [Mon, 27 Dec 2010 13:09:02 +0000 (13:09 +0000)]
A perldelta entry describing the refactoring of the chop/chomp implementation.

11 years agoMove do_chomp() from pp.c to doop.c, and make it static.
Nicholas Clark [Mon, 27 Dec 2010 12:56:12 +0000 (12:56 +0000)]
Move do_chomp() from pp.c to doop.c, and make it static.

It was never part of the public API, and only ever used by pp_{s,}cho{,m}p.

11 years agoMerge the opcode bodies for chop/chomp and schop/schomp.
Nicholas Clark [Mon, 27 Dec 2010 11:41:10 +0000 (11:41 +0000)]
Merge the opcode bodies for chop/chomp and schop/schomp.

11 years agoMerge Perl_do_chop() and Perl_do_chomp().
Nicholas Clark [Mon, 27 Dec 2010 08:58:19 +0000 (08:58 +0000)]
Merge Perl_do_chop() and Perl_do_chomp().

They share code for dealing with PVAVs, PVHVs, read only values and handling
PL_encoding. They are not part of the public API, and Google codesearch shows
no users outside the core.

11 years agoConvert Perl_do_chomp() to the same prototype as Perl_do_chop().
Nicholas Clark [Mon, 27 Dec 2010 08:22:21 +0000 (08:22 +0000)]
Convert Perl_do_chomp() to the same prototype as Perl_do_chop().

Pass in an SV to hold the count, rather than returning the count.

11 years agoRefactor pp_chomp to process arguments in the same order as pp_chop.
Nicholas Clark [Mon, 27 Dec 2010 08:09:15 +0000 (08:09 +0000)]
Refactor pp_chomp to process arguments in the same order as pp_chop.

Previously list chomp worked from last to first, whilst list chop worked from
first to last.

11 years agoFix links (and hence the podchecker test) after cce04bebd8af026c.
Nicholas Clark [Mon, 27 Dec 2010 07:42:45 +0000 (07:42 +0000)]
Fix links (and hence the podchecker test) after cce04bebd8af026c.