This is a live mirror of the Perl 5 development currently hosted at
8 years agoperldiag: Describe \g syntax error
Karl Williamson [Wed, 22 May 2013 19:28:07 +0000 (13:28 -0600)]
perldiag: Describe \g syntax error

Commit 779fedd7c3021f013726c8f53cb9e66c54637ebf added a warning,
which is nearly identical to an existing one, but didn't change the
description of the existing one to encompass both.  This rectifies that.

8 years agoregcomp.c: Actually emit proper warning
Karl Williamson [Wed, 20 Mar 2013 17:42:18 +0000 (11:42 -0600)]
regcomp.c: Actually emit proper warning

Before this commit, /\g/ raised the wrong warning
    Reference to invalid group 0
This rearranges the code so that the proper warning is emitted.
    Unterminated \g... pattern

8 years agoMake Unicode::UCD::search_invlist() available
Karl Williamson [Wed, 22 May 2013 02:34:47 +0000 (20:34 -0600)]
Make Unicode::UCD::search_invlist() available

This commit documents this function, removing the initial underscore
from its name.  (And it hardens input checking.)

8 years agoUnicode::UCD Clarifications in pod
Karl Williamson [Wed, 22 May 2013 01:41:44 +0000 (19:41 -0600)]
Unicode::UCD Clarifications in pod

There are no "missing" values in inversion maps; there is a default
value returned for each one.  So change the example variables' names.
Plus another sentence rewording for clarity.

8 years agoUnicode::UCD: Move function in file.
Karl Williamson [Mon, 20 May 2013 18:13:22 +0000 (12:13 -0600)]
Unicode::UCD: Move function in file.

This is in preparation for making this function public, and it should be
listed in the pod later than it otherwise would be.

8 years agoUnicode::UCD: Correct wrong pod info
Karl Williamson [Mon, 20 May 2013 16:41:01 +0000 (10:41 -0600)]
Unicode::UCD: Correct wrong pod info

 This was erroneous.  Extra clarifications are also added.

8 years agoremove a spurious space
Ricardo Signes [Wed, 22 May 2013 13:33:16 +0000 (09:33 -0400)]
remove a spurious space

8 years agoSome more comments describing the slab allocator.
Nicholas Clark [Wed, 22 May 2013 11:56:50 +0000 (13:56 +0200)]
Some more comments describing the slab allocator.

These are based on the description of commit 8be227ab5eaa23f2, but provide
explanations near to the relevant C code.

8 years agoAdd comments describing the operation of S_scan_ident().
Nicholas Clark [Mon, 8 Apr 2013 14:30:18 +0000 (16:30 +0200)]
Add comments describing the operation of S_scan_ident().

8 years agoMore tests for the "Ambiguous use of ... resolved ..." warning S_scan_ident().
Nicholas Clark [Mon, 8 Apr 2013 14:27:19 +0000 (16:27 +0200)]
More tests for the "Ambiguous use of ... resolved ..." warning S_scan_ident().

In particular, test that the special case for reporting $# as @ works.

8 years agoFix typo in Porting/sync-with-cpan
Max Maischein [Tue, 21 May 2013 19:40:21 +0000 (21:40 +0200)]
Fix typo in Porting/sync-with-cpan

I will run `make test_porting` on the correct branch before submitting a patch.
I will run `make test_porting` on the correct branch before submitting a patch.
I will run `make test_porting` on the correct branch before submitting a patch.

8 years agoEliminate external call to tar executable in favour of Archive::Tar
Max Maischein [Tue, 21 May 2013 17:09:47 +0000 (19:09 +0200)]
Eliminate external call to tar executable in favour of Archive::Tar

Archive::Tar has ->extract_archive, which does Just That. This means
we lose immediate support for bzip2 files, but not all
incarnations of `tar` support it either.

Signed-off-by: David Golden <>
8 years agoAdd new Module::CoreList::Utils to MANIFEST
Chris 'BinGOs' Williams [Tue, 21 May 2013 13:13:52 +0000 (14:13 +0100)]
Add new Module::CoreList::Utils to MANIFEST

8 years agoMerge branch 'smoke-me/coreutils' into blead
Chris 'BinGOs' Williams [Tue, 21 May 2013 12:32:53 +0000 (13:32 +0100)]
Merge branch 'smoke-me/coreutils' into blead

8 years agoRemove 2 superfluous use lines from ExtUtils::CBuilder.
Nicholas Clark [Wed, 24 Apr 2013 15:01:43 +0000 (17:01 +0200)]
Remove 2 superfluous use lines from ExtUtils::CBuilder.

use IO::File was added with the upgrade to 0.23 (commit c3fb68a339256eb3 in
April 2008), but the use of IO::File in the code was eliminated by the
upgrade to 0.2800 (commit 06e8058f27e4269b in Dec 2010), which replaced
the code in question with use of File::Temp. The latter refactoring also
added the use Data::Dumper; line, but did not add any code which uses

8 years agoRefactor 3 tests so that they avoid clearing %:: via list assignment.
Nicholas Clark [Wed, 10 Apr 2013 11:44:07 +0000 (13:44 +0200)]
Refactor 3 tests so that they avoid clearing %:: via list assignment.

For all 3, clearing %:: was intended to expose another bug, not to directly
test the effects of clearing %::

Tested by building the 3 revisions that added the tests, and confirming that
the revised test also triggers the bug that each fixed.

8 years agoTest that caller does not SEGV when the current package is undefined.
Nicholas Clark [Fri, 5 Apr 2013 10:12:53 +0000 (12:12 +0200)]
Test that caller does not SEGV when the current package is undefined.

Prior to commit d4d03940c58a0177 this code would SEGV under ithreads.
Test suggested by Brian Fraser.

8 years agoRemove fakethr.h and eliminate all references to it and FAKE_THREADS
Nicholas Clark [Mon, 20 May 2013 15:55:46 +0000 (17:55 +0200)]
Remove fakethr.h and eliminate all references to it and FAKE_THREADS

fakethr.h and FAKE_THREADS were for a "green" threads implementation of
5005threads. 5005threads itself is long gone, and it's not clear that
-DFAKE_THREADS *ever* built correctly. Certainly it did not work for the
5.005 release, and it did not work at the time of the commits for the initial
checkin. The closest that it seems to have been to working is around commit
c6ee37c52f2ca9e5 (Dec 1997), where the headers no longer contained errors,
but perl.c failed to compile.

8 years agoMerge the refactoring of x2p's Makefile to blead.
Nicholas Clark [Tue, 21 May 2013 05:49:29 +0000 (07:49 +0200)]
Merge the refactoring of x2p's Makefile to blead.

8 years agoSimplify x2p's Makefile.
Nicholas Clark [Wed, 15 May 2013 19:48:12 +0000 (21:48 +0200)]
Simplify x2p's Makefile.

Eliminate plexe and plc, which relate to tests for the compiler and were
added as part of commit 52cebf5efc9883c7 in May 1988. The compiler was
removed by commit de1254415ffeb03b in Sept 2006.

The files and were removed with Perl 5.000.
The macros 'public', 'private' and 'util' mirror the structure of the top
level Makefile.SH. However, x2p only ever used 'public', so simplify things
by inlining the value of 'public' in the only place that uses it.
'addedbyconf' now only contains the value of 'plextract', so use the latter
directly in the one place that had used 'addedbyconf'.

8 years agoRemove rules to delete *.loadmap and *.prelmap files, generated on VM/ESA
Nicholas Clark [Wed, 15 May 2013 19:34:21 +0000 (21:34 +0200)]
Remove rules to delete *.loadmap and *.prelmap files, generated on VM/ESA

These rules to clean up properly on VM/ESA were added in Oct 1998 by
perforce changes 1961, 1962 and 1963 in the confperl branch. VM/ESA support
was removed by commit 043fec90e88a2e23 in Aug 2012.

8 years agoAdd x2p/Makefile.SH to the *.SH files processed by the top level Makefile.
Nicholas Clark [Wed, 15 May 2013 19:26:59 +0000 (21:26 +0200)]
Add x2p/Makefile.SH to the *.SH files processed by the top level Makefile.

This makes the top level Makefile responsible for deleting x2p/Makefile.
With this, we can eliminate the 'sh' and 'shextract' from x2p's Makefile.

8 years agoRemove the now unused 'shlist' Makefile targets.
Nicholas Clark [Wed, 15 May 2013 19:17:31 +0000 (21:17 +0200)]
Remove the now unused 'shlist' Makefile targets.

8 years agoProgrammatically generate dependencies for all *.SH files.
Nicholas Clark [Wed, 15 May 2013 18:57:37 +0000 (20:57 +0200)]
Programmatically generate dependencies for all *.SH files.

Previously dependencies for Makefile, config.h and makedepend were
explicitly coded into verbatim sections of Makefile.SH, with most of the
others being generated by makedepend.SH

8 years agoAdd runtests.SH to the code that generates the targets sh and shextract.
Nicholas Clark [Wed, 15 May 2013 18:25:47 +0000 (20:25 +0200)]
Add runtests.SH to the code that generates the targets sh and shextract.

The generated Makefile is functionally identical.

8 years agoEliminate x2p/cflags.SH. x2p's Makefile can use ../cflags
Nicholas Clark [Wed, 15 May 2013 15:14:50 +0000 (17:14 +0200)]
Eliminate x2p/cflags.SH. x2p's Makefile can use ../cflags

x2p/Makefile is only used on *nix, so this should not present a problem.

8 years agoPass in to makedepend the name(s) of files that all objects depend on.
Nicholas Clark [Wed, 15 May 2013 17:40:46 +0000 (19:40 +0200)]
Pass in to makedepend the name(s) of files that all objects depend on.

8 years agoIn the Makefile, generate the value of shextract programmatically.
Nicholas Clark [Wed, 15 May 2013 14:54:40 +0000 (16:54 +0200)]
In the Makefile, generate the value of shextract programmatically.

shextract lists the files generated by shell scripts named *.SH which need
deleting. Instead of maintaining it by hand, generate it in Makefile.SH from
the list of *.SH files.

This indirectly eliminates the last reference to F<makedir>. makedir.SH
was eliminated by commit ebca06e95b02d1a8 and the reference to makedir.SH in
Makefile.SH eliminated by commit 847471027aa42997 (both Sept 2009), but
that commit missed that the reference to makedir a few lines later was

8 years agoDefer running makedepend in x2p/ until it's needed.
Nicholas Clark [Wed, 15 May 2013 11:01:22 +0000 (13:01 +0200)]
Defer running makedepend in x2p/ until it's needed.

We can run makedepend in x2p/ as part of the regular build process, which
means that it can run as part of a parallel make. This gets a slight
speedup (0.2s on this system), and increases flexibility on how x2p/Makefile
is generated.

8 years agoAdd x2p/makefile to the dependencies for targets within x2p/
Nicholas Clark [Wed, 15 May 2013 10:49:44 +0000 (12:49 +0200)]
Add x2p/makefile to the dependencies for targets within x2p/

This will give us more flexibility in when and how we generate it.

[x2p/makefile is x2p/GNUmakefile on OS X]

8 years agoRemove vestigial *.SH code which can link the extracted file into ../
Nicholas Clark [Wed, 15 May 2013 10:33:05 +0000 (12:33 +0200)]
Remove vestigial *.SH code which can link the extracted file into ../

4 of the *.SH files have code which links the extracted file into the parent
directory if the current directory ends SH. This code dates from Perl 1.
It seems that the intent was that the *.SH files could live in a SH/
directory, but that feature was neither used or mentioned in the
documentation in Perl 1, and hasn't been used since.

8 years agoMerge the pack refactoring to blead.
Nicholas Clark [Mon, 20 May 2013 19:42:33 +0000 (21:42 +0200)]
Merge the pack refactoring to blead.

8 years agoNotes in perldelta for the tiny XS-visible changes of the pack refactoring.
Nicholas Clark [Mon, 20 May 2013 19:40:27 +0000 (21:40 +0200)]
Notes in perldelta for the tiny XS-visible changes of the pack refactoring.

8 years agoAnnotate the "cold" paths in pp_pack.c with UNLIKELY().
Nicholas Clark [Wed, 8 May 2013 08:40:07 +0000 (10:40 +0200)]
Annotate the "cold" paths in pp_pack.c with UNLIKELY().

The usual case is nice regular bytes in the host's nice regular order.

8 years agoEliminate the implementations of [hv]to[vh][ls] for mixed-endian systems.
Nicholas Clark [Tue, 7 May 2013 16:25:53 +0000 (18:25 +0200)]
Eliminate the implementations of [hv]to[vh][ls] for mixed-endian systems.

As pp_pack.c has had mixed-endian support removed, there is little point in
keeping code in perl.h and util.c only needed for architectures that cannot
be built.

8 years agoEliminate Perl_my_swabn(), as it is now unused.
Nicholas Clark [Tue, 7 May 2013 16:17:39 +0000 (18:17 +0200)]
Eliminate Perl_my_swabn(), as it is now unused.

It is not marked as part of the API, and no code on CPAN is using it.

8 years agoWhen endian-swapping in pack, simply copy the bytes in reverse order.
Nicholas Clark [Tue, 7 May 2013 15:39:42 +0000 (17:39 +0200)]
When endian-swapping in pack, simply copy the bytes in reverse order.

This should restore support for big endian Crays. It doesn't support
mixed-endian systems.

8 years agoPass 'needs_swap' as a parameter to SHIFT_BYTES.
Nicholas Clark [Tue, 7 May 2013 14:22:08 +0000 (16:22 +0200)]
Pass 'needs_swap' as a parameter to SHIFT_BYTES.

It feels wrong to have it as an implicit parameter sucked in via the textual
expansion of the macro. Whilst it can be derived from the parameter
'datumtype', it seems that the C compiler generates a lot less efficient code
that way.

8 years agoWhen endian-swapping in unpack, simply copy the bytes in reverse order.
Nicholas Clark [Tue, 7 May 2013 13:15:54 +0000 (15:15 +0200)]
When endian-swapping in unpack, simply copy the bytes in reverse order.

It is considerably simpler to re-order the bytes before reading them into
the variable of the desired type, than to read into the variable and then
need a specialised "reverse this integer" function for each size of integer.

This should restore support for big endian Crays. It doesn't support
mixed-endian systems. Support for mixed-endian systems can be restored (if
needed) by re-ordering the bytes correctly at the locations which currently
only know how to reverse the bytes.

8 years agoFold the implementation of DO_BO_UNPACK into SHIFT_BYTES(), its only user.
Nicholas Clark [Tue, 7 May 2013 10:23:00 +0000 (12:23 +0200)]
Fold the implementation of DO_BO_UNPACK into SHIFT_BYTES(), its only user.

8 years agoRe-implement SHIFT16 and SHIFT32 as wrappers to SHIFT_BYTES.
Nicholas Clark [Tue, 7 May 2013 09:53:17 +0000 (11:53 +0200)]
Re-implement SHIFT16 and SHIFT32 as wrappers to SHIFT_BYTES.

8 years agoRefactor the two uses of SHIFT{16,32} not followed by DO_BO_UNPACK().
Nicholas Clark [Tue, 7 May 2013 08:08:53 +0000 (10:08 +0200)]
Refactor the two uses of SHIFT{16,32} not followed by DO_BO_UNPACK().

There is one place where SHIFT16() is not immediately followed by
DO_BO_UNPACK() ('n!' and 'v!'), and one place where SHIFT32() is not
immediately followed by DO_BO_UNPACK() ('N!' and 'V!'). Every other use of
either macro is followed by DO_BO_UNPACK(). For the two locations that don't
have DO_BO_UNPACK(), the modifiers '<' and '>' are illegal, hence
DO_BO_UNPACK() will always be a no-op. Hence add DO_BO_UNPACK() to both
(which permits refactoring to simplify things), and add assert()s that the
assumptions are true.

8 years agoRemove the now unused 'type' argument from the macros DO_BO_(UN)?PACK.
Nicholas Clark [Tue, 7 May 2013 07:25:39 +0000 (09:25 +0200)]
Remove the now unused 'type' argument from the macros DO_BO_(UN)?PACK.

8 years agoAs DO_BO_(UN)?PACK are now implemented with my_swabn(), simplify 'J' and 'j'.
Nicholas Clark [Mon, 6 May 2013 18:40:34 +0000 (20:40 +0200)]
As DO_BO_(UN)?PACK are now implemented with my_swabn(), simplify 'J' and 'j'.

The conditionally compiled code to figure out the correct named integer
size for UVs and IVs is no longer needed, as my_swabn() will swap UVs and
IVs, whatever their length.

8 years agoMerge the identical definitions of DO_BO_UNPACK and DO_BO_PACK.
Nicholas Clark [Mon, 6 May 2013 17:58:10 +0000 (19:58 +0200)]
Merge the identical definitions of DO_BO_UNPACK and DO_BO_PACK.

Delete the now-unused mixed-endian definitions of DO_BO_UNPACK and
DO_BO_PACK, and the macro BO_CANT_DOIT, as they were the last two things
using it.

8 years agoSwap byte order in DO_BO_(UN)?PACK based on a variable needs_swap.
Nicholas Clark [Mon, 6 May 2013 17:41:10 +0000 (19:41 +0200)]
Swap byte order in DO_BO_(UN)?PACK based on a variable needs_swap.

Add the macro NEEDS_SWAP to initialise needs_swap based on
TYPE_ENDIANNESS(datumtype). This makes the two definitions of DO_BO_UNPACK
identical, and the two definitions of DO_BO_PACK identical.

This also makes building pp_pack.c on a mixed endian byteorder architecture
a compile time error. The commit adds pointers on where to add code to
re-instate support for such architectures.

8 years agoDO_BO_{UN,}PACK can use my_swabn() directly.
Nicholas Clark [Mon, 6 May 2013 16:43:26 +0000 (18:43 +0200)]
DO_BO_{UN,}PACK can use my_swabn() directly.

This removes the only users of my_{be,le,h}to{be,le,h}n, so remove the
definitions for those macros.

8 years agoUse DO_BO_{UN,}PACK in place of DO_BO_UNPACK_{N,PC}
Nicholas Clark [Mon, 6 May 2013 16:05:24 +0000 (18:05 +0200)]
Use DO_BO_{UN,}PACK in place of DO_BO_UNPACK_{N,PC}

Also, eliminate the intermediate macros DO_BO_PACK_PTR and DO_BO_UNPACK_PTR.

8 years agoEliminate my_{hto[bl]e,[bl]etoh}{16,32,64,s,i,l} as nothing now uses them.
Nicholas Clark [Mon, 6 May 2013 15:16:18 +0000 (17:16 +0200)]
Eliminate my_{hto[bl]e,[bl]etoh}{16,32,64,s,i,l} as nothing now uses them.

8 years agoIn pp_pack.c, refactor DO_BO_(UN)?PACK to use my_letohn etc
Nicholas Clark [Mon, 6 May 2013 14:54:12 +0000 (16:54 +0200)]
In pp_pack.c, refactor DO_BO_(UN)?PACK to use my_letohn etc

Previously they were using a my_letoh* function for the appropriate size.

This commit probably breaks fixed 16 and 32 bit templates on big endian
Crays where sizeof(short) and sizeof(int) are 8. A future commit will
restore support. (Although it's not clear whether such Crays can still
build blead cleanly, as we've not had any feedback since Boeing
decommissioned their Cray.)

8 years agoIn pp_pack.c, refactor DO_BO_(UN)?PACK_PTR to use my_letohn etc
Nicholas Clark [Mon, 6 May 2013 14:36:09 +0000 (16:36 +0200)]
In pp_pack.c, refactor DO_BO_(UN)?PACK_PTR to use my_letohn etc

Previously they were casting the pointer to an integer value, calling
a my_letoh* function for the appropriate size, and casting the return value
back to a pointer.

8 years agoIn pp_pack.c, refactor DO_BO_(UN)?PACK_N to use sizeof() on the variable.
Nicholas Clark [Mon, 6 May 2013 14:22:01 +0000 (16:22 +0200)]
In pp_pack.c, refactor DO_BO_(UN)?PACK_N to use sizeof() on the variable.

Previously they were using sizeof() on the type argument passed to the
macro. This change makes their implementation more like DO_BO_(UN)?PACK

8 years agoRefactor macros in pp_pack.c, removing support for mixed-endian byte orders.
Nicholas Clark [Mon, 6 May 2013 13:46:02 +0000 (15:46 +0200)]
Refactor macros in pp_pack.c, removing support for mixed-endian byte orders.

The byte-order handling can be simplified considerably if we don't have to
support mixed-endian systems. It's not clear whether Perl 5.000 even
compiled on PDP-11s, let alone more recent versions.

Support probably can be added back at the end of the refactoring, if someone
has time and a PDP-11 to test on, but for the intermediate stages it is a
lot easier not to need to think about such platforms.

8 years agoEliminate the conditionally-compiled fallback functions for htonl etc.
Nicholas Clark [Mon, 6 May 2013 12:40:04 +0000 (14:40 +0200)]
Eliminate the conditionally-compiled fallback functions for htonl etc.

These are now only being used for mixed-endian platforms which do not
provide their own htnol (etc) functions. Given that the fallbacks have been
buggy since they were added in Perl 3.0, it's safe to conclude that no
mixed-endian platforms were ever using these functions.

It's also unclear why these functions were ever marked as 'A', part of the
API. XS code can't call them directly, as it can't rely on them being
compiled. Unsurprisingly, no code on CPAN references them.

8 years agoRemove buggy loop-based byte swapping code.
Nicholas Clark [Mon, 6 May 2013 11:28:20 +0000 (13:28 +0200)]
Remove buggy loop-based byte swapping code.

The irony is that the union-based code special-cased for little endian
systems actually works everywhere, even on mixed-endian systems.

8 years agoUpdate the Win32 miniperl conditional compilation, for the htonl etc changes.
Nicholas Clark [Mon, 6 May 2013 06:20:57 +0000 (08:20 +0200)]
Update the Win32 miniperl conditional compilation, for the htonl etc changes.

As of commit 19253ae62cd13079 (Oct 2012), miniperl on Win32 avoids using
Winsock. The win32_* wrappers for htonl etc had used the pre-processor
macro MYSWAP to conditionally compile in the correct code. However, MYSWAP
was defined as a side effect of using the htonl etc wrappers in util.c,
which are no longer needed. Hence use the WIN32_NO_SOCKETS macro directly
in win32sck.c for the correct conditional compilation.

8 years agoFallbacks for ntohl, ntohs, htonl and htons for little endian systems.
Nicholas Clark [Sat, 4 May 2013 20:50:12 +0000 (22:50 +0200)]
Fallbacks for ntohl, ntohs, htonl and htons for little endian systems.

The host byteorder agnostic functions in util.c are now only used on mixed
endian systems.

8 years agoProvide ntohl, ntohs, htonl and htons no-op macros on big endian systems.
Nicholas Clark [Sat, 4 May 2013 20:03:59 +0000 (22:03 +0200)]
Provide ntohl, ntohs, htonl and htons no-op macros on big endian systems.

This means that there are always macros or functions for ntohl, ntohs,
htonl and htons available, so eliminate use of HAS_NTOHL etc, and
unconditionally compile the code that it was protecting. However, as code
on CPAN is using these guard macros, define all of them in perl.h

(Technically the 4 are not quite no-ops, as they truncate their values to
32 or 16 bits, to be consistent with the implementations for platforms which
need re-ordering.)

8 years agoProvide vtohl, vtohs, htovl and htovs no-op macros on little endian systems.
Nicholas Clark [Sat, 4 May 2013 19:30:27 +0000 (21:30 +0200)]
Provide vtohl, vtohs, htovl and htovs no-op macros on little endian systems.

This means that there are always macros or functions for vtohl, vtohs,
htovl and htovs available, so eliminate HAS_VTOHL etc, and unconditionally
compile the code that it was protecting. shows that no code on
CPAN uses any of these macros.

(Technically the 4 are not quite no-ops, as they truncate their values to
32 or 16 bits, to be consistent with the implementations for platforms which
need re-ordering.)

8 years agovtohl, vtohs, htovl and htovs are no-ops on 64 bit little endian systems.
Nicholas Clark [Sat, 4 May 2013 19:07:14 +0000 (21:07 +0200)]
vtohl, vtohs, htovl and htovs are no-ops on 64 bit little endian systems.

Previously they were implemented as function calls on 64 bit little endian
systems. Bit endian systems implemented them as byte-swapping macros. 32
little endian system didn't implement them at all. 32 and 64 bit little
endian systems now behave identically.

8 years agoEliminate the definitions for DO_BO_PACK_P and DO_BO_UNPACK_P.
Nicholas Clark [Fri, 3 May 2013 15:06:01 +0000 (17:06 +0200)]
Eliminate the definitions for DO_BO_PACK_P and DO_BO_UNPACK_P.

Commit 07409e015252427f in April 2005 replaced all the uses of these two
macros with DO_BO_PACK_PC and DO_BO_UNPACK_PC.

8 years agoEliminate pre-5.9.x conditional code for PERL_PACK_CAN_SHRIEKSIGN
Nicholas Clark [Fri, 3 May 2013 13:52:38 +0000 (15:52 +0200)]
Eliminate pre-5.9.x conditional code for PERL_PACK_CAN_SHRIEKSIGN

PERL_PACK_CAN_SHRIEKSIGN has been unconditionally defined for versions 5.9.x
and greater, and undefined for 5.8.x. As we are never going to need to
port changes back to maint-5.8 any more, eliminate all the 5.8.x related code
and the macro that supports it.

8 years agoEliminate pre-5.9.x conditional code for PERL_PACK_CAN_BYTEORDER
Nicholas Clark [Fri, 3 May 2013 13:26:34 +0000 (15:26 +0200)]
Eliminate pre-5.9.x conditional code for PERL_PACK_CAN_BYTEORDER

PERL_PACK_CAN_BYTEORDER has been unconditionally defined for versions 5.9.x
and greater, and undefined for 5.8.x. As we are never going to need to
port changes back to maint-5.8 any more, eliminate all the 5.8.x related code,
and the macro that supports it.

8 years agoMerge the reworking of how is used.
Nicholas Clark [Mon, 20 May 2013 19:12:01 +0000 (21:12 +0200)]
Merge the reworking of how is used.

8 years agoAdd regen/ to t/porting/regen.t
Nicholas Clark [Mon, 29 Apr 2013 10:06:39 +0000 (12:06 +0200)]
Add regen/ to t/porting/regen.t

8 years agoMove to regen/
Nicholas Clark [Mon, 29 Apr 2013 09:54:19 +0000 (11:54 +0200)]
Move to regen/

8 years agoRefactor to use regen/
Nicholas Clark [Mon, 29 Apr 2013 09:47:30 +0000 (11:47 +0200)]
Refactor to use regen/

8 years agoExtract the generated packprops array into packsizetables.c.
Nicholas Clark [Mon, 29 Apr 2013 09:23:11 +0000 (11:23 +0200)]
Extract the generated packprops array into packsizetables.c.

The C source is the output from
Previously it was pasted into pp_pack.c

 LocalWords:  packprops

8 years agoPropagate a change from commit 1651fc447620d361 into
Nicholas Clark [Mon, 29 Apr 2013 09:08:05 +0000 (11:08 +0200)]
Propagate a change from commit 1651fc447620d361 into

pp_pack.c contains a table generated by, pasted into the
C source. The C source was updated by commit 1651fc447620d361 in April 2007,
but the table used to generate the code was not.

8 years Correct comment typo
Karl Williamson [Wed, 13 Mar 2013 22:18:12 +0000 (16:18 -0600)] Correct comment typo

8 years agoChange LIKELY() and UNLIKELY() to cast their first argument to a bool.
Nicholas Clark [Wed, 6 Mar 2013 15:27:08 +0000 (16:27 +0100)]
Change LIKELY() and UNLIKELY() to cast their first argument to a bool.

This avoids problems such as pointers being compared with the literal value 1.
Suggested by Zefram.

Note that this is technically a change of behaviour, as the macro EXPECT(),
which they are both both wrappers for, returns its value, so they will now
be returning TRUE or FALSE, rather than the actual value passed to them.
However, all uses in the core and on CPAN are only within if() statements, so
this should not make any difference in practice.

8 years agohandy.h: Change the error return of two macros
Karl Williamson [Sat, 18 May 2013 20:05:00 +0000 (14:05 -0600)]
handy.h: Change the error return of two macros

These two undocumented macros returned the REPLACEMENT CHARACTER if the
input was outside the Latin1 range.  This was contrary to all other
similar macros, which return their input if it is invalid.  It caused
warnings in some (dumber than average) compilers.

These macros are undocumented; this changes the behavior only of illegal
inputs to them.

8 years agoregcomp.c: Add comment
Karl Williamson [Sat, 18 May 2013 19:55:50 +0000 (13:55 -0600)]
regcomp.c: Add comment

8 years agoutf8.c: White space only.
Karl Williamson [Sat, 18 May 2013 19:06:47 +0000 (13:06 -0600)]
utf8.c: White space only.

Indent in newly formed block

8 years agofold_grind.t: Add tests
Karl Williamson [Sat, 18 May 2013 19:09:05 +0000 (13:09 -0600)]
fold_grind.t: Add tests

fold-grind stresses the /i regex handling by reading the Unicode folding
rules and creating tests for problematic cases, as well as some
non-problematic ones.

Because of the large number of tests generated, it otherwise avoids
tests that it doesn't think are problematic.

Problematic cases include those whose folds cross the ordinal 127/128 or
255/256 boundaries, along with other considerations.

Until this commit, fold_grind failed to realize that even if the pair of
characters currently being tested don't cross those boundaries, if their
eventual folds do, this could be problematic.  Suppose X and Y are both
on the same side of the boundaries, and both fold to Z which is on
another side.  Then X and Y should be equivalent under /i even if the
fold to Z is prohibited because of /aa or /l.  fold_grind was
overzealous in pruning such tests.

The previous patch fixed bugs in handling such cases; and this patch
fixes the tests to look for similar things that might possibly arise in
the future.

Interestingly, this bug came to light during porting to an EBCDIC
platform.  The reason is that because of the different collation order,
fold_grind chose one of the buggy cases to test as one its
non-problematic tests.

8 years agoFix multi-char fold edge case
Karl Williamson [Sat, 18 May 2013 14:25:16 +0000 (08:25 -0600)]
Fix multi-char fold edge case

use locale;
   eq 2 x fc("\N{LATIN SMALL LETTER LONG S}")

should return true, as the SHARP S folds to two 's's in a row, and the
LONG S is an antique variant of 's', and folds to s.  Until this commit,
the expression was false.

Similarly, the following should match, but didn't until this commit:


The reason these didn't work properly is that in both cases the actual
fold to 's' is disallowed.  In the first case because of locale; and in
the second because of /aa.  And the code wasn't smart enough to realize
that these were legal.

The fix is to special case these so that the fold of sharp s (both
capital and small) is two LONG S's under /aa; as is the fold of the
capital sharp s under locale.  The latter is user-visible, and the
documentation of fc() now points that out.  I believe this is such an
edge case that no mention of it need be done in perldelta.

8 years agoExpand flags parameter from boolean in _to_fold_latin1
Karl Williamson [Sat, 18 May 2013 05:07:05 +0000 (23:07 -0600)]
Expand flags parameter from boolean in _to_fold_latin1

This will be used in future commits to pass more flags.

8 years agounicode_constants.h: Add some #defines
Karl Williamson [Fri, 17 May 2013 03:37:43 +0000 (21:37 -0600)]
unicode_constants.h: Add some #defines

These will be used in future commits

8 years agoutf8.c: Replace two macro calls with equiv single
Karl Williamson [Thu, 16 May 2013 02:55:27 +0000 (20:55 -0600)]
utf8.c: Replace two macro calls with equiv single

UTF8_IS_ABOVE_LATIN1() is equivalent to

So we can use just it, for clearer code with fewer branches.

8 years agolib/charnames.t: Fix wrongly complemented test
Karl Williamson [Sat, 11 May 2013 22:00:02 +0000 (16:00 -0600)]
lib/charnames.t: Fix wrongly complemented test

The 'if' test should be the opposite of what it is.  I believe I had it
this way for forcing the branch to be taken during testing, and forgot
to restore it.  It only matters if Perl is compiled with early Unicodes,
or on a non-ASCII platform.

8 years agot/re/fold_grind.t: White space only
Karl Williamson [Fri, 10 May 2013 02:48:40 +0000 (20:48 -0600)]
t/re/fold_grind.t: White space only

Commit 3345a47950127cf99a197eba4dce9c91f7bc9139 created a new
block; but didn't indent it.  This commit does.

8 years agoperlapi: Move 'experimental' warning to front of entries
Karl Williamson [Tue, 7 May 2013 16:04:40 +0000 (10:04 -0600)]
perlapi: Move 'experimental' warning to front of entries

In a long multi-paragraph entry, the fact that the described function is
considered experimental may be lost, as it comes at the end.  This just
moves it to the front.

8 years agoregcomp.c: Remove always-true test
Karl Williamson [Tue, 7 May 2013 16:01:58 +0000 (10:01 -0600)]
regcomp.c: Remove always-true test

In this code, j is guaranteed to be above 255, so no need to test for

8 years agoregcomp.c: White-space only
Karl Williamson [Mon, 6 May 2013 00:26:39 +0000 (18:26 -0600)]
regcomp.c: White-space only

The previous commit allows us to outdent a largish block, reflowing
things to fit into the extra available width, and saving a few vertical

8 years agoregcomp.c: Reorder two 'if's so shorter branches are first
Karl Williamson [Sun, 5 May 2013 16:40:56 +0000 (10:40 -0600)]
regcomp.c: Reorder two 'if's so shorter branches are first

This makes it easier to understand what is going on

8 years agoperllocale: Update to mention fc(), \F
Karl Williamson [Sun, 5 May 2013 04:22:53 +0000 (22:22 -0600)]
perllocale: Update to mention fc(), \F

8 years agoregcomp.c: Clarify comment
Karl Williamson [Sun, 5 May 2013 03:23:05 +0000 (21:23 -0600)]
regcomp.c: Clarify comment

8 years agopp.c: Eliminate custom macro and use Copy() instead
Karl Williamson [Sun, 5 May 2013 02:23:14 +0000 (20:23 -0600)]
pp.c: Eliminate custom macro and use Copy() instead

I think it's clearer to use Copy.  When I wrote this custom macro, we
didn't have the infrastructure to generate a UTF-8 encoded string at
compile time.

8 years agoperl #117865] [PATCH] Eliminate useless variable and sizeof(char)
Dagfinn Ilmari Mannsåker [Sun, 5 May 2013 02:18:35 +0000 (20:18 -0600)]
perl #117865] [PATCH] Eliminate useless variable and sizeof(char)

bufsiz is always just set from bsiz (via a useless multiplication by
sizeof(char), which is by definition 1), so instead of trying to keep
them in sync, just get rid of bufsiz use bsiz directly# Please enter the commit message for your changes. Lines starting

8 years agoop.c: Don't fold constant fc() in locale
Karl Williamson [Sat, 4 May 2013 22:09:39 +0000 (16:09 -0600)]
op.c: Don't fold constant fc() in locale

We do compile time folding of calls to ops with constant parameters.
This should be skipped if the op's result depends on locale, and it is
being called from within the scope of 'use locale', as the result is not
known until runtime.  fc() was folding anyway.

There is no test, as this only shows up when run in a locale that it
makes a difference in, and there is no guarantee that such a locale
would occur on any computer, and it is a real pain to go searching
through the computer's available locales for such a one for just this

8 years Don't list undocumented deprecated fcns in API
Karl Williamson [Tue, 30 Apr 2013 14:42:08 +0000 (08:42 -0600)] Don't list undocumented deprecated fcns in API

autodoc creates a list of all the undocumented functions that are part
of the API.  It omits ones that are experimental and whose API may
change; and now it omits ones that are deprecated (and whose API is
planned to change to be non-existent)

8 years Add note for deprecated functions
Karl Williamson [Tue, 30 Apr 2013 14:39:44 +0000 (08:39 -0600)] Add note for deprecated functions

This causes each deprecated function to have a prominent note to that
effect in its API documentation.

8 years agoembed.fnc: Slight clarification in comments
Karl Williamson [Sat, 27 Apr 2013 14:59:19 +0000 (08:59 -0600)]
embed.fnc: Slight clarification in comments

8 years agoAdd tests for case-change macros API
Karl Williamson [Mon, 20 May 2013 16:39:56 +0000 (10:39 -0600)]
Add tests for case-change macros API

8 years agoUse new case changing macros
Karl Williamson [Thu, 25 Apr 2013 16:07:47 +0000 (10:07 -0600)]
Use new case changing macros

The previous commit added macros to do some case changing.  This
commit uses them in the core, where appropriate.

8 years agohandy.h: Add some macro definitions
Karl Williamson [Thu, 25 Apr 2013 16:05:22 +0000 (10:05 -0600)]
handy.h: Add some macro definitions

These macros fill in all the missing case changing operations.  They
were omitted before because they are identical in their input domains to
other operations.  But by adding them here, that detail no longer need be
known by the callers.  toFOLD_LC is not documented, as is subject to

8 years agopp.c: Nit in comment
Karl Williamson [Thu, 25 Apr 2013 14:41:13 +0000 (08:41 -0600)]
pp.c: Nit in comment

8 years agoperlclib.pod: Update character class macro descriptions
Karl Williamson [Wed, 24 Apr 2013 21:39:08 +0000 (15:39 -0600)]
perlclib.pod: Update character class macro descriptions

Much has changed since this pod was last updated.

8 years agoperlclib.pod: Fix too long verbatim lines
Karl Williamson [Wed, 24 Apr 2013 21:36:07 +0000 (15:36 -0600)]
perlclib.pod: Fix too long verbatim lines

8 years agoperlapi: Add docs for some case-changing macros; clarify others
Karl Williamson [Thu, 25 Apr 2013 03:18:14 +0000 (21:18 -0600)]
perlapi: Add docs for some case-changing macros; clarify others

The case changing macros are now almost all documented.  The exception
is toUPPER_LC, which may change in 5.19

In addition the functions in utf8.c that these macros call now refer to
them instead of having their own documentation.  People should really be
using the macros instead of calling the functions directly.  I'm not
deprecating the functions because I can't foresee the need to change
them, so code that uses them should continue to be ok.