This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
Jarkko Hietaniemi [Mon, 29 Feb 2016 13:47:54 +0000 (08:47 -0500)]
Scalar-List-Utils customization bump
Jarkko Hietaniemi [Mon, 29 Feb 2016 13:43:51 +0000 (08:43 -0500)]
Scalar-List-Utils version bump
Jarkko Hietaniemi [Mon, 29 Feb 2016 13:39:02 +0000 (08:39 -0500)]
product() with zero IV crash/hang
CID 104785: Division or modulo by zero (DIVIDE_BY_ZERO)
238. divide_by_zero: In expression 9223372036854775807L / retiv, division by expression retiv which may be zero has undefined behavior.
215 if(!SvNOK(sv) && SvIOK(sv) && (SvIV(sv) < IV_MAX / retiv)) {
Cherry-pick of the changes in
https://rt.cpan.org/Public/Bug/Display.html?id=105415
Jarkko Hietaniemi [Mon, 29 Feb 2016 12:16:59 +0000 (07:16 -0500)]
Socket customization bump
Jarkko Hietaniemi [Mon, 29 Feb 2016 12:15:08 +0000 (07:15 -0500)]
Socket version bump
Jarkko Hietaniemi [Mon, 29 Feb 2016 11:50:58 +0000 (06:50 -0500)]
Check for max length before derefing by length.
Coverity CID 135025 (#1 of 1): Out-of-bounds read (OVERRUN)
29. overrun-local: Overrunning array addr.sun_path of 108 bytes at byte offset 108 using index addr_len (which evaluates to 108).
864 for (addr_len = 0; addr.sun_path[addr_len]
28. incr: Incrementing addr_len. The value of addr_len may now be up to 108.
865 && addr_len < maxlen; addr_len++);
Reported upstream as
https://rt.cpan.org/Ticket/Display.html?id=111707
Daniel Dragan [Mon, 29 Feb 2016 03:44:18 +0000 (22:44 -0500)]
teach makedef.pl an alternate macro for PERL_COPY_ON_WRITE
otherwise a -DPERL_NO_COW perl win32 build fails during linking perl523.dll
with missing Perl_sv_setsv_cow
Lukas Mai [Sun, 28 Feb 2016 22:10:50 +0000 (23:10 +0100)]
perlport: use italics instead of colon in "don't":s (RT #127627)
Dagfinn Ilmari Mannsåker [Mon, 29 Feb 2016 13:55:41 +0000 (13:55 +0000)]
Improve wording of perldelta entry for
ae146f5496e
Alex Vandiver [Mon, 23 Mar 2015 03:44:11 +0000 (23:44 -0400)]
Adjust callsites that use UTF8SKIP without checking UTF
Assuming UTF-8 semantics and advancing character-by-character when 'use
utf8' is not enabled is not as problematic as the inverse. However,
properly UTF8SKIP should only be used when UTF8 semantics are explicitly
asked for.
Change the three occurrences of UTF8SKIP that are not protected by UTF
checks.
Tony Cook [Sun, 28 Feb 2016 22:59:16 +0000 (09:59 +1100)]
perldelta for
ae146f5496e
Daniel Dragan [Sun, 28 Feb 2016 22:52:56 +0000 (09:52 +1100)]
[perl #127584] using Win32 32b gmake with 64b gcc caused wrong archname
Using a 32 bit Win32 gmake, with a GCC that produces 64 bit binaries, made
a perl with PTRSIZE 64 bits, and 64 bit machine code, but archname IDed
that build as "x86" not "x64", which is very wrong. Perl's
win32/GNUMakefile autodetects the bitness of the GCC and sets things up
accordingly. Fixes [perl #127584]. This bug might be a regression
introduced in commit
745dedb9b5 or the GNUMakefile parallel build branch.
Jarkko Hietaniemi [Sun, 28 Feb 2016 22:35:33 +0000 (17:35 -0500)]
Upgrade to IPC-SysV 2.06.
Fixing an oopsie of yours truly from 2.05.
Daniel Dragan [Fri, 26 Feb 2016 20:35:28 +0000 (15:35 -0500)]
static funcs in HiRes.xs
Less indirection on ELF.
Chris 'BinGOs' Williams [Sun, 28 Feb 2016 15:53:56 +0000 (15:53 +0000)]
[perl #127624] corelist: wrong Digest::SHA version in 5.18.4
A bit of sleuthing showed that it was actually version bumped for
the v5.18.3 release.
Also noticed that Config hadn't been updated as well, sorted that
out too.
Karl Williamson [Sat, 27 Feb 2016 22:07:09 +0000 (15:07 -0700)]
regcomp.c: Use less peak memory
This continues the process started in
accb4364d92e26c20e6a538fc04d1af52a8b94e2 of lowering memory use by not
creating unnecessary mortal SVs.
This changes the inversion union and intersection functions to avoid
entirely the creation of new mortals.
Karl Williamson [Sat, 27 Feb 2016 22:05:09 +0000 (15:05 -0700)]
regcomp.c: Modify an assert
This newly-added assert could fail, but hasn't so far. Fix it.
Karl Williamson [Sat, 27 Feb 2016 22:01:43 +0000 (15:01 -0700)]
regcomp.c: Avoid an unnecessary mortal SV
In some paths, an SV was created mortal, and immediately thrown away.
Karl Williamson [Sat, 27 Feb 2016 21:59:47 +0000 (14:59 -0700)]
regcomp.c: Improve free-ing up unused inversion list space
The invlist_trim() function wasn't freeing up space if the new space
needed was small. This now frees up all but the required minimum.
Karl Williamson [Sat, 27 Feb 2016 20:54:51 +0000 (13:54 -0700)]
regcomp.c: Add new static inline convenience function
Karl Williamson [Wed, 24 Feb 2016 17:06:34 +0000 (10:06 -0700)]
regcomp.c: Change variable names, white-space
A future commit will make more sense if these names are changed. This
reindents some code so that it doesn't overflow 79 columns
Karl Williamson [Sat, 27 Feb 2016 19:36:37 +0000 (12:36 -0700)]
regcomp.c: Change name of static function
I found myself using this function, forgetting that it zapped one of the
parameters, so change the name so that can't be forgotten.
Lukas Mai [Sat, 27 Feb 2016 04:17:57 +0000 (05:17 +0100)]
perlfunc overhaul
- remove trailing whitespace
- consistently refer to builtins as C<foo>, not foo() or C<foo()>
- hyperlink each C<foo> builtin to its section in perlfunc
- replace some occurrences of -w with a reference to the warnings pragma
- refer to listy comma as "list concatenation" because that's what it
does
- consistently hyperlink references to external programs (L<touch(1)>),
system calls (L<fork(2)>), and library functions (L<fdopen(3)>)
- hyperlink variables to their section in perlvar
- hyperlink the names of modules/pragmas
- hyperlink names of functions provided by modules (where possible)
- consistently use "pragmas", not "pragmata" (there were only two of
those)
- use the same wording for all conditional builtins / features
- -T and -B are file tests, not switches
- remove "see L</open>" (regarding the ':encoding' layer) from
description of binmode because I don't see why it was there
- refer to variables as C<$foo>, not $foo
- hyperlink some error messages to perldiag
- remove & from subroutine calls
- grammar: write "if X, Y" with a comma and "Y if X" without
- use 'my' in examples when introducing new variables
- 'while (', not 'while('
- don't capitalize the next word after a semicolon
- consistently start error messages (die/warn) with "Can't" (not
"can't", "Cannot", or "cannot")
- replace bareword filehandles by normal variables in examples
- add missing ')'
- fix module names: IPC::SysV::Msg -> IPC::Msg, IPC::SysV::Semaphore ->
IPC::Semaphore
- 'open': replace note about binmode with equivalent paragraph from
'binmode' (the one in 'open' claimed unix systems don't need binmode,
which is not true with encodings)
- 'open': delete overly clever example of generating filehandle names in
a recursive function (this is a non-issue with lexical filehandles)
- 'open': instead of running 'perl -V' and looking for the useperlio
line, you can just run 'perl -V:useperlio'
- 'open': mention shell feature of 'yourscript.pl <( other command )',
which makes the only remaining use of 2-arg open redundant
- 'open': sysopen uses different modes than open; they're not "subtly
different" and there's no "may" about it
- 'open': use $fh->autoflush(1) instead of select/$| dance (especially
since the example already loads IO::Handle for no reason)
- 'printf': remove garbled text ("Look for this throught pod")
- change "use locale 'not_characters'" to the correct "use locale
':not_characters'"
- (hopefully) fix inconsistent use of "real filehandle"; use "bareword
filehandle" instead to distinguish from scalar variables / globrefs
- ":encoding" is a layer, not a pragma
- 'readline': actually use readline in examples
- ?...? is no longer valid; use m?...? instead
- 'sort': whether the algorithm is stable has no effect on runtime
complexity, so "That algorithm was not stable, so I<could> go
quadratic" is nonsense
- 'sort': declaring $a/$b as lexicals is an error regardless of strict
- 'sysopen': as far as I can tell the note about depending on fdopen()
is only true for non-PerlIO builds
- 'use': add an example of what 'use Module VERSION' expands to
- add 'select FILEHANDLE' to filehandle related functions
Also touch ext/Pod-Functions/Functions_pm.PL to make it parse
L<C<foo>|...> in the overview paragraphs.
And teach t/porting/podcheck.t about a ton of man pages and some
external modules.
Karl Williamson [Fri, 26 Feb 2016 23:41:11 +0000 (16:41 -0700)]
regcomp.c: Add missing 'STATIC'
Karl Williamson [Fri, 26 Feb 2016 20:57:10 +0000 (13:57 -0700)]
Fix regex failures on big-endian systems
Commit
accb4364d92e26c20e6a538fc04d1af52a8b94e2 caused regexes to fail
on big-endian systems. It was because I used SvCUR where I should have
been using SvLEN, and was overwriting the final byte of real data with
0, which didn't matter as long as that byte was 0, which in our smokes
on litlle-endian systems, it was.
Further clarification is that inversion lists are stored as UV*, whereas
the scalar handling code is expecting char*. By casting, it all works
out, except that the final byte is kept as a single char NUL. I was
trying to write that final byte as a byte, but by using SvCUR, I was
getting a byte in one of the UVs. With small numbers on a little-endian
system, that byte will be 0 anyway, but not on a big-endian one.
Lukas Mai [Wed, 24 Feb 2016 23:59:41 +0000 (00:59 +0100)]
perlvar: hyperlink from $^D to perlrun/-D
Lukas Mai [Thu, 25 Feb 2016 02:48:48 +0000 (03:48 +0100)]
podcheck.t: expand POD sequences in L</...> section names
Matthew Horsfall [Wed, 24 Feb 2016 20:06:38 +0000 (15:06 -0500)]
Fix perldoc -f sleep to use $SIG{ALRM} instead of $SIG{ALARM}.
Karl Williamson [Tue, 23 Feb 2016 21:04:19 +0000 (14:04 -0700)]
Use less memory in compiling regexes
This is at least a partial patch for [perl #127392], cutting the maximum
memory used on my box from around 8600kB to 7800kB. For [perl #127568],
which has been merged into #127392, the savings are even larger, about
37%
Previously a large number of large mortal SVs could be created while
compiling a single regex pattern, and their accumulated memory quickly
added up. This changes things to not use so many mortals.
Karl Williamson [Tue, 23 Feb 2016 21:00:23 +0000 (14:00 -0700)]
regcomp.c: Guard against corrupting inversion list SV
I don't know of any cases where this happens, but in working on the next
commit I triggered a problem with shrinking an inversion list so much
that the required 0 UV at the beginning was freed.
Daniel Dragan [Sun, 21 Feb 2016 17:28:14 +0000 (12:28 -0500)]
silence warning in Win32CORE
Win32CORE.c: In function ‘boot_Win32CORE’:
../../XSUB.h:127:43: warning: unused parameter ‘cv’ [-Wunused-parameter]
Tony Cook [Tue, 23 Feb 2016 04:09:39 +0000 (15:09 +1100)]
[perl #127386] clarify that exit in the die pseudo-code is perl's exit
Chris 'BinGOs' Williams [Tue, 23 Feb 2016 00:44:08 +0000 (00:44 +0000)]
M-CL sync with what tis is on CPAN
Ricardo Signes [Sun, 21 Feb 2016 21:59:17 +0000 (08:59 +1100)]
release schedule: Sawyer to release October 2016
Sawyer X [Sun, 21 Feb 2016 16:51:25 +0000 (17:51 +0100)]
Merge branch 'blead' of ssh://perl5.git.perl.org/perl into blead
Sawyer X [Sun, 21 Feb 2016 13:02:27 +0000 (14:02 +0100)]
More updates to Module::CoreList:
I hope I got this right (I probably didn't though). The release
version was
20160121, not
20160220 or
20160221, so I'm not really
sure what's going on. Of course, with Module::CoreList I'm rarely
sure.
Still all tests pass and the world hasn't exploded yet, as far
as I know.
If you find a problem with this, I would appreciate a fix, but
also to ping me and tell me what I did wrong. I promise to update
the release checklist with it.
Thanks!
Sawyer X [Sun, 21 Feb 2016 12:36:10 +0000 (13:36 +0100)]
update Module::CoreList and bump version
Karl Williamson [Sun, 21 Feb 2016 01:29:25 +0000 (18:29 -0700)]
t/re/pat_advanced.t: Test for [#perl 126886]
This was fixed by
cfbef7dc3bfb89e4ed2c00ea9c9e3bcfd0b170fd
Sawyer X [Sat, 20 Feb 2016 22:51:37 +0000 (23:51 +0100)]
bump version to 5.23.9
Sawyer X [Sat, 20 Feb 2016 22:39:02 +0000 (23:39 +0100)]
new perldelta for 5.23.9
Sawyer X [Sat, 20 Feb 2016 22:21:58 +0000 (23:21 +0100)]
update 5.23.8 as done on release schedule
Sawyer X [Sat, 20 Feb 2016 22:21:11 +0000 (23:21 +0100)]
add 5.23.8 epigraph
Sawyer X [Sat, 20 Feb 2016 22:17:07 +0000 (23:17 +0100)]
Merge branch 'release-5.23.8' into blead
Sawyer X [Sat, 20 Feb 2016 20:09:58 +0000 (21:09 +0100)]
add new release to perlhist
Sawyer X [Sat, 20 Feb 2016 19:46:45 +0000 (20:46 +0100)]
Typos, POD errors, etc.
Sawyer X [Sat, 20 Feb 2016 19:22:02 +0000 (20:22 +0100)]
Update perldelta module versions (Porting/corelist-perldelta.pl)
Sawyer X [Sat, 20 Feb 2016 18:52:03 +0000 (19:52 +0100)]
update Module::CoreList (Porting/corelist.pl)
Sawyer X [Sat, 20 Feb 2016 17:22:33 +0000 (18:22 +0100)]
cleanup perldelta
Sawyer X [Sat, 20 Feb 2016 14:31:02 +0000 (15:31 +0100)]
Document 38e3b24
Sawyer X [Fri, 19 Feb 2016 23:20:38 +0000 (00:20 +0100)]
Document
e57270be442bfaa9dc23eebd67485e5a806b44e3:
I wasn't sure where or how much of it to document, but it seems
like it's important, and this relating to permissions not being
removed, I consider it security-related. This is similiar to what
the original Debian ticket that relates to it mentioned.
I've cut Niko's text a bit shorter, taken from the commit message
itself.
Sawyer X [Thu, 18 Feb 2016 16:30:07 +0000 (17:30 +0100)]
Sawyer X [Wed, 17 Feb 2016 18:15:58 +0000 (19:15 +0100)]
Update perldelta.pod:
This includes most changes I've noticed. I ran through all
commits since the last commit Stevan did. There are some commits
there which I haven't reflect and not sure whether they were,
but I will take that up with their respected authors.
Jarkko Hietaniemi [Sat, 20 Feb 2016 13:49:04 +0000 (08:49 -0500)]
Add assert(matches_string).
Coverity CID #135728: Explicit null dereferenced (FORWARD_NULL)
Coverity sees an execution path that leaves matches_string NULL.
Jarkko Hietaniemi [Thu, 18 Feb 2016 02:04:18 +0000 (21:04 -0500)]
Upgrade to IPC-SysV 2.05.
Craig A. Berry [Fri, 19 Feb 2016 21:33:10 +0000 (15:33 -0600)]
Cast PL_dump_re_max_len to avoid type mismatch warning.
Specifically this one on VMS:
|| ! grok_atoUV(dump_len_string, &PL_dump_re_max_len, NULL))
.....................................^
%CC-W-PTRMISMATCH, In this statement, the referenced type of the
pointer value "&(my_perl->Idump_re_max_len)" is "unsigned int",
which is not compatible with "unsigned long".
This was new code in
2bfbbbaf9ef1783ba.
Karl Williamson [Fri, 19 Feb 2016 18:16:06 +0000 (11:16 -0700)]
regcomp.c: White-space only
Re-indent and reflow to fit in 80 cols after previous commit
Karl Williamson [Fri, 19 Feb 2016 18:11:40 +0000 (11:11 -0700)]
regcomp.c: Can't do optimization if inverting
Something like /[^\W_0-9]/ was getting optimized into something it
shouldn't have been. Although, the way the execution code is
structured, I couldn't find a case where it actually made a difference.
So skip the optimization if inverting.
Karl Williamson [Thu, 18 Feb 2016 21:51:01 +0000 (14:51 -0700)]
regcomp.c: Use colors for -Dr metanotation
Use a different color for the metanotation than the code points being
output under Debugcolor. The default is to have stand out mode for the
code points, and not for the meta.
Karl Williamson [Thu, 18 Feb 2016 21:44:02 +0000 (14:44 -0700)]
regcomp.c: Backlslash {} in -Dr output
This is because it could otherwise be confused with the meta notation
used there.
Karl Williamson [Thu, 18 Feb 2016 21:43:14 +0000 (14:43 -0700)]
Revamp -Dr handling of /[...]/
This revamps the handling of -Dr for bracketed character classes. There
were bugs introduced earlier in 5.23, and this consolidates the handling
of /d classes so that the interactions can be better considered. It
tries inverting the portion that is in the bitmap range to see if the
output is shorter, and clearer that way. And it always makes the
above-bitmap code points show as not-inverted, as that is clearer.
I ran out of time before the freeze, so I had to not invert in some
cases.
Karl Williamson [Fri, 19 Feb 2016 04:47:15 +0000 (21:47 -0700)]
Add environment variable for -Dr: PERL_DUMP_RE_MAX_LEN
The regex engine when displaying debugging info, say under -Dr, will elide
data in order to keep the output from getting too long. For example,
the number of code points in all of Unicode matched by \w is quite
large, and so when displaying a pattern that matches this, only the
first some number of them are printed, and the rest are truncated,
represented by "...".
Sometimes, one wants to see more than what the
compiled-into-the-engine-max shows. This commit creates code to read
this environment variable to override the default max lengths. This
changes the lengths for everything to the input number, even if they
have different compiled maximums in the absence of this variable.
I'm not currently documenting this variable, as I don't think it works
properly under threads, and we may want to alter the behavior in various
ways as a result of gaining experience with using it.
Karl Williamson [Mon, 15 Feb 2016 23:27:20 +0000 (16:27 -0700)]
regcomp.c: Save a branch test
This branch will only be true if the answer to the previous branch was
also true, so can just move it to within that to avoid an unnecessary
test.
Karl Williamson [Mon, 15 Feb 2016 23:20:43 +0000 (16:20 -0700)]
regcomp.c: Clarify -Dr output under /l
It is now redundant to indicate that an ANYOF node is for locale, as the
regnode type ANYOFL now clearly indicates that. But also sometimes the
node is only vaid if the runtime locale is a UTF-8 one. That was not
clearly indicated.
Karl Williamson [Sun, 14 Feb 2016 01:00:36 +0000 (18:00 -0700)]
regcomp.c: Comments, white-space, add grouping () for clarity
Karl Williamson [Fri, 19 Feb 2016 04:43:14 +0000 (21:43 -0700)]
Add a parameter to a static function
This parameter will be used in a future commit, it changes the output
format of this function that displays the contents of an inversion list
so that it won't have to be parsed later, simplifying the code at that
time.
Karl Williamson [Fri, 19 Feb 2016 04:36:04 +0000 (21:36 -0700)]
Change private function to static
This function was used outside the file it contains, but was only
defined (by #ifdef's) for those few internal core files for which it was
needed. Now all those uses have gone, save for the one file. Better to
make it static so no one can circumvent those #ifdef's.
Karl Williamson [Fri, 19 Feb 2016 04:08:24 +0000 (21:08 -0700)]
regcomp.c: Change structure element size and loc
The 'strict' field is only a bool, but was declared I32, which led to
warnings on some compilers when it was passed to a function expecting a
bool. It is moved to the end of the structure, since it doesn't pack
well with the rest.
Karl Williamson [Thu, 18 Feb 2016 04:24:37 +0000 (21:24 -0700)]
regcomp.c: Move static declaration to file level
This array will be used in a future commit outside the function it
previously was declared in
Karl Williamson [Thu, 18 Feb 2016 04:17:46 +0000 (21:17 -0700)]
regcomp.c: optimization for qr/[...]/il
Certain matches are calculated as being legal only when the current
execution time local is a UTF-8 one. However, a character class can
have multiple components (and usually does), and some of those components
may be duplicates of some of these matches, and be valid regardless of
the locale. This commit removes them from the tentative list, and if it
goes to zero, clears it. This will improve execution time slightly.
Karl Williamson [Thu, 18 Feb 2016 04:15:52 +0000 (21:15 -0700)]
regcomp.c: Avoid a segfault
I stumbled across this in adding more code elsewhere, so I don't know
how to trigger it. This is in the intersection routine for two
inversion lists. The corresponding union code correctly handles the
case when the input is NULL, so just copy that to here.
Karl Williamson [Sat, 13 Feb 2016 22:35:11 +0000 (15:35 -0700)]
PATCH: [perl 127537] /\W/ regression with UTF-8
This bug is apparently uncommon in the field, as I was the one who
discovered it. It requires a UTF-8 pattern containing a complemented
posix class, like \W or \S, in an inverted character class, like
[^\Wfoo] in a pattern that also has a synthetic start class generated by
the regex optimizer for it .
The fix is trivial.
Karl Williamson [Sat, 13 Feb 2016 18:53:50 +0000 (11:53 -0700)]
regcomp.c, toke.c: swap functions being inline static
grok_bslash_x() is so large that no compiler will inline it. Move it to
dquote.c from dq_inline.c. Conversely, move form_octal_warning() to
dq_inline.c. It is so tiny that the function call overhead is scarcely
smaller than the function body.
This also moves things in embed.fnc so all these functions. are not
visible outside the few files they are supposed to be used in.
Karl Williamson [Mon, 15 Feb 2016 18:02:07 +0000 (11:02 -0700)]
Cast correctly to U8, not char
U8 is what the function being called is expecting
Karl Williamson [Tue, 16 Feb 2016 03:59:10 +0000 (20:59 -0700)]
perlapi: Hide the swash functions
These should be internal only, and we may want to get rid of them
someday. Hide their existence so that people who don't already know
about them won't be tempted to try to use them.
Karl Williamson [Tue, 16 Feb 2016 03:32:32 +0000 (20:32 -0700)]
regcomp.h: Not all ANYOF flags are in use.
So, it's better to not have a mask to include the unused ones.
Karl Williamson [Sun, 14 Feb 2016 00:21:28 +0000 (17:21 -0700)]
regcomp.c: Simplify a few lines of code
This code had been written before the isMNEMONIC_CNTRL() macro was
created. Using the macro simplifies things a little.
Karl Williamson [Sat, 13 Feb 2016 22:51:50 +0000 (15:51 -0700)]
regcomp.c: Clean up logic in function
This function uses some crude heuristics to decide whether to make a
synthetic start class or not. This commit removes some redundancies.
Karl Williamson [Thu, 11 Feb 2016 17:25:04 +0000 (10:25 -0700)]
regcomp.c: -Dr \xZZ instead of \x{ZZ}
The brackets are unnecessary and clutter the output.
Karl Williamson [Thu, 11 Feb 2016 17:12:57 +0000 (10:12 -0700)]
regcomp.c: Fix -Dr bug
It was using a wrong length calculation, which under some circumstances
caused the output to include extra bytes. Also I added comments, and
changed a variable name, so I don't have to figure this out again from
scratch.
Karl Williamson [Mon, 15 Feb 2016 18:04:36 +0000 (11:04 -0700)]
regcomp.c: Use macro to hide complexity
There is an existing macro that does these three lines in one source
line.
Karl Williamson [Sat, 13 Feb 2016 20:49:00 +0000 (13:49 -0700)]
Don't allow /\N{}/ under 're strict'
This is the one remaining empty {} that was accepted under the
experimental 'use re "strict"'.
Karl Williamson [Sat, 13 Feb 2016 22:20:49 +0000 (15:20 -0700)]
perlrecharclass: Add some missing info
Tom Hukins [Wed, 17 Feb 2016 15:04:10 +0000 (15:04 +0000)]
Remove an unused variable
Other Time::HiRes test scripts define and use $limit to cope with timing
on heavily loaded systems.
This test script defined the variable but never used it.
Daniel Dragan [Thu, 18 Feb 2016 00:15:39 +0000 (11:15 +1100)]
[perl #127556] update installperl to new location of W32 libperl link lib
commit
bf543eaf90 made the Win32 GCC or VC linkers produce
[lib]perl[5xx].[a/lib] in the /lib/CORE dir to reduce the prereq recipie
lines needing to run until XS modules can be built ("Extensions" which
builds all DLL XS modules is the longest running target and every effort
should be made for it to be started sooner by the make tool in parallel
build). The file is now made in /lib/CORE, previously it was made in root
and xcopy-ed to /lib/CORE in the same target that built the file. xcopy is
a seperate process run so was remove in that commit.
installperl doesn't use uninstalled /lib/CORE to determine the contents of
installed /lib/CORE (maybe that is a bug or bad design?), so the linking
lib was not being installed after a "[g/d]make install" making it
impossible to compile XS code on Win32 Perl. Change installperl
to look for the linking lib in /lib/CORE on Win32 and not in root. Even
though the nmake makefile still does the XCOPY since it is older/less
maintained, the installperl code still works since the root and /lib/CORE
files are identical on the nmake build and built in the same target.
James E Keenan [Wed, 17 Feb 2016 23:50:57 +0000 (18:50 -0500)]
Jarkko Hietaniemi [Wed, 17 Feb 2016 14:40:00 +0000 (09:40 -0500)]
Time::HiRes version bump.
Jarkko Hietaniemi [Wed, 17 Feb 2016 14:37:25 +0000 (09:37 -0500)]
Allow TIME_HIRES_DONT_RUN_PROBES=1 to aid cross-compiling
If that is true, the probes are compiled but not run.
https://rt.cpan.org/Ticket/Display.html?id=111391
Patch kindly supplied by Niko Tyni.
Karl Williamson [Tue, 16 Feb 2016 19:08:20 +0000 (12:08 -0700)]
t/re/reg_mesg.t: Add a couple of tests
Daniel Dragan [Thu, 11 Feb 2016 10:48:58 +0000 (05:48 -0500)]
minor comment improvements in hv.h and scope.h
-perl doesn't use malloc, it uses Newx (per interp memory)
-say what the return type is of SSNEW
Lukas Mai [Mon, 15 Feb 2016 20:17:18 +0000 (21:17 +0100)]
Revert "tweak NOT_REACHED in DEBUGGING builds"
This reverts commit
5b48e25f83f62f48ea280c49b00302e063384348.
The above commit breaks win32 builds:
IO.xs(73) : error C2065: 'my_perl' : undeclared identifier
IO.xs(73) : error C2223: left of '->IProc' must point to struct/union
where dist/IO/IO.xs contains:
69: static int
70: not_here(const char *s)
71: {
72: croak("%s not implemented on this architecture", s);
73: NORETURN_FUNCTION_END;
74: }
and perl.h contains:
# define NORETURN_FUNCTION_END NOT_REACHED;
David Mitchell [Mon, 15 Feb 2016 15:37:33 +0000 (15:37 +0000)]
doop.c: fix typo in header comment
Tony Cook [Mon, 15 Feb 2016 02:05:18 +0000 (13:05 +1100)]
perldelta: move the two Win32 gmake improvements to where they belong
Daniel Dragan [Sat, 13 Feb 2016 09:05:24 +0000 (04:05 -0500)]
fix win32 gmake with win64 VC with 32 bit GCC in PATH build failure
The assignment of PROCESSOR_ARCHITEW6432 to PROCESSOR_ARCHITECTURE near
the "When we are running from a 32bit cmd.exe on AMD64 then" comment
doesn't happen if WIN64 var was already assigned to. Do the 32/64 auto
detection only for GCC builds, not for VC builds. I not implementing 32/64
and cl version (CCTYPE setting) detection by parsing stdout of "cl<enter>"
with batch and gmake syntax at this time.
failure message:
generate_uudmap.obj : fatal error LNK1112: module machine type 'x64'
conflicts with target machine type 'X86'
GNUmakefile:1416: recipe for target '..\generate_uudmap.exe' failed
gmake: *** [..\generate_uudmap.exe] Error 2
Jarkko Hietaniemi [Sun, 14 Feb 2016 00:34:20 +0000 (19:34 -0500)]
Skip the length sanity check if d_name is pointer or less.
[perl #127511] v5.23.7-308-g1d41bb7 broke t/op/threads-dirh.t on solaris threaded builds
In other words, skip it if the dirent->d_name is a pointer (char *)
or less (struct-final char d_name[1], as it seems to be in Solaris).
The length sanity check is meant for places where the d_name is
a true array.
Follow-up to
1d41bb72.
Craig A. Berry [Sat, 13 Feb 2016 22:29:14 +0000 (16:29 -0600)]
DynaLoader shouldn't use mod2fname when finding .bs files.
Some platforms (probably only VMS and Android at the moment) take
special steps via the function DynaLoader::mod2fname to construct
a dynamic library name that will be unique and (if too long)
truncated. Then DynaLoader looks for a bootstrap file with the
exact same name as the dynamic library except with a .bs file
extension.
However, ExtUtils::MakeMaker has never produced bootstrap files
that have been run through mod2fname, so while a Foo:Bar extension
would produce a loadable library named PL__Foo_Bar.exe, the
bootstrap would be called Bar.bs. That shouldn't be a problem
since the bootstrap file is just Perl code read by Perl, but
DynaLoader has (apparently forever) been looking for
PL__Foo_Bar.bs and not finding it. So let's look for it by the
name under which it actually exists.
There are no core extensions that produce non-empty bootstrap
files and no existing test coverage, but as-yet-unintegrated
versions of MakeMaker do have such tests. See, for example,
https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/commit/
7f5e9a35addeea7ebfcded28277c85f723e1a5de
Jarkko Hietaniemi [Sat, 13 Feb 2016 23:26:09 +0000 (18:26 -0500)]
Solaris /usr/bin/sed cannot handle labels of length eight.
You will just get a bunch of these from makedepend:
Finding dependencies for av.o.
Label too long: : testcont
According to POSIX, it should, eight being the minimum supported length.
Shoulda woulda coulda. Label of length seven seems to be fine.
Lukas Mai [Sat, 13 Feb 2016 21:11:59 +0000 (22:11 +0100)]
tweak NOT_REACHED in DEBUGGING builds
Previously, NOT_REACHED was defined as ASSUME(0), which is assert(0) in
DEBUGGING builds.
On some platforms (HP-UX/IA64, others?) gcc doesn't know that assert(0)
never returns. We have some code of the form (simplified):
int x;
switch (A) {
case B: x = 0; break;
case C: x = 1; break;
default: NOT_REACHED;
}
return x;
Now gcc thinks control can pass through the default branch and hit the
'return'. This triggers a warning of the form
warning: 'x' may be used uninitialized in this function
[-Wmaybe-uninitialized]
This commit defines NOT_REACHED as abort() in DEBUGGING builds.
Hopefully every compiler knows that abort() can't return, thus getting
rid of the bogus warnings.
Jarkko Hietaniemi [Sat, 13 Feb 2016 14:55:01 +0000 (09:55 -0500)]
Time::HiRes version bump.
Jarkko Hietaniemi [Sat, 13 Feb 2016 16:38:30 +0000 (11:38 -0500)]
Whitespace only: zap EOL spaces
Jarkko Hietaniemi [Sat, 13 Feb 2016 14:50:03 +0000 (09:50 -0500)]
Add the Time-HiRes Changes file from CPAN.