This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
Karl Williamson [Thu, 6 Dec 2018 23:57:17 +0000 (16:57 -0700)]
regen/mk_invlists.pl: Add new table
This table contains all the code points that are in any multi-character
fold (not the folded-from character, but what that character folds to).
It will be used in a future commit.
Karl Williamson [Thu, 6 Dec 2018 23:53:23 +0000 (16:53 -0700)]
regen/mk_invlists.pl: Rmv no longer used array
Karl Williamson [Fri, 7 Dec 2018 17:42:21 +0000 (10:42 -0700)]
t/harness: Catch incorrect serial directory specification
The previous commit fixed a bug. This commit detects if someone creates
a new instance of that bug.
Karl Williamson [Fri, 7 Dec 2018 17:32:35 +0000 (10:32 -0700)]
t/harness: Actually run IO::Zlib tests sequentially
Commit
bc55cddf915d70f806feda38506788f4c61a2574 tried to do this, but it
turns out it didn't actually, because it didn't precisely name the
directory.
Petr Písař [Fri, 7 Dec 2018 14:25:53 +0000 (09:25 -0500)]
Make ext/B/t/strict.t test alike to other ones.
Signed-off-by: Petr Písař <ppisar@redhat.com>
For: RT 133713
James E Keenan [Fri, 7 Dec 2018 02:42:51 +0000 (02:42 +0000)]
Correct error message in t/taint.t.
In this test file, our temporary directory is named 'for_find_taint'.
Make sure the error method reflects that. (This was overlooked in
f09dd912ca4 2018-11-19.)
Karl Williamson [Sun, 2 Dec 2018 20:05:47 +0000 (13:05 -0700)]
regcomp.c: Use simpler variable name as long as possible
This just extends the use of a variable name a little longer, as it's
easier to read than the nested macro calls that eventually have to be
used.
Karl Williamson [Sun, 2 Dec 2018 19:22:39 +0000 (12:22 -0700)]
regcomp.c: Prefer one of similarly named vars
These two variables are similarly named, but have slightly different
purposes. Comment out one of them, and convert to using the other
consistently
Karl Williamson [Sun, 2 Dec 2018 18:46:07 +0000 (11:46 -0700)]
t/re/anyof.t: Remove duplicate test case
Karl Williamson [Sun, 2 Dec 2018 18:17:26 +0000 (11:17 -0700)]
Use consistent spelling in qr// dumping
Under -Dr (or use re 'Debug') the compiled regex engine program is
displayed. I noticed that it used two different spellings for
'infinity'. This commit changes so only one is used, the one that has
been in the field the longest.
Karl Williamson [Wed, 5 Dec 2018 01:22:05 +0000 (18:22 -0700)]
regcomp.c: Clarify comment
Niko Tyni [Sun, 2 Dec 2018 09:57:01 +0000 (11:57 +0200)]
Fix t/porting/manifest.t failures when run in a foreign git checkout
The change at
ba6733216202523a95b0b7ee2e534b8e30b6d7df didn't work
correctly: find_git_or_skip() in t/test.pl looks at PERL_BUILD_PACKAGING
too late, so it doesn't change the logic of skipping, only the explanation
of why tests get skipped if they do. This was originally reported at
<https://bugs.debian.org/914962>.
Committer: update commit message for upstream context
Karl Williamson [Wed, 5 Dec 2018 00:59:31 +0000 (17:59 -0700)]
regcomp.sym: Clarify descriptions of EXACTish regnodes
Karl Williamson [Tue, 4 Dec 2018 19:05:59 +0000 (12:05 -0700)]
inline.h: Clarify comment
This function works as well as possible on non-UTF-8 inputs. No need to
list the UTF-8-only failures, since those aren't legal inputs.
Tony Cook [Wed, 5 Dec 2018 04:35:19 +0000 (15:35 +1100)]
bump $ExtUtils::ExtUtils::VERSION to 3.40
Tony Cook [Wed, 5 Dec 2018 04:22:52 +0000 (15:22 +1100)]
(perl #133654) don't include OUTLIST parameters in the prototype
The generated prototype (with PROTOTYPES: ENABLE) would include
OUTLIST parameters, but these aren't arguments to the perl function.
Tony Cook [Mon, 3 Dec 2018 05:15:52 +0000 (16:15 +1100)]
(perl #133706) remove exploit code from Storable
Storable packaged the metasploit framework code for CVE-2015-1592,
which triggered virus scanners.
To prevent that remove the packaged exploit code and test for the
underlying structure we trigger the warning on.
James E Keenan [Tue, 4 Dec 2018 00:25:51 +0000 (19:25 -0500)]
Add header-guards to 2 additional files
Two header files in ext/SDBM_File appear to be blead-upstream, so we can
add header guards here as well.
For: RT 133699
James E Keenan [Thu, 29 Nov 2018 03:50:29 +0000 (22:50 -0500)]
Provide header guards to prevent re-inclusion
Per LGTM analysis: https://lgtm.com/projects/g/Perl/perl5/alerts/?mode=tree&ruleFocus=
2163210746
and LGTM recommendation: https://lgtm.com/rules/
2163210746/
For: RT 133699
Karl Williamson [Sun, 2 Dec 2018 08:30:39 +0000 (01:30 -0700)]
Revert "regcomp.c: Use a weird value in a place where ignored"
This reverts commit
5a4bc50b395654abde21718cbce2e296049f470d.
It turns out I was wrong, and the value isn't ignored. The commit
caused the pattern to be optimized differently, but still be valid,
so no tests failed.
James E Keenan [Sat, 1 Dec 2018 17:58:41 +0000 (12:58 -0500)]
Sync Test::Simple with CPAN version 1.302141
Committer: Update perldelta
James E Keenan [Sat, 1 Dec 2018 17:39:27 +0000 (12:39 -0500)]
Add instruction to configure to SYNOPSIS
Because I always to forget to ./Configure before trying to bring in an
updated upstream module from CPAN.
James E Keenan [Fri, 30 Nov 2018 03:12:10 +0000 (22:12 -0500)]
Correct typo
James E Keenan [Fri, 30 Nov 2018 03:09:41 +0000 (22:09 -0500)]
Drop sentence which is no longer valid as of 5.28
Per recommendation of Dan Book.
For: RT 133705
Steve Hay [Thu, 29 Nov 2018 21:06:04 +0000 (21:06 +0000)]
Tick off 5.26.3 and 5.28.1
Steve Hay [Thu, 29 Nov 2018 21:03:00 +0000 (21:03 +0000)]
Steve Hay [Thu, 29 Nov 2018 20:49:00 +0000 (20:49 +0000)]
Import perl5263delta.pod and perl5281delta.pod
Steve Hay [Thu, 29 Nov 2018 20:11:17 +0000 (20:11 +0000)]
Update Module-CoreList with data for 5.26.3 and 5.28.1
Steve Hay [Thu, 29 Nov 2018 19:49:30 +0000 (19:49 +0000)]
Epigraphs for 5.26.3 and 5.28.1
Karl Williamson [Mon, 24 Sep 2018 17:16:14 +0000 (11:16 -0600)]
PATCH: [perl #133423]
Karl Williamson [Thu, 29 Nov 2018 18:55:09 +0000 (11:55 -0700)]
locale.c: Failure to build if not allowing LC_COLLATE
This is part of [perl #133696]. A typo was causing a macro to be
defined in terms of itself, hence an illegal recursive definition.
Karl Williamson [Thu, 29 Nov 2018 18:53:58 +0000 (11:53 -0700)]
locale.c: Don't use numeric unless LC_NUMERIC
This commit #ifdef's a usage of a variable that isn't valid unless the
system has LC_NUMERIC
Karl Williamson [Thu, 29 Nov 2018 18:50:58 +0000 (11:50 -0700)]
locale.c: Fix wrong scope of #if's
The function print_bytes_for_locale() should be defined if DEBUGGING;
prior to this commit it didn't get defined unless LC_COLLATE was
defined on the platform.
Eugen Konkov [Thu, 29 Nov 2018 17:56:07 +0000 (10:56 -0700)]
More removals of $a,$b in perldata for [#perl #133700]
Eugen Konkov [Thu, 29 Nov 2018 17:21:20 +0000 (10:21 -0700)]
PATCH: [perl #133700] avoid use of $a and $b in perldata
Tony Cook [Thu, 29 Nov 2018 03:16:03 +0000 (14:16 +1100)]
make boot_Win32CORE extern "C" for C++ builds
Tony Cook [Thu, 29 Nov 2018 03:12:01 +0000 (14:12 +1100)]
stdio.h on Cygwin doesn't expose cuserid() with _GNU_SOURCE
It's probably possible to expose it by setting _XOPEN_SOURCE to
some specific value, but this appears to be a bug.
https://cygwin.com/ml/cygwin/2018-11/msg00230.html
Tony Cook [Wed, 28 Nov 2018 23:50:19 +0000 (23:50 +0000)]
Pass a UV to a format expecting a UV
MAX_LEGAL_CP can end up as int depending on the ranges of the types
involved, causing a type mismatch on the format in cp_above_legal_max.
By adding the cast to the macro definition we both prevent the type
mismatch on the format, but also may allow some static analysis tool to
detect comparisons against signed types, which is likely an error.
jdhedden [Wed, 28 Nov 2018 03:53:40 +0000 (22:53 -0500)]
Upgrade to threads::shared 1.59
Committer: perldelta entry
Karl Williamson [Tue, 27 Nov 2018 17:07:12 +0000 (10:07 -0700)]
Add USE_THREAD_SAFE_LOCALE to non-bin-compat options list
Spotted by Tux
Karl Williamson [Tue, 27 Nov 2018 16:43:01 +0000 (09:43 -0700)]
regcomp.c: White-space only
Vertical align continuation chars in a macro
Karl Williamson [Tue, 27 Nov 2018 16:42:45 +0000 (09:42 -0700)]
Add regnode EXACTFU_ONLY8
This is a regnode that otherwise would be an EXACTFU except that it
contains a code point that requires UTF-8 to match, including all the
possible folds involving it. Hence if the target string isn't UTF-8, we
know it can't possibly match, without needing to try.
For completeness, there could also be an EXACTFAA_ONLY8 and an
EXACTFL_ONLY8 created, but I think these are unlikely to actually appear
in the wild, since using /aa is mainly about ASCII, and /l mostly will
involve characters that don't require UTF-8.
Karl Williamson [Sat, 17 Nov 2018 22:51:19 +0000 (15:51 -0700)]
Add regnode EXACT_ONLY8
This is a regnode that otherwise would be an EXACT except that it
contains a code point that requires UTF-8 to represent. Hence if the
target string isn't UTF-8, we know it can't possibly match, without
needing to try.
Karl Williamson [Sat, 17 Nov 2018 22:47:02 +0000 (15:47 -0700)]
regcomp.c: Use common code instead of duplicating it
The common code is about to get more complicated, so use it instead of a
copy.
David Mitchell [Tue, 27 Nov 2018 16:36:35 +0000 (16:36 +0000)]
perlreref.pod: disambiguate "code"
It says:
(?(cond)yes) Conditional expression, where "cond" can be:
(?=pat) lookahead
...
A strict reading of that is that there must be two pairs of parens
in each conditional construct, e.g. (?((?=pat))yes).
Make the text clearer.
David Mitchell [Tue, 27 Nov 2018 13:26:39 +0000 (13:26 +0000)]
handle /(?(?{code}))/ mixed compile-and runtime
Where a runtime pattern contains both compile-time and run-time code
blocks, e.g.:
$re = '(?{ RRR })';
/ $re X(?{ CCC })Y/
The compile-time code-block CCC is parsed at the same time as the
surrounding text. The runtime code RRR is parsed at runtime by
constructing a fake pattern and re-parsing it, but with any compile-time
code-blocks blanked out (so they don't get compiled twice). The compiled
regex is then thrown away, but any optrees just created for the runtime
code blocks are kept.
For example at runtime, the re-parsed pattern looks like:
/ (?{ RRR }) X__________Y/
Unfortunately this was failing for the conditional pattern, e.g.
/ $re X(?(?{ CCC }))Y/
which was getting blanked as
/ (?{ RRR }) X(?_______)Y/
which isn't valid syntax.
This commit blanks (?{...}) into (?=====) instead which is always legal.
Aaron Crane [Tue, 27 Nov 2018 11:32:11 +0000 (11:32 +0000)]
Rely on C89 "const"
The metaconfig probe for <db.h> previously relied on the d_const symbol set
by the "const" probe, so generating Configure here has been done against
metaconfig commit
1204d4627a06b11f16620188f3fa83159ed35fd9 which changes
that.
Thanks to khw++ for pointing out this oversight in my attempt last year to
make the codebase rely on C89.
Karl Williamson [Sun, 18 Nov 2018 22:46:07 +0000 (15:46 -0700)]
regexec.c: Use ANYOF bitmap lookup in more cases
ANYOFish nodes have a bitmap. If we know the value is in the bitmap
range, then flags that apply to out-of-range values are irrelevant.
Other flags being set indicate that the desired answer is more
complicated than just using a bitmap lookup. But exclude this
irrelevant flag from that calculation when we know the value is in the
bitmap.
There are other flags that it is possible to exclude, but not without
further conditionals, or unsharing code, and are either rarely set or
are for node types that we don't worry so much about optimal
performance, like /l and /d. The changes introduced by this commit
are determined at .c compile time except for a runtime mask, and hence
don't introduce new branches that may destroy the instruction cache
pipeline.
Karl Williamson [Sun, 18 Nov 2018 22:24:45 +0000 (15:24 -0700)]
regexec.c: Refactor expanded macro from prev. commit
Karl Williamson [Sun, 18 Nov 2018 22:12:02 +0000 (15:12 -0700)]
regexec.c: Expand out macro in only remaining use
There is only one call to this macro. It's easier to understand if
expanded out instead of the call. The next commit will refactor.
Karl Williamson [Wed, 21 Nov 2018 03:59:18 +0000 (20:59 -0700)]
regcomp.c: Clarify comment
Karl Williamson [Sun, 18 Nov 2018 21:52:15 +0000 (14:52 -0700)]
regcomp.c: Initialize a variable more conservatively
It doesn't matter currently, but thes variable shouldn't be TRUE unless
/i is in effect.
Karl Williamson [Sun, 18 Nov 2018 20:39:49 +0000 (13:39 -0700)]
regcomp.c: Use a weird value in a place where ignored
This way, it doesn't confuse that it is legal, and should it stop being
ignored in the called function, it will show up as a problem much
sooner.
Karl Williamson [Sat, 17 Nov 2018 23:02:31 +0000 (16:02 -0700)]
regexec.c: Add comment
Karl Williamson [Sat, 17 Nov 2018 22:54:34 +0000 (15:54 -0700)]
regexec.c: Rmv unused macros
Karl Williamson [Sun, 18 Nov 2018 23:06:50 +0000 (16:06 -0700)]
regcomp.h: Clarify comments
Karl Williamson [Thu, 15 Nov 2018 18:09:35 +0000 (11:09 -0700)]
regcomp.c: Consolidate duplicated code into 1 place
Karl Williamson [Wed, 21 Nov 2018 04:21:44 +0000 (21:21 -0700)]
regcomp.c: Use better method for setting debug offsets
This was changing the parse pointer around some code and restoring it
afterwards. The purpose must have been to get the debug offsets
correct. But there is a better way to do that, which doesn't take up
cycles on a non-Debugging build, and that is to set the offsets
directly.
Karl Williamson [Wed, 21 Nov 2018 04:18:51 +0000 (21:18 -0700)]
regcomp.c: Remove another sizing pass relict
We no longer play with the emit ptr in this function, so no need to save
and restore it.
Karl Williamson [Sun, 25 Nov 2018 19:14:49 +0000 (12:14 -0700)]
Move isPOWER_OF_2() macro to handy.h
This is in preparation for it to be used outside of the file which
previously defined it.
Karl Williamson [Sun, 25 Nov 2018 19:12:19 +0000 (12:12 -0700)]
regen/mk_invlists.pl: Generate a new value
The new value is the maximum number of code points that fold to any
single code point. It will be used in a future commit.
James E Keenan [Mon, 26 Nov 2018 17:29:03 +0000 (12:29 -0500)]
Rename local variable to prevent confusion with global
Per: https://lgtm.com/projects/g/Perl/perl5/alerts/?mode=tree&ruleFocus=
2157860312
For: RT # 133686 (partial)
James E Keenan [Mon, 26 Nov 2018 17:14:51 +0000 (12:14 -0500)]
Rename global variable to prevent confusion with local
Per: https://lgtm.com/projects/g/Perl/perl5/alerts/?mode=tree&ruleFocus=
2157860312
Tony Cook [Mon, 26 Nov 2018 03:21:13 +0000 (14:21 +1100)]
Tony Cook [Tue, 20 Nov 2018 23:05:27 +0000 (10:05 +1100)]
(perl #133659) make an in-place edit successful if the exit status is zero
during global destruction.
This means that code like:
perl -i -ne '...; last'
will replace the input file with the in-place edit output of the file,
but:
perl -i -ne '...; die'
or
perl -i -ne '...; exit 1'
won't.
Tony Cook [Tue, 20 Nov 2018 05:43:43 +0000 (16:43 +1100)]
(perl #133659) tests for global destruction handling of inplace editing
Tony Cook [Tue, 20 Nov 2018 04:30:20 +0000 (15:30 +1100)]
(perl #133659) move argvout cleanup to a new function
James E Keenan [Fri, 23 Nov 2018 16:49:03 +0000 (11:49 -0500)]
Remove 1 comparison whose result is always the same.
Per: https://lgtm.com/projects/g/Perl/perl5/alerts/?mode=tree&ruleFocus=
2154840804
For: RT 133686 (partial)
James E Keenan [Fri, 23 Nov 2018 18:45:25 +0000 (13:45 -0500)]
Eliminate empty conditional branch
Per: https://lgtm.com/projects/g/Perl/perl5/alerts/?mode=tree&ruleFocus=
2154840803
For: RT 133686 (partial)
James E Keenan [Sat, 24 Nov 2018 00:17:38 +0000 (19:17 -0500)]
AltaVista is no more.
Provide a non-Mountain View alternative.
For: RT # 133684
James E Keenan [Fri, 23 Nov 2018 22:13:59 +0000 (17:13 -0500)]
Split NAME line on multiple whitespaces
For: RT # 133683
pod/perlmodlib.pod is a file generated by pod/perlmodlib.PL, which is
run by 'miniperl' during 'make'. That program parses the 'NAME' header
of .pod files and fragments of POD found in 'regen/opcode.pl'. The POD
for B::Op_private is one such fragment. Correcting a superfluous
whitespace in that fragment did not suffice to prevent the downstream
formatting error reported in the RT -- an error visible with 'pod2text'
and 'pod2html' as well. We also had to make the regex which
perlmodlib.PL uses to parse the 'NAME' header more flexible.
Dagfinn Ilmari Mannsåker [Thu, 22 Nov 2018 12:14:38 +0000 (12:14 +0000)]
perlfunc: clarify reset EXPR behaviour
Mention that it only affects variables in the current package, and
that it affects scalars, arrays and hashes ("variables and arrays"
is just confus(ed|ing)).
Karen Etheridge [Wed, 21 Nov 2018 17:40:19 +0000 (09:40 -0800)]
oops, typo
Tomasz Konojacki [Wed, 21 Nov 2018 08:26:31 +0000 (09:26 +0100)]
optimize IV -> UV conversions
This commit replaces all instances of code that looks like this:
uv = (iv == IV_MIN) ? (UV)iv : (UV)(-iv)
with simpler and more optimal:
uv = -(UV)iv
While -iv indeed results in an undefined behaviour when iv == IV_MIN,
-(UV)iv is perfectly well defined and does the right thing.
C standard guarantees that the result of (UV)iv (for negative iv) is
equal to iv + UV_MAX + 1 (see 6.3.1.3, paragraph 2 in C11). It also
guarantees that the result of -uv is UV_MAX - uv + 1 (6.2.5,
paragraph 9).
That means that the result of -(UV)iv is UV_MAX - (iv + UV_MAX + 1) + 1
which is equal to -iv for *all* possible negative values of iv.
[perl #133677]
David Mitchell [Wed, 21 Nov 2018 12:09:45 +0000 (12:09 +0000)]
S_hv_delete_common(): avoid undefined behaviour
ASAN -fsanitize-undefined was tripping on the second of these two lines:
svp = AvARRAY(isa);
end = svp + AvFILLp(isa)+1;
In the case where svp is NULL and AvFILLp(isa) is -1, the first addition
is undefined behaviour. Add the 1 first, so that it becomes
svp + (-1+1), which is safe.
Dominic Hargreaves [Wed, 21 Nov 2018 10:49:39 +0000 (10:49 +0000)]
lgtm.yml: fix erroneous inclusion
Karen Etheridge [Tue, 20 Nov 2018 22:46:24 +0000 (14:46 -0800)]
add entries for Module-CoreList 5.0181220
I did this manually; I am not sure if 'perl -Ilib Porting/corelist.pl
cpan' would add these entries on the next blead-point release day.
Karen Etheridge [Tue, 20 Nov 2018 22:46:05 +0000 (14:46 -0800)]
bump version of released Module-CoreList
Karen Etheridge [Tue, 20 Nov 2018 22:24:49 +0000 (14:24 -0800)]
Bump the perl version in various places for 5.29.6
Karen Etheridge [Tue, 20 Nov 2018 22:18:38 +0000 (14:18 -0800)]
new perldelta for 5.29.6
Karen Etheridge [Tue, 20 Nov 2018 22:17:22 +0000 (14:17 -0800)]
tick off 5.29.5 release
Karen Etheridge [Tue, 20 Nov 2018 22:16:44 +0000 (14:16 -0800)]
epigraph for 5.29.5 release
Karen Etheridge [Tue, 20 Nov 2018 20:47:18 +0000 (12:47 -0800)]
add new release to perlhist
Karen Etheridge [Tue, 20 Nov 2018 20:24:47 +0000 (12:24 -0800)]
finalize perldelta for 5.29.5
Karen Etheridge [Tue, 20 Nov 2018 20:24:04 +0000 (12:24 -0800)]
RMG tweaks
Karen Etheridge [Tue, 20 Nov 2018 20:23:54 +0000 (12:23 -0800)]
fix whitespace
Karen Etheridge [Tue, 20 Nov 2018 20:19:07 +0000 (12:19 -0800)]
update list of customized files
Karen Etheridge [Tue, 20 Nov 2018 19:36:53 +0000 (11:36 -0800)]
Update Module::Corelist for 5.29.5
Karen Etheridge [Tue, 20 Nov 2018 18:57:43 +0000 (10:57 -0800)]
5.22 and 5.24 are now outside the regular release window
Karl Williamson [Tue, 20 Nov 2018 15:55:43 +0000 (08:55 -0700)]
regcomp.c: Rmv malformed assert()
This had a plain '=' instead of an '==', thus setting the value in the
process of asserting it, hence would always be true. But changing it to
'==' causes the assertion to fail in various cases.
I need to rethink this, so in the meantime am simply removing it.
Spotted by Dave Mitchell++
David Mitchell [Tue, 20 Nov 2018 10:59:22 +0000 (10:59 +0000)]
t/perf/benchmarks.t: improve do error checks
Make the checks for "do 't/perf/benchmarks'" look more like those
suggested for 'do' in perlfunc.
In particular, this may help track down the issue in RT #133663.
Niko Tyni [Sat, 17 Nov 2018 17:27:42 +0000 (19:27 +0200)]
Make Errno_pm.PL compatible with /usr/include/<ARCH>/errno.h
As seen in <https://bugs.debian.org/798955>, Debian glibc
maintainers intend to move system header files from /usr/include to
/usr/include/<arch> at some point. This would break Errno_pm.PL, which
has logic for asking cpp for the location of errno.h but fails earlier
if errno.h is not on a list of known paths.
Take the cpp fallback instead of dying. The behaviour should stay
identical as long as errno.h is not moved.
This will also enable multiarch (non-sysroot) cross builds.
Original patch by Helmut Grohne.
Bug-Debian: https://bugs.debian.org/875921
Tony Cook [Mon, 19 Nov 2018 23:25:59 +0000 (10:25 +1100)]
James Clarke is now a perl author
James Clarke [Mon, 19 Nov 2018 14:25:56 +0000 (14:25 +0000)]
Also work around renameat() kernel bug on GNU/kFreeBSD
Karl Williamson [Mon, 19 Nov 2018 20:59:56 +0000 (13:59 -0700)]
Allow forcing use of POSIX 2008 locale fcns
These thread-safe functions are not normally used on unthreaded builds,
retaining the use of the library functions that have long been used.
But, it is now possible to tell Configure to use them on unthreaded
builds.
Karl Williamson [Mon, 19 Nov 2018 20:55:04 +0000 (13:55 -0700)]
t/harness: Run tests for IO::Zlib sequentially
Most of these failed for me in one run inexplicably. This typically
means there was a glitch, and its likely to be that the tests somehow
interferred with each other. Rather than take the time to investigate
further, I changed harness to run the tests for this distribution
sequentially.
Karl Williamson [Sun, 18 Nov 2018 20:18:49 +0000 (13:18 -0700)]
PATCH: [perl #133649] fails on OpenBSD-6.4 unthreaded
OpenBSD has a (perfectly legal) different syntax for the string
parameter to setlocale(), so the failing tests are not actually valid on
that platform. Rather than go to the significant effort to create a
Configure probe to find out what platforms use what syntax, simply skip
these on this platform. The tests aren't skipped if built with threads,
as they actually help make sure that the code that deals with different
syntaxes for thread-safe handling of locales works in the face of
different syntaxes
Dominic Hargreaves [Mon, 19 Nov 2018 19:17:17 +0000 (19:17 +0000)]
lgtm.yml: work around some incorrect classification
David Mitchell [Mon, 19 Nov 2018 16:28:03 +0000 (16:28 +0000)]
perlguts: clarify SV types which are scalars
The '< SVt_PVAV' entry looked to one reader like malformed HTML
rather than indicating a numerical range.
http://nntp.perl.org/group/perl.perl5.porters/252585
David Mitchell [Mon, 19 Nov 2018 14:12:05 +0000 (14:12 +0000)]
ext/File-Find: support parallel testing
t/harness was recently modified to run tests under ext/ etc in parallel.
ext/File-Find/t/ has two test scripts which both use the same temporary
directory names.
Make taint.t use different names, so that it can run in parallel with
the other script.