This is a live mirror of the Perl 5 development currently hosted at
9 years agoTweaks to RMG
Steve Hay [Sat, 18 Aug 2012 13:10:03 +0000 (14:10 +0100)]
Tweaks to RMG

Use the simpler syntax for starting the CPAN shell. Remove notes about
needing Unix tools on Windows for CPAN and CPANPLUS when LWP is not
installed: these are not required since the likes of Net::FTP and
HTTP::Tiny are used instead.

9 years agoDon't use /dev/tty if it happens to exist on Windows
Steve Hay [Sat, 18 Aug 2012 11:28:32 +0000 (12:28 +0100)]
Don't use /dev/tty if it happens to exist on Windows

This fixes CPAN RT#79001 and CPAN RT#79064.

9 years agoWe don't support compilers other than MS VC++ and MinGW/gcc on Windows
Steve Hay [Sat, 18 Aug 2012 09:39:56 +0000 (10:39 +0100)]
We don't support compilers other than MS VC++ and MinGW/gcc on Windows

9 years agoRemove two unused #defines
Steve Hay [Sat, 18 Aug 2012 09:36:12 +0000 (10:36 +0100)]
Remove two unused #defines

9 years agoWe don't support MS VC++ < 6.0
Steve Hay [Sat, 18 Aug 2012 09:33:13 +0000 (10:33 +0100)]
We don't support MS VC++ < 6.0

9 years agoparser.t: Correct test count
Father Chrysostomos [Sat, 18 Aug 2012 06:20:53 +0000 (23:20 -0700)]
parser.t: Correct test count

Why do I keep making these mistakes? :-(

9 years agosv.h: Don’t repeat _XPV_HEAD
Father Chrysostomos [Fri, 17 Aug 2012 23:52:50 +0000 (16:52 -0700)]
sv.h: Don’t repeat _XPV_HEAD

9 years agowrite.t: Eek! debugging code
Father Chrysostomos [Fri, 17 Aug 2012 23:54:40 +0000 (16:54 -0700)]
write.t: Eek! debugging code

9 years agoperldelta entries
Father Chrysostomos [Fri, 17 Aug 2012 23:44:57 +0000 (16:44 -0700)]
perldelta entries

9 years ago[perl #114040] Allow pod in quoted constructs
Father Chrysostomos [Fri, 17 Aug 2012 21:45:29 +0000 (14:45 -0700)]
[perl #114040] Allow pod in quoted constructs

When the case = in toke.c:yylex is reached and PL_lex_state is
not LEX_NORMAL, that means we are in some sort of quoted construct,
and the entire construct’s content is in the current line buffer
(which, consequently contains more than one line).  So we need to check
that when encountering pod.  Quoted constructs need to be treated the
same way as string eval, which also puts all the code in the line

9 years agoDon’t leak formats defined inside subs
Father Chrysostomos [Fri, 17 Aug 2012 21:24:05 +0000 (14:24 -0700)]
Don’t leak formats defined inside subs

I made them leak inadvertently in 5.17.2 with commit e09ac076a1da.

This was unfortunately backported to 5.16.1 (as 3149499832) without
anybody noticing the bug.

9 years agopad.c: Document pad_add_anon’s refcounting
Father Chrysostomos [Fri, 17 Aug 2012 20:39:27 +0000 (13:39 -0700)]
pad.c: Document pad_add_anon’s refcounting

9 years agoperldelta: Clarify note about B::PADLIST
Father Chrysostomos [Fri, 17 Aug 2012 20:28:46 +0000 (13:28 -0700)]
perldelta: Clarify note about B::PADLIST

9 years agopp_ctl.c:pp_dbstate: Don’t adjust CvDEPTH for XSUBs
Father Chrysostomos [Fri, 17 Aug 2012 06:44:11 +0000 (23:44 -0700)]
pp_ctl.c:pp_dbstate: Don’t adjust CvDEPTH for XSUBs

Commit c127bd3aaa5c5 made XS DB::DB subs work.  Before that,
pp_dbstate assumed DB::DB was written it perl.  It adjusts CvDEPTH
when calling the XSUB, which serves no purpose.  It was presumably
just copied from the pure-Perl-calling code.  pp_entersub does-
n’t do this.

9 years agoRestore VC++ 6 build on Windows
Steve Hay [Fri, 17 Aug 2012 23:33:53 +0000 (00:33 +0100)]
Restore VC++ 6 build on Windows

Commits bb02a38feb and 1bd3586145 resulted in VC++ 6 complaining "error
C2099: initializer is not a constant" when initializing bodies_by_type in
sv.c. Workaround the apparent compiler bug using a patch from Jan Dubois,
amended to be compiler-specific as suggested by Nicholas Clark since
anonymous unions are not valid C89.

Date: Wed, 15 Aug 2012 00:55:06 -0700
Message-ID: <005a01cd7abb$498294e0$dc87bea0$>

9 years agoUpgrade to B::Debug 1.18
Steve Hay [Fri, 17 Aug 2012 17:41:02 +0000 (18:41 +0100)]
Upgrade to B::Debug 1.18

9 years agonewCONSTSUB needs its own CV.
Craig A. Berry [Fri, 17 Aug 2012 16:05:14 +0000 (11:05 -0500)]
newCONSTSUB needs its own CV.

It had been using one called simply C<cv> but that name is already
taken in the (opaque) argument list generated by the XS_EUPXS
wrapper around the function name.  And that cv is actually used
by boilerplate code generated from PPCODE, but only when there is
an ALIAS section present, which there wasn't before c0810f8ef84,
but now is.

So declare and use our own CV and leave the one passed in alone.

9 years agoRemove the UTS port.
Nicholas Clark [Tue, 14 Aug 2012 09:54:48 +0000 (11:54 +0200)]
Remove the UTS port.

UTS was a mainframe version of System V created by Amdahl, subsequently sold
to UTS Global. The port has not been touched since before 5.8.0, and UTS
Global is now defunct.

9 years agoperldelta - Add remaining changes not yet documented
Steve Hay [Fri, 17 Aug 2012 08:20:50 +0000 (09:20 +0100)]
perldelta - Add remaining changes not yet documented

Also some other general tidying and wrapping.

9 years agoCGI's t/url.t is no longer customized
Steve Hay [Thu, 16 Aug 2012 13:36:32 +0000 (14:36 +0100)]
CGI's t/url.t is no longer customized

The upgrade to 3.60 contained the changes which were in blead.

9 years agoperldelta - Fix mistakes
Steve Hay [Thu, 16 Aug 2012 08:25:35 +0000 (09:25 +0100)]
perldelta - Fix mistakes

9 years agoperldelta - Document Windows-specific changes
Steve Hay [Thu, 16 Aug 2012 08:11:00 +0000 (09:11 +0100)]
perldelta - Document Windows-specific changes

9 years agoUpgrade to CGI 3.60
Steve Hay [Thu, 16 Aug 2012 07:30:57 +0000 (08:30 +0100)]
Upgrade to CGI 3.60

There were already no t/lib/Test or cgi-lib_porting.html files, so these
can be removed from EXCLUDED.

9 years agoperldelta for a444d2d4f37/#114368
Father Chrysostomos [Thu, 16 Aug 2012 03:34:04 +0000 (20:34 -0700)]
perldelta for a444d2d4f37/#114368

9 years agoperldelta for fc33dad25ea/#114020
Father Chrysostomos [Thu, 16 Aug 2012 03:32:50 +0000 (20:32 -0700)]
perldelta for fc33dad25ea/#114020

This was not the main topic of #114020, but all the discussion
surrounding the change is in that ticket.

9 years agoperldelta: Tweak wording
Father Chrysostomos [Thu, 16 Aug 2012 03:30:47 +0000 (20:30 -0700)]
perldelta: Tweak wording

I don’t know what (or whether) I was thinking when I wrote that.

9 years agoperldelta: missing bug number
Father Chrysostomos [Thu, 16 Aug 2012 03:29:15 +0000 (20:29 -0700)]
perldelta: missing bug number

9 years agoperldelta: more format stuff
Father Chrysostomos [Thu, 16 Aug 2012 03:27:55 +0000 (20:27 -0700)]
perldelta: more format stuff

9 years agoUpgrade Module-Pluggable to 4.3
Steve Hay [Wed, 15 Aug 2012 23:31:32 +0000 (00:31 +0100)]
Upgrade Module-Pluggable to 4.3

There is also no need to list Build.PL as EXCLUDED since it is IGNORABLE

9 years agoUpgrade perlfaq to 5.0150041
Steve Hay [Wed, 15 Aug 2012 23:12:09 +0000 (00:12 +0100)]
Upgrade perlfaq to 5.0150041

9 years agoUpgrade Socket to 2.004
Steve Hay [Wed, 15 Aug 2012 22:59:29 +0000 (23:59 +0100)]
Upgrade Socket to 2.004

9 years agoUpgrade Socket from 2.002 to 2.003
Steve Hay [Wed, 15 Aug 2012 16:56:13 +0000 (17:56 +0100)]
Upgrade Socket from 2.002 to 2.003

9 years agoperldelta - Wrap to 79 columns
Steve Hay [Wed, 15 Aug 2012 16:54:23 +0000 (17:54 +0100)]
perldelta - Wrap to 79 columns

9 years agoperldelta - Document Module::Pluggable changes
Steve Hay [Wed, 15 Aug 2012 16:52:43 +0000 (17:52 +0100)]
perldelta - Document Module::Pluggable changes

9 years agoTweak the test from 35f7559499c4a614 to work with PERL_UNICODE set.
Nicholas Clark [Tue, 14 Aug 2012 10:22:45 +0000 (12:22 +0200)]
Tweak the test from 35f7559499c4a614 to work with PERL_UNICODE set.

9 years agoperldelta
Steve Hay [Wed, 15 Aug 2012 13:51:09 +0000 (14:51 +0100)]

Remove duplicate note about B::Concise, fix a typo and note that
Module-Pluggable is now upgraded.

9 years agoUpgrade to Module-Pluggable 4.2
Steve Hay [Wed, 15 Aug 2012 13:04:18 +0000 (14:04 +0100)]
Upgrade to Module-Pluggable 4.2

The core build process cannot use Build.PL since Module::Build and/or its
prerequisites may not have been built yet, so EXCLUDE that and retain our
(already CUSTOMIZED) Makefile.PL instead for now.

9 years agoAdd new Win32 test script to MANIFEST
Steve Hay [Wed, 15 Aug 2012 08:23:07 +0000 (09:23 +0100)]
Add new Win32 test script to MANIFEST

The file was added by c3c06741ad.

9 years agoFix t/op/magic.t on Windows
Steve Hay [Wed, 15 Aug 2012 08:02:12 +0000 (09:02 +0100)]
Fix t/op/magic.t on Windows

These tests have been failing since they were added by 613c63b465, but
we can now fix them using new Win32 APIs.

9 years agoperldelta - note changes in Win32 0.45
Steve Hay [Wed, 15 Aug 2012 07:56:50 +0000 (08:56 +0100)]
perldelta - note changes in Win32 0.45

9 years agoperldelta - note changes in Encode 2.47
Steve Hay [Wed, 15 Aug 2012 07:52:27 +0000 (08:52 +0100)]
perldelta - note changes in Encode 2.47

9 years agoUpgrade to Sys-Syslog 0.30
Steve Hay [Wed, 15 Aug 2012 07:25:20 +0000 (08:25 +0100)]
Upgrade to Sys-Syslog 0.30

This now incorporates blead's customization of t/syslog.t. Also,
win32/PerlLog_RES.uu shouldn't be listed as EXCLUDED since it is
actually included!

9 years agoUpdate to Win32-0.45 from CPAN
Jan Dubois [Tue, 14 Aug 2012 23:34:32 +0000 (16:34 -0700)]
Update to Win32-0.45 from CPAN

9 years agoUpdate Encode to CPAN version 2.47
Chris 'BinGOs' Williams [Wed, 15 Aug 2012 06:47:38 +0000 (07:47 +0100)]
Update Encode to CPAN version 2.47


  $Revision: 2.47 $ $Date: 2012/08/15 05:36:16 $
    POD Fixes: Copyright and mail address
  ! Makefile.PL
    Added LICENSE => 'perl'
  ! lib/Encode/ t/gsm0338.t
    REALLY fixed RT#75670: Wrong decoding for GSM 3.38 character \x09
    ucm/gsm0338.ucm is dropped from MANIFEST since 2.25
    but I was fixing the wrong file!

9 years agoAdd Joaquin Ferrero to AUTHORS
Father Chrysostomos [Wed, 15 Aug 2012 01:13:36 +0000 (18:13 -0700)]
Add Joaquin Ferrero to AUTHORS

9 years agoperlvar.pod, line 1337, bad filehandle
Joaquin Ferrero [Wed, 15 Aug 2012 01:12:54 +0000 (18:12 -0700)]
perlvar.pod, line 1337, bad filehandle

9 years agoperldelta for 7ef30830/#114018
Father Chrysostomos [Tue, 14 Aug 2012 21:40:38 +0000 (14:40 -0700)]
perldelta for 7ef30830/#114018

9 years agoperldelta for 35f7559499, B::Concise dumping formats
Father Chrysostomos [Tue, 14 Aug 2012 21:39:15 +0000 (14:39 -0700)]
perldelta for 35f7559499, B::Concise dumping formats

9 years agoperldelta for 2c658e55b, no formats after comp errors
Father Chrysostomos [Tue, 14 Aug 2012 21:32:42 +0000 (14:32 -0700)]
perldelta for 2c658e55b, no formats after comp errors

9 years agoperldelta for format parsing fixes
Father Chrysostomos [Tue, 14 Aug 2012 21:29:10 +0000 (14:29 -0700)]
perldelta for format parsing fixes

9 years agoperldelta for ee23553f1b7 & c782dc1db597
Father Chrysostomos [Tue, 14 Aug 2012 21:23:32 +0000 (14:23 -0700)]
perldelta for ee23553f1b7 & c782dc1db597

9 years agoperldelta for f32c7e864b6: recursive formats
Father Chrysostomos [Tue, 14 Aug 2012 21:22:15 +0000 (14:22 -0700)]
perldelta for f32c7e864b6: recursive formats

9 years agoperldelta for 9a71543479/#78550
Father Chrysostomos [Tue, 14 Aug 2012 21:20:12 +0000 (14:20 -0700)]
perldelta for 9a71543479/#78550

9 years agoperldelta for cae5dbbe30b
Father Chrysostomos [Tue, 14 Aug 2012 21:19:00 +0000 (14:19 -0700)]
perldelta for cae5dbbe30b

9 years agoperldelta for 3207fc6be29
Father Chrysostomos [Tue, 14 Aug 2012 21:16:56 +0000 (14:16 -0700)]
perldelta for 3207fc6be29

9 years agoperldelta for #114222: use constant {()}
Father Chrysostomos [Tue, 14 Aug 2012 21:15:46 +0000 (14:15 -0700)]
perldelta for #114222: use constant {()}

9 years agoTest initial tick in sub declaration
Father Chrysostomos [Wed, 4 Jul 2012 13:23:16 +0000 (06:23 -0700)]
Test initial tick in sub declaration

9 years agoAllow test_bootstrap.t to run from the top level
Father Chrysostomos [Mon, 2 Jul 2012 06:05:21 +0000 (23:05 -0700)]
Allow test_bootstrap.t to run from the top level

9 years agopad.c apidocs: Missing fullstop
Father Chrysostomos [Mon, 2 Jul 2012 03:23:06 +0000 (20:23 -0700)]
pad.c apidocs: Missing fullstop

9 years agofix a comment: this tests perl #91852 not 91850
Tony Cook [Wed, 15 Aug 2012 00:34:32 +0000 (10:34 +1000)]
fix a comment: this tests perl #91852 not 91850

noted by mauke (James Rustle) in #p5p

9 years agoUpgrade to Pod-Simple 3.23
Steve Hay [Tue, 14 Aug 2012 22:48:38 +0000 (23:48 +0100)]
Upgrade to Pod-Simple 3.23

9 years agoMissed other typo in README.cygwin
Chris 'BinGOs' Williams [Tue, 14 Aug 2012 22:08:09 +0000 (23:08 +0100)]
Missed other typo in README.cygwin

Yes, it was on the same line as the other one.

Eagle-eyed Jerry Hedden spotted that one.

9 years agoUpdate perldelta to describe changes in all module upgrades so far
Steve Hay [Tue, 14 Aug 2012 21:54:21 +0000 (22:54 +0100)]
Update perldelta to describe changes in all module upgrades so far

9 years agoCorrect a typo in README.cygwin
Chris 'BinGOs' Williams [Tue, 14 Aug 2012 19:27:10 +0000 (20:27 +0100)]
Correct a typo in README.cygwin

Also changed the current version of Cygwin to 1.7.16 and changed
a 'disencouraged' to 'discouraged'. There were both uses in the
document this at least makes the use consistent.

9 years agoDocument new diagnostic message added by d903973c05
Steve Hay [Tue, 14 Aug 2012 16:38:22 +0000 (17:38 +0100)]
Document new diagnostic message added by d903973c05

9 years agoTidy up comments and formatting in d903973c05
Steve Hay [Tue, 14 Aug 2012 16:33:50 +0000 (17:33 +0100)]
Tidy up comments and formatting in d903973c05

9 years agofix RT#88840, don't terminate a child fork psuedo process in DLL Loader Lock
Daniel Dragan [Tue, 14 Aug 2012 12:50:25 +0000 (13:50 +0100)]
fix RT#88840, don't terminate a child fork psuedo process in DLL Loader Lock

TerminateThread will terminate a thread but leaks all resources
of that thread, and all locks will never be released, as documented in MSDN.
There is no alternative to locks not being released that I see, but atleast
-e "if ($pid=fork){kill(9,$pid)} else {sleep 5}"
in fork.t won't deadlock with this patch since win32_start_child be reached before
TerminateThread happens. The 5 ms timeout can be increased if problems
arise in the future. The HWND of the child is delivered by win32_start_child
very early, before any perl bytecode is executed, therefore the delay is
keeping in spirit with a kill 9. In any case, if the child thread fails
to schedule, (a DllMain in DLL_THREAD_ATTACH of some DLL in the process
deadlocks or does very long (over 5 ms right now) sync IO), the parent interp
will bail out.

9 years agoDocument that newCONSTSUB{,_flags} takes ownership of a reference to the SV.
Nicholas Clark [Mon, 13 Aug 2012 14:11:35 +0000 (16:11 +0200)]
Document that newCONSTSUB{,_flags} takes ownership of a reference to the SV.

Also note the collusion between op_const_cv() and cv_clone(), whereby the
former returns a fresh copy of the SV to the latter, which is then immediately
passed to newCONSTSUB.

9 years agoXS::APItest::newCONSTSUB was not handling SV reference counts correctly.
Nicholas Clark [Mon, 13 Aug 2012 13:11:41 +0000 (15:11 +0200)]
XS::APItest::newCONSTSUB was not handling SV reference counts correctly.

newCONSTSUB() and newCONSTSUB_flags() take ownership of (one reference to)
the passed-in SV. As the XS wrapper is passing in a SV taken from the stack,
it needs to up the reference count by one in order to avoid later bugs.

9 years agoUse ALIAS to provide XS::APItest::newCONSTSUB and newCONSTSUB_flags
Nicholas Clark [Mon, 13 Aug 2012 11:38:03 +0000 (13:38 +0200)]
Use ALIAS to provide XS::APItest::newCONSTSUB and newCONSTSUB_flags

Previously both C routines were wrapped with newCONSTSUB_type, which used a
"type" parameter to determine which C code to call. Use an ALIAS to bind the
code to two names, and eliminate the "type" parameter.

This makes the test code clearer. It's not perfect, as the XS wrapper
XS::APItest::newCONSTSUB has a flags parameter whereas the underlying C code
does not, but fixing this would require considerably more XS hackery.

9 years agoClean up temporary test file in Search-Dict test
Steve Hay [Tue, 14 Aug 2012 00:07:29 +0000 (01:07 +0100)]
Clean up temporary test file in Search-Dict test

Need to untie before unlink on Windows.

9 years agoRegenerate test data for porting/customized.t
Steve Hay [Mon, 13 Aug 2012 23:44:32 +0000 (00:44 +0100)]
Regenerate test data for porting/customized.t

9 years agoMore tweaks to
Steve Hay [Mon, 13 Aug 2012 23:23:00 +0000 (00:23 +0100)]
More tweaks to

- One CGI test is currently customized
- Nine Text::Balanced tests are currently customized
- One Test::Harness test is currently customized and another is renamed,
requiring a MAP; plus all the module version numbers are bumped
- Getopt::Long doesn't require a MAP

I have requested new CPAN versions of various CPAN distros that are
currently customized with changes which should be merged back upstream
with a view to getting them back in sync as they are intended to be.
Namely: CGI, Sys-Syslog, Test-Harness, Text-Balanced and Text-Tabs+Wrap.

9 years agoInsert missing words into SvPV_force* documentation
Steve Hay [Mon, 13 Aug 2012 13:05:15 +0000 (14:05 +0100)]
Insert missing words into SvPV_force* documentation

9 years agoFix broken links in perldelta
Steve Hay [Mon, 13 Aug 2012 08:46:46 +0000 (09:46 +0100)]
Fix broken links in perldelta

Clearly, I need to be more vigilant about running porting/*.t before
pushing things which I'm sure couldn't possibly break anything...

9 years agoMinor perldelta changes
Steve Hay [Mon, 13 Aug 2012 08:18:45 +0000 (09:18 +0100)]
Minor perldelta changes

including wrapping lines to 79 columns in the template pod.

9 years agoBegin editing perldelta for 5.17.3
Steve Hay [Mon, 13 Aug 2012 07:55:31 +0000 (08:55 +0100)]
Begin editing perldelta for 5.17.3

Add list of modules upgraded so far, plus a few tidy-ups.

9 years agoBump $Win32CORE::VERSION
Steve Hay [Mon, 13 Aug 2012 07:54:27 +0000 (08:54 +0100)]

The .c file was changed by 2e94d7323a.

9 years agoMark missing CPAN distribution files as EXCLUDED from the core
Steve Hay [Mon, 13 Aug 2012 00:39:21 +0000 (01:39 +0100)]
Mark missing CPAN distribution files as EXCLUDED from the core

All tests and test data are already excluded, and I don't think
cpan-mirrors belongs in the perl core either.

9 years agoBetter description for Pod::Find.
jkeenan [Sun, 12 Aug 2012 18:45:08 +0000 (14:45 -0400)]
Better description for Pod::Find.

9 years agoskip failing leak test under -Dmad
David Mitchell [Sun, 12 Aug 2012 17:27:31 +0000 (18:27 +0100)]
skip failing leak test under -Dmad

a test for a leaky regex introduced by d97935e0 leaks under MAD:
because it uses eval, and eval leaks under MAD.
So skip it in this case.

9 years agoUpdate Encode to CPAN version 2.46
Chris 'BinGOs' Williams [Sun, 12 Aug 2012 08:20:59 +0000 (09:20 +0100)]
Update Encode to CPAN version 2.46


  $Revision: 2.46 $ $Date: 2012/08/12 05:49:30 $
    Fixed: RT#78917 for I18N-Charset: Fails with Encode 2.45
    To be more exact, 2.45 broke Encode->encodings(':all')

9 years agoUpdate Module-Load-Conditional to CPAN version 0.54
Chris 'BinGOs' Williams [Sun, 12 Aug 2012 08:18:30 +0000 (09:18 +0100)]
Update Module-Load-Conditional to CPAN version 0.54


  Changes for 0.54    Sun Aug 12 09:10:13 BST 2012
  * VMS test fixes from Craig Berry

9 years agoSync Module-CoreList version with CPAN
Chris 'BinGOs' Williams [Sun, 12 Aug 2012 08:09:29 +0000 (09:09 +0100)]
Sync Module-CoreList version with CPAN

9 years agomktables: Rebuild if local Makefile has changed
Karl Williamson [Sat, 11 Aug 2012 20:56:55 +0000 (14:56 -0600)]
mktables: Rebuild if local Makefile has changed

Normally, mktables is called from the Makefile at the base level.  But
during development, it may manually be called from the directory (and
hence that directory's Makefile).  This patch causes it to rebuild if
that Makefile changes.

9 years agoperlre: Nits
Karl Williamson [Sat, 11 Aug 2012 20:30:02 +0000 (14:30 -0600)]
perlre: Nits

This fixes some grammar ("either" legally should refer to only a
dual-valued option set) and removes unnecessary distracting detail.

9 years agoregcomp.c: Optimization not valid for Latin Sharp S
Karl Williamson [Sat, 11 Aug 2012 20:19:45 +0000 (14:19 -0600)]
regcomp.c: Optimization not valid for Latin Sharp S

The regex optimizer optimizes some quantifier expressions into simpler
versions.  It turns out that these optimizations don't work on a
quantified, folded LATIN SMALL LETTER SHARP S under /d.  This is due to
the size differential of the fold from the source.

This commit omits the optimization if this circumstance occurs anywhere
in the regex prior to the determination of whether to optimize or not.
I tried adding a parameter to study_chunk() to indicate more locally if
the optimization should be excluded or not; but my first attempt did not
fix the bug, and I chose to not pursue that line.  This character is so
abnormal that it's probably best anyway to be overly cautious when
confronted with it.

9 years agoregcomp.c: Extract duplicate code to common function
Karl Williamson [Sat, 11 Aug 2012 20:10:05 +0000 (14:10 -0600)]
regcomp.c: Extract duplicate code to common function

Comments warned about keeping the two code sections in sync; this commit
takes the portions that are identical and makes a common function out of
them, so the synchronization becomes automatic.

9 years agoregcomp.c: Make sure counter same in passes 1 and 2
Karl Williamson [Fri, 10 Aug 2012 18:16:45 +0000 (12:16 -0600)]
regcomp.c: Make sure counter same in passes 1 and 2

The number of elements was not being incremented in pass 1, whereas that
number is needed later on in pass 1.  This did not cause a
bug, as currently, in pass 1 we care only if the count is 1 or not, and
this occurred only in a case where it would get incremented properly to
more than 1 anyway.  But this is a potential bug that should be
squelched before it happens.

9 years agoregcomp.c: Comments only
Karl Williamson [Fri, 10 Aug 2012 17:58:49 +0000 (11:58 -0600)]
regcomp.c: Comments only

The diffs will show more than this, as a block of comments was moved and

9 years agoregcomp.c: Use old paradigm in dealing with flags recursively
Karl Williamson [Fri, 10 Aug 2012 17:53:20 +0000 (11:53 -0600)]
regcomp.c: Use old paradigm in dealing with flags recursively

In a recursive call to reg(), instead of passing our flags pointer, pass
a new one and upon return or in that result with the existing one.  I
can see why this should be done, as you don't want to lose what you
already have, as reg() will start by resetting it to 0.  I don't know
why one ands it with the known flags, but I'm presuming there is a
reason, and so am copying the paradigm.  I searched the commit messages
and didn't find anything.  No tests failed, and I didn't figure out a
test that would fail.

9 years agoregcomp.c: Create NOTHING node when would have been 0 length EXACT
Karl Williamson [Fri, 10 Aug 2012 15:11:11 +0000 (09:11 -0600)]
regcomp.c: Create NOTHING node when would have been 0 length EXACT

It's peculiar circumstances indeed that would get to this point in the
code with an EXACT node to be created, but nothing to populate it with.
Perhaps it is impossible; I'm not sure.  But commit
5f820f894e71b6970a5aa0fd763a84b647fd628a changed the behavior, which I
discovered in later re-reading the code.  Probably the node would be
populated with a single NUL.  Just in case it is possible to get here
under these peculiar circumstances, this commit adds code to handle the
case, with a NOTHING node instead of a 0 length EXACT.

9 years agoregcomp.c: Set flags when optimizing a [char class]
Karl Williamson [Thu, 9 Aug 2012 20:38:03 +0000 (14:38 -0600)]
regcomp.c: Set flags when optimizing a [char class]

A bracketed character class containing a single Latin1-range character
has long been optimized into an EXACT node.  Also, flags are set to
include SIMPLE.  However, EXACT nodes containing code points that are
different when encoded under UTF-8 versus not UTF-8 should not be marked

To fix this, the address of the flags parameter is now passed to
regclass(), the function that parses bracketed character classes, which
now sets it appropriately.  The unconditional setting of SIMPLE that was
always done in the code after calling regclass() has been removed.

In addition, the setting of the flags for EXACT nodes has been pushed
into the common function that populates them.

regclass() will also now increment the naughtiness count if optimized to
a node that normally does that.  I do not understand this heuristic
behavior very well, and could not come up with a test case for it;
experimentation revealed that there are no test cases in our test suite
for which naughtiness makes any difference at all.

9 years agoregcomp.c: change pattern to utf8 if needed in \N{}
Karl Williamson [Wed, 8 Aug 2012 03:06:06 +0000 (21:06 -0600)]
regcomp.c: change pattern to utf8 if needed in \N{}

This patch is in preparation for future patches that will no longer
always make any pattern that contains \N{} be encoded in UTF-8.  Thus
this patch doesn't actually change anything, but enables future ones.

9 years agore/re_tests: Correct Todo test
Karl Williamson [Mon, 6 Aug 2012 22:42:27 +0000 (16:42 -0600)]
re/re_tests: Correct Todo test

This test was not doing what it purported to test.  It should show that
a /[s\xDF]/i would not match 'ss', because the 's' is seen in the class,
and not the \xDF (which matches 'ss' under /i) in the appropriate

9 years Nits in pod
Karl Williamson [Sat, 4 Aug 2012 17:02:16 +0000 (11:02 -0600)] Nits in pod

This has clarifications, grammar changes, and reflowing to fit into 79

9 years agoAdd some tests for [\N{}]
Karl Williamson [Thu, 2 Aug 2012 16:50:00 +0000 (10:50 -0600)]
Add some tests for [\N{}]

9 years agoUpgrade Compress-Raw-Zlib to 2.056
Steve Hay [Sat, 11 Aug 2012 11:11:47 +0000 (12:11 +0100)]
Upgrade Compress-Raw-Zlib to 2.056

9 years agopp_require thread safety for VMS.
Craig A. Berry [Sat, 11 Aug 2012 02:25:09 +0000 (21:25 -0500)]
pp_require thread safety for VMS.

When we translate path names of required modules into Unix format,
we haven't (recently) been using the optional second argument to
the translation routines,[1] an argument that supplies a buffer for
the translation.  That causes them to use a static buffer. Which
means that if two or more different threads are doing a require
operation at the same time, they will be blindly sharing the same

So allocate buffers as we need them and make them mortal so they
will go away at the next state transition.

[1] Use of an automatic variable for the buffer was removed way
back in 46fc3d4c69a0ad.

9 years typo
Father Chrysostomos [Fri, 10 Aug 2012 20:35:42 +0000 (13:35 -0700)] typo