From: Jarkko Hietaniemi <jhi@iki.fi>
Date: Thu, 29 May 2014 14:34:28 +0000 (-0400)
Subject: printf %s, cast appropriately.
X-Git-Tag: v5.21.1~395
X-Git-Url: https://perl5.git.perl.org/perl5.git/commitdiff_plain/b8c610ededd36d59dcdd6f513b727a3430c1c7f4?ds=sidebyside

printf %s, cast appropriately.

[perl #121881]

Fix for Coverity perl5 CID 29050:
Printf arg type mismatch (PW.PRINTF_ARG_MISMATCH)
printf_arg_mismatch: argument is incompatible with corresponding
format string conversion
---

diff --git a/ext/NDBM_File/NDBM_File.xs b/ext/NDBM_File/NDBM_File.xs
index 52e60fc..e3adf3f 100644
--- a/ext/NDBM_File/NDBM_File.xs
+++ b/ext/NDBM_File/NDBM_File.xs
@@ -109,7 +109,7 @@ ndbm_STORE(db, key, value, flags = DBM_REPLACE)
 	    if (RETVAL < 0 && errno == EPERM)
 		croak("No write permission to ndbm file");
 	    croak("ndbm store returned %d, errno %d, key \"%s\"",
-			RETVAL,errno,key.dptr);
+                  RETVAL, errno, (const char *)key.dptr);
 	    dbm_clearerr(db->dbp);
 	}