From: David Mitchell <davem@iabyn.com>
Date: Mon, 6 Feb 2017 09:20:04 +0000 (+0000)
Subject: Perl_fbm_instr(): remove dead code.
X-Git-Tag: v5.25.10~93
X-Git-Url: https://perl5.git.perl.org/perl5.git/commitdiff_plain/add424dabf9dadd0817fac9b1bf4c5d4e8bbd196

Perl_fbm_instr(): remove dead code.

For the case where littlestr hasn't been FBM compiled (!SvVALID()), it
can't be SvTAIL(), so there's no need for optional \n handling.

Spotted by Coverity.
---

diff --git a/util.c b/util.c
index 53b4109..efe4c02 100644
--- a/util.c
+++ b/util.c
@@ -951,16 +951,7 @@ Perl_fbm_instr(pTHX_ unsigned char *big, unsigned char *bigend, SV *littlestr, U
 	char * const b = ninstr((char*)big,(char*)bigend,
 			 (char*)little, (char*)little + littlelen);
 
-	if (!b && tail) {	/* Automatically multiline!  */
-	    /* Chop \n from littlestr: */
-	    s = bigend - littlelen + 1;
-	    if (*s == *little
-		&& memEQ((char*)s + 1, (char*)little + 1, littlelen - 2))
-	    {
-		return (char*)s;
-	    }
-	    return NULL;
-	}
+        assert(!tail); /* valid => FBM; tail only set on SvVALID SVs */
 	return b;
     }