From: Steve Peters <steve@fisharerojo.org>
Date: Sat, 19 Nov 2005 19:14:42 +0000 (+0000)
Subject: Down with "warning: code has no effect"
X-Git-Tag: perl-5.9.3~638
X-Git-Url: https://perl5.git.perl.org/perl5.git/commitdiff_plain/891c2e08c4b0cd567c57c23427f594d70b2bced2?hp=65e66c80cefadd5e860e8232c69fd1a11e6c5b92

Down with "warning: code has no effect"

p4raw-id: //depot/perl@26176
---

diff --git a/XSUB.h b/XSUB.h
index c38ccd2..b3e586c 100644
--- a/XSUB.h
+++ b/XSUB.h
@@ -320,7 +320,7 @@ Rethrows a previously caught exception.  See L<perlguts/"Exception Handling">.
 */
 
 #define DBM_setFilter(db_type,code)				\
-	{							\
+	STMT_START {						\
 	    if (db_type)					\
 	        RETVAL = sv_mortalcopy(db_type) ;		\
 	    ST(0) = RETVAL ;					\
@@ -334,9 +334,10 @@ Rethrows a previously caught exception.  See L<perlguts/"Exception Handling">.
 	        else						\
 	            db_type = newSVsv(code) ;			\
 	    }	    						\
-	}
+	} STMT_END
 
 #define DBM_ckFilter(arg,type,name)				\
+        STMT_START {						\
 	if (db->type) {						\
 	    if (db->filtering) {				\
 	        croak("recursion detected in %s", name) ;	\
@@ -361,7 +362,7 @@ Rethrows a previously caught exception.  See L<perlguts/"Exception Handling">.
                 arg = sv_2mortal(arg);                          \
             }                                                   \
             SvOKp(arg);                                         \
-	}
+	} } STMT_END                                                     
 
 #if 1		/* for compatibility */
 #  define VTBL_sv		&PL_vtbl_sv