From: Jarkko Hietaniemi <jhi@iki.fi>
Date: Thu, 19 Nov 2015 02:18:37 +0000 (-0500)
Subject: analysis does not like mutex being either held or released
X-Git-Tag: v5.23.6~208^2~2
X-Git-Url: https://perl5.git.perl.org/perl5.git/commitdiff_plain/78d35ce204926ecd797db064ca69e45a82b8f6ca?hp=337458b10d074d4e2412b2adcdd789a0ed6c8349;ds=sidebyside

analysis does not like mutex being either held or released

threads.xs:1020:1: warning: mutex 'thread->mutex' is not held on every path through here [-Wthread-safety-analysis]
}
^
---

diff --git a/dist/threads/threads.xs b/dist/threads/threads.xs
index 73f704b..9333a34 100644
--- a/dist/threads/threads.xs
+++ b/dist/threads/threads.xs
@@ -1017,7 +1017,10 @@ S_ithread_create(
     my_pool->running_threads++;
     MUTEX_UNLOCK(&my_pool->create_destruct_mutex);
     return (thread);
+CLANG_DIAG_IGNORE(-Wthread-safety);
+/* warning: mutex 'thread->mutex' is not held on every path through here [-Wthread-safety-analysis] */
 }
+CLANG_DIAG_RESTORE;
 
 #endif /* USE_ITHREADS */