From: David Mitchell <davem@iabyn.com>
Date: Thu, 15 Oct 2015 15:03:34 +0000 (+0100)
Subject: remove redundant croak code in pp_leavesublv
X-Git-Tag: v5.23.8~154^2~104
X-Git-Url: https://perl5.git.perl.org/perl5.git/commitdiff_plain/3972faa0c6e454c492bb49d05fe2a0e8f31f892e

remove redundant croak code in pp_leavesublv

Just before a code path that croaks, it does a POPSUB etc.
Since this will be done by the unwind following the croak anyway, it's
redundant.
---

diff --git a/pp_ctl.c b/pp_ctl.c
index 13205fe..23f6cce 100644
--- a/pp_ctl.c
+++ b/pp_ctl.c
@@ -2336,10 +2336,6 @@ PP(pp_leavesublv)
 		what = "undef";
 	    }
           croak:
-            CX_LEAVE_SCOPE(cx);
-	    POPSUB(cx);
-	    cxstack_ix--;
-	    PL_curpm = cx->blk_oldpm;
 	    Perl_croak(aTHX_
 	              "Can't return %s from lvalue subroutine", what
 	    );