From: James E Keenan <jkeenan@cpan.org>
Date: Mon, 26 Nov 2018 17:29:03 +0000 (-0500)
Subject: Rename local variable to prevent confusion with global
X-Git-Tag: v5.29.6~108
X-Git-Url: https://perl5.git.perl.org/perl5.git/commitdiff_plain/363d7d4a2b1a2867eccb5132540f9055aca201ef

Rename local variable to prevent confusion with global

Per:  https://lgtm.com/projects/g/Perl/perl5/alerts/?mode=tree&ruleFocus=2157860312

For: RT # 133686 (partial)
---

diff --git a/locale.c b/locale.c
index ff6322f..c32dd3f 100644
--- a/locale.c
+++ b/locale.c
@@ -5050,15 +5050,15 @@ Perl__is_in_locale_category(pTHX_ const bool compiling, const int category)
 
     const COP * const cop = (compiling) ? &PL_compiling : PL_curcop;
 
-    SV *categories = cop_hints_fetch_pvs(cop, "locale", 0);
-    if (! categories || categories == &PL_sv_placeholder) {
+    SV *these_categories = cop_hints_fetch_pvs(cop, "locale", 0);
+    if (! these_categories || these_categories == &PL_sv_placeholder) {
         return FALSE;
     }
 
     /* The pseudo-category 'not_characters' is -1, so just add 1 to each to get
      * a valid unsigned */
     assert(category >= -1);
-    return cBOOL(SvUV(categories) & (1U << (category + 1)));
+    return cBOOL(SvUV(these_categories) & (1U << (category + 1)));
 }
 
 char *