This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
regcomp.c: Remove redundant 'if'
authorKarl Williamson <khw@cpan.org>
Fri, 27 Oct 2017 15:32:26 +0000 (09:32 -0600)
committerKarl Williamson <khw@cpan.org>
Fri, 27 Oct 2017 16:22:10 +0000 (10:22 -0600)
We have already assured earlier in the function that this 'if' is always
true.

regcomp.c

index b8ae535..688da6a 100644 (file)
--- a/regcomp.c
+++ b/regcomp.c
@@ -12216,7 +12216,6 @@ S_grok_bslash_N(pTHX_ RExC_state_t *pRExC_state,
         RExC_recode_x_to_native = 1;
 #endif
 
-        if (node_p) {
             if (!(*node_p = reg(pRExC_state, 1, &flags, depth+1))) {
                 if (flags & (RESTART_PASS1|NEED_UTF8)) {
                     *flagp = flags & (RESTART_PASS1|NEED_UTF8);
@@ -12226,7 +12225,6 @@ S_grok_bslash_N(pTHX_ RExC_state_t *pRExC_state,
                     (UV) flags);
             }
             *flagp |= flags&(HASWIDTH|SPSTART|SIMPLE|POSTPONED);
-        }
 
         /* Restore the saved values */
        RExC_start = RExC_adjusted_start = save_start;