Data::Dumper: reorder elements of style struct

Putting all the pointers and pointer-sized integers together at the start of
the struct reduces the amount of wasted space on platforms where pointers
are wider than ints. In particular, this should reduce the size of the style
struct by eight bytes on typical 64-bit configurations.

This could have been part of the previous commit, but having the order of
the struct's elements match the subroutine arguments that it replaced made
it easier to review that change for correctness.

diff --git a/dist/Data-Dumper/Dumper.xs b/dist/Data-Dumper/Dumper.xs
index b5fab4d..9294645 100644 (file)
--- a/dist/Data-Dumper/Dumper.xs
+++ b/dist/Data-Dumper/Dumper.xs
@@ -47,21 +47,21 @@
  * stack all the time (as was the case in an earlier implementation). But
  * this means that, for example, "sortkeys" is a separate parameter. */
 typedef struct {
-    I32 indent;
     SV *pad;
     SV *xpad;
     SV *sep;
     SV *pair;
     SV *freezer;
     SV *toaster;
+    SV *bless;
+    IV maxrecurse;
+    I32 indent;
     I32 purity;
     I32 deepcopy;
     I32 quotekeys;
-    SV *bless;
     I32 maxdepth;
-    int use_sparse_seen_hash;
     I32 useqq;
-    IV maxrecurse;
+    int use_sparse_seen_hash;
 } Style;
 
 static I32 num_q (const char *s, STRLEN slen);