avoid double defining the POSIX::TCSANOW constant sub

On Win32 which has no native TCSANOW definition this would produce:

Constant subroutine TCSANOW redefined at ../lib/POSIX.pm line -1.

because the macro wasn't defined when building the unknown symbols
table but was defined when building the defined symbols table.

diff --git a/ext/POSIX/POSIX.xs b/ext/POSIX/POSIX.xs
index 2737559..27aabb5 100644 (file)
--- a/ext/POSIX/POSIX.xs
+++ b/ext/POSIX/POSIX.xs
@@ -841,11 +841,15 @@ getattr(termios_ref, fd = 0)
     OUTPUT:
        RETVAL
 
     OUTPUT:
        RETVAL
 

+# If we define TCSANOW here then both a found and not found constant sub
+# are created causing a Constant subroutine TCSANOW redefined warning

 #ifndef TCSANOW
 #ifndef TCSANOW

-#  define TCSANOW 0
+#  define DEF_SETATTR_ACTION 0
+#else
+#  define DEF_SETATTR_ACTION TCSANOW

 #endif
 SysRet
 #endif
 SysRet

-setattr(termios_ref, fd = 0, optional_actions = TCSANOW)
+setattr(termios_ref, fd = 0, optional_actions = DEF_SETATTR_ACTION)

        POSIX::Termios  termios_ref
        int             fd
        int             optional_actions
        POSIX::Termios  termios_ref
        int             fd
        int             optional_actions

diff --git a/ext/POSIX/lib/POSIX.pm b/ext/POSIX/lib/POSIX.pm
index d90794d..e50ee23 100644 (file)
--- a/ext/POSIX/lib/POSIX.pm
+++ b/ext/POSIX/lib/POSIX.pm
@@ -4,7 +4,7 @@ use warnings;
 
 our ($AUTOLOAD, %SIGRT);
 
 
 our ($AUTOLOAD, %SIGRT);
 

-our $VERSION = '1.26';
+our $VERSION = '1.27';

 
 require XSLoader;
 
 
 require XSLoader;