This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
regex: Add comments
authorKarl Williamson <public@khwilliamson.com>
Mon, 9 May 2011 15:03:13 +0000 (09:03 -0600)
committerKarl Williamson <public@khwilliamson.com>
Thu, 19 May 2011 16:31:19 +0000 (10:31 -0600)
regcharclass.h
regcomp.c
regen/regcharclass.pl

index 47d4b41..924841f 100644 (file)
 0x2029 == cp ) ) ) ) ) )
 
 /*
-       TRICKYFOLD: Problematic fold case letters.
+       TRICKYFOLD: Problematic fold case letters.  When adding to this list, also should add them to regcomp.c and fold_grind.t
 
        0x00DF  # LATIN SMALL LETTER SHARP S
        0x0390  # GREEK SMALL LETTER IOTA WITH DIALYTIKA AND TONOS
index b9730f9..f074aca 100644 (file)
--- a/regcomp.c
+++ b/regcomp.c
@@ -8872,13 +8872,14 @@ tryagain:
                            break;
 
                        /* These are the tricky fold characters.  Flush any
-                        * buffer first. */
+                        * buffer first. (When adding to this list, also should
+                        * add them to fold_grind.t to make sure get tested) */
                        case GREEK_SMALL_LETTER_UPSILON_WITH_DIALYTIKA_AND_TONOS:
                        case GREEK_SMALL_LETTER_IOTA_WITH_DIALYTIKA_AND_TONOS:
                        case LATIN_SMALL_LETTER_SHARP_S:
                        case LATIN_CAPITAL_LETTER_SHARP_S:
-                       case 0x1FD3:
-                       case 0x1FE3:
+                       case 0x1FD3: /* GREEK SMALL LETTER IOTA WITH DIALYTIKA AND OXIA */
+                       case 0x1FE3: /* GREEK SMALL LETTER UPSILON WITH DIALYTIKA AND OXIA */
                            if (len != 0) {
                                p = oldp;
                                goto loopdone;
index a640a39..5d7789c 100755 (executable)
@@ -729,7 +729,7 @@ VERTWS: Vertical Whitespace: \v \V
 0x2029          # PARAGRAPH SEPARATOR
 
 
-TRICKYFOLD: Problematic fold case letters.
+TRICKYFOLD: Problematic fold case letters.  When adding to this list, also should add them to regcomp.c and fold_grind.t
 => generic cp generic-cp generic-both :fast safe
 0x00DF # LATIN SMALL LETTER SHARP S
 0x0390 # GREEK SMALL LETTER IOTA WITH DIALYTIKA AND TONOS