Fix a remaining B::Lint bug.

p4raw-id: //depot/perl@16806

diff --git a/ext/B/B/Lint.pm b/ext/B/B/Lint.pm
index cb15b79..9a977c8 100644 (file)
--- a/ext/B/B/Lint.pm
+++ b/ext/B/B/Lint.pm
@@ -250,6 +250,11 @@ sub B::SVOP::lint {
            if ($gv->NAME =~ /^_./ && $gv->STASH->NAME ne $curstash) {
                warning('Illegal reference to private name %s', $gv->NAME);
            }
            if ($gv->NAME =~ /^_./ && $gv->STASH->NAME ne $curstash) {
                warning('Illegal reference to private name %s', $gv->NAME);
            }

+       } elsif ($opname eq "method_named") {
+           my $method = $op->gv->PV;
+           if ($method =~ /^_./) {
+               warning("Illegal reference to private method name $method");
+           }

        }
     }
     if ($check{undefined_subs}) {
        }
     }
     if ($check{undefined_subs}) {

diff --git a/ext/B/t/lint.t b/ext/B/t/lint.t
index 6f21eaf..7be86ac 100644 (file)
--- a/ext/B/t/lint.t
+++ b/ext/B/t/lint.t
@@ -63,13 +63,10 @@ RESULT
 Illegal reference to private name _x at -e line 1
 RESULT
 
 Illegal reference to private name _x at -e line 1
 RESULT
 

-    {
-       local $TODO = q/doesn't catch methods/;
-       runlint 'private-names', 'sub A::_f{};A->_f()', <<'RESULT',
+    runlint 'private-names', 'sub A::_f{};A->_f()', <<'RESULT',

 Illegal reference to private method name _f at -e line 1
 RESULT
 Illegal reference to private method name _f at -e line 1
 RESULT

-       'private-names';
-    }
+    'private-names (method)';

 
     runlint 'undefined-subs', 'foo()', <<'RESULT';
 Undefined subroutine foo called at -e line 1
 
     runlint 'undefined-subs', 'foo()', <<'RESULT';
 Undefined subroutine foo called at -e line 1