This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
Prune some dead code in pp.c:pp_undef
authorFather Chrysostomos <sprout@cpan.org>
Tue, 16 Oct 2012 05:53:30 +0000 (22:53 -0700)
committerFather Chrysostomos <sprout@cpan.org>
Tue, 16 Oct 2012 05:53:30 +0000 (22:53 -0700)
Since commit 6fc9266916, the if (SvFAKE) check under the SVt_PVGV case
in pp_undef has been redundant.  And PVBMs are no longer GVs.

pp.c

diff --git a/pp.c b/pp.c
index 24837a0..28a774e 100644 (file)
--- a/pp.c
+++ b/pp.c
@@ -980,11 +980,9 @@ PP(pp_undef)
        }
        break;
     case SVt_PVGV:
-       if (SvFAKE(sv)) {
-           SvSetMagicSV(sv, &PL_sv_undef);
-           break;
-       }
-       else if (isGV_with_GP(sv)) {
+       assert(isGV_with_GP(sv));
+       assert(!SvFAKE(sv));
+       {
            GP *gp;
             HV *stash;
 
@@ -1022,7 +1020,6 @@ PP(pp_undef)
 
            break;
        }
-       /* FALL THROUGH */
     default:
        if (SvTYPE(sv) >= SVt_PV && SvPVX_const(sv) && SvLEN(sv)) {
            SvPV_free(sv);