This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
hv.h: Don’t call a char * parameter ‘sv’!
authorFather Chrysostomos <sprout@cpan.org>
Wed, 30 Nov 2011 04:12:56 +0000 (20:12 -0800)
committerFather Chrysostomos <sprout@cpan.org>
Wed, 30 Nov 2011 04:12:56 +0000 (20:12 -0800)
This goes all the way back to bbce6d6978 (inseparable changes from
patch from perl5.003_08 to perl5.003_09).  It is mightily confusing
for anyone trying to figure out how these things work.

hv.h

diff --git a/hv.h b/hv.h
index 2058fcd..e45460a 100644 (file)
--- a/hv.h
+++ b/hv.h
@@ -452,8 +452,8 @@ C<SV*>.
 #define hv_magic(hv, gv, how) sv_magic(MUTABLE_SV(hv), MUTABLE_SV(gv), how, NULL, 0)
 #define hv_undef(hv) Perl_hv_undef_flags(aTHX_ hv, 0)
 
-#define Perl_sharepvn(sv, len, hash) HEK_KEY(share_hek(sv, len, hash))
-#define sharepvn(sv, len, hash)             Perl_sharepvn(sv, len, hash)
+#define Perl_sharepvn(pv, len, hash) HEK_KEY(share_hek(pv, len, hash))
+#define sharepvn(pv, len, hash)             Perl_sharepvn(pv, len, hash)
 
 #define share_hek_hek(hek)                                             \
     (++(((struct shared_he *)(((char *)hek)                            \