This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
Avoid a double SV leak in an error state branch of pp_require.
authorNicholas Clark <nick@ccl4.org>
Fri, 15 Jan 2010 16:29:56 +0000 (16:29 +0000)
committerNicholas Clark <nick@ccl4.org>
Fri, 15 Jan 2010 16:29:56 +0000 (16:29 +0000)
Avoid using a sprintf format for a constant value (0).

pp_ctl.c

index 81a942f..d5f2f5d 100644 (file)
--- a/pp_ctl.c
+++ b/pp_ctl.c
@@ -3275,21 +3275,21 @@ PP(pp_require)
                        SVfARG(vnormal(PL_patchlevel)));
                }
                else { /* probably 'use 5.10' or 'use 5.8' */
-                   SV * hintsv = newSV(0);
+                   SV *hintsv;
                    I32 second = 0;
 
                    if (av_len(lav)>=1) 
                        second = SvIV(*av_fetch(lav,1,0));
 
                    second /= second >= 600  ? 100 : 10;
-                   hintsv = Perl_newSVpvf(aTHX_ "v%d.%d.%d",
-                       (int)first, (int)second,0);
+                   hintsv = Perl_newSVpvf(aTHX_ "v%d.%d.0",
+                                          (int)first, (int)second);
                    upg_version(hintsv, TRUE);
 
                    DIE(aTHX_ "Perl %"SVf" required (did you mean %"SVf"?)"
                        "--this is only %"SVf", stopped",
                        SVfARG(vnormal(req)),
-                       SVfARG(vnormal(hintsv)),
+                       SVfARG(vnormal(sv_2mortal(hintsv))),
                        SVfARG(vnormal(PL_patchlevel)));
                }
            }