This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
Add tests for all the other types that %^H serialisation is supposed
authorNicholas Clark <nick@ccl4.org>
Wed, 12 Apr 2006 22:49:58 +0000 (22:49 +0000)
committerNicholas Clark <nick@ccl4.org>
Wed, 12 Apr 2006 22:49:58 +0000 (22:49 +0000)
to support. In the process, found and corrected a bug.
Tests are good, m'kay.

p4raw-id: //depot/perl@27780

hv.c
t/op/caller.t

diff --git a/hv.c b/hv.c
index a37b26e..f0f9c39 100644 (file)
--- a/hv.c
+++ b/hv.c
@@ -2619,7 +2619,7 @@ Perl_refcounted_he_chain_2hv(pTHX_ const struct refcounted_he *chain)
            break;
        case HVrhek_IV:
            value = (chain->refcounted_he_data[0] & HVrhek_UV)
-               ? newSViv(chain->refcounted_he_val.refcounted_he_u_iv)
+               ? newSVuv(chain->refcounted_he_val.refcounted_he_u_iv)
                : newSViv(chain->refcounted_he_val.refcounted_he_u_uv);
            break;
        case HVrhek_PV:
index c32b044..d0716be 100644 (file)
@@ -5,7 +5,7 @@ BEGIN {
     chdir 't' if -d 't';
     @INC = '../lib';
     require './test.pl';
-    plan( tests => 65 );
+    plan( tests => 71 );
 }
 
 my @c;
@@ -231,4 +231,39 @@ EOE
        $^H{dooot} = "FIP\0FOP\0FIDDIT\0FAP";
     }
     is(get_dooot(), "FIP\0FOP\0FIDDIT\0FAP", "Can do embedded 0 bytes");
+
+    BEGIN {
+       $^H{dooot} = chr 256;
+    }
+    is(get_dooot(), chr 256, "Can do Unicode");
+
+    BEGIN {
+       $^H{dooot} = -42;
+    }
+    is(get_dooot(), -42, "Can do IVs");
+
+    BEGIN {
+       $^H{dooot} = ~0;
+    }
+    cmp_ok(get_dooot(), '>', 42, "Can do UVs");
+}
+
+{
+    my ($k1, $k2, $k3);
+    BEGIN {
+       $k1 = chr 163;
+       $k2 = $k1;
+       $k3 = $k1;
+       utf8::upgrade $k2;
+       utf8::encode $k3;
+
+       $^H{$k1} = 1;
+       $^H{$k2} = 2;
+       $^H{$k3} = 3;
+    }
+
+       
+    is(get_hash()->{$k1}, 2, "UTF-8 or not, it's the same");
+    is(get_hash()->{$k2}, 2, "UTF-8 or not, it's the same");
+    is(get_hash()->{$k3}, 3, "Octect sequences and UTF-8 are distinct");
 }