This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
Add comment to explain why we want to probe for statfs() et al
authorAaron Crane <arc@cpan.org>
Wed, 1 Nov 2017 17:52:24 +0000 (17:52 +0000)
committerAaron Crane <arc@cpan.org>
Sat, 4 Nov 2017 12:11:42 +0000 (12:11 +0000)
perl.c

diff --git a/perl.c b/perl.c
index 9f3898d..846d443 100644 (file)
--- a/perl.c
+++ b/perl.c
@@ -3958,12 +3958,20 @@ S_open_script(pTHX_ const char *scriptname, bool dosearch, bool *suidscript)
     return rsfp;
 }
 
-/* Mention
+/* In the days of suidperl, we refused to execute a setuid script stored on
+ * a filesystem mounted nosuid and/or noexec. This meant that we probed for the
+ * existence of the appropriate filesystem-statting function, and behaved
+ * accordingly. But even though suidperl is long gone, we must still include
+ * those probes for the benefit of modules like Filesys::Df, which expect the
+ * results of those probes to be stored in %Config; see RT#126368. So mention
+ * the relevant cpp symbols here, to ensure that metaconfig will include their
+ * probes in the generated Configure:
+ *
  * I_SYSSTATVFS        HAS_FSTATVFS
  * I_SYSMOUNT
  * I_STATFS    HAS_FSTATFS     HAS_GETFSSTAT
  * I_MNTENT    HAS_GETMNTENT   HAS_HASMNTOPT
- * here so that metaconfig picks them up. */
+ */
 
 
 #ifdef SETUID_SCRIPTS_ARE_SECURE_NOW