avoid infinite recursion in _perl_abs_path()

If _perl_abs_path() couldn't opendir("..") then it would call
File::Spec->rel2abs, which was liable to call back to Cwd::getcwd() and
thus to _perl_abs_path(), producing an infinite recursion.  The call to
File::Spec->rel2abs is of dubious value anyway, so just turn that into
an error return.  Fixes [perl #132651].

diff --git a/dist/PathTools/Cwd.pm b/dist/PathTools/Cwd.pm
index d6c65e9..c648a57 100644 (file)
--- a/dist/PathTools/Cwd.pm
+++ b/dist/PathTools/Cwd.pm
@@ -421,9 +421,7 @@ sub _perl_abs_path
        local *PARENT;
        unless (opendir(PARENT, $dotdots))
        {
        local *PARENT;
        unless (opendir(PARENT, $dotdots))
        {

-           # probably a permissions issue.  Try the native command.
-           require File::Spec;
-           return File::Spec->rel2abs( $start, _backtick_pwd() );
+           return undef;

        }
        unless (@cst = stat($dotdots))
        {
        }
        unless (@cst = stat($dotdots))
        {

diff --git a/dist/PathTools/t/cwd_enoent.t b/dist/PathTools/t/cwd_enoent.t
index 9980dfd..59e3612 100644 (file)
--- a/dist/PathTools/t/cwd_enoent.t
+++ b/dist/PathTools/t/cwd_enoent.t
@@ -1,8 +1,6 @@
 use warnings;
 use strict;
 
 use warnings;
 use strict;
 

-use Test::More skip_all => "infinite loop seen on FreeBSD [perl #132651]";
-

 use Config;
 use Errno qw(ENOENT);
 use File::Temp qw(tempdir);
 use Config;
 use Errno qw(ENOENT);
 use File::Temp qw(tempdir);