Make strict vars respect ‘package ĵ; *ĵ::bar = [];’

In this particular case, the name of the current package in UTF-8 (it
cannot be expressed in Latin-1) is the same byte sequence as the name
of the package being assigned to in Latin-1.

Some of the logic in stashpv_hvname_match was faulty.  It worked for
a Latin-1 current package assigning to a glob in a UTF-8 package, but
not the other way around.

diff --git a/t/lib/strict/vars b/t/lib/strict/vars
index 568d991..b8c6d1f 100644 (file)
--- a/t/lib/strict/vars
+++ b/t/lib/strict/vars
@@ -554,3 +554,12 @@ package Foo;
 use strict;
 eval 'package foo; @bar = 1' or die;
 EXPECT
+########
+# UTF8 and Latin1 package names equivalent at the byte level
+use utf8;
+# ĵ in UTF-8 is the same as ĵ in Latin-1
+package ĵ;
+*ĵ::bar = [];
+use strict;
+eval 'package ĵ; @bar = 1' or die;
+EXPECT

diff --git a/util.c b/util.c
index 500bef5..716944d 100644 (file)
--- a/util.c
+++ b/util.c
@@ -5861,7 +5861,7 @@ Perl_stashpv_hvname_match(pTHX_ const COP *c, const HV *hv)
 
     if (!stashpv || !name)
        return stashpv == name;
-    if ( HvNAMEUTF8(hv) && !utf8 ) {
+    if ( !HvNAMEUTF8(hv) != !utf8 ) {
         if (utf8) {
             return (bytes_cmp_utf8(
                         (const U8*)stashpv, len,